erc20 0.0.17 → 0.0.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53d1ed4b12b1b7e295242f5345c3ebd4f22e8fe83af31bd2bcb4f27ec8a0b4ca
-  data.tar.gz: e377b3185614081e92f72a7fda5c9a8019de72a3497b9d28259e13f17a5f1ab0
+  metadata.gz: 37aa39344c429cfd2153f004bd2a92730cd3a22c4f11c04e31573d36a98b2045
+  data.tar.gz: c64d6baecf8256cce26bad81f16608b01098b1c581a1370dedb05b9761a8a6e2
 SHA512:
-  metadata.gz: 892709a9568e7837a708feefd8d7880d309fae9f921d1a8266e1b7b995acb1575a6305af92a1dd5dab7b9e7a7f3da9cc5b0b2539a9984eac91d291f59c5d86d1
-  data.tar.gz: d945d2ec483e4cc14ff76683294941cfaf9603963baf8c3acbf64189ee59aead1ec70e6b2d292c889d790c8f8f6fcd59c5327bb2a5223a138821fd5592971178
+  metadata.gz: 030bd6e0734bef65820b1c0a63237eed014bc1e1291e7a98f2e8ffe17bffab6aaa3d6cc9685f0901002512376c6ac2bece5d9c564249259700df82ba2bb609c0
+  data.tar.gz: 5836008fa63ea04bc68f7e8cc670f18b17ec887be606fedf1315e1d6e94d6be2b21859693c173d7ecd56e173fcd13f4598e08099fca941fb1bedd6367dc16e80

data/lib/erc20/erc20.rb

@@ -42,5 +42,5 @@
 # License:: MIT
 module ERC20
   # Current version of the gem (changed by the +.rultor.yml+ on every release)
-  VERSION = '0.0.17'
+  VERSION = '0.0.18'
 end

data/lib/erc20/wallet.rb

@@ -159,22 +159,22 @@ class ERC20::Wallet
     b
   end
 
-  # How much ETH gas is required in order to send this ETH transaction.
+  # How much ETH gas is required in order to send ERC20 transaction.
   #
   # @param [String] from The departing address, in hex
-  # @param [String] to Arriving address, in hex
+  # @param [String] to Arriving address, in hex (it's OK to skip it)
   # @return [Integer] How many ETH required
-  def eth_gas_required(from, to)
-    gas_estimate(from, to)
+  def gas_required(from, to = from)
+    gas_estimate(from, to, to_pay_data(from, 100_000))
   end
 
-  # How much ETH gas is required in order to send this ERC20 transaction.
+  # How much ETH gas is required in order to send this ETH transaction.
   #
   # @param [String] from The departing address, in hex
-  # @param [String] to Arriving address, in hex
+  # @param [String] to Arriving address, in hex (it's OK to skip it)
   # @return [Integer] How many ETH required
-  def gas_required(from, to)
-    gas_estimate(from, to, to_pay_data(from, 100_000))
+  def eth_gas_required(from, to = from)
+    gas_estimate(from, to)
   end
 
   # Send a single ERC20 payment from a private address to a public one.
@@ -430,7 +430,9 @@ class ERC20::Wallet
   # public address to another public address, possible carrying some data
   # inside the transaction.
   def gas_estimate(from, to, data = '')
-    jsonrpc.eth_estimateGas({ from:, to:, data: }, 'latest').to_i(16)
+    gas = jsonrpc.eth_estimateGas({ from:, to:, data: }, 'latest').to_i(16)
+    @log.debug("Estimated gas is #{gas} ETH#{data.empty? ? '' : ', for ERC20 transfer'}")
+    gas
   end
 
   def to_pay_data(address, amount)

data/test/erc20/test_wallet.rb

@@ -73,6 +73,12 @@ class TestWallet < Minitest::Test
     assert_predicate(b, :positive?)
   end
 
+  def test_checks_same_address_gas_required_on_mainnet
+    b = mainnet.gas_required(STABLE, STABLE)
+    refute_nil(b)
+    assert_predicate(b, :positive?)
+  end
+
   def test_fails_with_invalid_infura_key
     skip('Apparently, even with invalid key, Infura returns balance')
     w = ERC20::Wallet.new(
@@ -102,11 +108,16 @@ class TestWallet < Minitest::Test
 
   def test_checks_gas_required_on_hardhat
     on_hardhat do |wallet|
-      b = wallet.gas_required(
+      b1 = wallet.gas_required(
         Eth::Key.new(priv: JEFF).address.to_s,
         Eth::Key.new(priv: WALTER).address.to_s
       )
-      assert_equal(21_597, b)
+      assert_equal(21_597, b1)
+      b2 = wallet.gas_required(
+        Eth::Key.new(priv: JEFF).address.to_s,
+        Eth::Key.new(priv: JEFF).address.to_s
+      )
+      assert_equal(b1, b2)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: erc20
 version: !ruby/object:Gem::Version
-  version: 0.0.17
+  version: 0.0.18
 platform: ruby
 authors:
 - Yegor Bugayenko