erb_lint 0.0.37 → 0.1.2

data/lib/erb_lint/reporters/json_reporter.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+require "json"
+
+module ERBLint
+  module Reporters
+    class JsonReporter < Reporter
+      def preview; end
+
+      def show
+        puts formatted_data
+      end
+
+      private
+
+      def formatted_data
+        {
+          metadata: metadata,
+          files: formatted_files,
+          summary: summary,
+        }.to_json
+      end
+
+      def metadata
+        {
+          erb_lint_version: ERBLint::VERSION,
+          ruby_engine: RUBY_ENGINE,
+          ruby_version: RUBY_VERSION,
+          ruby_patchlevel: RUBY_PATCHLEVEL.to_s,
+          ruby_platform: RUBY_PLATFORM,
+        }
+      end
+
+      def summary
+        {
+          offenses: stats.found,
+          inspected_files: stats.processed_files.size,
+          corrected: stats.corrected,
+        }
+      end
+
+      def formatted_files
+        processed_files.map do |filename, offenses|
+          {
+            path: filename,
+            offenses: formatted_offenses(offenses),
+          }
+        end
+      end
+
+      def formatted_offenses(offenses)
+        offenses.map do |offense|
+          format_offense(offense)
+        end
+      end
+
+      def format_offense(offense)
+        {
+          linter: offense.linter.class.simple_name,
+          message: offense.message.to_s,
+          location: {
+            start_line: offense.line_number,
+            start_column: offense.column,
+            last_line: offense.source_range.last_line,
+            last_column: offense.source_range.last_column,
+            length: offense.source_range.length,
+          },
+        }
+      end
+    end
+  end
+end

data/lib/erb_lint/reporters/multiline_reporter.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative "compact_reporter"
 
 module ERBLint
@@ -9,7 +10,7 @@ module ERBLint
       def format_offense(filename, offense)
         <<~EOF
 
-          #{offense.message}#{Rainbow(' (not autocorrected)').red if autocorrect}
+          #{offense.message}#{Rainbow(" (not autocorrected)").red if autocorrect}
           In file: #{filename}:#{offense.line_number}
         EOF
       end

data/lib/erb_lint/runner.rb

@@ -8,7 +8,7 @@ module ERBLint
     def initialize(file_loader, config)
       @file_loader = file_loader
       @config = config || RunnerConfig.default
-      raise ArgumentError, 'expect `config` to be a RunnerConfig instance' unless @config.is_a?(RunnerConfig)
+      raise ArgumentError, "expect `config` to be a RunnerConfig instance" unless @config.is_a?(RunnerConfig)
 
       linter_classes = LinterRegistry.linters.select { |klass| @config.for_linter(klass).enabled? }
       @linters = linter_classes.map do |linter_class|
@@ -18,8 +18,9 @@ module ERBLint
     end
 
     def run(processed_source)
+      relative_filename = processed_source.filename.delete_prefix("#{@file_loader.base_path}/")
       @linters
-        .reject { |linter| linter.excludes_file?(processed_source.filename) }
+        .reject { |linter| linter.excludes_file?(relative_filename) }
         .each do |linter|
         linter.run(processed_source)
         @offenses.concat(linter.offenses)

data/lib/erb_lint/runner_config.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'erb_lint/runner_config_resolver'
+require "erb_lint/runner_config_resolver"
 
 module ERBLint
   class RunnerConfig
@@ -9,7 +9,7 @@ module ERBLint
     def initialize(config = nil, file_loader = nil)
       @config = (config || {}).dup.deep_stringify_keys
 
-      resolver.resolve_inheritance_from_gems(@config, @config.delete('inherit_gem'))
+      resolver.resolve_inheritance_from_gems(@config, @config.delete("inherit_gem"))
       resolver.resolve_inheritance(@config, file_loader) if file_loader
       @config.delete("inherit_from")
     end
@@ -24,15 +24,16 @@ module ERBLint
       elsif klass.is_a?(Class) && klass <= ERBLint::Linter
         klass.simple_name
       else
-        raise ArgumentError, 'expected String or linter class'
+        raise ArgumentError, "expected String or linter class"
       end
       linter_klass = LinterRegistry.find_by_name(klass_name)
       raise Error, "#{klass_name}: linter not found (is it loaded?)" unless linter_klass
+
       linter_klass.config_schema.new(config_hash_for_linter(klass_name))
     end
 
     def global_exclude
-      @config['exclude'] || []
+      @config["exclude"] || []
     end
 
     def merge(other_config)
@@ -61,6 +62,7 @@ module ERBLint
             SpaceIndentation: { enabled: default_enabled },
             SpaceInHtmlTag: { enabled: default_enabled },
             TrailingWhitespace: { enabled: default_enabled },
+            RequireInputAutocomplete: { enabled: default_enabled },
           },
         )
       end
@@ -74,13 +76,13 @@ module ERBLint
     private
 
     def linters_config
-      @config['linters'] || {}
+      @config["linters"] || {}
     end
 
     def config_hash_for_linter(klass_name)
       config_hash = linters_config[klass_name] || {}
-      config_hash['exclude'] ||= []
-      config_hash['exclude'].concat(global_exclude) if config_hash['exclude'].is_a?(Array)
+      config_hash["exclude"] ||= []
+      config_hash["exclude"].concat(global_exclude) if config_hash["exclude"].is_a?(Array)
       config_hash
     end
 

data/lib/erb_lint/runner_config_resolver.rb

@@ -24,10 +24,11 @@
 module ERBLint
   class RunnerConfigResolver
     def resolve_inheritance(hash, file_loader)
-      inherited_files = Array(hash['inherit_from'])
+      inherited_files = Array(hash["inherit_from"])
       base_configs(file_loader, inherited_files).reverse_each do |base_config|
         base_config.each do |k, v|
           next unless v.is_a?(Hash)
+
           v = v.deep_merge(hash[k]) if hash.key?(k)
           hash[k] = v
         end
@@ -36,12 +37,12 @@ module ERBLint
 
     def resolve_inheritance_from_gems(hash, gems)
       (gems || {}).each_pair do |gem_name, config_path|
-        raise(ArgumentError, "can't inherit configuration from the erb-lint gem") if gem_name == 'erb-lint'
+        raise(ArgumentError, "can't inherit configuration from the erb-lint gem") if gem_name == "erb-lint"
 
-        hash['inherit_from'] = Array(hash['inherit_from'])
+        hash["inherit_from"] = Array(hash["inherit_from"])
         Array(config_path).reverse_each do |path|
           # Put gem configuration first so local configuration overrides it.
-          hash['inherit_from'].unshift(gem_config_path(gem_name, path))
+          hash["inherit_from"].unshift(gem_config_path(gem_name, path))
         end
       end
     end

data/lib/erb_lint/stats.rb

@@ -1,25 +1,32 @@
 # frozen_string_literal: true
+
 module ERBLint
   class Stats
-    attr_accessor :found,
-                  :corrected,
-                  :exceptions,
-                  :linters,
-                  :files,
-                  :processed_files
+    attr_accessor :ignored,
+      :found,
+      :corrected,
+      :exceptions,
+      :linters,
+      :autocorrectable_linters,
+      :files,
+      :processed_files
 
     def initialize(
+      ignored: 0,
       found: 0,
       corrected: 0,
       exceptions: 0,
       linters: 0,
+      autocorrectable_linters: 0,
       files: 0,
       processed_files: {}
     )
+      @ignored = ignored
       @found = found
       @corrected = corrected
       @exceptions = exceptions
       @linters = linters
+      @autocorrectable_linters = autocorrectable_linters
       @files = files
       @processed_files = processed_files
     end

data/lib/erb_lint/utils/block_map.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require 'better_html/ast/node'
-require 'better_html/test_helper/ruby_node'
+require "better_html/ast/node"
+require "better_html/test_helper/ruby_node"
 
 module ERBLint
   module Utils
@@ -194,6 +194,7 @@ module ERBLint
 
       def find_entry(range)
         return unless range
+
         @entries.find do |entry|
           entry.contains_ruby_range?(Range.new(range.begin_pos, range.end_pos))
         end

data/lib/erb_lint/utils/offset_corrector.rb

@@ -63,8 +63,8 @@ module ERBLint
           node_or_range
         else
           raise TypeError,
-            'Expected a Parser::Source::Range, Comment or ' \
-                        "Rubocop::AST::Node, got #{node_or_range.class}"
+            "Expected a Parser::Source::Range, Comment or " \
+              "Rubocop::AST::Node, got #{node_or_range.class}"
         end
       end
     end

data/lib/erb_lint/utils/ruby_to_erb.rb

@@ -9,14 +9,15 @@ module ERBLint
         def html_options_to_tag_attributes(hash_node)
           hash_node.children.map do |pair_node|
             key_node, value_node = *pair_node
-            key = ruby_to_erb(key_node, '=') { |s| s.tr('_', '-') }
-            value = ruby_to_erb(value_node, '=') { |s| escape_quote(s) }
-            [key, "\"#{value}\""].join('=')
-          end.join(' ')
+            key = ruby_to_erb(key_node, "=") { |s| s.tr("_", "-") }
+            value = ruby_to_erb(value_node, "=") { |s| escape_quote(s) }
+            [key, "\"#{value}\""].join("=")
+          end.join(" ")
         end
 
         def ruby_to_erb(node, indicator = nil, &block)
           return node if node.nil? || node.is_a?(String)
+
           case node.type
           when :str, :sym
             s = node.children.first.to_s
@@ -43,7 +44,7 @@ module ERBLint
         end
 
         def escape_quote(str)
-          str.gsub('"', '"')
+          str.gsub('"', """)
         end
       end
     end

data/lib/erb_lint/utils/severity_levels.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module ERBLint
+  module Utils
+    module SeverityLevels
+      SEVERITY_NAMES = [:info, :refactor, :convention, :warning, :error, :fatal].freeze
+
+      SEVERITY_CODE_TABLE = { I: :info, R: :refactor, C: :convention,
+                              W: :warning, E: :error, F: :fatal, }.freeze
+
+      def severity_level_for_name(name)
+        SEVERITY_NAMES.index(name || :error) + 1
+      end
+    end
+  end
+end

data/lib/erb_lint/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ERBLint
-  VERSION = '0.0.37'
+  VERSION = "0.1.2"
 end

data/lib/erb_lint.rb

@@ -1,26 +1,3 @@
 # frozen_string_literal: true
 
-require 'rubocop'
-
-require 'erb_lint/corrector'
-require 'erb_lint/file_loader'
-require 'erb_lint/linter_config'
-require 'erb_lint/linter_registry'
-require 'erb_lint/linter'
-require 'erb_lint/offense'
-require 'erb_lint/processed_source'
-require 'erb_lint/runner_config'
-require 'erb_lint/runner'
-require 'erb_lint/version'
-require 'erb_lint/stats'
-require 'erb_lint/reporter'
-
-# Load linters
-Dir[File.expand_path('erb_lint/linters/**/*.rb', File.dirname(__FILE__))].each do |file|
-  require file
-end
-
-# Load reporters
-Dir[File.expand_path('erb_lint/reporters/**/*.rb', File.dirname(__FILE__))].each do |file|
-  require file
-end
+require "erb_lint/version"

metadata

@@ -1,45 +1,45 @@
 --- !ruby/object:Gem::Specification
 name: erb_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.37
+  version: 0.1.2
 platform: ruby
 authors:
 - Justin Chan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-01-12 00:00:00.000000000 Z
+date: 2022-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: better_html
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.7
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.7
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: html_tokenizer
+  name: better_html
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.7
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: html_tokenizer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 2.7.1.4
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: rainbow
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: smart_properties
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rainbow
+  name: smart_properties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -160,6 +160,7 @@ extra_rdoc_files: []
 files:
 - exe/erblint
 - lib/erb_lint.rb
+- lib/erb_lint/all.rb
 - lib/erb_lint/cli.rb
 - lib/erb_lint/corrector.rb
 - lib/erb_lint/file_loader.rb
@@ -175,6 +176,9 @@ files:
 - lib/erb_lint/linters/hard_coded_string.rb
 - lib/erb_lint/linters/no_javascript_tag_helper.rb
 - lib/erb_lint/linters/parser_errors.rb
+- lib/erb_lint/linters/partial_instance_variable.rb
+- lib/erb_lint/linters/require_input_autocomplete.rb
+- lib/erb_lint/linters/require_script_nonce.rb
 - lib/erb_lint/linters/right_trim.rb
 - lib/erb_lint/linters/rubocop.rb
 - lib/erb_lint/linters/rubocop_text.rb
@@ -187,6 +191,7 @@ files:
 - lib/erb_lint/processed_source.rb
 - lib/erb_lint/reporter.rb
 - lib/erb_lint/reporters/compact_reporter.rb
+- lib/erb_lint/reporters/json_reporter.rb
 - lib/erb_lint/reporters/multiline_reporter.rb
 - lib/erb_lint/runner.rb
 - lib/erb_lint/runner_config.rb
@@ -195,6 +200,7 @@ files:
 - lib/erb_lint/utils/block_map.rb
 - lib/erb_lint/utils/offset_corrector.rb
 - lib/erb_lint/utils/ruby_to_erb.rb
+- lib/erb_lint/utils/severity_levels.rb
 - lib/erb_lint/version.rb
 homepage: https://github.com/Shopify/erb-lint
 licenses:
@@ -216,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: ERB lint tool