equivalent-xml 0.4.4 → 0.5.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MjZkNWNmMGY5ZGUzOTNkYzMwYWUxOGVmODljYzgyMTgzZjc4YzEyMw==
+    MDRhZTQ4ZjZiYmU5ZmIzZTU1M2U5MzU1ZjE1MzY2MjFmN2VlZjUzYg==
   data.tar.gz: !binary |-
-    Mjk5ZjM4ZTA0N2UwNWJjNjI3ZGRlNTk2OTk0M2UyZGUxYzE5NTNiYw==
+    NTY1MTViYWYzYjY5NWFmNTU3YjdlYTg4MjRhNjQ2MGFhNjJjNTk5Zg==
 SHA512:
   metadata.gz: !binary |-
-    YTYxODA2Y2ZjNDFjZWM3OGY0MTA3MmJiNzgxMTBlZWRhMTg4NzY4M2Q3YTc0
-    NTJmMjM0YWFjNGFlOGZmZmRiNTI5NzQ3ZWMyNDM5ZjJiZjZkYjJiMjBhMTEz
-    NmFhNGU0ZGQ1MjhlZWJjOWY4N2Q1NzhhNTIwNTAyNWFlODFjNjg=
+    ZjkwYjhmMjA5Yjg3ZTQyNTI1MjgwZWQ3MjNmMzE3MTM5MTIwOTc0MTlmMDMx
+    NmI4OTljYzA4Njk0ZTdkMDlhMDhmNjQxNTZhMTYxYzFkNWM2MGQ0NDAwNzMw
+    NmM2ZWY1MGUxZTQ1MjcxM2JkNjVlOWQ1MjI2ZWYwNGJjODQ5ZDc=
   data.tar.gz: !binary |-
-    Y2EyYjA5MDQ3N2UzOTQ3MGFiMDU3ODdjNTdmYWY2ZGU3OTc4ZDNhYWEyMjYy
-    MmQzNGU3ZDIzYzI0MTJkNGQzZjI1NGY5YzJmZjc2MjQ1YmY2YjgxYzc1OGU0
-    MDY1YzVlMzcxYmQzMjNiM2E0MGQxOTA4ODg5NDYxYzY4MjY5MTU=
+    M2VkNjVlNGQ2YThmYTc4OTQzMTQwYjg2OTJmYjUzODg1YjQwNGY5YmU2YzNj
+    OGM0NTNiYjNhNDk1Y2QxODUyODE4Y2VlYzlmZmMxNzY2Y2I0MTczYmY4Njc3
+    ZTZhODA3OTk3YzdiMDhlOGZjNTZiMjljZTUzM2FmMjg3YzU4Y2U=

data/README.md

@@ -113,6 +113,8 @@ Chained modifiers:
 
 ## History
 
+- <b>0.5.1</b> - Fix false negative when comparing a Nokogiri::XML::Node to a string (introduced in 0.5.0)
+- <b>0.5.0</b> - Allow to compare XML-Fragments in Strings (contrib. by webmasters)
 - <b>0.4.4</b> - Fix rspec 3 deprecation warnings while maintaining compatibility with rspec 1 & 2 (w/assist from barelyknown & DanielHeath)
 - <b>0.4.3</b> - Updates for rspec 3
 - <b>0.4.2</b> - Move version back into gemspec for now

data/lib/equivalent-xml.rb

@@ -21,6 +21,9 @@ module EquivalentXml
       if [node_1, node_2].any? { |node| node.is_a?(Nokogiri::XML::NodeSet)}
         self.compare_nodesets(as_nodeset(node_1, opts), as_nodeset(node_2, opts), opts, &block)
       else
+        # Don't let one node to coerced to a DocumentFragment if the other one is a Document
+        node_2 = Nokogiri::XML(node_2) if node_1.is_a?(Nokogiri::XML::Document) and !node_2.is_a?(Nokogiri::XML::Node)
+        node_1 = Nokogiri::XML(node_1) if node_2.is_a?(Nokogiri::XML::Document) and !node_1.is_a?(Nokogiri::XML::Node)
         self.compare_nodes(as_node(node_1), as_node(node_2), opts, &block)
       end
     end
@@ -156,8 +159,8 @@ module EquivalentXml
       if data.respond_to?(:node_type)
         return data
       else
-        result = Nokogiri::XML(data)
-        if result.root.nil?
+        result = Nokogiri::XML.fragment(data)
+        if result.respond_to?(:root) && result.root.nil?
           return data
         else
           return result

data/spec/equivalent-xml_spec.rb

@@ -198,6 +198,13 @@ describe EquivalentXml do
 
       expect(doc1).to be_equivalent_to(doc2).ignoring_content_of("SerialNumber")
     end
+
+    it "should properly compare a document to a string" do
+      doc1 = '<test_document><foo/><test_xml/></test_document>'
+      doc2 = Nokogiri::XML doc1
+      expect(doc1).to be_equivalent_to(doc2)
+      expect(doc2).to be_equivalent_to(doc1)
+    end
   end
 
   context "with the :ignore_content_paths option set to an array of CSS selectors" do
@@ -216,4 +223,13 @@ describe EquivalentXml do
       expect(doc1).to be_equivalent_to(doc2).ignoring_attr_values
     end
   end
+
+  context "(on fragments consisting of multiple nodes)" do
+    it "should compare all nodes" do
+      doc1 = "<h1>Headline</h1><h1>Headline</h1>"
+      doc2 = "<h1>Headline</h1><h2>Headline2</h2>"
+      expect(doc1).not_to be_equivalent_to(doc2)
+    end
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: equivalent-xml
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.5.1
 platform: ruby
 authors:
 - Michael B. Klein
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-15 00:00:00.000000000 Z
+date: 2014-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri