equalizer 0.0.5 → 0.0.7

data/config/rubocop.yml

@@ -0,0 +1,57 @@
+AllCops:
+  Includes:
+    - '**/*.rake'
+    - 'Gemfile'
+    - 'Gemfile.devtools'
+  Excludes:
+    - '**/vendor/**'
+
+# Avoid parameter lists longer than five parameters.
+ParameterLists:
+  Max: 3
+  CountKeywordArgs: true
+
+# Avoid more than `Max` levels of nesting.
+BlockNesting:
+  Max: 3
+
+# Align with the style guide.
+CollectionMethods:
+  PreferredMethods:
+    collect:  'map'
+    inject:   'reduce'
+    find:     'detect'
+    find_all: 'select'
+
+# Do not force public/protected/private keyword to be indented at the same
+# level as the def keyword. My personal preference is to outdent these keywords
+# because I think when scanning code it makes it easier to identify the
+# sections of code and visually separate them. When the keyword is at the same
+# level I think it sort of blends in with the def keywords and makes it harder
+# to scan the code and see where the sections are.
+AccessControl:
+  Enabled: false
+
+# Disable documentation checking until a class needs to be documented once
+Documentation:
+  Enabled: false
+
+# Do not always use &&/|| instead of and/or.
+AndOr:
+  Enabled: false
+
+# Do not favor modifier if/unless usage when you have a single-line body
+IfUnlessModifier:
+  Enabled: false
+
+# Allow case equality operator (in limited use within the specs)
+CaseEquality:
+  Enabled: false
+
+# Constants do not always have to use SCREAMING_SNAKE_CASE
+ConstantName:
+  Enabled: false
+
+# Not all trivial readers/writers can be defined with attr_* methods
+TrivialAccessors:
+  Enabled: false

data/equalizer.gemspec

@@ -6,20 +6,16 @@ Gem::Specification.new do |gem|
   gem.name        = 'equalizer'
   gem.version     = Equalizer::VERSION.dup
   gem.authors     = ['Dan Kubb', 'Markus Schirp']
-  gem.email       = %w[dan.kubb@gmail.com mbj@seonic.net]
+  gem.email       = %w[dan.kubb@gmail.com mbj@schirp-dso.com]
   gem.description = 'Module to define equality, equivalence and inspection methods'
   gem.summary     = gem.description
   gem.homepage    = 'https://github.com/dkubb/equalizer'
+  gem.licenses    = 'MIT'
 
   gem.require_paths    = %w[lib]
-  gem.files            = `git ls-files`.split($/)
-  gem.test_files       = `git ls-files -- {spec}/*`.split($/)
-  gem.extra_rdoc_files = %w[LICENSE README.md TODO]
+  gem.files            = `git ls-files`.split("\n")
+  gem.test_files       = `git ls-files -- spec/{unit,integration}`.split("\n")
+  gem.extra_rdoc_files = %w[LICENSE README.md CONTRIBUTING.md TODO]
 
-  gem.add_runtime_dependency('backports',  [ '~> 3.0', '>= 3.0.3' ])
-  gem.add_runtime_dependency('adamantium', '~> 0.0.6')
-
-  gem.add_development_dependency('rake',  '~> 10.0.3')
-  gem.add_development_dependency('rspec', '~> 1.3.2')
-  gem.add_development_dependency('yard',  '~> 0.8.5')
+  gem.add_development_dependency('bundler', '~> 1.3', '>= 1.3.5')
 end

data/lib/equalizer.rb

@@ -1,10 +1,7 @@
 # encoding: utf-8
 
-require 'adamantium'
-
 # Define equality, equivalence and inspection methods
 class Equalizer < Module
-  include Adamantium
 
   # Initialize an Equalizer with the given keys
   #
@@ -20,6 +17,7 @@ class Equalizer < Module
     @keys = keys
     define_methods
     include_comparison_methods
+    freeze
   end
 
 private

data/lib/equalizer/version.rb

@@ -3,6 +3,6 @@
 class Equalizer < Module
 
   # Gem version
-  VERSION = '0.0.5'.freeze
+  VERSION = '0.0.7'.freeze
 
 end # class Equalizer

data/spec/spec_helper.rb

@@ -1,11 +1,35 @@
 # encoding: utf-8
 
+if ENV['COVERAGE'] == 'true'
+  require 'simplecov'
+  require 'coveralls'
+
+  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+    SimpleCov::Formatter::HTMLFormatter,
+    Coveralls::SimpleCov::Formatter,
+  ]
+
+  SimpleCov.start do
+    command_name 'spec:unit'
+
+    add_filter 'config'
+    add_filter 'spec'
+    add_filter 'vendor'
+
+    minimum_coverage 100
+  end
+end
+
+require 'devtools/spec_helper'
 require 'equalizer'
-require 'spec'
-require 'spec/autorun'
 
-# require spec support files and shared behavior
-Dir[File.expand_path('../{support,shared}/**/*.rb', __FILE__)].each { |f| require f }
+# TODO: FIXME!
+# Cache correct freezer in ice_nine before
+# rspec2 infects the world...
+Equalizer.new
 
-Spec::Runner.configure do |config|
+RSpec.configure do |config|
+  config.expect_with :rspec do |expect_with|
+    expect_with.syntax = :expect
+  end
 end

data/spec/unit/equalizer/methods/{eql_spec.rb → eql_predicate_spec.rb}

@@ -12,7 +12,7 @@ describe Equalizer::Methods, '#eql?' do
       include Equalizer::Methods
 
       def cmp?(comparator, other)
-        !!(comparator and other)
+        !!(comparator && other)
       end
     end
   end

data/spec/unit/equalizer/{class_method/new_spec.rb → universal_spec.rb}

@@ -3,6 +3,7 @@
 require 'spec_helper'
 
 describe Equalizer, '.new' do
+
   let(:object) { described_class }
   let(:name)   { 'User'          }
   let(:klass)  { ::Class.new     }
@@ -23,20 +24,21 @@ describe Equalizer, '.new' do
     it { should be_frozen }
 
     it 'defines #hash and #inspect methods dynamically' do
-      subject.public_instance_methods(false).map(&:to_s).should =~ %w[ hash inspect ]
+      expect(subject.public_instance_methods(false).map(&:to_s).sort)
+        .to eql(%w[hash inspect])
     end
 
     describe '#eql?' do
       context 'when the objects are similar' do
         let(:other) { instance.dup }
 
-        it { instance.eql?(other).should be(true) }
+        it { expect(instance.eql?(other)).to be(true) }
       end
 
       context 'when the objects are different' do
-        let(:other) { stub('other') }
+        let(:other) { double('other') }
 
-        it { instance.eql?(other).should be(false) }
+        it { expect(instance.eql?(other)).to be(false) }
       end
     end
 
@@ -44,46 +46,47 @@ describe Equalizer, '.new' do
       context 'when the objects are similar' do
         let(:other) { instance.dup }
 
-        it { (instance == other).should be(true) }
+        it { expect(instance == other).to be(true) }
       end
 
       context 'when the objects are different' do
-        let(:other) { stub('other') }
+        let(:other) { double('other') }
 
-        it { (instance == other).should be(false) }
+        it { expect(instance == other).to be(false) }
       end
     end
 
     describe '#hash' do
       it 'has the expected arity' do
-        klass.instance_method(:hash).arity.should be(0)
+        expect(klass.instance_method(:hash).arity).to be(0)
       end
 
-      it { instance.hash.should eql(klass.hash) }
+      it { expect(instance.hash).to eql(klass.hash) }
     end
 
     describe '#inspect' do
       it 'has the expected arity' do
-        klass.instance_method(:inspect).arity.should be(0)
+        expect(klass.instance_method(:inspect).arity).to be(0)
       end
 
-      it { instance.inspect.should eql('#<User>') }
+      it { expect(instance.inspect).to eql('#<User>') }
     end
   end
 
   context 'with keys' do
     subject { object.new(*keys) }
 
-    let(:keys)       { [ :first_name ].freeze }
-    let(:first_name) { 'John'                 }
-    let(:instance)   { klass.new(first_name)  }
+    let(:keys)       { [:firstname, :lastname].freeze }
+    let(:firstname)  { 'John'                         }
+    let(:lastname)   { 'Doe'                          }
+    let(:instance)   { klass.new(firstname, lastname) }
 
     let(:klass) do
       ::Class.new do
-        attr_reader :first_name
+        attr_reader :firstname, :lastname
 
-        def initialize(first_name)
-          @first_name = first_name
+        def initialize(firstname, lastname)
+          @firstname, @lastname = firstname, lastname
         end
       end
     end
@@ -100,20 +103,21 @@ describe Equalizer, '.new' do
     it { should be_frozen }
 
     it 'defines #hash and #inspect methods dynamically' do
-      subject.public_instance_methods(false).map(&:to_s).should =~ %w[ hash inspect ]
+      expect(subject.public_instance_methods(false).map(&:to_s).sort)
+        .to eql(%w[ hash inspect ])
     end
 
     describe '#eql?' do
       context 'when the objects are similar' do
         let(:other) { instance.dup }
 
-        it { instance.eql?(other).should be(true) }
+        it { expect(instance.eql?(other)).to be(true) }
       end
 
       context 'when the objects are different' do
-        let(:other) { stub('other') }
+        let(:other) { double('other') }
 
-        it { instance.eql?(other).should be(false) }
+        it { expect(instance.eql?(other)).to be(false) }
       end
     end
 
@@ -121,22 +125,34 @@ describe Equalizer, '.new' do
       context 'when the objects are similar' do
         let(:other) { instance.dup }
 
-        it { (instance == other).should be(true) }
+        it { expect(instance == other).to be(true) }
       end
 
-      context 'when the objects are different' do
-        let(:other) { stub('other') }
+      context 'when the objects are different type' do
+        let(:other) { klass.new('Foo', 'Bar') }
 
-        it { (instance == other).should be(false) }
+        it { expect(instance == other).to be(false) }
+      end
+
+      context 'when the objects are from different type' do
+        let(:other) { double('other') }
+
+        it { expect(instance == other).to be(false) }
       end
     end
 
     describe '#hash' do
-      it { instance.hash.should eql(klass.hash ^ first_name.hash) }
+      it 'returns the expected hash' do
+        expect(instance.hash)
+          .to eql(klass.hash ^ firstname.hash ^ lastname.hash)
+      end
     end
 
     describe '#inspect' do
-      it { instance.inspect.should eql('#<User first_name="John">') }
+      it 'returns the expected string' do
+        expect(instance.inspect)
+          .to eql('#<User firstname="John" lastname="Doe">')
+      end
     end
   end
 end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: equalizer
 version: !ruby/object:Gem::Version
-  version: 0.0.5
-  prerelease: 
+  version: 0.0.7
 platform: ruby
 authors:
 - Dan Kubb
@@ -10,166 +9,94 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-01 00:00:00.000000000 Z
+date: 2013-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: backports
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.0'
-    - - ! '>='
+        version: '1.3'
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 3.0.3
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 3.0.3
-- !ruby/object:Gem::Dependency
-  name: adamantium
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.0.6
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.0.6
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 10.0.3
+        version: 1.3.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 10.0.3
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.3.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.3.2
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.8.5
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
+        version: '1.3'
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.8.5
+        version: 1.3.5
 description: Module to define equality, equivalence and inspection methods
 email:
 - dan.kubb@gmail.com
-- mbj@seonic.net
+- mbj@schirp-dso.com
 executables: []
 extensions: []
 extra_rdoc_files:
 - LICENSE
 - README.md
+- CONTRIBUTING.md
 - TODO
 files:
 - .gitignore
-- .rvmrc
+- .rspec
+- .ruby-gemset
 - .travis.yml
+- CONTRIBUTING.md
 - Gemfile
+- Gemfile.devtools
 - Guardfile
 - LICENSE
 - README.md
 - Rakefile
 - TODO
+- config/devtools.yml
 - config/flay.yml
 - config/flog.yml
+- config/mutant.yml
+- config/reek.yml
 - config/roodi.yml
-- config/site.reek
+- config/rubocop.yml
 - config/yardstick.yml
 - equalizer.gemspec
 - lib/equalizer.rb
 - lib/equalizer/version.rb
-- spec/rcov.opts
-- spec/shared/command_method_behavior.rb
-- spec/shared/each_method_behaviour.rb
-- spec/shared/hash_method_behavior.rb
-- spec/shared/idempotent_method_behavior.rb
-- spec/shared/invertible_method_behaviour.rb
-- spec/spec.opts
 - spec/spec_helper.rb
 - spec/support/config_alias.rb
-- spec/unit/equalizer/class_method/new_spec.rb
-- spec/unit/equalizer/methods/eql_spec.rb
-- spec/unit/equalizer/methods/equal_value_spec.rb
-- tasks/metrics/ci.rake
-- tasks/metrics/flay.rake
-- tasks/metrics/flog.rake
-- tasks/metrics/heckle.rake
-- tasks/metrics/metric_fu.rake
-- tasks/metrics/roodi.rake
-- tasks/metrics/yardstick.rake
-- tasks/spec.rake
-- tasks/yard.rake
+- spec/unit/equalizer/methods/eql_predicate_spec.rb
+- spec/unit/equalizer/methods/equality_operator_spec.rb
+- spec/unit/equalizer/universal_spec.rb
 homepage: https://github.com/dkubb/equalizer
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Module to define equality, equivalence and inspection methods
-test_files: []
+test_files:
+- spec/unit/equalizer/methods/eql_predicate_spec.rb
+- spec/unit/equalizer/methods/equality_operator_spec.rb
+- spec/unit/equalizer/universal_spec.rb
 has_rdoc: