epub_tools 0.3.1 → 0.4.0

data/test/split_chapters_test.rb

@@ -27,26 +27,47 @@ class SplitChaptersTest < Minitest::Test
   end
 
   def test_run_generates_chapter_files
-    EpubTools::SplitChapters.new(@input, 'BookTitle', @out, 'chap').run
+    result = EpubTools::SplitChapters.new(input_file: @input, book_title: 'BookTitle', output_dir: @out,
+                                          output_prefix: 'chap').run
+
+    # Check return value is an array of chapter file paths
+    assert_instance_of Array, result
+    assert_equal 3, result.size
+
+    expected_paths = [
+      File.join(@out, 'chap_0.xhtml'),
+      File.join(@out, 'chap_1.xhtml'),
+      File.join(@out, 'chap_2.xhtml')
+    ]
+
+    expected_paths.each do |path|
+      assert_includes result, path
+      assert_path_exists path, "Expected file #{path} to exist"
+    end
+
     files = Dir.children(@out)
+
     assert_includes files, 'chap_0.xhtml'
     assert_includes files, 'chap_1.xhtml'
     assert_includes files, 'chap_2.xhtml'
 
     # Prologue
     prologue = File.read(File.join(@out, 'chap_0.xhtml'))
+
     assert_includes prologue, '<h1>Prologue</h1>'
     assert_includes prologue, 'Intro text'
     refute_includes prologue, 'Chapter 1'
 
     # Chapter 1
     ch1 = File.read(File.join(@out, 'chap_1.xhtml'))
+
     assert_includes ch1, '<h1>Chapter 1</h1>'
     assert_includes ch1, 'First paragraph'
     refute_includes ch1, 'Chapter 2'
 
     # Chapter 2
     ch2 = File.read(File.join(@out, 'chap_2.xhtml'))
+
     assert_includes ch2, '<h1>Chapter 2</h1>'
     assert_includes ch2, 'Second paragraph'
   end

data/test/{text_style_class_finder_test.rb → style_finder_test.rb}

@@ -1,8 +1,8 @@
 require 'yaml'
 require_relative 'test_helper'
-require_relative '../lib/epub_tools/text_style_class_finder'
+require_relative '../lib/epub_tools/style_finder'
 
-class TextStyleClassFinderTest < Minitest::Test
+class StyleFinder < Minitest::Test
   def setup
     @tmp = Dir.mktmpdir
     @xhtml = File.join(@tmp, 'doc.xhtml')
@@ -22,19 +22,20 @@ class TextStyleClassFinderTest < Minitest::Test
   end
 
   def test_finds_italic_and_bold_classes
-    EpubTools::TextStyleClassFinder.new(@xhtml, @yaml).call
+    EpubTools::StyleFinder.new(file_path: @xhtml, output_path: @yaml).run
     data = YAML.load_file(@yaml)
+
     assert_equal ['c1'], data['italics']
     assert_equal ['c2'], data['bolds']
   end
 
   def test_verbose_mode
     text = <<~OUTPUT
-    Classes with font-style: italic: c1
-    Classes with font-weight: 700: c2
+      Classes with font-style: italic: c1
+      Classes with font-weight: 700: c2
     OUTPUT
     assert_output(text) do
-      EpubTools::TextStyleClassFinder.new(@xhtml, @yaml, verbose: true).call
+      EpubTools::StyleFinder.new(file_path: @xhtml, output_path: @yaml, verbose: true).run
     end
   end
 end

data/test/test_helper.rb

@@ -1,9 +1,8 @@
-if ENV['COVERAGE']
-  require 'simplecov'
-  SimpleCov.start do
-    add_filter '/test/'
-  end
+require 'simplecov'
+SimpleCov.start do
+  add_filter '/test/'
 end
+
 require 'minitest/autorun'
 require 'tmpdir'
 require 'fileutils'

data/test/unpack_ebook_test.rb

@@ -24,6 +24,7 @@ class UnpackEbookTest < Minitest::Test
       Dir.glob(File.join(@build_dir, '**', '*'), File::FNM_DOTMATCH).sort.each do |src_path|
         rel_path = src_path.sub(%r{^#{Regexp.escape(@build_dir)}/?}, '')
         next if rel_path.empty? || rel_path == 'mimetype'
+
         if File.directory?(src_path)
           zip.mkdir(rel_path)
         else
@@ -40,19 +41,34 @@ class UnpackEbookTest < Minitest::Test
   end
 
   def test_run_extracts_all_entries
-    EpubTools::UnpackEbook.new(@epub_file, @dest_dir).run
+    result = EpubTools::UnpackEbook.new(epub_file: @epub_file, output_dir: @dest_dir).run
+
+    # Check return value is the output directory path
+    assert_equal @dest_dir, result
+
     # Check extracted files
     assert Dir.exist?(@dest_dir)
     assert_equal 'application/epub+zip', File.read(File.join(@dest_dir, 'mimetype'))
-    assert File.exist?(File.join(@dest_dir, 'META-INF', 'container.xml'))
-    assert File.exist?(File.join(@dest_dir, 'OEBPS', 'title.xhtml'))
+    assert_path_exists File.join(@dest_dir, 'META-INF', 'container.xml')
+    assert_path_exists File.join(@dest_dir, 'OEBPS', 'title.xhtml')
+  end
+
+  def test_run_with_default_output_dir
+    # Create the test with default output directory
+    result = EpubTools::UnpackEbook.new(epub_file: @epub_file).run
+
+    expected_dir = File.join(File.dirname(@epub_file), File.basename(@epub_file, '.epub'))
+
+    assert_equal expected_dir, result
+    assert Dir.exist?(expected_dir)
+    assert_path_exists File.join(expected_dir, 'mimetype')
   end
 
   def test_missing_epub_raises_error
     missing = File.join(@tmp, 'nope.epub')
     error = assert_raises(ArgumentError) do
-      EpubTools::UnpackEbook.new(missing, @dest_dir).run
+      EpubTools::UnpackEbook.new(epub_file: missing, output_dir: @dest_dir).run
     end
-    assert_includes error.message, "does not exist"
+    assert_includes error.message, 'does not exist'
   end
 end

data/test/xhtml_cleaner_test.rb

@@ -28,12 +28,18 @@ class XHTMLCleanerTest < Minitest::Test
   end
 
   def test_cleaner_removes_and_transforms_tags
-    EpubTools::XHTMLCleaner.new(@file, @config).call
-    result = File.read(@file)
-    assert_includes result, '<i>ItalicsOnly</i>'
-    assert_includes result, 'KeepThis'
-    refute_includes result, '<span'
-    refute_includes result, '<hr'
-    refute_includes result, 'RemoveMe'
+    result = EpubTools::XHTMLCleaner.new(filename: @file, class_config: @config).run
+
+    # Check return value is the filename that was cleaned
+    assert_equal @file, result
+    assert_path_exists @file
+
+    content = File.read(@file)
+
+    assert_includes content, '<i>ItalicsOnly</i>'
+    assert_includes content, 'KeepThis'
+    refute_includes content, '<span'
+    refute_includes content, '<hr'
+    refute_includes content, 'RemoveMe'
   end
 end

data/test/xhtml_extractor_test.rb

@@ -22,8 +22,24 @@ class XHTMLExtractorTest < Minitest::Test
   end
 
   def test_extracts_xhtml_excluding_nav
-    @extractor.extract_all
+    result = @extractor.run
+
+    # Check return value is an array of extracted file paths
+    assert_instance_of Array, result
+    assert_equal 2, result.size
+
+    expected_paths = [
+      File.join(@tgt, 'sample_chapter1.xhtml'),
+      File.join(@tgt, 'sample_ch2.xhtml')
+    ]
+
+    expected_paths.each do |path|
+      assert_includes result, path
+      assert_path_exists path
+    end
+
     files = Dir.children(@tgt)
+
     assert_includes files, 'sample_chapter1.xhtml'
     assert_includes files, 'sample_ch2.xhtml'
     refute_includes files, 'nav.xhtml'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: epub_tools
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Jaime Rodas
@@ -23,20 +23,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.18'
-- !ruby/object:Gem::Dependency
-  name: rubyzip
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.4'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -52,33 +38,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '13.2'
 - !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.25'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.25'
-- !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubyzip
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: '2.4'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.4'
 email:
 - rodas@hey.com
 executables:
@@ -90,6 +62,7 @@ files:
 - ".github/workflows/ci.yml"
 - ".gitignore"
 - ".nova/Configuration.json"
+- ".rubocop.yml"
 - ".ruby-version"
 - Gemfile
 - Gemfile.lock
@@ -100,25 +73,34 @@ files:
 - epub_tools.gemspec
 - lib/epub_tools.rb
 - lib/epub_tools/add_chapters.rb
-- lib/epub_tools/cli_helper.rb
+- lib/epub_tools/cli.rb
+- lib/epub_tools/cli/command_registry.rb
+- lib/epub_tools/cli/option_builder.rb
+- lib/epub_tools/cli/runner.rb
 - lib/epub_tools/compile_book.rb
 - lib/epub_tools/epub_initializer.rb
+- lib/epub_tools/loggable.rb
 - lib/epub_tools/pack_ebook.rb
 - lib/epub_tools/split_chapters.rb
-- lib/epub_tools/text_style_class_finder.rb
+- lib/epub_tools/style_finder.rb
 - lib/epub_tools/unpack_ebook.rb
 - lib/epub_tools/version.rb
 - lib/epub_tools/xhtml_cleaner.rb
 - lib/epub_tools/xhtml_extractor.rb
 - style.css
 - test/add_chapters_test.rb
+- test/cli/command_registry_test.rb
+- test/cli/option_builder_test.rb
+- test/cli/runner_test.rb
+- test/cli_commands_test.rb
+- test/cli_test.rb
 - test/cli_version_test.rb
 - test/compile_book_test.rb
 - test/epub_initializer_test.rb
 - test/pack_ebook_test.rb
 - test/split_chapters_test.rb
+- test/style_finder_test.rb
 - test/test_helper.rb
-- test/text_style_class_finder_test.rb
 - test/unpack_ebook_test.rb
 - test/xhtml_cleaner_test.rb
 - test/xhtml_extractor_test.rb
@@ -128,6 +110,7 @@ licenses:
 metadata:
   source_code_uri: https://github.com/jaimerodas/epub_tools/tree/main
   homepage_uri: https://github.com/jaimerodas/epub_tools
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib

data/lib/epub_tools/cli_helper.rb

@@ -1,31 +0,0 @@
-require 'optparse'
-
-module EpubTools
-  # A simple helper to DRY CLI OptionParser usage across commands
-  class CLIHelper
-    # Parses ARGV into options hash, enforces required keys, and displays help/errors.
-    # options: hash of defaults; required_keys: array of symbols required
-    def self.parse(options = {}, required_keys = [], &block)
-      parser = OptionParser.new do |opts|
-        block.call(opts, options)
-        opts.on('-h', '--help', 'Prints this help') { puts opts; exit }
-      end
-      begin
-        parser.parse!
-        unless required_keys.empty?
-          missing = required_keys.select { |k| options[k].nil? }
-          unless missing.empty?
-            STDERR.puts "Missing required options: #{missing.map { |k| "--#{k.to_s.gsub('_','-')}" }.join(', ')}"
-            STDERR.puts parser
-            exit 1
-          end
-        end
-      rescue OptionParser::InvalidOption, OptionParser::MissingArgument => e
-        STDERR.puts e.message
-        STDERR.puts parser
-        exit 1
-      end
-      options
-    end
-  end
-end