epub-maker 0.1.0 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79b98ceec5a5bd31ccbcea077c5c109e11b98c64acab7fa9c6d2eb4ede22b25c
-  data.tar.gz: e1520191cd13384acd70c13e5a7d390587bb6238c535ba3971e5d8485d3c1920
+  metadata.gz: 4aeffa7298ad5bb22c54beaa0eaafc0f46cbcd724a950202d917ef9186345a5c
+  data.tar.gz: ea10fe12472421d4585636290c814df4eab87d9d4fc466a480d94d229174d3c4
 SHA512:
-  metadata.gz: 8c6d10a5797d1ee3f66fc520875b3d569e746841f70badfce7f77cbf15e9b67121e09d9e6144ec3cde21ec92eb6afb303849db2939866a49fe61a0b65195fb79
-  data.tar.gz: cfb54f2c6bff8808e0a846d2f94d0f5668bb1e1e267b5e4d64725ccaa0182f66f146f9c1ca963858f6e3ff5d93882c813798b34d0d024fb684d084cf1eaaf3c1
+  metadata.gz: 3ef569b71794f317b6a05136bd94ff9dcee19caa0993d58ab7f1f4d5b03bba2edc9836300892e5b1780ce0afe1b1498b84bfcbd884c9d6fe4ad9e82b1ef191a4
+  data.tar.gz: 39e9011f7bcac33805936f1842959a697bbf8b72d415b7b6cdd82b0dc782548316f369951e7aac68c299f1f50f40058239316868bd55de4841dc92da81775c23

data/.gitlab-ci.yml

@@ -38,7 +38,7 @@ test:2.5:
       - deps
 
 test:2.6:
-  image: ruby:2.6-rc
+  image: ruby:2.6
   script: bundle exec rake test
   except:
     - tags
@@ -46,3 +46,23 @@ test:2.6:
     key: ruby:2.6
     paths:
       - deps
+
+test:2.7:
+  image: ruby:2.7
+  script: bundle exec rake test
+  except:
+    - tags
+  cache:
+    key: ruby:2.7
+    paths:
+      - deps
+
+test:3.0:
+  image: ruby:3.0-rc
+  script: bundle exec rake test
+  except:
+    - tags
+  cache:
+    key: ruby:3.0
+    paths:
+      - deps

data/CHANGELOG.markdown

@@ -1,3 +1,30 @@
+0.1.5
+-----
+
+* [BUG FIX]Compare path name in the same encoding when finding file in ZIP archive
+* Add `PhysicalContaienr.mtime` API to set mtime of files in EPUB archive
+
+0.1.4
+-----
+
+* Add `Publication::Package::Metadata#modified=` method
+* Rescue Errno::EXDEV on renaming temporary EPUB file
+
+0.1.3
+-----
+
+* Add workaround Window file renaming problem
+
+0.1.2
+------
+
+* Close temp file when archiving EPUB file
+
+0.1.1
+-----
+
+* Update Nokogiri version to < 1.11
+
 0.1.0
 -----
 

data/README.markdown

@@ -178,40 +178,19 @@ Todo
 Recent Changes
 --------------
 
-### 0.1.0
+### 0.1.5
 
-* [BUG FIX]Fix the case file extension should be wrong
-* Add Nokogiri to runtime dependencies explicitly
+* [BUG FIX]Compare path name in the same encoding when finding file in ZIP archive
+* Add `PhysicalContaienr.mtime` API to set mtime of files in EPUB archive
 
-### 0.0.9
+### 0.1.4
 
-* Remove [ruby-uuid][] gem from dependencies
-* [BUG FIX]Convert Set to Array before writing into XML
-* Follow change of EPUB Parser v0.3.6
+* Add `Publication::Package::Metadata#modified=` method
+* Rescue Errno::EXDEV on renaming temporary EPUB file
 
-[ruby-uuid]: https://github.com/shyouhei/ruby-uuid
+### 0.1.3
 
-### 0.0.8
-
-* Use default temporary directory for `EPUB::Maker.archive`
-
-### 0.0.7
-
-* Change temporary directory used by `EPUB::Maker.archive`
-
-### 0.0.6
-
-* Add `epub-archive` command
-* Add `EPUB::Maker.archive` method
-
-### 0.0.5
-
-* Fix bug to modify `dc:rights` to `dc:right`
-
-### 0.0.4
-* API change: #save -> #write for PhysicalContainer classes
-* Bump required EPUB Parser version: 0.2.0 -> 0.2.6
-* Deprecate `EPUB::OCF::PhysicalContainer.save`
+* Add workaround Window file renaming problem
 
 Contributing
 ------------

data/Rakefile

@@ -2,11 +2,17 @@ require 'rake/testtask'
 require 'rake/clean'
 require 'yard'
 require "rubygems/tasks"
+  require "open-uri"
 
 task :default => :test
 
 CLEAN.include 'README.html'
 
+VALID_EPUB = "test/fixtures/accessible_epub_3.epub"
+file VALID_EPUB do |t|
+  File.write t.name, URI("https://github.com/IDPF/epub3-samples/releases/download/20170606/accessible_epub_3.epub").read
+end
 Rake::TestTask.new
+task test: VALID_EPUB
 YARD::Rake::YardocTask.new
 Gem::Tasks.new

data/epub-maker.gemspec

@@ -25,7 +25,8 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'archive-zip'
   gem.add_runtime_dependency 'rake'
   gem.add_runtime_dependency 'addressable', '>= 2.3.5'
-  gem.add_runtime_dependency "nokogiri", ">= 1.6.0", "< 1.9"
+  gem.add_runtime_dependency 'rexml'
+  gem.add_runtime_dependency "nokogiri", ">= 1.6.0", "< 1.11"
 
   gem.add_development_dependency 'zipruby'
   gem.add_development_dependency 'test-unit'

data/lib/epub/maker.rb

@@ -76,7 +76,9 @@ module EPUB
         raise "source directory #{source_dir} not exist" unless source_dir.exist?
 
         epub_file = Pathname(epub_file)
-        temp_dest = Pathname(Tempfile.create(epub_file.basename.to_path, epub_file.dirname.to_path))
+        temp_dest_file = Tempfile.create(epub_file.basename.to_path, epub_file.dirname.to_path)
+        temp_dest_file.close
+        temp_dest = Pathname(temp_dest_file)
         Pathname.mktmpdir "epub-maker" do |dir|
           temp_container = dir/source_dir.basename
 

data/lib/epub/maker/ocf/physical_container.rb

@@ -13,15 +13,33 @@ module EPUB
   class OCF
     class PhysicalContainer
       class << self
+        @@mtime = nil
+
+        def mtime
+          @@mtime
+        end
+
+        # Sets +mtime+, which is used when setting mtime of file in EPUB(ZIP) archive.
+        # Currently supported for only {ArchiveZip} adapter
+        #
+        # @example
+        #   EPUB::OCF::PhysicalCotainer.adapter = :ArchiveZip
+        #   EPUB::OCF::PhysicalCotainer.mtime = Time.new(2020, 1, 1)
+        #
+        # @return [Time]
+        def mtime=(time)
+          @@mtime = time
+        end
+
         def write(container_path, path_name, content)
           open(container_path) {|container|
-            container.write(path_name, content)
+            container.write(path_name, content, mtime: mtime)
           }
         end
 
         def save(container_path, path_name, content)
           warn "EPUB::OCF::PhysicalContainer.#{__method__} is deprecated. Use .write instead"
-          write(container_path, path_name, content)
+          write(container_path, path_name, content, mtime: mtime)
         end
       end
     end

data/lib/epub/maker/ocf/physical_container/archive_zip.rb

@@ -5,7 +5,7 @@ module EPUB
     class PhysicalContainer
       class ArchiveZip < self
         # @todo Write multiple files at once
-        def write(path_name, content)
+        def write(path_name, content, mtime: nil)
           ::Dir.mktmpdir do |dir|
             tmp_archive_path = ::File.join(dir, ::File.basename(@container_path) + '.tmp')
             ::File.open @container_path do |archive_in|
@@ -15,23 +15,36 @@ module EPUB
                   Archive::Zip.open archive_out, :w do |z_out|
                     updated = false
                     z_in.each do |entry|
-                      if entry.zip_path == path_name
+                      if entry.zip_path == path_name.force_encoding('ASCII-8BIT')
                         entry.file_data = StringIO.new(content)
                         updated = true
                       end
+                      if mtime
+                        entry.mtime = mtime
+                      end
                       z_out << entry
                     end
                     unless updated
                       entry = Archive::Zip::Entry::File.new(path_name)
                       entry.file_data = StringIO.new(content)
+                      if mtime
+                        entry.mtime = mtime
+                      end
                       z_out << entry
                     end
                   end
                 end
               end
             end
-            ::File.chmod 0666 & ~::File.umask, tmp_archive_path
-            ::File.rename tmp_archive_path, @container_path
+            begin
+              ::File.chmod 0666 & ~::File.umask, tmp_archive_path
+              ::File.rename tmp_archive_path, @container_path
+            rescue Errno::EACCES, Errno::EXDEV
+              # In some cases on Windows, we fail to rename the file
+              # but succeed to copy although I don't know why.
+              # Race condition? I don't know. But no time to dig deeper.
+              ::FileUtils.copy tmp_archive_path, @container_path
+            end
           end
         end
       end

data/lib/epub/maker/publication.rb

@@ -1,6 +1,7 @@
 require 'securerandom'
 require 'epub/publication/package'
 require "nokogiri"
+require "mimemagic"
 
 module EPUB
   module Publication
@@ -183,6 +184,21 @@ module EPUB
           name
         end
 
+        # Shortcut to set modified date time
+        # @param datetime [String, #to_time]
+        def modified=(datetime)
+          modified = self.modified
+          unless modified
+            modified = Meta.new
+            modified.property = "dcterms:modified"
+            self.metas << modified
+          end
+          modified.content = datetime.respond_to?(:to_time) ?
+                               datetime.to_time.utc.xmlschema :
+                               datetime
+          modified
+        end
+
         class Meta
           def valid?
             property
@@ -235,6 +251,15 @@ module EPUB
           end
           item.manifest = self
           yield item if block_given?
+          unless item.media_type
+            path = item.href.to_s
+            item.media_type =
+              if path.end_with? ".html"
+                "application/xhtml+xml"
+              else
+                MimeMagic.by_path(item.href.to_s).type
+              end
+          end
           self << item
           item
         end
@@ -263,7 +288,11 @@ module EPUB
               elsif content_file
                 File.read(content_file)
               else
-                raise 'no content nor content_file'
+                begin
+                  read
+                rescue OCF::PhysicalContainer::NoEntry
+                  raise 'no content nor content_file'
+                end
               end
             book = manifest.package.book
             book.container_adapter.write book.epub_file, entry_name, content_to_save

data/lib/epub/maker/version.rb

@@ -1,5 +1,5 @@
 module EPUB
   module Maker
-    VERSION = "0.1.0"
+    VERSION = "0.1.5"
   end
 end

data/test/helper.rb

@@ -11,6 +11,12 @@ class Test::Unit::TestCase
   def assert_valid_epub(file)
     assert_true Epubcheck::Ruby::CLI.new.execute(file)
   end
+
+  private
+
+  def valid_epub
+    Pathname.new("test/fixtures/accessible_epub_3.epub")
+  end
 end
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 require 'epub'

data/test/test_inplace_editing.rb

@@ -1,13 +1,15 @@
 require_relative 'helper'
 require 'epub/maker'
 
-class TestImplaceEditing < Test::Unit::TestCase
+class TestInplaceEditing < Test::Unit::TestCase
   def setup
     @assets_dir = Pathname(__dir__)/'fixtures'/'book'
     @dir = Pathname.mktmpdir('epub-maker-test')
     @file = @dir/'book.epub'
     EPUB::Maker.archive @assets_dir, @file
     @book = EPUB::Parser.parse(@file)
+    @valid_epub = @dir/valid_epub.basename
+    FileUtils.cp valid_epub, @valid_epub
   end
 
   def teardown
@@ -57,4 +59,25 @@ class TestImplaceEditing < Test::Unit::TestCase
 
     assert_match '<title>Edited Title</title>', item.read
   end
+
+  def test_edit_without_change
+    epub = EPUB::Parser.parse(@valid_epub)
+    epub.save
+    assert_equal epub.release_identifier, EPUB::Parser.parse(@valid_epub).release_identifier
+  end
+
+  def test_specify_mtime
+    # Currently, only ArchiveZip supports this API
+    EPUB::OCF::PhysicalContainer.adapter = :ArchiveZip
+    mtime = EPUB::OCF::PhysicalContainer.mtime = Time.new(2020, 1, 1)
+    epub = EPUB::Parser.parse(@valid_epub)
+    epub.metadata.unique_identifier.content = "new-unique-identifier"
+    epub.package.save
+
+    Archive::Zip.open @valid_epub.to_path do |z|
+      z.each do |entry|
+        assert_equal mtime, entry.mtime
+      end
+    end
+  end
 end

data/test/test_maker.rb

@@ -73,7 +73,6 @@ class TestMaker < Test::Unit::TestCase
       error_message = error.message
     end
     dirname = error_message.match(/\[EPUB::Maker\].*:\s*(.+)\Z/m).captures.last
-
     assert_path_exist dirname
   end
 

data/test/test_maker_publication.rb

@@ -2,6 +2,7 @@
 require_relative 'helper'
 require 'epub/parser'
 require 'epub/maker/publication'
+require "date"
 
 class TestMakerPublication < Test::Unit::TestCase
   def setup
@@ -37,4 +38,25 @@ class TestMakerPublication < Test::Unit::TestCase
     media_type = doc.xpath('/opf:package/opf:bindings/opf:mediaType', EPUB::NAMESPACES).first
     assert_equal 'application/x-demo-slideshow', media_type['media-type']
   end
+
+  def test_modified=
+    metadata = EPUB::Publication::Package::Metadata.new
+    metadata.modified = "2011-01-01T12:00:00Z"
+
+    assert_equal 1, metadata.metas.length
+    assert_equal "2011-01-01T12:00:00Z", metadata.modified.content
+
+    metadata.modified = Time.new(2020, 2, 1, 0, 0, 0, "+09:00")
+    assert_equal 1, metadata.metas.length
+    assert_equal "2020-01-31T15:00:00Z", metadata.modified.content
+
+    metadata.modified = Date.new(1993, 2, 24)
+    assert_equal 1, metadata.metas.length
+    expected = Time.new(1993, 2, 24, 0, 0, 0, Time.now.utc_offset)
+    assert_equal expected.utc.xmlschema, metadata.modified.content
+
+    metadata.modified = DateTime.new(1993, 2, 24, 0, 0, 0, "+00:00")
+    assert_equal 1, metadata.metas.length
+    assert_equal "1993-02-24T00:00:00Z", metadata.modified.content
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: epub-maker
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.5
 platform: ruby
 authors:
 - KITAITI Makoto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-29 00:00:00.000000000 Z
+date: 2020-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: epub-parser
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.5
+- !ruby/object:Gem::Dependency
+  name: rexml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -89,7 +103,7 @@ dependencies:
         version: 1.6.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '1.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -99,7 +113,7 @@ dependencies:
         version: 1.6.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '1.11'
 - !ruby/object:Gem::Dependency
   name: zipruby
   requirement: !ruby/object:Gem::Requirement
@@ -288,8 +302,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: EPUB Maker