eppo-server-sdk 3.3.0 → 3.4.0

data/README.md

@@ -38,8 +38,40 @@ eppo_core = { path = '../eppo_core' }
 
 Make sure you remove the override before updating `Cargo.lock`. Otherwise, the lock file will be missing `eppo_core` checksum and will be unsuitable for release. (CI will warn you if you do this accidentally.)
 
+## Build locally
+
+Install all dependencies:
+```sh
+bundle install
+```
+
+Build native extension:
+```sh
+bundle exec rake build
+```
+
+Run tests:
+```sh
+bundle exec rspec
+```
+
 ## Releasing
 
 * Bump versions in `ruby-sdk/lib/eppo_client/version.rb` and `ruby-sdk/ext/eppo_client/Cargo.toml`
 * Run `cargo update --workspace --verbose` to update `Cargo.lock`
 * Run `bundle` to update `Gemfile.lock`
+
+
+## Building Ruby native lib
+
+1. Clone this repository at the desired Ruby SDK tag, eg.: `git clone --depth 1 --branch ruby-sdk@x.y.z https://github.com/Eppo-exp/eppo-multiplatform.git`
+2. Open `build.sh` and update `rb-sys-dock --platform <platform>` with the desired platform, eg.: `rb-sys-dock --platform x86_64-linux`
+3. Run `docker build --build-arg WORKDIR=$(pwd) -f Dockerfile.ruby.build -t ruby-sdk-builder .` to build the builder docker image
+4. Run the following command to build the gem with native lib:
+```
+mkdir -p rust/cargo/registry && docker run --rm -it \
+  -v /var/run/docker.sock:/var/run/docker.sock \
+  -v /tmp:/tmp -v \
+  $(pwd)/rust:$(pwd)/rust ruby-sdk-builder
+```
+5. The gem will be available at `ruby-sdk/pkg/eppo-server-sdk-x.y.z-arch.gem`

data/ext/eppo_client/Cargo.toml

@@ -1,18 +1,18 @@
 [package]
 name = "eppo_client"
 # TODO: this version and lib/eppo_client/version.rb should be in sync
-version = "3.3.0"
+version = "3.4.0"
 edition = "2021"
 license = "MIT"
 publish = false
-rust-version = "1.71.1"
+rust-version = "1.75.0"
 
 [lib]
 crate-type = ["cdylib"]
 
 [dependencies]
 env_logger = { version = "0.11.3", features = ["unstable-kv"] }
-eppo_core = { version = "4.1.1", features = ["vendored"] }
+eppo_core = { version = "=7.0.0", features = ["vendored", "magnus"] }
 log = { version = "0.4.21", features = ["kv_serde"] }
 magnus = { version = "0.6.4" }
 serde = { version = "1.0.203", features = ["derive"] }

data/ext/eppo_client/src/client.rs

@@ -8,7 +8,7 @@ use eppo_core::{
     ufc::VariationType,
     Attributes, ContextAttributes,
 };
-use magnus::{error::Result, exception, prelude::*, Error, TryConvert, Value};
+use magnus::{error::Result, exception, prelude::*, Error, IntoValue, Ruby, TryConvert, Value};
 
 use crate::{configuration::Configuration, SDK_METADATA};
 
@@ -116,7 +116,8 @@ impl Client {
     }
 
     pub fn get_assignment(
-        &self,
+        ruby: &Ruby,
+        rb_self: &Self,
         flag_key: String,
         subject_key: String,
         subject_attributes: Value,
@@ -125,7 +126,7 @@ impl Client {
         let expected_type: VariationType = serde_magnus::deserialize(expected_type)?;
         let subject_attributes: Attributes = serde_magnus::deserialize(subject_attributes)?;
 
-        let result = self
+        let result = rb_self
             .evaluator
             .get_assignment(
                 &flag_key,
@@ -136,7 +137,7 @@ impl Client {
             // TODO: maybe expose possible errors individually.
             .map_err(|err| Error::new(exception::runtime_error(), err.to_string()))?;
 
-        Ok(serde_magnus::serialize(&result).expect("assignment value should be serializable"))
+        Ok(result.into_value_with(&ruby))
     }
 
     pub fn get_assignment_details(
@@ -146,6 +147,8 @@ impl Client {
         subject_attributes: Value,
         expected_type: Value,
     ) -> Result<Value> {
+        let ruby = Ruby::get_with(subject_attributes);
+
         let expected_type: VariationType = serde_magnus::deserialize(expected_type)?;
         let subject_attributes: Attributes = serde_magnus::deserialize(subject_attributes)?;
 
@@ -156,7 +159,7 @@ impl Client {
             Some(expected_type),
         );
 
-        Ok(serde_magnus::serialize(&result).expect("assignment value should be serializable"))
+        Ok(result.into_value_with(&ruby))
     }
 
     pub fn get_bandit_action(
@@ -173,7 +176,7 @@ impl Client {
         .map_err(|err| {
             Error::new(
                 exception::runtime_error(),
-                format!("enexpected value for subject_attributes: {err}"),
+                format!("Unexpected value for subject_attributes: {err}"),
             )
         })?;
         let actions = serde_magnus::deserialize(actions)?;

data/lib/eppo_client/client.rb

@@ -22,7 +22,7 @@ module EppoClient
     def init(config)
       config.validate
 
-      if !@core.nil?
+      if @core
         STDERR.puts "Eppo Warning: multiple initialization of the client"
         @core.shutdown
       end
@@ -91,7 +91,10 @@ module EppoClient
       log_assignment(result[:assignment_event])
       log_bandit_action(result[:bandit_event])
 
-      return {:variation => result[:variation], :action => result[:action]}
+      {
+        :variation => result[:variation],
+        :action => result[:action]
+      }
     end
 
     def get_bandit_action_details(flag_key, subject_key, subject_attributes, actions, default_variation)
@@ -102,7 +105,7 @@ module EppoClient
       log_assignment(result[:assignment_event])
       log_bandit_action(result[:bandit_event])
 
-      return {
+      {
         :variation => result[:variation],
         :action => result[:action],
         :evaluationDetails => details
@@ -116,13 +119,11 @@ module EppoClient
       logger = Logger.new($stdout)
       begin
         assignment = @core.get_assignment(flag_key, subject_key, subject_attributes, expected_type)
-        if not assignment then
-          return default_value
-        end
+        return default_value unless assignment
 
         log_assignment(assignment[:event])
 
-        return assignment[:value][:value]
+        return assignment[:value]
       rescue StandardError => error
         logger.debug("[Eppo SDK] Failed to get assignment: #{error}")
 
@@ -137,19 +138,16 @@ module EppoClient
       result, event = @core.get_assignment_details(flag_key, subject_key, subject_attributes, expected_type)
       log_assignment(event)
 
-      if not result[:variation] then
+      if !result[:variation]
         result[:variation] = default_value
-      else
-        # unwrap from AssignmentValue to untyped value
-        result[:variation] = result[:variation][:value]
       end
 
-      return result
+      result
     end
     # rubocop:enable Metrics/MethodLength
 
     def log_assignment(event)
-      if not event then return end
+      return unless event
 
       # Because rust's AssignmentEvent has a #[flatten] extra_logging
       # field, serde_magnus serializes it as a normal HashMap with
@@ -170,7 +168,7 @@ module EppoClient
     end
 
     def log_bandit_action(event)
-      if not event then return end
+      return unless event
 
       begin
         @assignment_logger.log_bandit_action(event)

data/lib/eppo_client/version.rb

@@ -2,5 +2,5 @@
 
 # TODO: this version and ext/eppo_client/Cargo.toml should be in sync
 module EppoClient
-  VERSION = "3.3.0"
+  VERSION = "3.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eppo-server-sdk
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.4.0
 platform: ruby
 authors:
 - Eppo
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-11-22 00:00:00.000000000 Z
+date: 2025-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rb_sys