epics 2.1.0 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15557f467cdc9d8ca61665fc9c177001f95c668c6b05bab941223a630130e7f4
-  data.tar.gz: b6177ec4c23c26641ddc48eb1b99478c49768e02a114d448769aa405bbe6bedc
+  metadata.gz: f91eb25c88880d2a09b23003cffc9601350a5c980e618945186177108917fdcb
+  data.tar.gz: aea9b65df7b8773a324cc8a8e457b96036e35f5cba7bf2aebc424183d9053b43
 SHA512:
-  metadata.gz: ae3f679ae1b3d6a32851701716eca59ab4d17d9e3ef8f0f95ba7acd09ebb1c9f80750ee76f65e53596490b9aead1c89196c530515a8c40a19049c14d254fe8eb
-  data.tar.gz: a4b9d40d66190362de7f68d11fbb178827980683c5d25323c9d48a6f15f5fa4dcce721f52e80b601a73f3877dee648042c2d95938ce597b91868317b050d8b7c
+  metadata.gz: 2559bbcbb940f957f21ec202d1fd67f766017426868c3413bba616aa438b904bbd8980e6f716274142e72707ca5166c34f8ac5ff23b4b996c4d49accc948ec07
+  data.tar.gz: '081d8491005d6c146b002d22c0a0f3fc90feb4c09d67cc406383ea8825c47e28d6579012d3e7b4ec754909ba60c65e5fbcdb6f7e145961a545160b89f53f84d9'

data/.semaphore/semaphore.yml

@@ -16,30 +16,30 @@ blocks:
   - name: Spec versions
     task:
       jobs:
-        - name: "2.7"
+        - name: "3.0"
           commands:
             - checkout
-            - sem-version ruby 2.7
+            - sem-version ruby 3.0
             - cache restore
-            - gem install bundler:2.4.3
+            - gem install bundler:2.4.12
             - bundle install
             - cache store
             - bundle exec rspec
-        - name: "3.0"
+        - name: "3.1"
           commands:
             - checkout
-            - sem-version ruby 3.0
+            - sem-version ruby 3.1
             - cache restore
-            - gem install bundler:2.4.3
+            - gem install bundler:2.4.12
             - bundle install
             - cache store
             - bundle exec rspec
-        - name: "3.1"
+        - name: "3.2"
           commands:
             - checkout
-            - sem-version ruby 3.1
+            - sem-version ruby 3.2
             - cache restore
-            - gem install bundler:2.4.3
+            - gem install bundler:2.4.12
             - bundle install
             - cache store
             - bundle exec rspec

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+### 2.1.2
+
+- [BUGFIX] Fix order data encryption for OpenSSL 3
+
+### 2.1.1
+
+- [HOUSEKEEPING] update Bank public key initialization for OpenSSL 3
+
 ### 2.1.0
 
 - [HOUSEKEEPING] updates Nokogiri dependencies

data/README.md

@@ -3,9 +3,11 @@
 
 # Epics
 
-EPICS is a ruby implementation of the [EBICS](http://www.ebics.org/) (Electronic Banking Internet
+EPICS is a ruby implementation of the [EBICS](https://www.ebics.org/) (Electronic Banking Internet
 Communication Standard).
 
+It supports EBICS 2.5.
+
 The client supports the complete initialization process comprising INI, HIA and HPB including the
 INI letter generation. It offers support for the most common download and upload order types
 (STA HAA HTD HPD PTK HAC HKD C52 C53 C54 CD1 CDB CDD CCT VMK).

data/epics.gemspec

@@ -43,8 +43,9 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'faraday',  '>= 1.10.0'
   spec.add_dependency 'nokogiri', '>= 1.14.0'
   spec.add_dependency 'rubyzip',  '>= 2.3.2'
+  spec.add_dependency 'rexml',    '>= 3.2.5'
 
-  spec.add_development_dependency 'bundler', '>= 2.4.3'
+  spec.add_development_dependency 'bundler', '>= 2.4.12'
   spec.add_development_dependency 'equivalent-xml'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rake', '~> 13.0'

data/lib/epics/client.rb

@@ -105,13 +105,11 @@ class Epics::Client
       modulus  = Base64.decode64(node.at_xpath(".//*[local-name() = 'Modulus']").content)
       exponent = Base64.decode64(node.at_xpath(".//*[local-name() = 'Exponent']").content)
 
-      bank   = OpenSSL::PKey::RSA.new
-      if bank.respond_to?(:set_key)
-        bank.set_key(OpenSSL::BN.new(modulus, 2), OpenSSL::BN.new(exponent, 2), nil)
-      else
-        bank.n = OpenSSL::BN.new(modulus, 2)
-        bank.e = OpenSSL::BN.new(exponent, 2)
-      end
+      sequence = []
+      sequence << OpenSSL::ASN1::Integer.new(OpenSSL::BN.new(modulus, 2))
+      sequence << OpenSSL::ASN1::Integer.new(OpenSSL::BN.new(exponent, 2))
+
+      bank = OpenSSL::PKey::RSA.new(OpenSSL::ASN1::Sequence(sequence).to_der)
 
       self.keys["#{host_id.upcase}.#{type}"] = Epics::Key.new(bank)
     end

data/lib/epics/generic_upload_request.rb

@@ -1,15 +1,17 @@
 class Epics::GenericUploadRequest < Epics::GenericRequest
   attr_accessor :key
+  attr_accessor :iv
   attr_accessor :document
 
   def initialize(client, document)
     super(client)
     self.document = document
-    self.key ||= cipher.random_key
+    self.key = cipher.random_key
+    self.iv = 0.chr * cipher.iv_len
   end
 
   def cipher
-    @cipher ||= OpenSSL::Cipher.new("aes-128-cbc")
+    @cipher ||= OpenSSL::Cipher.new("aes-128-cbc").tap { |cipher| cipher.encrypt }
   end
 
   def digester
@@ -49,9 +51,9 @@ class Epics::GenericUploadRequest < Epics::GenericRequest
 
   def encrypt(d)
     cipher.reset
-    cipher.encrypt
     cipher.padding = 0
     cipher.key = self.key
+    cipher.iv = self.iv
     (cipher.update(pad(d)) + cipher.final)
   end
 

data/lib/epics/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Epics
-  VERSION = '2.1.0'
+  VERSION = '2.1.2'
 end

data/spec/generic_upload_spec.rb

@@ -46,4 +46,13 @@ RSpec.describe Epics::GenericUploadRequest do
     end
 
   end
+
+  describe '#encrypted_order_data' do
+    it 'returns the same data every time' do
+      data_1 = subject.encrypted_order_data
+      data_2 = subject.encrypted_order_data
+
+      expect(data_1).to eq(data_2)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: epics
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.2
 platform: ruby
 authors:
 - Lars Brillert
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-25 00:00:00.000000000 Z
+date: 2023-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -52,20 +52,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.2
+- !ruby/object:Gem::Dependency
+  name: rexml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.2.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.2.5
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.3
+        version: 2.4.12
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.3
+        version: 2.4.12
 - !ruby/object:Gem::Dependency
   name: equivalent-xml
   requirement: !ruby/object:Gem::Requirement