epics 1.8.0 → 1.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0a022ab9e8c8af9a64b970a4d927b53f09321b6767545bee5c584538aa4a296a
-  data.tar.gz: 3dd7d404d54e32fe14993ba0272e666b94f38e1238d304c916d373ea057bff75
+  metadata.gz: 1d010ef17cbdb364881aa1d097aa37aa5d5dcbe10475042a48c2fdbff7f06bbd
+  data.tar.gz: 9344c72519ee202a8b919ee1995d6784063767bf5b486f43e4f69fe1866c4099
 SHA512:
-  metadata.gz: d821c36ea05aa51c005dd1dc6b86cd28f8067faf746e556e87f098fecd1a1951c2e33f3ee4a2df494a0df54e168b07f3155ea60be132a4663711a39ab03f8116
-  data.tar.gz: b48e1f0da804c867f0ce292f2db56352745f515607ea2292bae08c689fb6124b7c025aa4463792042a0e85feda8b4a0016b612c97cbb443d0648e5f499e84967
+  metadata.gz: 9fea543b7b03303a272a67499f1c79b60e574c58fc43e9843f11100ca92f8311869c89904f3b1d3a7507fd579380b846d81752b25a488a4969d5548b5820b070
+  data.tar.gz: 6f8df9fe023baee3c6f6d292a9ba1df6a77af88da38a4b93323c7a8c2adb8199e9554bac8920a87eb33670f698d1c3c0a8911b15eed9d9a9741863b776ac80e2

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+### 1.8.1
+- [BUGFIX] Remove masking of transport client errors
+
 ### 1.8.0
 
 - [HOUSEKEEPING] updates faraday and rubyzip

data/lib/epics/error.rb

@@ -334,4 +334,3 @@ class Epics::Error < StandardError
   end
 
 end
-class Epics::Error::UnknownError < StandardError; end

data/lib/epics/middleware/parse_ebics.rb

@@ -9,12 +9,8 @@ class Epics::ParseEbics < Faraday::Middleware
   def call(env)
     @app.call(env).on_complete do |response|
       response.body = ::Epics::Response.new(@client, response.body)
-      raise Epics::Error::TechnicalError, response.body.technical_code if response.body.technical_error?
-      raise Epics::Error::BusinessError, response.body.business_code if response.body.business_error?
+      raise(Epics::Error::TechnicalError, response.body.technical_code) if response.body.technical_error?
+      raise(Epics::Error::BusinessError, response.body.business_code)   if response.body.business_error?
     end
-  rescue Epics::Error::TechnicalError, Epics::Error::BusinessError
-    raise # re-raise as otherwise they would be swallowed by the following rescue
-  rescue StandardError => e
-    raise Epics::Error::UnknownError, e
   end
 end

data/lib/epics/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Epics
-  VERSION = '1.8.0'
+  VERSION = '1.8.1'
 end

data/spec/middleware/parse_ebics_spec.rb

@@ -23,17 +23,13 @@ RSpec.describe Epics::ParseEbics do
     expect(subject.post('/ok').body).to be_kind_of(Epics::Response)
   end
 
-  it 'will handle a timeout with raising an Epics::Error::TechnicalError' do
-    expect { subject.post('/timeout') }.to raise_error(Epics::Error::UnknownError, 'timeout')
-  end
-
   context 'failures' do
-    it 'will handle a timeout with raising an Epics::Error::TechnicalError' do
-      expect { subject.post('/timeout') }.to raise_error(Epics::Error::UnknownError, 'timeout')
+    it 'will raise a timeout correctly' do
+      expect { subject.post('/timeout') }.to raise_error(Faraday::TimeoutError, 'timeout')
     end
 
-    it 'will handle a no connection error with raising an Epics::Error::TechnicalError' do
-      expect { subject.post('/no_connection') }.to raise_error(Epics::Error::UnknownError, 'peer has finished all lan parties and gone home')
+    it 'will properly raise non-epics errors' do
+      expect { subject.post('/no_connection') }.to raise_error(Faraday::ConnectionFailed, 'peer has finished all lan parties and gone home')
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: epics
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.8.1
 platform: ruby
 authors:
 - Lars Brillert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-03 00:00:00.000000000 Z
+date: 2020-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -305,7 +305,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: a ruby implementation of the EBICS protocol