epics 1.3.1 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 61d881bf8791586ff4fa95db25764760a5ca0a1f
-  data.tar.gz: 63360ac97af8276e2338498e38f43e9c3460d10f
+  metadata.gz: e1b144ee107acb92e07bc5374887837121f4bd25
+  data.tar.gz: 40b4435924bae79be5e3dccd5dd51f512c07393c
 SHA512:
-  metadata.gz: d9d31d54ffdeb3c97f0a4c3b49192272b1ea6e1829a3de89b299a783cb28b487e12dfb5e1c531156a26083c38f3d774664942a9390dac99f0171c7b2e031137d
-  data.tar.gz: 856a8e8940b28ced56c3d02118dd1a819331d2eb16febbe08cf797e69e1099153456a3e3dcaec89d503a1b45a43a31f96f7287c740c81a9f4b22dd313983d460
+  metadata.gz: 4ac0b1b88d188ab1ac3995bee74c5c3213121c7cf1af9406a24fe48736f3cd0bce046ffdaaff6e8da0ed73f39d9b053d979b7b75b2ce3d7e8b7257a6e21890cb
+  data.tar.gz: e42b512dbd90a1fe8ef7b08625338514262c276340b4116fc0ae9f94e369d14d4a061ec7345b7680e94bfb0ef8963668e4ed8d63a160ceff9c2de6fd2cb290d9

data/.travis.yml

@@ -1,6 +1,6 @@
 language: ruby
 rvm:
-  - 1.9.3
   - 2.0.0
-  - 2.1.2
+  - 2.1.8
+  - 2.2.4
   - jruby

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+### 1.4.0
+
+  * [ENHANCEMENT] STA without date range to fetch all statements which have not yet been fetched
+  * [ENHANCEMENT] HAC without date range to fetch all transaction logs which have not yet been fetched
+
 ### 1.3.1
 
   * [ENHANCEMENT] make xpath namespaces explicit, so we can cover a wider

data/CONTRIBUTING.md

@@ -1,5 +1,3 @@
 # Contributing to Epics
 
-## Before You Start
-
-Please contact team@railslove.com before working on Epics!
+To get started, <a href="https://www.clahub.com/agreements/railslove/epics">sign the Contributor License Agreement</a>.

data/lib/epics/client.rb

@@ -123,7 +123,7 @@ class Epics::Client
     upload(Epics::CCT, document)
   end
 
-  def STA(from, to)
+  def STA(from = nil, to = nil)
     download(Epics::STA, from, to)
   end
 
@@ -159,7 +159,7 @@ class Epics::Client
     download(Epics::PTK, from, to)
   end
 
-  def HAC(from, to)
+  def HAC(from = nil, to = nil)
     download(Epics::HAC, from, to)
   end
 

data/lib/epics/hac.rb

@@ -1,12 +1,23 @@
 class Epics::HAC < Epics::GenericRequest
   attr_accessor :from, :to
 
-  def initialize(client, from, to)
+  # By default HAC only returns data for transactions which have not yet been fetched. Therefore,
+  # most applications not not have to specify a date range, but can simply fetch the status and
+  # be done
+  def initialize(client, from = nil, to = nil)
     super(client)
     self.from = from
     self.to = to
   end
 
+  def date_range
+    if !!from && !!to
+      { "DateRange" => { "Start" => from, "End" => to } }
+    else
+      { :content! => '' }
+    end
+  end
+
   def header
     {
       :@authenticate => true,
@@ -23,12 +34,7 @@ class Epics::HAC < Epics::GenericRequest
         "OrderDetails" => {
           "OrderType" => "HAC",
           "OrderAttribute" => "DZHNN",
-          "StandardOrderParams" => {
-            "DateRange" => {
-              "Start" => from,
-              "End" => to
-            }
-          }
+          "StandardOrderParams" => date_range
         },
         "BankPubKeyDigests" => {
           "Authentication" => {

data/lib/epics/sta.rb

@@ -1,12 +1,20 @@
 class Epics::STA < Epics::GenericRequest
   attr_accessor :from, :to
 
-  def initialize(client, from, to)
+  def initialize(client, from = nil, to = nil)
     super(client)
     self.from = from
     self.to = to
   end
 
+  def date_range
+    if !!from && !!to
+      { "DateRange" => { "Start" => from, "End" => to } }
+    else
+      { :content! => '' }
+    end
+  end
+
   def header
     {
       :@authenticate => true,
@@ -23,12 +31,7 @@ class Epics::STA < Epics::GenericRequest
         "OrderDetails" => {
           "OrderType" => "STA",
           "OrderAttribute" => "DZHNN",
-          "StandardOrderParams" => {
-            "DateRange" => {
-              "Start" => from,
-              "End" => to
-            }
-          }
+          "StandardOrderParams" => date_range
         },
         "BankPubKeyDigests" => {
           "Authentication" => {

data/lib/epics/version.rb

@@ -1,3 +1,3 @@
 module Epics
-  VERSION = "1.3.1"
+  VERSION = "1.4.0"
 end

data/spec/orders/hac_spec.rb

@@ -1,11 +1,39 @@
 RSpec.describe Epics::HAC do
-
   let(:client) { Epics::Client.new( File.open(File.join( File.dirname(__FILE__), '..', 'fixtures', 'SIZBN001.key')), 'secret' , 'https://194.180.18.30/ebicsweb/ebicsweb', 'SIZBN001', 'EBIX', 'EBICS') }
 
-  subject { described_class.new(client, "2014-09-01", "2014-09-30") }
+  context 'with date range' do
+    subject(:order) { described_class.new(client, "2014-09-01", "2014-09-30") }
+
+    describe '#to_xml' do
+      specify { expect(order.to_xml).to be_a_valid_ebics_doc }
+
+      it 'does includes a date range as standard order parameter' do
+        expect(order.to_xml).to include('<StandardOrderParams><DateRange><Start>2014-09-01</Start><End>2014-09-30</End></DateRange></StandardOrderParams>')
+      end
+    end
 
-  describe '#to_xml' do
-    specify { expect(subject.to_xml).to be_a_valid_ebics_doc }
+    describe '#to_receipt_xml' do
+      before { order.transaction_id = SecureRandom.hex(16) }
+
+      specify { expect(order.to_receipt_xml).to be_a_valid_ebics_doc }
+    end
   end
 
-end
+  context 'without date range' do
+    subject(:order) { described_class.new(client) }
+
+    describe '#to_xml' do
+      specify { expect(order.to_xml).to be_a_valid_ebics_doc }
+
+      it 'does not include a standard order parameter' do
+        expect(order.to_xml).to include('<StandardOrderParams/>')
+      end
+    end
+
+    describe '#to_receipt_xml' do
+      before { order.transaction_id = SecureRandom.hex(16) }
+
+      specify { expect(order.to_receipt_xml).to be_a_valid_ebics_doc }
+    end
+  end
+end

data/spec/orders/sta_spec.rb

@@ -1,17 +1,39 @@
 RSpec.describe Epics::STA do
-
   let(:client) { Epics::Client.new( File.open(File.join( File.dirname(__FILE__), '..', 'fixtures', 'SIZBN001.key')), 'secret' , 'https://194.180.18.30/ebicsweb/ebicsweb', 'SIZBN001', 'EBIX', 'EBICS') }
 
-  subject { described_class.new(client, "2014-09-01", "2014-09-30") }
+  context 'with date range' do
+    subject(:order) { described_class.new(client, "2014-09-01", "2014-09-30") }
 
-  describe '#to_xml' do
-    specify { expect(subject.to_xml).to be_a_valid_ebics_doc }
-  end
+    describe '#to_xml' do
+      specify { expect(order.to_xml).to be_a_valid_ebics_doc }
 
-  describe '#to_receipt_xml' do
-    before { subject.transaction_id = SecureRandom.hex(16) }
+      it 'does includes a date range as standard order parameter' do
+        expect(order.to_xml).to include('<StandardOrderParams><DateRange><Start>2014-09-01</Start><End>2014-09-30</End></DateRange></StandardOrderParams>')
+      end
+    end
 
-    specify { expect(subject.to_receipt_xml).to be_a_valid_ebics_doc }
+    describe '#to_receipt_xml' do
+      before { order.transaction_id = SecureRandom.hex(16) }
+
+      specify { expect(order.to_receipt_xml).to be_a_valid_ebics_doc }
+    end
   end
 
-end
+  context 'without date range' do
+    subject(:order) { described_class.new(client) }
+
+    describe '#to_xml' do
+      specify { expect(order.to_xml).to be_a_valid_ebics_doc }
+
+      it 'does not include a standard order parameter' do
+        expect(order.to_xml).to include('<StandardOrderParams/>')
+      end
+    end
+
+    describe '#to_receipt_xml' do
+      before { order.transaction_id = SecureRandom.hex(16) }
+
+      specify { expect(order.to_receipt_xml).to be_a_valid_ebics_doc }
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: epics
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.4.0
 platform: ruby
 authors:
 - Lars Brillert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-17 00:00:00.000000000 Z
+date: 2015-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -295,7 +295,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: a ruby implementation of the EBICS protocol