epb_view_models 2.1.4 → 2.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d0afd5a7caeb45cbe256054c67d7c2c48509d30f0cc30830e3158a7fdb2e799e
-  data.tar.gz: 1d73a915230ecb63d67afca596b307fc4cf26849c46b8ea44623a6f76cd5cfb4
+  metadata.gz: 297a382293d1b6296686a0becea2a3dc30f5ef1fceafd92c822208146352112c
+  data.tar.gz: cc2ff6c08f0d7bb362181bd7628d8d5c88ce1dec432078062fce2c1a6e4ca40e
 SHA512:
-  metadata.gz: 66871443879f52e577da10b8906591c6f6195bcc46e36e8a74a13965f8628dcbd3c777c08598be9f7f2d8ae1c2da0f29484520bda995cad9cf6350527111dee2
-  data.tar.gz: b7ef0c3f454c3dba7479667c1e1f3062d569b8662e2dd9f1a57afcf7bc432f3bff456d413f0e521a2c8ffb4cb77c1237ae32c15e4e21e15d83d9ee6814a50597
+  metadata.gz: 44bfff8af36be2a9ce565be901b9ba79cdd8b30fe8c5376b650143a74667a7f64d32293c2f5a4dc37bcb2cc1ff15099f69631b5cffe7591c50d136ec12580229
+  data.tar.gz: 2e1fecda6730a8c9b8c3bf891d22b4cb59fe5a01d0bbe75220f793add923c186fe976af75a7046c71dee5ce008722bfb49f5d439ff3cb2c808b00d776bde4765

data/lib/epb_view_models.rb

@@ -5,7 +5,7 @@ loader = Zeitwerk::Loader.for_gem(warn_on_extra_files: false)
 loader.setup
 
 module EpbViewModels
-  VERSION = "2.1.4"
+  VERSION = "2.1.5"
 end
 
 # Monkey patching to avoid using ActiveRecord::Type::Boolean.new.cast

data/lib/view_model/rd_sap_schema_210/common_schema.rb

@@ -125,6 +125,7 @@ module ViewModel
             {
               sequence: xpath(%w[Sequence], node).to_i,
               improvement_code: xpath(%w[Improvement-Details Improvement-Number], node),
+              # the schema version is set to 21.0.1 as 21.0.0 had missing improvements in the external definitions
               improvement_summary: improvement_code ? accessor.fetch_details(schema_version: "RdSAP-Schema-21.0.1", improvement_number: improvement_code).summary : xpath(%w[Improvement-Summary], node),
               improvement_description: improvement_code ? accessor.fetch_details(schema_version: "RdSAP-Schema-21.0.1", improvement_number: improvement_code).description : xpath(%w[Improvement-Description], node),
               indicative_cost: xpath(%w[Indicative-Cost], node),

data/lib/view_model/rd_sap_schema_ni_210/common_schema.rb

@@ -125,8 +125,9 @@ module ViewModel
             {
               sequence: xpath(%w[Sequence], node).to_i,
               improvement_code: xpath(%w[Improvement-Details Improvement-Number], node),
-              improvement_summary: improvement_code ? accessor.fetch_details(schema_version: "RdSAP-Schema-NI-21.0.0", improvement_number: improvement_code).summary : xpath(%w[Improvement-Summary], node),
-              improvement_description: improvement_code ? accessor.fetch_details(schema_version: "RdSAP-Schema-NI-21.0.0", improvement_number: improvement_code).description : xpath(%w[Improvement-Description], node),
+              # the schema version is set to 21.0.1 as 21.0.0 had missing improvements in the external definitions
+              improvement_summary: improvement_code ? accessor.fetch_details(schema_version: "RdSAP-Schema-NI-21.0.1", improvement_number: improvement_code).summary : xpath(%w[Improvement-Summary], node),
+              improvement_description: improvement_code ? accessor.fetch_details(schema_version: "RdSAP-Schema-NI-21.0.1", improvement_number: improvement_code).description : xpath(%w[Improvement-Description], node),
               indicative_cost: xpath(%w[Indicative-Cost], node),
             }
           end
@@ -397,6 +398,41 @@ module ViewModel
         xpath(%w[Heated-Room-Count])&.to_i
       end
 
+      def low_energy_lighting
+        if fixed_lighting_outlets_count.zero?
+          return 0
+        end
+
+        ((low_energy_fixed_lighting_outlets_count.to_f / fixed_lighting_outlets_count) * 100).round
+      end
+
+      def fixed_lighting_outlets_count
+        fixed_lighting_outlets_count = low_energy_fixed_lighting_outlets_count
+        if xpath(%w[Incandescent-Fixed-Lighting-Bulbs-Count])
+          fixed_lighting_outlets_count += xpath(%w[Incandescent-Fixed-Lighting-Bulbs-Count])&.to_i
+        end
+        fixed_lighting_outlets_count
+      end
+
+      def low_energy_fixed_lighting_outlets_count
+        low_energy_fixed_lighting_outlets_count = 0
+        if xpath(%w[CFL-Fixed-Lighting-Bulbs-Count])
+          low_energy_fixed_lighting_outlets_count += xpath(%w[CFL-Fixed-Lighting-Bulbs-Count])&.to_i
+        end
+        if xpath(%w[LED-Fixed-Lighting-Bulbs-Count])
+          low_energy_fixed_lighting_outlets_count += xpath(%w[LED-Fixed-Lighting-Bulbs-Count])&.to_i
+        end
+        if xpath(%w[Low-Energy-Fixed-Lighting-Bulbs-Count])
+          low_energy_fixed_lighting_outlets_count += xpath(%w[Low-Energy-Fixed-Lighting-Bulbs-Count])&.to_i
+        end
+
+        low_energy_fixed_lighting_outlets_count
+      end
+
+      def open_fireplaces_count
+        xpath(%w[Open-Chimneys-Count])&.to_i
+      end
+
       def hot_water_description
         xpath(%w[Hot-Water Description])
       end

data/lib/view_model/rd_sap_schema_ni_2101/common_schema.rb

@@ -125,8 +125,8 @@ module ViewModel
             {
               sequence: xpath(%w[Sequence], node).to_i,
               improvement_code: xpath(%w[Improvement-Details Improvement-Number], node),
-              improvement_summary: improvement_code ? accessor.fetch_details(schema_version: "RdSAP-Schema-21.0.0", improvement_number: improvement_code).summary : xpath(%w[Improvement-Summary], node),
-              improvement_description: improvement_code ? accessor.fetch_details(schema_version: "RdSAP-Schema-21.0.0", improvement_number: improvement_code).description : xpath(%w[Improvement-Description], node),
+              improvement_summary: improvement_code ? accessor.fetch_details(schema_version: "RdSAP-Schema-NI-21.0.1", improvement_number: improvement_code).summary : xpath(%w[Improvement-Summary], node),
+              improvement_description: improvement_code ? accessor.fetch_details(schema_version: "RdSAP-Schema-NI-21.0.1", improvement_number: improvement_code).description : xpath(%w[Improvement-Description], node),
               indicative_cost: xpath(%w[Indicative-Cost], node),
             }
           end
@@ -398,13 +398,17 @@ module ViewModel
       end
 
       def low_energy_lighting
-        (low_energy_fixed_lighting_outlets_count / fixed_lighting_outlets_count) * 100
+        if fixed_lighting_outlets_count.zero?
+          return 0
+        end
+
+        ((low_energy_fixed_lighting_outlets_count.to_f / fixed_lighting_outlets_count) * 100).round
       end
 
       def fixed_lighting_outlets_count
         fixed_lighting_outlets_count = low_energy_fixed_lighting_outlets_count
-        if xpath(%w[Incandescent-Lighting-Bulbs-Count])
-          fixed_lighting_outlets_count += xpath(%w[Incandescent-Lighting-Bulbs-Count])&.to_i
+        if xpath(%w[Incandescent-Fixed-Lighting-Bulbs-Count])
+          fixed_lighting_outlets_count += xpath(%w[Incandescent-Fixed-Lighting-Bulbs-Count])&.to_i
         end
         fixed_lighting_outlets_count
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: epb_view_models
 version: !ruby/object:Gem::Version
-  version: 2.1.4
+  version: 2.1.5
 platform: ruby
 authors:
 - MHCLG Energy Performance of Buildings
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-07-08 00:00:00.000000000 Z
+date: 2025-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri