eol_rb 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 491894da6db5634007466ed6a22c12157eec58696fe5c2dac6504b76ed29908b
-  data.tar.gz: a305819c3871d10e5cdbd8acf629579e617f802bf08dd6d0c03b56d2575ddc9f
+  metadata.gz: f869412732c788fe696a4e02cc9a1027c095196017e5381a15c2abb8dfc5e8c3
+  data.tar.gz: 62f4d9767acfd5021c6d1362f8a29af4d712251e5989f9a8761093a99f0a4661
 SHA512:
-  metadata.gz: 5336fb2ff4381e04be59332b7bd3bb8858b38eef543e2f333d7671b7ae70a77a4bfd88228516421353819738c1b8180ba0781c26f5b71e129f32a1079f83b579
-  data.tar.gz: 01abf889f63ba25756b6fc219776f98f1f01db862fcb0dc1c72394f046cd2dfc89afad77f7b0cb66f48ead201a9eb95b843f085d9630db1fbb571aadce38af8b
+  metadata.gz: 8a24a8c5a7b99ef2a778f8b3977ed50c6d3539a490dafaedc9acc014d2dee509f28804c6e0f8b700e89e21dbc7a7efba05e44e716d5138ed82d98955bb42ecc1
+  data.tar.gz: 58caa00b251cfc6d423ce8f338e926a54144293f72bdaef246724e4436efaf4586dc73287fd978def8aa23e929954cff1dcded9a0b71448de93a94bc243bc84d

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.2.0] - 2022-11-29
+
+- Refactors resources usage
+
 ## [0.1.0] - 2022-11-23
 
 - Initial release

data/lib/eol_rb/cycle.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "json"
+
 module EOL
   class Client
     # Class for retrieving information about Cycles
@@ -9,9 +11,18 @@ module EOL
       class << self
         def get(client, product, cycle)
           res = client.get("/#{product}/#{cycle}.json")
-          raise NotFoundError, "Cycle #{cycle} could not be found under product #{product}" if res.status == 404
 
-          res
+          if res.status == 404
+            available_cycles = []
+            Product.get(client, product).each do |p|
+              available_cycles.push(p["cycle"])
+            end
+
+            raise NotFoundError,
+                  "Cycle #{cycle} could not be found under product #{product}. Try any of #{available_cycles.inspect}"
+          end
+
+          JSON.parse(res.body)
         end
       end
     end

data/lib/eol_rb/product.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "json"
+
 module EOL
   class Client
     # Class for retrieving information about Products
@@ -8,14 +10,14 @@ module EOL
 
       class << self
         def all(client)
-          client.get("/all.json")
+          JSON.parse(client.get("/all.json").body)
         end
 
         def get(client, product)
           res = client.get("/#{product}.json")
           raise NotFoundError, "Product #{product} could not be found in the API" if res.status == 404
 
-          res
+          JSON.parse(res.body)
         end
       end
     end

data/lib/eol_rb/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EOL
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/lib/eol_rb.rb

@@ -32,19 +32,15 @@ module EOL
     end
 
     def products
-      res = Client::Product.all(@client)
-
-      JSON.parse(res.body)
+      Client::Product.all(@client)
     end
 
     def of(product, cycle: "")
-      res = if cycle.empty?
-              Client::Product.get(@client, product)
-            else
-              Client::Cycle.get(@client, product, cycle)
-            end
-
-      JSON.parse(res.body)
+      if cycle.empty?
+        Client::Product.get(@client, product)
+      else
+        Client::Cycle.get(@client, product, cycle)
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: eol_rb
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Alejandro Colomina
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-28 00:00:00.000000000 Z
+date: 2022-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday