envirobly 1.7.0 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89cfd488c2765b1d8bc3205d34cf6d4e49230f4eb3a371cdb05b6785d690c955
-  data.tar.gz: f52f5be5eaf21eb35273f3d5d9da22af91ca2d6078faedcd1e875ebbcdab13e1
+  metadata.gz: 3e6005245f891cfc1cee6078dfd201ba7662f1beff0d462452e09b5b406eb7f8
+  data.tar.gz: e1ebac83b39461529d6eb06d8b92f4d275bb8225b4868bd97e41104a085dcd67
 SHA512:
-  metadata.gz: 9f8e1e766e47c1a7765cf96c0b893ab8cec55a16feb1916423f944396bdf9c1c17c215b4ed7f415217ccc8bb4c559331b687e3c91e71b698ea9ed34d81ec2c48
-  data.tar.gz: 2c0d7c929da365fa21c4a946049da551c6ab5eb6c6492babf138b64a01d0f7f43f5c99693989c65bb260ac7ebbc1a0ed47d7bccea633df6ecbedcd2afe4ad0ed
+  metadata.gz: 696c939aff4ab4047f2eea626d23f381ea364992220a96533a9282946aa3c1ef30915a218ee64776137c7cf4897f723d86476448ef26c8fe9392f6e491ec593e
+  data.tar.gz: 81fcd2a06ce9a82a28a98eebf07f5ed40caa37415cbbaf94103d8fc65e6724950f7a06ed0c27e5a691d1b43777d64fb71170b043fefb0135641573f6039c0422

data/lib/envirobly/api.rb

@@ -6,6 +6,8 @@ require "socket"
 require "uri"
 
 class Envirobly::Api
+  include Envirobly::Colorize
+
   HOST = ENV["ENVIROBLY_API_HOST"].presence || "on.envirobly.com"
   USER_AGENT = "Envirobly CLI v#{Envirobly::VERSION}"
   CONTENT_TYPE = "application/json"
@@ -16,12 +18,7 @@ class Envirobly::Api
   end
 
   def validate_shape(params)
-    post_as_json(api_v1_shape_validations_url, params:, headers: authorization_headers).tap do |response|
-      unless response.success?
-        $stderr.puts "Validation request responded with #{response.code}. Aborting."
-        exit 1
-      end
-    end
+    post_as_json(api_v1_shape_validations_url, params:, headers: authorization_headers)
   end
 
   def create_deployment(params)
@@ -49,7 +46,7 @@ class Envirobly::Api
   LONG_RETRY_INTERVAL = 6.seconds
   def get_deployment_with_delay_and_retry(url, tries = 1)
     sleep SHORT_RETRY_INTERVAL * tries
-    response = get_as_json URI(url)
+    response = get_as_json URI(url), retriable: true
 
     if response.success?
       response
@@ -67,8 +64,8 @@ class Envirobly::Api
     end
   end
 
-  def get_as_json(url, headers: {})
-    request(url, type: Net::HTTP::Get, headers:)
+  def get_as_json(url, headers: {}, retriable: false)
+    request(url, type: Net::HTTP::Get, headers:, retriable:)
   end
 
   def post_as_json(url, params: {}, headers: {})
@@ -112,7 +109,11 @@ class Envirobly::Api
       URI::HTTPS.build(host: HOST, path: "/api/#{path}", query:)
     end
 
-    def request(url, type:, headers: {})
+    def request(url, type:, headers: {}, retriable: false)
+      if ENV["ENVIROBLY_CLI_LOG_LEVEL"] == "debug"
+        puts "[Envirobly::Api] request #{url} #{type} #{headers}"
+      end
+
       uri = URI(url)
       http = Net::HTTP.new uri.host, uri.port
       http.use_ssl = true
@@ -126,18 +127,41 @@ class Envirobly::Api
       yield request if block_given?
 
       http.request(request).tap do |response|
+        if ENV["ENVIROBLY_CLI_LOG_LEVEL"] == "debug"
+          puts "[Envirobly::Api] response #{response.code} => #{response.body}"
+        end
+
         def response.object
           @json_parsed_body ||= JSON.parse(body)
         rescue
-          @json_parsed_body = { error_message: body }
+          @json_parsed_body = { "error_message" => body }
         end
 
         def response.success?
           (200..299).include?(code.to_i)
         end
 
-        if @exit_on_error && !response.success? && response.object["error_message"].present?
-          puts response.object["error_message"] # TODO: Replace with shell.say_error
+        if !retriable && @exit_on_error && !response.success?
+          informed = false
+
+          if response.object.try(:key?, "error_message")
+            puts response.object["error_message"]
+            informed = true
+          end
+
+          if response.object.try(:key?, "config_errors")
+            display_config_errors response.object["config_errors"]
+            informed = true
+          end
+
+          unless informed
+            puts red("Error response (#{response.code}) from the API")
+          end
+
+          if response.code.to_i == 401
+            puts "Run `envirobly signin` to ensure you're signed in with a valid access token"
+          end
+
           exit 1
         end
       end
@@ -150,4 +174,17 @@ class Envirobly::Api
     def authorization_headers
       { "Authorization" => @access_token.as_http_bearer }
     end
+
+    def display_config_errors(errors)
+      puts "#{red(cross)} Config contains the following issues:"
+
+      errors.each do |error|
+        puts
+        puts "  #{error["message"]}"
+
+        if error["path"]
+          puts faint("  #{downwards_arrow_to_right} #{error["path"]}")
+        end
+      end
+    end
 end

data/lib/envirobly/cli/main.rb

@@ -22,9 +22,8 @@ class Envirobly::Cli::Main < Envirobly::Base
   desc "signout", "Sign out"
   def signout
     Envirobly::AccessToken.destroy
-    say "You've signed out."
-    say "This didn't delete the access token itself."
-    say "You can sign in again with `envirobly signin`."
+    say "You've signed out"
+    say "You can sign in again with `envirobly signin`"
   end
 
   desc "set_default_account", "Choose default account to deploy the current project to"
@@ -45,14 +44,9 @@ class Envirobly::Cli::Main < Envirobly::Base
     api = Envirobly::Api.new
 
     params = { validation: configs.to_params }
-    response = api.validate_shape params
+    api.validate_shape params
 
-    if response.object.fetch("valid")
-      puts "Config is valid #{green_check}"
-    else
-      display_config_errors response.object.fetch("errors")
-      exit 1
-    end
+    say "Config is valid #{green_check}"
   end
 
   desc "instance_types [REGION]", "List instance types in the given region, including price and performance characteristics."

data/lib/envirobly/colorize.rb

@@ -40,17 +40,4 @@ module Envirobly::Colorize
   def cross
     "✖"
   end
-
-  def display_config_errors(errors)
-    puts "#{red(cross)} Config contains the following issues:"
-
-    errors.each do |error|
-      puts
-      puts "  #{error["message"]}"
-
-      if error["path"]
-        puts faint("  #{downwards_arrow_to_right} #{error["path"]}")
-      end
-    end
-  end
 end

data/lib/envirobly/deployment.rb

@@ -9,12 +9,12 @@ module Envirobly
     attr_reader :params
 
     def initialize(environ_name:, commit:, account_id:, project_name:, project_id:, region:, shell:)
-      @environ_name = environ_name
       @commit = commit
       @config = Config.new
       @default_account = Defaults::Account.new(shell:)
       @default_project = Defaults::Project.new(shell:)
       @default_region = Defaults::Region.new(shell:)
+      @shell = shell
 
       target = Target.new(
         default_account_id: @default_account.value,
@@ -41,6 +41,7 @@ module Envirobly
         shell.say "--#{param.to_s.parameterize} ignored, due to other arguments overriding it"
       end
 
+      @environ_name = target.environ_name
       @params = {
         account_id: target.account_id,
         project_id: target.project_id,
@@ -74,11 +75,6 @@ module Envirobly
       Duration.measure do
         response = api.create_deployment @params
 
-        unless response.success?
-          display_config_errors response.object.fetch("errors")
-          exit 1
-        end
-
         print "Preparing project..."
 
         @default_account.save_if_none response.object.fetch("account_id")

data/lib/envirobly/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Envirobly
-  VERSION = "1.7.0"
+  VERSION = "1.8.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: envirobly
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.8.0
 platform: ruby
 authors:
 - Robert Starsi