enumitation 0.0.1 → 0.0.3

data/.rspec

@@ -0,0 +1 @@
+--format doc

data/README.md

@@ -13,8 +13,7 @@ join table to contain the values and a foreign key constraint were overkill?  We
 could opt for an enum field, but maybe your DBMS doesn't support enums.  Or maybe it does,
 but you just aren't in the mood for an enum field today.
 
-Also, do you need to provide these values for options in a select field
-in a form?
+Also, do you need to provide these values as options in a select form field?
 
 Enumitation exists to allow restrictions on ActiveRecord attribute values without
 the need for a join table or enum field, while also providing those values for
@@ -81,7 +80,11 @@ all that work when you can get it from a one-liner?
 True, but the ones I found either didn't fit my needs or they did so much more than I needed.
 I wanted something that fit my needs exactly and nothing more.
 
+## Testing
+
+    bundle exec rspec spec
+
 ## Contributing
 
 If you think Enumitation could be better, fork away and send a pull
-request!
+request!  Please make sure to include specs for your changes.

data/enumitation.gemspec

@@ -20,7 +20,9 @@ DESC
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.add_development_dependency('rspec', '> 2')
   s.add_development_dependency('rr', '>= 1.0.2')
-  s.add_development_dependency('activerecord', '> 3')
+  s.add_development_dependency('activerecord', '~> 3')
+  s.add_development_dependency('ap')
+  s.add_development_dependency('ruby-debug19')
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 end

data/lib/enumitation.rb

@@ -1,10 +1,12 @@
 module Enumitation
   autoload :ClassMethods, 'enumitation/class_methods'
 
-  ActiveRecord::Base.class_eval do
-    def self.inherited(subclass)
-      subclass.extend ClassMethods
-      super
+  ActiveRecord::Base.instance_eval do
+    def enumitation(attribute, values)
+      extend ClassMethods
+
+      self.enumitation_values[attribute] = Array(values)
+      add_inclusion_validation(attribute, values)
     end
   end
 end

data/lib/enumitation/class_methods.rb

@@ -2,6 +2,9 @@ module Enumitation
   module ClassMethods
 
     def self.extended(base)
+      # If we've already been extended, don't do it again
+      return if defined? base.enumitation_values
+
       class << base
         attr_accessor :enumitation_values
       end
@@ -9,11 +12,6 @@ module Enumitation
       base.enumitation_values = {}
     end
 
-    def enumitation(attribute, values)
-      enumitation_values[attribute] = Array(values)
-      add_inclusion_validation(attribute, values)
-    end
-
     def select_options_for(attribute)
       return [] if enumitation_values.empty?
 

data/lib/enumitation/version.rb

@@ -1,3 +1,3 @@
 module Enumitation
-  VERSION = "0.0.1"
+  VERSION = "0.0.3"
 end

data/spec/enumitation_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+
+describe Enumitation do
+  before(:all) do
+    class MyModel < ActiveRecord::Base
+      enumitation :number, %w[1 2]
+    end
+  end
+
+  after(:all) do
+    Object.send :remove_const, :MyModel
+  end
+
+  it "adds the enumitation method to the model" do
+    MyModel.methods.should include(:enumitation)
+  end
+
+  describe "#enumitation" do
+    it "adds the select_options_for method to the model" do
+      MyModel.methods.should include(:select_options_for)
+    end
+
+    it "adds the validates_inclusion_of validator to the model" do
+      MyModel.should have(1).validators_on :number
+
+      validator = MyModel.validators.first
+      validator.should be_a_kind_of ActiveModel::Validations::InclusionValidator
+
+      validator.options[:in].should == %w[1 2]
+    end
+
+    it "can be called more than once without reinitializing the enumitation values" do
+      # Validate that the original enumitation still exists
+      MyModel.enumitation_values.keys.should include(:number)
+
+      MyModel.enumitation :other_field, %w[one two]
+
+      # Should still include the :number enumitation
+      MyModel.enumitation_values.keys.should include(:number)
+    end
+  end
+end

data/spec/lib/class_methods_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+
+describe Enumitation::ClassMethods do
+  before(:all) do
+    class MyModel < ActiveRecord::Base
+      enumitation :number, %w[1 2]
+    end
+  end
+
+  after(:all) do
+    Object.send :remove_const, :MyModel
+  end
+
+  describe "select_options_for" do
+    context "when no label translation is present" do
+      it "returns select options with label and value of equal values" do
+        MyModel.select_options_for(:number).should == [%w[1 1], %w[2 2]]
+      end
+    end
+
+    context "when label translation is present" do
+      before do
+        %w[1 2].each do |num|
+          mock(I18n).t(num,
+                       :scope => "enumitation.models.my_model.number",
+                       :default => num) do
+
+            if num == '1'
+              'one'
+            elsif num == '2'
+              'two'
+            end
+          end
+        end
+      end
+
+      it "returns select options with the label translated" do
+        MyModel.select_options_for(:number).should == [%w[one 1], %w[two 2]]
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,19 @@
+require 'rubygems'
+require 'bundler/setup'
+
+require 'active_record'
+require 'enumitation'
+
+RSpec.configure do |config|
+  config.mock_with :rr
+end
+
+# Stub out AR
+ActiveRecord::Base.class_eval do
+  alias_method :save, :valid?
+  def self.columns() @columns ||= []; end
+
+  def self.column(name, sql_type = nil, default = nil, null = true)
+    columns << ActiveRecord::ConnectionAdapters::Column.new(name.to_s, default, sql_type, null)
+  end
+end

metadata

@@ -2,7 +2,7 @@
 name: enumitation
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors: 
 - Chad Boyd
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-05 00:00:00 -05:00
+date: 2011-07-01 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -41,11 +41,33 @@ dependencies:
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">"
+    - - ~>
       - !ruby/object:Gem::Version 
         version: "3"
   type: :development
   version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: ap
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+  type: :development
+  version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: ruby-debug19
+  prerelease: false
+  requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+  type: :development
+  version_requirements: *id005
 description: |
   Ever wanted to restrict an attribute to specific values, but not wanted to
   create a join table to hold the values, and didn't want (or couldn't) create
@@ -61,6 +83,7 @@ extra_rdoc_files: []
 
 files: 
 - .gitignore
+- .rspec
 - Gemfile
 - README.md
 - Rakefile
@@ -68,6 +91,9 @@ files:
 - lib/enumitation.rb
 - lib/enumitation/class_methods.rb
 - lib/enumitation/version.rb
+- spec/enumitation_spec.rb
+- spec/lib/class_methods_spec.rb
+- spec/spec_helper.rb
 has_rdoc: true
 homepage: http://github.com/hoverlover/enumitation
 licenses: []
@@ -96,5 +122,7 @@ rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Fake enums for ActiveModel
-test_files: []
-
+test_files: 
+- spec/enumitation_spec.rb
+- spec/lib/class_methods_spec.rb
+- spec/spec_helper.rb