enumerize 0.8.0 → 2.6.1

data/test/attribute_map_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module Enumerize
@@ -9,12 +11,12 @@ module Enumerize
     end
 
     it 'empty when no attrs' do
-      subject.must_be_empty
+      expect(subject).must_be_empty
     end
 
     it 'not empty when attr added' do
       subject << make_attr(:a)
-      subject.wont_be_empty
+      expect(subject).wont_be_empty
     end
 
     it 'iterates over added attrs' do
@@ -32,20 +34,20 @@ module Enumerize
         actual << element
       end
 
-      count.must_equal 2
-      actual.must_equal [attr_1, attr_2]
+      expect(count).must_equal 2
+      expect(actual).must_equal [attr_1, attr_2]
     end
 
     it 'reads attribute by name' do
       attr = make_attr(:a)
       subject << attr
-      subject[:a].must_equal attr
+      expect(subject[:a]).must_equal attr
     end
 
     it 'reads attribute by name using string' do
       attr = make_attr(:a)
       subject << attr
-      subject['a'].must_equal attr
+      expect(subject['a']).must_equal attr
     end
 
     it 'updates dependants' do
@@ -62,7 +64,7 @@ module Enumerize
       subject << attr
       dependant = AttributeMap.new
       subject.add_dependant dependant
-      dependant[:a].must_equal attr
+      expect(dependant[:a]).must_equal attr
     end
   end
 end

data/test/attribute_test.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
-describe Enumerize::Attribute do
+class AttributeTest < MiniTest::Spec
   def attr
     @attr ||= nil
   end
@@ -11,22 +13,33 @@ describe Enumerize::Attribute do
 
   it 'returns values' do
     build_attr nil, :foo, :in => [:a, :b]
-    attr.values.must_equal %w[a b]
+    expect(attr.values).must_equal %w[a b]
+  end
+
+  it 'returns frozen values' do
+    build_attr nil, :foo, :in => [:a, :b]
+    expect(attr.values.map(&:frozen?)).must_equal [true, true]
   end
 
   it 'converts name to symbol' do
     build_attr nil, 'foo', :in => %w[a b]
-    attr.name.must_equal :foo
+    expect(attr.name).must_equal :foo
+  end
+
+  it 'uses custom value class' do
+    value_class = Class.new(Enumerize::Value)
+    build_attr nil, 'foo', :in => %w[a b], :value_class => value_class
+    expect(attr.values.first).must_be_instance_of value_class
   end
 
   describe 'i18n scopes' do
     it 'returns scopes from options' do
       build_attr nil, 'foo', :in => %w[a b], :i18n_scope => %w[bar buzz]
-      attr.i18n_scopes.must_equal %w[bar buzz]
+      expect(attr.i18n_scopes).must_equal %w[bar buzz]
     end
 
     it 'accepts only string scopes' do
-      proc { build_attr nil, 'foo', :in => %w[a b], :i18n_scope => [%w[bar buzz], "bar.buzz"] }.must_raise ArgumentError
+      expect(proc { build_attr nil, 'foo', :in => %w[a b], :i18n_scope => [%w[bar buzz], "bar.buzz"] }).must_raise ArgumentError
     end
   end
 
@@ -34,32 +47,32 @@ describe Enumerize::Attribute do
     it 'returns all options for select' do
       store_translations(:en, :enumerize => {:foo => {:a => 'a text', :b => 'b text'}}) do
         build_attr nil, :foo, :in => %w[a b]
-        attr.options.must_equal [['a text', 'a'], ['b text', 'b']]
+        expect(attr.options).must_equal [['a text', 'a'], ['b text', 'b']]
       end
     end
 
     it 'returns requested options for select via :only' do
       store_translations(:en, :enumerize => {:foo => {:a => 'a text', :b => 'b text'}}) do
         build_attr nil, :foo, :in => %w[a b]
-        attr.options(:only => :a).must_equal [['a text', 'a']]
-        attr.options(:only => [:b]).must_equal [['b text', 'b']]
-        attr.options(:only => []).must_equal []
+        expect(attr.options(:only => :a)).must_equal [['a text', 'a']]
+        expect(attr.options(:only => [:b])).must_equal [['b text', 'b']]
+        expect(attr.options(:only => [])).must_equal []
       end
     end
 
     it 'returns requested options for select via :except' do
       store_translations(:en, :enumerize => {:foo => {:a => 'a text', :b => 'b text'}}) do
         build_attr nil, :foo, :in => %w[a b]
-        attr.options(:except => :a).must_equal [['b text', 'b']]
-        attr.options(:except => :b).must_equal [['a text', 'a']]
-        attr.options(:except => []).must_equal [['a text', 'a'], ['b text', 'b']]
+        expect(attr.options(:except => :a)).must_equal [['b text', 'b']]
+        expect(attr.options(:except => :b)).must_equal [['a text', 'a']]
+        expect(attr.options(:except => [])).must_equal [['a text', 'a'], ['b text', 'b']]
       end
     end
 
     it 'does not work with both :only and :except' do
       store_translations(:en, :enumerize => {:foo => {:a => 'a text', :b => 'b text'}}) do
         build_attr nil, :foo, :in => %w[a b]
-        proc { attr.options(:except => [], :only => []) }.must_raise ArgumentError
+        expect(proc { attr.options(:except => [], :only => []) }).must_raise ArgumentError
       end
     end
   end
@@ -70,28 +83,44 @@ describe Enumerize::Attribute do
     end
 
     it 'returns hash keys as values' do
-      attr.values.must_equal %w[a b]
+      expect(attr.values).must_equal %w[a b]
     end
 
     it 'finds values by hash values' do
-      attr.find_value(1).must_equal 'a'
-      attr.find_value(2).must_equal 'b'
+      expect(attr.find_value(1)).must_equal 'a'
+      expect(attr.find_value(2)).must_equal 'b'
     end
   end
 
+  it 'sets up shortcut methods for each value' do
+    build_attr nil, :foo, :in => {:a => 1, :b => 2}
+
+    expect(attr).must_respond_to :a
+    expect(attr).must_respond_to :b
+
+    expect(attr.a.value).must_equal 1
+    expect(attr.b.value).must_equal 2
+    expect(attr.a.text).must_equal 'A'
+    expect(attr.b.text).must_equal 'B'
+  end
+
   describe 'values hash with zero' do
     before do
       build_attr nil, :foo, :in => {:a => 1, :b => 2, :c => 0}
     end
 
     it 'returns hash keys as values' do
-      attr.values.must_equal %w[a b c]
+      expect(attr.values).must_equal %w[a b c]
     end
 
     it 'finds values by hash values' do
-      attr.find_value(1).must_equal 'a'
-      attr.find_value(2).must_equal 'b'
-      attr.find_value(0).must_equal 'c'
+      expect(attr.find_value(1)).must_equal 'a'
+      expect(attr.find_value(2)).must_equal 'b'
+      expect(attr.find_value(0)).must_equal 'c'
+    end
+
+    it 'finds all values by hash values' do
+      expect(attr.find_values(1, 2, 0)).must_equal ['a', 'b', 'c']
     end
   end
 
@@ -101,12 +130,12 @@ describe Enumerize::Attribute do
     end
 
     it 'returns hash keys as values' do
-      attr.values.must_equal %w[a b]
+      expect(attr.values).must_equal %w[a b]
     end
 
     it 'finds values by hash values' do
-      attr.find_value(true).must_equal 'a'
-      attr.find_value(false).must_equal 'b'
+      expect(attr.find_value(true)).must_equal 'a'
+      expect(attr.find_value(false)).must_equal 'b'
     end
   end
 end

data/test/base_test.rb

@@ -1,49 +1,51 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
-describe Enumerize::Base do
-  let(:klass) do
+class BaseTest < MiniTest::Spec
+  let(:kklass) do
     Class.new do
       extend Enumerize
     end
   end
 
   let(:subklass) do
-    Class.new(klass)
+    Class.new(kklass)
   end
 
-  let(:object) { klass.new }
+  let(:object) { kklass.new }
 
   it 'returns nil when not set' do
-    klass.enumerize(:foo, :in => [:a, :b])
-    object.foo.must_equal nil
+    kklass.enumerize(:foo, :in => [:a, :b])
+    expect(object.foo).must_be_nil
   end
 
   it 'returns value that was set' do
-    klass.enumerize(:foo, :in => [:a, :b])
+    kklass.enumerize(:foo, :in => [:a, :b])
     object.foo = :a
-    object.foo.must_equal 'a'
+    expect(object.foo).must_equal 'a'
   end
 
   it 'returns translation' do
     store_translations(:en, :enumerize => {:foo => {:a => 'a text'}}) do
-      klass.enumerize(:foo, :in => [:a, :b])
+      kklass.enumerize(:foo, :in => [:a, :b])
       object.foo = :a
-      object.foo.text.must_equal 'a text'
-      object.foo_text.must_equal 'a text'
-      object.foo_text.must_equal 'a text'
+      expect(object.foo.text).must_equal 'a text'
+      expect(object.foo_text).must_equal 'a text'
+      expect(object.foo_text).must_equal 'a text'
     end
   end
 
   it 'returns nil as translation when value is nil' do
     store_translations(:en, :enumerize => {:foo => {:a => 'a text'}}) do
-      klass.enumerize(:foo, :in => [:a, :b])
-      object.foo_text.must_equal nil
+      kklass.enumerize(:foo, :in => [:a, :b])
+      expect(object.foo_text).must_be_nil
     end
   end
 
-  it 'scopes translation by i18 key' do
-    def klass.model_name
-      name = "ExampleClass"
+  it 'scopes translation by i18n key' do
+    def kklass.model_name
+      name = String.new("ExampleClass")
       def name.i18n_key
         'example_class'
       end
@@ -52,99 +54,99 @@ describe Enumerize::Base do
     end
 
     store_translations(:en, :enumerize => {:example_class => {:foo => {:a => 'a text scoped'}}}) do
-      klass.enumerize(:foo, :in => [:a, :b])
+      kklass.enumerize(:foo, :in => [:a, :b])
       object.foo = :a
-      object.foo.text.must_equal 'a text scoped'
-      object.foo_text.must_equal 'a text scoped'
+      expect(object.foo.text).must_equal 'a text scoped'
+      expect(object.foo_text).must_equal 'a text scoped'
     end
   end
 
   it 'returns humanized value if there are no translations' do
     store_translations(:en, :enumerize => {}) do
-      klass.enumerize(:foo, :in => [:a, :b])
+      kklass.enumerize(:foo, :in => [:a, :b])
       object.foo = :a
-      object.foo_text.must_equal 'A'
+      expect(object.foo_text).must_equal 'A'
     end
   end
 
   it 'stores value as string' do
-    klass.enumerize(:foo, :in => [:a, :b])
+    kklass.enumerize(:foo, :in => [:a, :b])
     object.foo = :a
-    object.instance_variable_get(:@foo).must_be_instance_of String
+    expect(object.instance_variable_get(:@foo)).must_be_instance_of String
   end
 
   it 'handles default value' do
-    klass.enumerize(:foo, :in => [:a, :b], :default => :b)
-    object.foo.must_equal 'b'
+    kklass.enumerize(:foo, :in => [:a, :b], :default => :b)
+    expect(object.foo).must_equal 'b'
   end
 
   it 'handles default value with lambda' do
-    klass.enumerize(:foo, :in => [:a, :b], :default => lambda { :b })
-    object.foo.must_equal 'b'
+    kklass.enumerize(:foo, :in => [:a, :b], :default => lambda { :b })
+    expect(object.foo).must_equal 'b'
   end
 
   it 'injects object instance into lamda default value' do
-    klass.enumerize(:foo, :in => [:a, :b], :default => lambda { |obj| :b if obj.is_a? klass })
-    object.foo.must_equal 'b'
+    kklass.enumerize(:foo, :in => [:a, :b], :default => lambda { |obj| :b if obj.is_a? kklass })
+    expect(object.foo).must_equal 'b'
   end
 
   it 'raises exception on invalid default value' do
-    proc {
-      klass.enumerize(:foo, :in => [:a, :b], :default => :c)
-    }.must_raise ArgumentError
+    expect(proc {
+      kklass.enumerize(:foo, :in => [:a, :b], :default => :c)
+    }).must_raise ArgumentError
   end
 
   it 'has enumerized attributes' do
-    klass.enumerized_attributes.must_be_empty
-    klass.enumerize(:foo, :in => %w[a b])
-    klass.enumerized_attributes[:foo].must_be_instance_of Enumerize::Attribute
+    expect(kklass.enumerized_attributes).must_be_empty
+    kklass.enumerize(:foo, :in => %w[a b])
+    expect(kklass.enumerized_attributes[:foo]).must_be_instance_of Enumerize::Attribute
   end
 
   it "doesn't override existing method" do
-    method = klass.method(:name)
-    klass.enumerize(:name, :in => %w[a b], :default => 'a')
-    klass.method(:name).must_equal method
+    method = kklass.method(:name)
+    kklass.enumerize(:name, :in => %w[a b], :default => 'a')
+    expect(kklass.method(:name)).must_equal method
   end
 
   it "inherits enumerized attributes from a parent class" do
-    klass.enumerize(:foo, :in => %w[a b])
-    subklass.enumerized_attributes[:foo].must_be_instance_of Enumerize::Attribute
+    kklass.enumerize(:foo, :in => %w[a b])
+    expect(subklass.enumerized_attributes[:foo]).must_be_instance_of Enumerize::Attribute
   end
 
   it "inherits enumerized attributes from a grandparent class" do
-    klass.enumerize(:foo, :in => %w[a b])
-    Class.new(subklass).enumerized_attributes[:foo].must_be_instance_of Enumerize::Attribute
+    kklass.enumerize(:foo, :in => %w[a b])
+    expect(Class.new(subklass).enumerized_attributes[:foo]).must_be_instance_of Enumerize::Attribute
   end
 
   it "doesn't add enumerized attributes to parent class" do
-    klass.enumerize(:foo, :in => %w[a b])
+    kklass.enumerize(:foo, :in => %w[a b])
     subklass.enumerize(:bar, :in => %w[c d])
 
-    klass.enumerized_attributes[:bar].must_equal nil
+    expect(kklass.enumerized_attributes[:bar]).must_be_nil
   end
 
   it 'adds new parent class attributes to subclass' do
-    subklass = Class.new(klass)
-    klass.enumerize :foo, :in => %w[a b]
-    subklass.enumerized_attributes[:foo].must_be_instance_of Enumerize::Attribute
+    subklass = Class.new(kklass)
+    kklass.enumerize :foo, :in => %w[a b]
+    expect(subklass.enumerized_attributes[:foo]).must_be_instance_of Enumerize::Attribute
   end
 
   it 'stores nil value' do
-    klass.enumerize(:foo, :in => [:a, :b])
+    kklass.enumerize(:foo, :in => [:a, :b])
     object.foo = nil
-    object.instance_variable_get(:@foo).must_equal nil
+    expect(object.instance_variable_get(:@foo)).must_be_nil
   end
 
   it 'casts value to string for validation' do
-    klass.enumerize(:foo, :in => [:a, :b])
+    kklass.enumerize(:foo, :in => [:a, :b])
     object.foo = :c
-    object.read_attribute_for_validation(:foo).must_equal 'c'
+    expect(object.read_attribute_for_validation(:foo)).must_equal 'c'
   end
 
   it "doesn't cast nil to string for validation" do
-    klass.enumerize(:foo, :in => [:a, :b])
+    kklass.enumerize(:foo, :in => [:a, :b])
     object.foo = nil
-    object.read_attribute_for_validation(:foo).must_equal nil
+    expect(object.read_attribute_for_validation(:foo)).must_be_nil
   end
 
   it 'calls super in the accessor method' do
@@ -170,33 +172,83 @@ describe Enumerize::Base do
     end
 
     object = klass.new
-    object.foo.must_be_nil
-    object.attributes.must_equal({:foo => nil})
+    expect(object.foo).must_be_nil
+    expect(object.attributes).must_equal({})
 
     object.foo = 'test'
-    object.foo.must_equal 'test'
-    object.attributes.must_equal(:foo => 'test')
+    expect(object.foo).must_equal 'test'
+    expect(object.attributes).must_equal(:foo => 'test')
   end
 
   it 'stores hash values' do
-    klass.enumerize(:foo, :in => {:a => 1, :b => 2})
+    kklass.enumerize(:foo, :in => {:a => 1, :b => 2})
 
     object.foo = :a
-    object.instance_variable_get(:@foo).must_equal 1
-    object.foo.must_equal 'a'
+    expect(object.instance_variable_get(:@foo)).must_equal 1
+    expect(object.foo).must_equal 'a'
 
     object.foo = :b
-    object.instance_variable_get(:@foo).must_equal 2
-    object.foo.must_equal 'b'
+    expect(object.instance_variable_get(:@foo)).must_equal 2
+    expect(object.foo).must_equal 'b'
   end
 
   it 'returns custom value' do
-    klass.enumerize(:foo, :in => {:a => 1, :b => 2})
+    kklass.enumerize(:foo, :in => {:a => 1, :b => 2})
 
     object.foo = :a
-    object.foo_value.must_equal 1
+    expect(object.foo_value).must_equal 1
 
     object.foo = :b
-    object.foo_value.must_equal 2
+    expect(object.foo_value).must_equal 2
+  end
+
+  it 'allows initialize method with arguments' do
+    klass = Class.new do
+      extend Enumerize
+
+      def initialize(argument, key_word_argument: nil); end
+    end
+
+    klass.new('arg1', key_word_argument: 'kwargs1')
+  end
+
+  it 'allows initialize method with arguments for inherited classes' do
+    parent_klass = Class.new do
+      def initialize(argument, key_word_argument: nil); end
+    end
+
+    klass = Class.new(parent_klass) do
+      extend Enumerize
+
+      def initialize(argument, key_word_argument: nil)
+        super
+      end
+    end
+
+    klass.new('arg1', key_word_argument: 'kwargs1')
+  end
+
+  it 'allows initializing object without keyword arguments' do
+    parent_klass = Class.new do
+      attr_reader :arguments
+
+      def initialize(arguments)
+        @arguments = arguments
+      end
+    end
+
+    klass = Class.new(parent_klass) do
+      extend Enumerize
+
+      def initialize(arguments)
+        super
+      end
+    end
+
+    params = { 'string_key' => 1, symbol_key: 2 }
+
+    object = klass.new(params)
+
+    expect(object.arguments).must_equal params
   end
 end

data/test/formtastic_test.rb

@@ -1,16 +1,9 @@
+# frozen_string_literal: true
+
 require 'test_helper'
-require 'rails'
-
-module Formtastic
-  module Helpers
-    module InputHelper
-      remove_method :input_class
-      def input_class(as)
-        input_class_with_const_defined(as)
-      end
-    end
-  end
-end
+
+Formtastic::FormBuilder.action_class_finder = Formtastic::ActionClassFinder
+Formtastic::FormBuilder.input_class_finder  = Formtastic::InputClassFinder
 
 class FormtasticSpec < MiniTest::Spec
   include ViewTestHelper
@@ -51,6 +44,12 @@ class FormtasticSpec < MiniTest::Spec
     end
   end
 
+  class Registration < Struct.new(:sex)
+    extend Enumerize
+
+    enumerize :sex, in: [:male, :female]
+  end
+
   before { $VERBOSE = nil }
   after  { $VERBOSE = true }
 
@@ -133,4 +132,21 @@ class FormtasticSpec < MiniTest::Spec
 
     assert_select 'input[type=text]'
   end
+
+  it 'renders select with enumerized values for non-ActiveModel object' do
+    concat(semantic_form_for(Registration.new, as: 'registration', url: '/') do |f|
+      f.input(:sex)
+    end)
+
+    assert_select 'select option[value=male]'
+    assert_select 'select option[value=female]'
+  end
+
+  it 'does not affect forms without object' do
+    concat(semantic_form_for('') do |f|
+      f.input(:name)
+    end)
+
+    assert_select 'input[type=text]'
+  end
 end

data/test/module_attributes_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class ModuleAttributesSpec < MiniTest::Spec
@@ -9,9 +11,9 @@ class ModuleAttributesSpec < MiniTest::Spec
 
     klass = Class.new
     klass.send :include, mod
-    klass.enumerized_attributes[:sex].must_be_instance_of Enumerize::Attribute
-    klass.new.sex.must_equal 'male'
-    klass.sex.must_be_instance_of Enumerize::Attribute
+    expect(klass.enumerized_attributes[:sex]).must_be_instance_of Enumerize::Attribute
+    expect(klass.new.sex).must_equal 'male'
+    expect(klass.sex).must_be_instance_of Enumerize::Attribute
   end
 
   it 'uses new attributes from the module' do
@@ -22,9 +24,9 @@ class ModuleAttributesSpec < MiniTest::Spec
     klass = Class.new
     klass.send :include, mod
     mod.enumerize :sex, :in => %w[male female], :default => 'male'
-    klass.enumerized_attributes[:sex].must_be_instance_of Enumerize::Attribute
-    klass.new.sex.must_equal 'male'
-    klass.sex.must_be_instance_of Enumerize::Attribute
+    expect(klass.enumerized_attributes[:sex]).must_be_instance_of Enumerize::Attribute
+    expect(klass.new.sex).must_equal 'male'
+    expect(klass.sex).must_be_instance_of Enumerize::Attribute
   end
 
   it 'validates attributes' do
@@ -44,7 +46,7 @@ class ModuleAttributesSpec < MiniTest::Spec
 
     object = klass.new
     object.sex = 'wrong'
-    object.wont_be :valid?
-    object.errors[:sex].must_include 'is not included in the list'
+    expect(object).wont_be :valid?
+    expect(object.errors[:sex]).must_include 'is not included in the list'
   end
 end