enumerate_by 0.4.1 → 0.4.2

data/CHANGELOG.rdoc

@@ -1,5 +1,9 @@
 == master
 
+== 0.4.2 / 2009-05-03
+
+* Fix bootstrapping without ids not working on update for certain database adapters
+
 == 0.4.1 / 2009-05-01
 
 * Improve #fast_bootstrap speed by 50% by using the connection directly

data/Rakefile

@@ -5,9 +5,10 @@ require 'rake/contrib/sshpublisher'
 
 spec = Gem::Specification.new do |s|
   s.name              = 'enumerate_by'
-  s.version           = '0.4.1'
+  s.version           = '0.4.2'
   s.platform          = Gem::Platform::RUBY
   s.summary           = 'Adds support for declaring an ActiveRecord class as an enumeration'
+  s.description       = s.summary
   
   s.files             = FileList['{lib,test}/**/*'] + %w(CHANGELOG.rdoc init.rb LICENSE Rakefile README.rdoc) - FileList['test/app_root/{log,log/*,script,script/*}']
   s.require_path      = 'lib'

data/lib/enumerate_by.rb

@@ -253,7 +253,10 @@ module EnumerateBy
       uncached do
         # Remove records that are no longer being used
         records.flatten!
-        delete_all(['id NOT IN (?)', records.map {|record| record[:id]}])
+        ids = records.map {|record| record[:id]}.compact
+        delete_all(ids.any? ? ['id NOT IN (?)', ids] : nil)
+        
+        # Find remaining existing records (to be updated)
         existing = all.inject({}) {|existing, record| existing[record.id] = record; existing}
         
         records.map! do |attributes|
@@ -302,7 +305,8 @@ module EnumerateBy
     def fast_bootstrap(*records)
       # Remove records that are no longer being used
       records.flatten!
-      delete_all(['id NOT IN (?)', records.map {|record| record[:id]}])
+      ids = records.map {|record| record[:id]}.compact
+      delete_all(ids.any? ? ['id NOT IN (?)', ids] : nil)
       
       # Find remaining existing records (to be updated)
       quoted_table_name = self.quoted_table_name

data/test/unit/enumerate_by_test.rb

@@ -295,6 +295,25 @@ class EnumerationBootstrappedWithExistingRecordsTest < ActiveRecord::TestCase
   end
 end
 
+class EnumerationBootstrappedWithExistingDynamicRecordsTest < ActiveRecord::TestCase
+  def setup
+    create_color(:name => 'RED')
+    create_color(:name => 'GREEN')
+  
+    @red, @green = Color.bootstrap(
+      {:name => 'red'},
+      {:name => 'green'}
+    )
+  end
+  
+  def test_should_synchronize_all_attributes
+    assert_equal 2, Color.count
+    
+    assert_equal 'red', @red.name
+    assert_equal 'green', @green.name
+  end
+end
+
 class EnumerationBootstrappedWithDefaultsTest < ActiveRecord::TestCase
   def setup
     @red = create_color(:name => 'RED', :html => '#f00')
@@ -375,6 +394,25 @@ class EnumeratioFastBootstrappedWithExistingRecordsTest < ActiveRecord::TestCase
   end
 end
 
+class EnumerationFastBootstrappedWithExistingDynamicRecordsTest < ActiveRecord::TestCase
+  def setup
+    create_color(:name => 'RED')
+    create_color(:name => 'GREEN')
+  
+    Color.fast_bootstrap(
+      {:name => 'red'},
+      {:name => 'green'}
+    )
+  end
+  
+  def test_should_synchronize_all_attributes
+    assert_equal 2, Color.count
+    
+    assert Color.exists?(:name => 'red')
+    assert Color.exists?(:name => 'green')
+  end
+end
+
 class EnumerationFastBootstrappedWithDefaultsTest < ActiveRecord::TestCase
   def setup
     @red = create_color(:name => 'RED', :html => '#f00')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: enumerate_by
 version: !ruby/object:Gem::Version 
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors: 
 - Aaron Pfeifer
@@ -9,11 +9,11 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-05-01 00:00:00 -04:00
+date: 2009-05-03 00:00:00 -04:00
 default_executable: 
 dependencies: []
 
-description: 
+description: Adds support for declaring an ActiveRecord class as an enumeration
 email: aaron@pluginaweek.org
 executables: []
 
@@ -25,28 +25,28 @@ files:
 - lib/enumerate_by.rb
 - lib/enumerate_by
 - lib/enumerate_by/extensions
-- lib/enumerate_by/extensions/associations.rb
-- lib/enumerate_by/extensions/xml_serializer.rb
 - lib/enumerate_by/extensions/base_conditions.rb
+- lib/enumerate_by/extensions/associations.rb
 - lib/enumerate_by/extensions/serializer.rb
-- test/factory.rb
-- test/test_helper.rb
+- lib/enumerate_by/extensions/xml_serializer.rb
 - test/unit
+- test/unit/xml_serializer_test.rb
 - test/unit/enumerate_by_test.rb
+- test/unit/serializer_test.rb
 - test/unit/assocations_test.rb
 - test/unit/json_serializer_test.rb
-- test/unit/serializer_test.rb
-- test/unit/xml_serializer_test.rb
 - test/unit/base_conditions_test.rb
+- test/factory.rb
 - test/app_root
+- test/app_root/app
+- test/app_root/app/models
+- test/app_root/app/models/color.rb
+- test/app_root/app/models/car.rb
 - test/app_root/db
 - test/app_root/db/migrate
 - test/app_root/db/migrate/001_create_colors.rb
 - test/app_root/db/migrate/002_create_cars.rb
-- test/app_root/app
-- test/app_root/app/models
-- test/app_root/app/models/car.rb
-- test/app_root/app/models/color.rb
+- test/test_helper.rb
 - CHANGELOG.rdoc
 - init.rb
 - LICENSE
@@ -79,9 +79,9 @@ signing_key:
 specification_version: 2
 summary: Adds support for declaring an ActiveRecord class as an enumeration
 test_files: 
+- test/unit/xml_serializer_test.rb
 - test/unit/enumerate_by_test.rb
+- test/unit/serializer_test.rb
 - test/unit/assocations_test.rb
 - test/unit/json_serializer_test.rb
-- test/unit/serializer_test.rb
-- test/unit/xml_serializer_test.rb
 - test/unit/base_conditions_test.rb