enum_table 0.0.1 → 0.1.0

data/CHANGELOG

@@ -1,3 +1,10 @@
+== 0.1.0 2012-11-30
+
+ * DB Nazi compliance.
+ * Remove customizability of the foreign key, since ActiveRecord mangles these
+   customizations when roundtripped through schema.rb.
+ * Foreign keys via foreigner now work.
+
 == 0.0.1 2012-11-05
 
  * Hi.

data/README.markdown

@@ -32,7 +32,7 @@ database directly. Another problem is the database cannot enforce any
 This plugin implements a different strategy which solves the above problems -
 each enum is defined by a table with `id` and `value` columns, which defines the
 values and the integers they map to. Altering the values can be done with simple
-DDL statements, which do not require rebuilding any tables.
+DML statements, which do not require rebuilding any tables.
 
 [enum_column3]: https://github.com/taktsoft/enum_column3
 [pt-osc]: http://www.percona.com/doc/percona-toolkit/2.1/pt-online-schema-change.html

data/lib/enum_table/schema_dumper.rb

@@ -12,7 +12,6 @@ module EnumTable
       table_names = @connection.enum_tables
       table_names.each do |table_name|
         stream.puts "  create_enum_table #{table_name.inspect}, force: true do |t|"
-        enum_table_column(stream, table_name, 'id', SchemaStatements::DEFAULT_ID_ATTRIBUTES)
         enum_table_column(stream, table_name, 'value', SchemaStatements::DEFAULT_VALUE_ATTRIBUTES)
         @connection.execute("SELECT id, value FROM #{table_name} ORDER BY id").each do |row|
           stream.puts "    t.add #{row[1].to_s.inspect}, #{row[0]}"

data/lib/enum_table/schema_statements.rb

@@ -22,7 +22,6 @@ module EnumTable
       end.sort
     end
 
-    DEFAULT_ID_ATTRIBUTES = {type: :integer, limit: 1, null: false}.freeze
     DEFAULT_VALUE_ATTRIBUTES = {type: :string, limit: 255, null: false}.freeze
 
     class NewTable
@@ -30,7 +29,6 @@ module EnumTable
         @connection = connection
         @name = name
         @options = options
-        @id = DEFAULT_ID_ATTRIBUTES.dup
         @value = DEFAULT_VALUE_ATTRIBUTES.dup
         @adds = []
         values = options.delete(:values) and
@@ -38,13 +36,12 @@ module EnumTable
       end
 
       def _create
-        @connection.create_table @name, @options.merge(id: false) do |t|
-          t.column :id, @id.delete(:type), @id
+        @connection.create_table @name, @options do |t|
           t.column :value, @value.delete(:type), @value
         end
         unless @connection.table_exists?(:enum_tables)
           @connection.create_table :enum_tables, id: false, force: true do |t|
-            t.string :table_name, null: false
+            t.string :table_name, null: false, limit: 255
           end
         end
         @connection.execute "INSERT INTO enum_tables(table_name) VALUES('#{@name}')"
@@ -52,10 +49,6 @@ module EnumTable
         @adds.each { |args| table.add(*args) }
       end
 
-      def id(options)
-        @id.update(options)
-      end
-
       def value(options)
         @value.update(options)
       end

data/lib/enum_table/version.rb

@@ -1,5 +1,5 @@
 module EnumTable
-  VERSION = [0, 0, 1]
+  VERSION = [0, 1, 0]
 
   class << VERSION
     include Comparable

data/test/enum_table/test_schema_dumper.rb

@@ -35,18 +35,6 @@ describe EnumTable::SchemaDumper do
         EOS
       end
 
-      it "dumps custom id column attributes" do
-        connection.create_enum_table :user_genders do |t|
-          t.id type: :string, limit: 20, null: true
-        end
-        ActiveRecord::SchemaDumper.dump(connection, stream)
-        stream.string.must_include(<<-EOS.gsub(/^ *\|/, ''))
-          |  create_enum_table "user_genders", force: true do |t|
-          |    t.id type: :string, limit: 20, null: true
-          |  end
-        EOS
-      end
-
       it "dumps custom value column attributes" do
         connection.create_enum_table :user_genders do |t|
           t.value type: :binary, limit: 20, null: true

data/test/enum_table/test_schema_statements.rb

@@ -28,15 +28,6 @@ describe EnumTable::SchemaStatements do
       connection.create_enum_table :genders, force: true
     end
 
-    it "allows configuring the id column in the block" do
-      connection.create_enum_table :genders do |t|
-        t.id type: :string, limit: 20
-      end
-      column = connection.columns(:genders).find { |c| c.name == 'id' }
-      column.type.must_equal :string
-      column.limit.must_equal 20
-    end
-
     it "allows configuring the type column in the block" do
       connection.create_enum_table :genders do |t|
         t.value type: :binary, limit: 20

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: enum_table
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-05 00:00:00.000000000 Z
+date: 2012-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -82,21 +82,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 123907201229092467
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 123907201229092467
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Enumeration tables for ActiveRecord
@@ -107,3 +101,4 @@ test_files:
 - test/enum_table/test_schema_dumper.rb
 - test/enum_table/test_schema_statements.rb
 - test/test_helper.rb
+has_rdoc: