enum_errors_away 0.3.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a042969d984fbb4972117e18c9a8f8d95b3cf83cd517ff8bfa52d2fd5356bdd2
-  data.tar.gz: cce23409d8eafac9e6cd2a8230127ef6060644f81fc6bd7b5871bb15cfc2ddb4
+  metadata.gz: 4bac7b769e6b6d6aeb286b30984f2dac7beec851398af2d42c56d7e3d0713732
+  data.tar.gz: 16a6cdfc2c12c90036c06e13211f52bafdb2affb118dc0290bea1f4b97e9450f
 SHA512:
-  metadata.gz: 6fd2754ab0fc90df56e0170f6b61f37083c7a9ccdb111acc831bcba1d5bf1a0e473ee2dd12114b2f651ba5d3b2c1f5895dc86833200e1248259450aa2c6394c4
-  data.tar.gz: d12a7d77b11ad0644d1c65d4aa6b17773d4eef109d1f856af9f590574de7b2b3fd6a2b16d54d05481e4e2afc7f1f365b2403e2b22d44f65df7534508545e858c
+  metadata.gz: 3e26fbee663d16d10a873f113500ea350c0e7e2eeae9617061a95b0328beb5681e22b4a0b43bc38dc892b4b725e93d0c85d6b32e5f9cbd64e82d64ae96a14329
+  data.tar.gz: c35c6f3b21e959825493b99f5046f0520c4c5d70e987382f7857388389c175dbd2a060b07a2c086a5fce26b8d54949153f9155fb8e76d348fb7837d251bd3cfc

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## [0.5.0] - 2026-04-01
+
+### Fixed
+
+- Handle PostgreSQL native enum columns correctly. When a column has `type: :enum` (created with `t.enum` in migrations), the gem now declares an attribute for it. Previously, the gem skipped all existing columns, but Rails 8 requires explicit attribute declarations for PostgreSQL native enum columns. (Fixes #1)
+
+## [0.4.0] - 2025-12-05
+
+Change the way we define the fallback. 
+Declare attribute if there's no column for it.
+
 ## [0.3.1] - 2025-11-28
 
 ### Fixed

data/lib/enum_errors_away/active_record_extension.rb

@@ -27,37 +27,38 @@ module EnumErrorsAway
                         { name => values }
                       end
 
-        # Pre-declare attributes for enum names that don't exist as columns
+        # Pre-declare attributes for enum names that don't have a database column.
+        # We check columns_hash to avoid overriding the column's type.
         definitions.each do |enum_name, enum_values|
           next if enum_name.nil? || enum_name.to_s.empty?
-          next if enum_values.nil?
 
           begin
             enum_name_str = enum_name.to_s
-            # @type var enum_name: Symbol | String
-            attribute enum_name, :integer if !attribute_types.key?(enum_name_str) && !columns_hash.key?(enum_name_str)
+            # Only declare attribute if there's no column for it,
+            # OR if the column is a PostgreSQL native enum (type :enum)
+            column = columns_hash[enum_name_str]
+            next if column && column.type != :enum
+
+            # Determine attribute type from enum values:
+            # - If all values are integers (or array), use :integer
+            # - If any value is a string, use :string
+            attr_type = if enum_values.is_a?(Array)
+                          :integer
+                        elsif enum_values.is_a?(Hash) && enum_values.values.any? { |v| v.is_a?(String) }
+                          :string
+                        else
+                          :integer
+                        end
+
+            attribute enum_name, attr_type
           rescue ActiveRecord::StatementInvalid, ActiveRecord::ConnectionNotEstablished
-            # Ignore database errors during schema introspection
+            # Silently ignore database errors - the enum may fail later,
+            # but that's the expected behavior without this gem
           end
         end
 
         # Call the original enum method
-        begin
-          super(name, values, **options)
-        rescue ArgumentError, RuntimeError => e
-          raise e unless e.message.include?('Undeclared attribute type for enum')
-
-          # Fallback: declare missing attributes and retry
-          definitions.each do |enum_name, enum_values|
-            next if enum_name.nil? || enum_name.to_s.empty?
-            next if enum_values.nil?
-
-            enum_name_str = enum_name.to_s
-            # @type var enum_name: Symbol | String
-            attribute enum_name, :integer unless attribute_types.key?(enum_name_str)
-          end
-          super(name, values, **options)
-        end
+        super(name, values, **options)
       end
       # rubocop:enable Metrics/AbcSize
       # rubocop:enable Metrics/MethodLength

data/lib/enum_errors_away/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module EnumErrorsAway
-  VERSION = '0.3.1'
+  VERSION = '0.5.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: enum_errors_away
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Sampo Kuokkanen
@@ -145,7 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.2
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Fix Rails 7.2+ enum migration failures
 test_files: []