enum_accessor 0.2.0 → 0.3.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 6b8947f56d293a6a55ae10dcdc009bfa6b2cfbd4
+  data.tar.gz: 75825ca40a5002cd3c1506b77df310aa6cb9138b
+SHA512:
+  metadata.gz: c41df44791461e8d1471a7d8a6567f3677cda98cb0b2a4226108cfc31adcb3feed3f894e6b0347a3881de61674149c478b40b4f320a3124a55d2d3df70e60a99
+  data.tar.gz: ff9bfc17e13950b8bb5844d625d4e8c1912221c0c46423250f569a4a5c0e438e0a39b27875e03c64e06d02852b2e2d3d985dc8b7d1d7814ff7bfda66de96fb2f

data/README.md

@@ -106,12 +106,14 @@ user.human_gender     # => 'Female'
 User.human_genders    # => { :female => 'Female', :male => 'Male' }
 ```
 
+## Changelog
+
+- v0.3.0: Add support for `find_or_create_by`
+
 ## Why enum keys are internally stored as strings rather than symbols?
 
 Because `params[:gender].to_sym` is dangerous. It could lead to problems like memory leak, slow symbol table lookup, or even DoS attack. If a user sends random strings for the parameter, it generates uncontrollable number of symbols, which can never be garbage collected, and eventually causes `symbol table overflow (RuntimeError)`, eating up gigabytes of memory.
 
-We 
-
 For the same reason, `ActiveSupport::HashWithIndifferentAccess` (which is used for `params`) keeps hash keys as string internally.
 
 https://github.com/rails/rails/blob/master/activesupport/lib/active_support/hash_with_indifferent_access.rb
@@ -130,5 +132,6 @@ There are tons of similar gems out there. Then why did I bother creating another
 * [coded_options](https://github.com/jasondew/coded_options)
 * [active_enum](https://github.com/adzap/active_enum)
 * [classy_enum](https://github.com/beerlington/classy_enum)
+* [enumerize](https://github.com/brainspec/enumerize)
 
 Also, EnumAccessor has one of the simplest code base, so that you can easily hack on.

data/lib/enum_accessor/railtie.rb

@@ -1,11 +1,11 @@
 module EnumAccessor
   if defined? Rails::Railtie
-  	class Railtie < Rails::Railtie
-  	  initializer 'enum_accessor.insert_into_active_record' do |app|
-  	    ActiveSupport.on_load :active_record do
-  	      include EnumAccessor
-  	    end
-  	  end
-  	end
+    class Railtie < Rails::Railtie
+      initializer 'enum_accessor.insert_into_active_record' do |app|
+        ActiveSupport.on_load :active_record do
+          include EnumAccessor
+        end
+      end
+    end
   end
 end

data/lib/enum_accessor/version.rb

@@ -1,3 +1,3 @@
 module EnumAccessor
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/lib/enum_accessor.rb

@@ -31,7 +31,12 @@ module EnumAccessor
 
       # Setter
       define_method("#{field}=") do |arg|
-        write_attribute field, const[arg.to_s]
+        case arg
+        when String, Symbol
+          write_attribute field, const[arg.to_s]
+        when Integer
+          write_attribute field, arg
+        end
       end
 
       # Raw-value getter

data/spec/enum_accessor_spec.rb

@@ -16,57 +16,65 @@ describe EnumAccessor do
   end
 
   it 'adds checker' do
-    @user.gender_female?.should == true
-    @user.gender_male?.should == false
+    expect(@user.gender_female?).to eq(true)
+    expect(@user.gender_male?).to eq(false)
   end
 
   it 'adds getter' do
-    @user.gender.should == :female
+    expect(@user.gender).to eq(:female)
   end
 
   it 'adds setter' do
     @user.gender = :male
-    @user.gender_male?.should == true
+    expect(@user.gender_male?).to eq(true)
   end
 
   it 'adds raw value getter' do
-    @user.gender_raw.should == 0
+    expect(@user.gender_raw).to eq(0)
   end
 
   it 'adds raw value setter' do
     @user.gender_raw = 1
-    @user.gender_male?.should == true
+    expect(@user.gender_male?).to eq(true)
   end
 
   it 'adds humanized methods' do
     I18n.locale = :ja
-    User.human_attribute_name(:gender).should == '性別'
-    @user.human_gender.should == '女'
-    User.human_genders(:female).should == '女'
-    User.human_genders.should == { :female => '女', :male => '男' }
+    expect(User.human_attribute_name(:gender)).to eq('性別')
+    expect(@user.human_gender).to eq('女')
+    expect(User.human_genders(:female)).to eq('女')
+    expect(User.human_genders).to eq({ :female => '女', :male => '男' })
 
     I18n.locale = :en
-    User.human_attribute_name(:gender).should == 'Gender'
-    @user.human_gender.should == 'Female'
-    User.human_genders(:female).should == 'Female'
-    User.human_genders.should == { :female => 'Female', :male => 'Male' }
+    expect(User.human_attribute_name(:gender)).to eq('Gender')
+    expect(@user.human_gender).to eq('Female')
+    expect(User.human_genders(:female)).to eq('Female')
+    expect(User.human_genders).to eq({ :female => 'Female', :male => 'Male' })
   end
 
   it 'defines internal constant' do
-    User::GENDERS.should == { "female" => 0, "male" => 1 }
+    expect(User::GENDERS).to eq({ "female" => 0, "male" => 1 })
   end
 
   it 'adds class methods' do
-    User.genders.should == { :female => 0, :male => 1 }
-    User.genders[:female].should == 0
-    User.genders(:female).should == 0
+    expect(User.genders).to eq({ :female => 0, :male => 1 })
+    expect(User.genders[:female]).to eq(0)
+    expect(User.genders(:female)).to eq(0)
   end
 
   it 'adds validation' do
     @user.gender = 'bogus'
-    @user.valid?.should be_false
+    expect(@user.valid?).to be_falsey
 
     @user.gender = 'male'
-    @user.valid?.should be_true
+    expect(@user.valid?).to be_truthy
+  end
+
+  it 'supports find_or_create_by' do
+    # `find_or_create_by` uses where-based raw value for find,
+    # then passes the raw value to the setter method for create.
+    expect {
+      User.find_or_create_by(gender: User.genders(:female))
+    }.to change{ User.count }.by(1)
   end
 end

data/spec/spec_helper.rb

@@ -11,5 +11,6 @@ RSpec.configure do |config|
   ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
 
   # Load translation
+  I18n.enforce_available_locales = true
   I18n.load_path << File.join(File.dirname(__FILE__), 'locales.yml')
 end

metadata

@@ -1,78 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: enum_accessor
 version: !ruby/object:Gem::Version
-  version: 0.2.0
-  prerelease: 
+  version: 0.3.0
 platform: ruby
 authors:
 - Kenn Ejima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-17 00:00:00.000000000 Z
+date: 2014-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Simple enum fields for ActiveRecord
@@ -82,8 +73,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -97,27 +88,26 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/kenn/enum_accessor
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Simple enum fields for ActiveRecord
 test_files:
 - spec/enum_accessor_spec.rb