enrico 0.1.6 → 0.2.2

data/spec/lib/enrico/country_public_holidays_for_month_spec.rb

@@ -6,62 +6,66 @@ require_relative '../../spec_helper'
 
 describe Enrico::Country do
 
-  describe "GET getPublicHolidaysForMonth" do
+  describe "GET getHolidaysForMonth" do
     before(:each) do
-      VCR.insert_cassette 'public_holidays_in_month', :record => :new_episodes
+      VCR.insert_cassette 'holidays_in_month'
     end
 
     after(:each) do
       VCR.eject_cassette
     end
-    let(:country) { Enrico::Country.new("ger") }
+    let(:country) { Enrico::Country.new("deu") }
     it "should return all holidays in month" do
-      date                      = Date.today.beginning_of_year
-      dates                     = country.public_holidays_for_month(date)
-      dates.first.date          = Date.today.beginning_of_year
-      dates.first.local_name    = "Neujahrstag"
-      dates.first.english_name  = "New Year's Day"
+      dates = country.holidays_for_month(Date.parse('2020-01-15'))
+
+      _(dates.first.date).must_equal Date.parse('2020-01-01')
+      _(dates.first.local_name).must_equal "Neujahrstag"
+      _(dates.first.english_name).must_equal "New Year's Day"
     end
   end
 
-  describe "GET getPublicHolidaysForYear" do
+  describe "GET getHolidaysForYear" do
     before(:each) do
-      VCR.insert_cassette 'public_holidays_in_year', :record => :new_episodes
+      VCR.insert_cassette 'holidays_in_year'
     end
 
     after(:each) do
       VCR.eject_cassette
     end
-    let(:country) { Enrico::Country.new("ger") }
-    it "should return all holidays in month" do
-      date                      = Date.today.beginning_of_year
-      dates                     = country.public_holidays_for_year(date)
-      dates.first.date          = Date.today.beginning_of_year
-      dates.first.local_name    = "Neujahrstag"
-      dates.first.english_name  = "New Year's Day"
+    let(:country) { Enrico::Country.new("deu") }
+    it "should return all holidays in year" do
+      dates = country.holidays_for_year(Date.parse('2020-06-01'))
+
+      _(dates.first.date).must_equal Date.parse('2020-01-01')
+      _(dates.first.local_name).must_equal "Neujahrstag"
+      _(dates.first.english_name).must_equal "New Year's Day"
+
+      _(dates.last.date).must_equal Date.parse('2020-12-26')
+      _(dates.last.local_name).must_equal "Zweiter Weihnachtsfeiertag"
+      _(dates.last.english_name).must_equal "Boxing Day"
     end
   end
 
-  describe "GET getPublicHolidaysForDateRange" do
+  describe "GET getForDateRange" do
     before(:each) do
-      VCR.insert_cassette 'public_holidays_in_date_range', :record => :new_episodes
+      VCR.insert_cassette 'holidays_in_date_range'
     end
 
     after(:each) do
       VCR.eject_cassette
     end
-    let(:country) { Enrico::Country.new("ger") }
+    let(:country) { Enrico::Country.new("deu") }
     it "should return all holidays in date range" do
-      start_date = Date.today.beginning_of_year
-      end_date = Date.today.beginning_of_year + 2.month
+      dates = country.holidays_for_date_range(Date.parse('2020-01-01'), Date.parse('2020-03-31'))
 
-      dates = country.public_holidays_for_date_range(start_date, end_date)
+      _(dates.first.date).must_equal Date.parse('2020-01-01')
+      _(dates.first.local_name).must_equal "Neujahrstag"
+      _(dates.first.english_name).must_equal "New Year's Day"
 
-      dates.first.date          = Date.today.beginning_of_year
-      dates.first.local_name    = "Neujahrstag"
-      dates.first.english_name  = "New Year's Day"
+      _(dates.last.date).must_equal Date.parse('2020-03-29')
+      _(dates.last.local_name).must_equal "Beginn der Sommerzeit"
+      _(dates.last.english_name).must_equal "Daylight Saving Time Starts"
     end
   end
 
 end
-

data/spec/lib/enrico/country_spec.rb

@@ -7,7 +7,7 @@ require_relative '../../spec_helper'
 describe Enrico::Country do
 
   before(:each) do
-    VCR.insert_cassette 'supported_countries', :record => :new_episodes
+    VCR.insert_cassette 'supported_countries'
   end
 
   after(:each) do
@@ -16,10 +16,10 @@ describe Enrico::Country do
 
   describe "default attributes" do
     it "must include httparty methods" do
-      Enrico::Country.must_include HTTParty
+      _(Enrico::Country).must_include HTTParty
     end
     it "must have the base url set to the Dribble API endpoint" do
-      Enrico::Country.base_uri.must_equal 'http://kayaposoft.com/enrico/json/v1.0'
+      _(Enrico::Country.base_uri).must_equal 'https://kayaposoft.com/enrico/json/v2.0'
     end
   end
 
@@ -30,61 +30,132 @@ describe Enrico::Country do
     end
 
     describe "get list of all supported countries" do
-      
+
       it "must have all method" do
-        Enrico::Country.must_respond_to :all
+        _(Enrico::Country).must_respond_to :all
       end
 
       it "must parse the api response from JSON to Hash" do
-        Enrico::Country.all.must_be_instance_of Array
+        _(Enrico::Country.all).must_be_instance_of HTTParty::Response
+        _(Enrico::Country.all.to_a).must_be_instance_of Array
       end
 
     end
 
     describe "default instance attributes" do
-      let(:country) { Enrico::Country.new("ger") }
+      let(:country) { Enrico::Country.new("deu") }
 
       it "must have an country_code attribute" do
-        country.must_respond_to :country_code
+        _(country).must_respond_to :country_code
       end
 
       it "must have the right id" do
-        country.country_code.must_equal 'ger'
+        _(country.country_code).must_equal 'deu'
       end
 
     end
 
     describe "get list of all supported countries" do
 
-      let(:country) { Enrico::Country.new("ger") }
+      let(:country) { Enrico::Country.new("deu") }
 
       it "must have a country method" do
-        country.must_respond_to :details
+        _(country).must_respond_to :details
       end
 
       it "must repond with the details of a country" do
-        country.full_name.must_equal 'Germany'
+        _(country.full_name).must_equal 'Germany'
       end
 
       it "should respond with the fromDate" do
         format = {"day"=>1, "month"=>1, "year"=>2011}
-        country.from_date.must_equal format
+        _(country.from_date).must_equal format
       end
 
       it "should respond with toDate" do
         toDate = {"day"=>31, "month"=>12, "year"=>32767}
-        country.toDate.must_equal toDate
+        _(country.toDate).must_equal toDate
       end
 
       it "should respond with regions" do
-        regions = ["Baden-Württemberg", "Bavaria", "Berlin", "Brandenburg", "Bremen", "Hamburg", "Hesse", "Mecklenburg-Vorpommern", "Lower Saxony", "North Rhine-Westphalia", "Rhineland-Palatinate", "Saarland", "Saxony", "Saxony-Anhalt", "Schleswig-Holstein", "Thuringia"]
-        country.regions.must_be_instance_of Array
-        country.regions.must_equal regions
+        regions = ["bw", "by", "be", "bb", "hb", "hh", "he", "ni", "mv", "nw", "rp", "sl", "sn", "st", "sh", "th"]
+        _(country.regions).must_be_instance_of Array
+        _(country.regions).must_equal regions
       end
 
     end
 
   end
 
-end
+  describe "method_missing" do
+    let(:country) { Enrico::Country.new("deu") }
+
+    before do
+      # Mock the details method to return a hash with test data
+      def country.details
+        {
+          "fullName" => "Germany",
+          "countryCode" => "deu",
+          "fromDate" => {"day"=>1, "month"=>1, "year"=>2011},
+          "toDate" => {"day"=>31, "month"=>12, "year"=>32767}
+        }
+      end
+    end
+
+    it "converts snake_case method names to camelCase for accessing details" do
+      _(country.full_name).must_equal "Germany"
+      _(country.country_code).must_equal "deu"
+    end
+
+    it "handles already camelCase properties" do
+      _(country.fromDate).must_equal({"day"=>1, "month"=>1, "year"=>2011})
+      _(country.toDate).must_equal({"day"=>31, "month"=>12, "year"=>32767})
+    end
 
+    it "raises NoMethodError for non-existent properties" do
+      assert_raises(NoMethodError) do
+        country.non_existent_property
+      end
+    end
+  end
+
+  describe "country_parameters" do
+    let(:country) { Enrico::Country.new("deu", "by") }
+    let(:country_no_region) { Enrico::Country.new("deu") }
+
+    it "includes country code and region in parameters" do
+      params = country.country_parameters({month: 1, year: 2024})
+      _(params).must_include "country=deu"
+      _(params).must_include "region=by"
+      _(params).must_include "month=1"
+      _(params).must_include "year=2024"
+    end
+
+    it "excludes nil region from parameters" do
+      params = country_no_region.country_parameters({month: 1, year: 2024})
+      _(params).must_include "country=deu"
+      _(params).wont_include "region="
+    end
+
+    it "includes holiday_type when provided and not empty" do
+      params = country.country_parameters({month: 1}, holiday_type: "public_holiday")
+      _(params).must_include "holidayType=public_holiday"
+    end
+
+    it "excludes holiday_type when nil" do
+      params = country.country_parameters({month: 1}, holiday_type: nil)
+      _(params).wont_include "holidayType"
+    end
+
+    it "excludes holiday_type when empty string" do
+      params = country.country_parameters({month: 1}, holiday_type: "")
+      _(params).wont_include "holidayType"
+    end
+
+    it "properly encodes parameters for URL" do
+      params = country.country_parameters({date: "01-01-2024"})
+      _(params).must_equal "country=deu&region=by&date=01-01-2024"
+    end
+  end
+
+end

data/spec/lib/enrico/is_public_holiday_spec.rb

@@ -8,25 +8,24 @@ describe Enrico::Country do
 
   describe "GET isPublicHoliday" do
     before(:each) do
-      VCR.insert_cassette 'is_public_holiday', :record => :new_episodes
+      VCR.insert_cassette 'is_public_holiday'
     end
     after(:each) do
       VCR.eject_cassette
     end
 
-    let(:country) { Enrico::Country.new("ger") }
+    let(:country) { Enrico::Country.new("deu") }
 
     it "should trueify that date is public holiday" do
-      date = Date.today.beginning_of_year
-      country.is_public_holiday?(date).must_equal true
+      date = Date.parse('2020-01-01')
+      _(country.is_public_holiday?(date)).must_equal true
     end
 
     it "should falsify that date is public holiday" do
-      date = Date.today.beginning_of_year + 28.days
-      country.is_public_holiday?(date).must_equal false
+      date = Date.parse('2020-01-29')
+      _(country.is_public_holiday?(date)).must_equal false
     end
 
   end
 
 end
-

data/spec/lib/enrico/vacation_day_spec.rb

@@ -1,34 +1,95 @@
 # encoding: utf-8
 
 require_relative '../../spec_helper'
-# For Ruby < 1.9.3, use this instead of require_relative
-# require (File.expand_path('./../../../spec_helper', __FILE__))
 
 describe Enrico::VacationDay do
+  describe "initialization" do
+    before(:each) do
+      VCR.insert_cassette 'holidays_in_month'
+    end
+    
+    after(:each) do
+      VCR.eject_cassette
+    end
 
-  describe "default instance attributes" do
-    let(:vacatin_date) {
-      Enrico::VacationDay.new(Date.today.beginning_of_year, "Neujahrstag", "New Year's Day")
-    }
+    it "creates VacationDay from real API response" do
+      country = Enrico::Country.new("deu")
+      vacation_days = country.holidays_for_month(Date.parse('2020-01-15'))
+      
+      day = vacation_days.first
+      _(day).must_be_instance_of Enrico::VacationDay
+      _(day.date).must_equal Date.new(2020, 1, 1)
+      _(day.local_name).must_equal "Neujahrstag"
+      _(day.english_name).must_equal "New Year's Day"
+    end
 
-    it "test initializer methods" do
-      beginning_of_year = Date.today.beginning_of_year
-      rsp = {"date"=>{"day"=> beginning_of_year.day, "month" => beginning_of_year.month, "year"=>beginning_of_year.year, "dayOfWeek"=>beginning_of_year.wday}, "localName"=>"Neujahrstag", "englishName"=>"New Year's Day"}
+    it "handles multi-language holidays" do
+      rsp = {
+        "date"=>{"day"=>1, "month"=>1, "year"=>2020, "dayOfWeek"=>3},
+        "name"=>[
+          {"lang"=>"de", "text"=>"Neujahrstag"},
+          {"lang"=>"en", "text"=>"New Year's Day"}
+        ],
+        "holidayType"=>"public_holiday"
+      }
       day = Enrico::VacationDay.new(rsp)
-      day.date.must_equal Date.today.beginning_of_year
-      day.local_name.must_equal "Neujahrstag"
-      day.english_name.must_equal "New Year's Day"
+      _(day.date).must_equal Date.new(2020, 1, 1)
+      _(day.local_name).must_equal "Neujahrstag"
+      _(day.english_name).must_equal "New Year's Day"
     end
 
-    it "test initializer methods" do
-      beginning_of_year = Date.today.beginning_of_year
-      rsp = {"date"=>{"day"=> beginning_of_year.day, "month" => beginning_of_year.month, "year"=>beginning_of_year.year, "dayOfWeek"=>beginning_of_year.wday}, "localName"=>"Neujahrstag", "englishName"=>"New Year's Day"}
+    it "handles single-language holidays" do
+      rsp = {
+        "date"=>{"day"=>4, "month"=>7, "year"=>2020, "dayOfWeek"=>6},
+        "name"=>[
+          {"lang"=>"en", "text"=>"Independence Day"}
+        ],
+        "holidayType"=>"public_holiday"
+      }
       day = Enrico::VacationDay.new(rsp)
-      day.date.must_equal Date.today.beginning_of_year
-      day.local_name.must_equal "Neujahrstag"
-      day.english_name.must_equal "New Year's Day"
+      _(day.date).must_equal Date.new(2020, 7, 4)
+      _(day.local_name).must_equal "Independence Day"
+      _(day.english_name).must_equal "Independence Day"
     end
 
-  end
+    it "falls back to local name when second language is nil" do
+      rsp = {
+        "date"=>{"day"=>25, "month"=>12, "year"=>2020, "dayOfWeek"=>5},
+        "name"=>[
+          {"lang"=>"fr", "text"=>"Noël"},
+          nil
+        ],
+        "holidayType"=>"public_holiday"
+      }
+      day = Enrico::VacationDay.new(rsp)
+      _(day.local_name).must_equal "Noël"
+      _(day.english_name).must_equal "Noël"
+    end
 
+    it "falls back to local name when second language is empty" do
+      rsp = {
+        "date"=>{"day"=>1, "month"=>5, "year"=>2020, "dayOfWeek"=>5},
+        "name"=>[
+          {"lang"=>"es", "text"=>"Día del Trabajo"},
+          {}
+        ],
+        "holidayType"=>"public_holiday"
+      }
+      day = Enrico::VacationDay.new(rsp)
+      _(day.local_name).must_equal "Día del Trabajo"
+      _(day.english_name).must_equal "Día del Trabajo"
+    end
+
+    it "parses dates with string values" do
+      rsp = {
+        "date"=>{"day"=>"15", "month"=>"8", "year"=>"2020", "dayOfWeek"=>6},
+        "name"=>[
+          {"lang"=>"it", "text"=>"Ferragosto"}
+        ],
+        "holidayType"=>"public_holiday"
+      }
+      day = Enrico::VacationDay.new(rsp)
+      _(day.date).must_equal Date.new(2020, 8, 15)
+    end
+  end
 end

metadata

@@ -1,118 +1,115 @@
 --- !ruby/object:Gem::Specification
 name: enrico
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.2.2
 platform: ruby
 authors:
 - Kalle Saas
-autorequire: 
+- Martin Gregoire
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2013-12-02 00:00:00.000000000 Z
+date: 2025-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: !binary |-
-          MC4xMi4w
+        version: 0.21.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: !binary |-
-          MC4xMi4w
+        version: 0.21.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: !binary |-
-          MS44Ljg=
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: !binary |-
-          MS44Ljg=
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: shoulda
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: http://github.com/easyPEP/enrico
+description: https://github.com/easyPEP/enrico
 email: kalle@easypep.de
 executables: []
 extensions: []
@@ -121,7 +118,9 @@ extra_rdoc_files:
 - README.md
 - README.rdoc
 files:
-- .document
+- ".document"
+- ".github/workflows/test.yml"
+- ".ruby-version"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -129,44 +128,42 @@ files:
 - README.rdoc
 - Rakefile
 - VERSION
-- enrico-0.1.5.gem
-- enrico-0.1.6.gem
 - enrico.gemspec
 - lib/enrico.rb
 - lib/enrico/country.rb
 - lib/enrico/vacation_day.rb
+- mise.toml
+- spec/fixtures/vcr_cassettes/holidays_in_date_range.yml
+- spec/fixtures/vcr_cassettes/holidays_in_month.yml
+- spec/fixtures/vcr_cassettes/holidays_in_year.yml
 - spec/fixtures/vcr_cassettes/is_public_holiday.yml
-- spec/fixtures/vcr_cassettes/public_holidays_in_date_range.yml
-- spec/fixtures/vcr_cassettes/public_holidays_in_month.yml
-- spec/fixtures/vcr_cassettes/public_holidays_in_year.yml
 - spec/fixtures/vcr_cassettes/supported_countries.yml
 - spec/lib/enrico/country_public_holidays_for_month_spec.rb
 - spec/lib/enrico/country_spec.rb
 - spec/lib/enrico/is_public_holiday_spec.rb
 - spec/lib/enrico/vacation_day_spec.rb
 - spec/spec_helper.rb
-homepage: http://github.com/easyPEP/enrico
+homepage: https://github.com/easyPEP/enrico
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.1.5
-signing_key: 
+rubygems_version: 3.4.19
+signing_key:
 specification_version: 4
 summary: A ruby wrapper around enrico holiday API
 test_files: []

data/spec/fixtures/vcr_cassettes/public_holidays_in_date_range.yml

@@ -1,33 +0,0 @@
----
-http_interactions:
-- request:
-    method: get
-    uri: http://kayaposoft.com/enrico/json/v1.0/?action=getPublicHolidaysForDateRange&country=ger&fromDate=01-01-2013&region=&toDate=01-03-2013
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers: {}
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Server:
-      - nginx
-      Date:
-      - Mon, 02 Dec 2013 17:41:33 GMT
-      Content-Type:
-      - application/json
-      Content-Length:
-      - '113'
-      Connection:
-      - keep-alive
-      Vary:
-      - User-Agent
-    body:
-      encoding: US-ASCII
-      string: ! '[{"date":{"day":1,"month":1,"year":2013,"dayOfWeek":2},"localName":"Neujahrstag","englishName":"New
-        Year''s Day"}]'
-    http_version: 
-  recorded_at: Mon, 02 Dec 2013 17:41:33 GMT
-recorded_with: VCR 2.3.0