enju_seed 0.4.0.beta.1 → 0.4.0.beta.2

data/spec/routing/roles_routing_spec.rb

@@ -1,33 +1,35 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe RolesController do
-  describe 'routing' do
-    it 'recognizes and generates #index' do
-      { get: '/roles' }.should route_to(controller: 'roles', action: 'index')
+  describe "routing" do
+
+    it "recognizes and generates #index" do
+      { get: "/roles" }.should route_to(controller: "roles", action: "index")
     end
 
-    # it "recognizes and generates #new" do
+    #it "recognizes and generates #new" do
     #  { :get => "/roles/new" }.should route_to(:controller => "roles", :action => "new")
-    # end
+    #end
 
-    it 'recognizes and generates #show' do
-      { get: '/roles/1' }.should route_to(controller: 'roles', action: 'show', id: '1')
+    it "recognizes and generates #show" do
+      { get: "/roles/1" }.should route_to(controller: "roles", action: "show", id: "1")
     end
 
-    it 'recognizes and generates #edit' do
-      { get: '/roles/1/edit' }.should route_to(controller: 'roles', action: 'edit', id: '1')
+    it "recognizes and generates #edit" do
+      { get: "/roles/1/edit" }.should route_to(controller: "roles", action: "edit", id: "1")
     end
 
-    # it "recognizes and generates #create" do
+    #it "recognizes and generates #create" do
     #  { :post => "/roles" }.should route_to(:controller => "roles", :action => "create")
-    # end
+    #end
 
-    it 'recognizes and generates #update' do
-      { put: '/roles/1' }.should route_to(controller: 'roles', action: 'update', id: '1')
+    it "recognizes and generates #update" do
+      { put: "/roles/1" }.should route_to(controller: "roles", action: "update", id: "1")
     end
 
-    # it "recognizes and generates #destroy" do
+    #it "recognizes and generates #destroy" do
     #  { :delete => "/roles/1" }.should route_to(:controller => "roles", :action => "destroy", :id => "1")
-    # end
+    #end
+
   end
 end

data/spec/routing/users_spec.rb

@@ -1,13 +1,14 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ProfilesController do
-  describe 'routing' do
-    it 'recognizes and generates #new' do
-      { get: '/users/sign_in' }.should route_to(controller: 'devise/sessions', action: 'new')
+  describe "routing" do
+
+    it "recognizes and generates #new" do
+      { get: "/users/sign_in" }.should route_to(controller: "devise/sessions", action: "new")
     end
 
-    it 'recognizes and generates #destroy' do
-      { delete: '/users/sign_out' }.should route_to(controller: 'devise/sessions', action: 'destroy')
+    it "recognizes and generates #destroy" do
+      { delete: "/users/sign_out" }.should route_to(controller: "devise/sessions", action: "destroy")
     end
   end
 end

data/spec/spec_helper.rb

@@ -47,51 +47,53 @@ RSpec.configure do |config|
   # triggering implicit auto-inclusion in groups with matching metadata.
   config.shared_context_metadata_behavior = :apply_to_host_groups
 
-  # The settings below are suggested to provide a good initial experience
-  # with RSpec, but feel free to customize to your heart's content.
-  #   # This allows you to limit a spec run to individual examples or groups
-  #   # you care about by tagging them with `:focus` metadata. When nothing
-  #   # is tagged with `:focus`, all examples get run. RSpec also provides
-  #   # aliases for `it`, `describe`, and `context` that include `:focus`
-  #   # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
-  #   config.filter_run_when_matching :focus
-  #
-  #   # Allows RSpec to persist some state between runs in order to support
-  #   # the `--only-failures` and `--next-failure` CLI options. We recommend
-  #   # you configure your source control system to ignore this file.
-  #   config.example_status_persistence_file_path = "spec/examples.txt"
-  #
-  #   # Limits the available syntax to the non-monkey patched syntax that is
-  #   # recommended. For more details, see:
-  #   #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
-  #   #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
-  #   config.disable_monkey_patching!
-  #
-  #   # Many RSpec users commonly either run the entire suite or an individual
-  #   # file, and it's useful to allow more verbose output when running an
-  #   # individual spec file.
-  #   if config.files_to_run.one?
-  #     # Use the documentation formatter for detailed output,
-  #     # unless a formatter has already been configured
-  #     # (e.g. via a command-line flag).
-  #     config.default_formatter = 'doc'
-  #   end
-  #
-  #   # Print the 10 slowest examples and example groups at the
-  #   # end of the spec run, to help surface which specs are running
-  #   # particularly slow.
-  #   config.profile_examples = 10
-  #
-  #   # Run specs in random order to surface order dependencies. If you find an
-  #   # order dependency and want to debug it, you can fix the order by providing
-  #   # the seed, which is printed after each run.
-  #   #     --seed 1234
-  #   config.order = :random
-  #
-  #   # Seed global randomization in this process using the `--seed` CLI option.
-  #   # Setting this allows you to use `--seed` to deterministically reproduce
-  #   # test failures related to randomization by passing the same `--seed` value
-  #   # as the one that triggered the failure.
-  #   Kernel.srand config.seed
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  config.disable_monkey_patching!
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
 end

data/spec/support/controller_macros.rb

@@ -1,28 +1,28 @@
 module ControllerMacros
   def login_admin
     before(:each) do
-      @request.env['devise.mapping'] = Devise.mappings[:admin]
+      @request.env["devise.mapping"] = Devise.mappings[:admin]
       sign_in FactoryBot.create(:admin)
     end
   end
 
   def login_librarian
     before(:each) do
-      @request.env['devise.mapping'] = Devise.mappings[:librarian]
+      @request.env["devise.mapping"] = Devise.mappings[:librarian]
       sign_in FactoryBot.create(:librarian)
     end
   end
 
   def login_user
     before(:each) do
-      @request.env['devise.mapping'] = Devise.mappings[:user]
+      @request.env["devise.mapping"] = Devise.mappings[:user]
       sign_in FactoryBot.create(:user)
     end
   end
 
   def login_fixture_admin
     before(:each) do
-      @request.env['devise.mapping'] = Devise.mappings[:admin]
+      @request.env["devise.mapping"] = Devise.mappings[:admin]
       @user = users(:admin)
       sign_in @user
     end
@@ -30,7 +30,7 @@ module ControllerMacros
 
   def login_fixture_librarian
     before(:each) do
-      @request.env['devise.mapping'] = Devise.mappings[:librarian]
+      @request.env["devise.mapping"] = Devise.mappings[:librarian]
       @user = users(:librarian1)
       sign_in @user
     end
@@ -38,7 +38,7 @@ module ControllerMacros
 
   def login_fixture_user
     before(:each) do
-      @request.env['devise.mapping'] = Devise.mappings[:user]
+      @request.env["devise.mapping"] = Devise.mappings[:user]
       @user = users(:user1)
       sign_in @user
     end

data/spec/system/profiles_spec.rb

@@ -0,0 +1,39 @@
+require 'rails_helper'
+
+RSpec.describe 'Profiles', type: :system do
+  include Devise::Test::IntegrationHelpers
+  fixtures :all
+
+  describe 'When logged in as Administrator' do
+    before do
+      sign_in users(:admin)
+    end
+
+    it 'should show user_number' do
+      visit profile_path(profiles(:admin))
+      expect(page).to have_content '00001'
+    end
+  end
+
+  describe 'When logged in as Librarian' do
+    before do
+      sign_in users(:librarian1)
+    end
+
+    it 'should show user_number' do
+      visit profile_path(profiles(:admin))
+      expect(page).not_to have_content '00001'
+    end
+  end
+
+  describe 'When logged in as User' do
+    before do
+      sign_in users(:user1)
+    end
+
+    it 'should show user_number' do
+      visit profile_path(profiles(:admin))
+      expect(page).not_to have_content '00001'
+    end
+  end
+end

data/spec/views/my_accounts/show.html.erb_spec.rb

@@ -1,39 +1,39 @@
 require 'spec_helper'
 
-describe 'my_accounts/show' do
+describe "my_accounts/show" do
   fixtures :all
 
   before(:each) do
     @profile = assign(:profile, profiles(:admin))
   end
 
-  describe 'when logged in as Librarian' do
+  describe "when logged in as Librarian" do
     before(:each) do
       @profile = assign(:profile, profiles(:librarian2))
       user = users(:librarian1)
       view.stub(:current_user).and_return(user)
     end
 
-    it 'renders attributes in <p>' do
+    it "renders attributes in <p>" do
       allow(view).to receive(:policy).and_return double(update?: true, destroy?: true)
       render
       # Run the generator again with the --webrat flag if you want to use webrat matchers
     end
 
-    it 'cannot be deletable by other librarian' do
+    it "cannot be deletable by other librarian" do
       allow(view).to receive(:policy).and_return double(update?: true, destroy?: true)
       render
     end
   end
 
-  describe 'when logged in as User' do
+  describe "when logged in as User" do
     before(:each) do
       @profile = assign(:profile, profiles(:user2))
       user = users(:librarian1)
       view.stub(:current_user).and_return(user)
     end
 
-    it 'renders attributes in <p>' do
+    it "renders attributes in <p>" do
       allow(view).to receive(:policy).and_return double(update?: true, destroy?: true)
       render
     end

data/spec/views/profiles/edit.html.erb_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'profiles/edit' do
+describe "profiles/edit" do
   fixtures :all
 
   before(:each) do
@@ -12,28 +12,28 @@ describe 'profiles/edit' do
     view.stub(:current_user).and_return(User.friendly.find('enjuadmin'))
   end
 
-  describe 'when logged in as librarian' do
+  describe "when logged in as librarian" do
     before(:each) do
       @profile = assign(:profile, profiles(:librarian2))
       user = users(:librarian1)
       view.stub(:current_user).and_return(user)
     end
 
-    it 'renders the edit user form' do
+    it "renders the edit user form" do
       allow(view).to receive(:policy).and_return double(destroy?: true)
       render
-      assert_select 'form', action: profiles_path(@profile), method: 'post' do
-        assert_select 'input#profile_user_number', name: 'profile[user_number]'
+      assert_select "form", action: profiles_path(@profile), method: "post" do
+        assert_select "input#profile_user_number", name: "profile[user_number]"
       end
     end
 
     it "should not display 'delete' link" do
       allow(view).to receive(:policy).and_return double(destroy?: false)
       render
-      expect(rendered).not_to have_selector("a[href='#{profile_path(@profile.id)}'][data-method='delete']")
+      expect(rendered).not_to have_selector("a[href='#{profile_path(@profile.id)}'][data-method='delete']") 
     end
 
-    it 'should disable role selection' do
+    it "should disable role selection" do
       allow(view).to receive(:policy).and_return double(destroy?: true)
       render
       expect(rendered).to have_selector("select#profile_user_attributes_user_has_role_attributes_role_id[disabled='disabled']")

data/spec/views/profiles/index.html.erb_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'profiles/index' do
+describe "profiles/index" do
   fixtures :all
 
   before(:each) do
@@ -10,10 +10,10 @@ describe 'profiles/index' do
     view.stub(:params).and_return(ActionController::Parameters.new)
   end
 
-  it 'renders a list of profiles' do
+  it "renders a list of profiles" do
     allow(view).to receive(:policy).and_return double(create?: true, update?: true, destroy?: true)
     render
     # Run the generator again with the --webrat flag if you want to use webrat matchers
-    assert_select 'tr>td', text: 'enjuadmin'
+    assert_select "tr>td", text: 'enjuadmin'
   end
 end

data/spec/views/profiles/new.html.erb_spec.rb

@@ -1,11 +1,12 @@
 require 'spec_helper'
 
-describe 'profiles/new' do
+describe "profiles/new" do
   fixtures :user_groups
 
   before(:each) do
     assign(:profile, stub_model(Profile,
-                                user_group_id: 1).as_new_record)
+      user_group_id: 1
+    ).as_new_record)
     assign(:user_groups, UserGroup.all)
     assign(:libraries, Library.all)
     assign(:roles, Role.all)
@@ -13,12 +14,12 @@ describe 'profiles/new' do
     view.stub(:current_user).and_return(User.friendly.find('enjuadmin'))
   end
 
-  it 'renders new user form' do
+  it "renders new user form" do
     render
 
     # Run the generator again with the --webrat flag if you want to use webrat matchers
-    assert_select 'form', action: profiles_path, method: 'post' do
-      assert_select 'input#profile_user_number', name: 'profile[user_number]'
+    assert_select "form", action: profiles_path, method: "post" do
+      assert_select "input#profile_user_number", name: "profile[user_number]"
     end
   end
 end

data/spec/views/profiles/show.html.erb_spec.rb

@@ -1,21 +1,21 @@
 require 'spec_helper'
 
-describe 'profiles/show' do
+describe "profiles/show" do
   fixtures :all
 
   before(:each) do
     @profile = assign(:profile, profiles(:admin))
-    view.stub(:current_user).and_return(User.friendly.find('enjuadmin'))
+    view.stub(:current_user).and_return(User.find_by(username: 'enjuadmin'))
   end
 
-  describe 'when logged in as Librarian' do
+  describe "when logged in as Librarian" do
     before(:each) do
       @profile = assign(:profile, profiles(:librarian2))
       user = users(:librarian1)
       view.stub(:current_user).and_return(user)
     end
 
-    it 'cannot be deletable by other librarian' do
+    it "cannot be deletable by other librarian" do
       allow(view).to receive(:policy).and_return double(update?: true, destroy?: true)
       render
     end

data/spec/views/roles/edit.html.erb_spec.rb

@@ -0,0 +1,18 @@
+require 'rails_helper'
+
+RSpec.describe "roles/edit", type: :view do
+  before(:each) do
+    @role = assign(:role, Role.create!(
+      :name => "my_string"
+    ))
+  end
+
+  it "renders the edit role form" do
+    render
+
+    assert_select "form[action=?][method=?]", role_path(@role), "post" do
+
+      assert_select "input[name=?]", "role[name]"
+    end
+  end
+end