enju_seed 0.3.6 → 0.4.0.beta.1

data/spec/models/profile_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe Profile do
-  #pending "add some examples to (or delete) #{__FILE__}"
+  # pending "add some examples to (or delete) #{__FILE__}"
   fixtures :all
 
   it 'should create a profile' do
@@ -14,7 +14,7 @@ describe Profile do
   end
 
   it 'should not set expired_at if its user group does not have valid period' do
-    profile = FactoryBot.create(:profile)
+    profile = FactoryBot.build(:profile, user_group_id: '')
     profile.expired_at.should be_nil
   end
 
@@ -26,44 +26,44 @@ describe Profile do
     profile.expired_at.should eq 10.days.from_now.end_of_day
   end
 
-  it "should create profile" do
+  it 'should create profile' do
     profile = FactoryBot.create(:profile)
-    assert !profile.new_record?, "#{profile.errors.full_messages.to_sentence}"
+    assert !profile.new_record?, profile.errors.full_messages.to_sentence.to_s
   end
 
-  it "should create profile with empty user_number" do
-    profile1 = FactoryBot.create(:profile, user_number: "")
-    profile2 = FactoryBot.create(:profile, user_number: "")
+  it 'should create profile with empty user_number' do
+    profile1 = FactoryBot.create(:profile, user_number: '')
+    profile2 = FactoryBot.create(:profile, user_number: '')
     profile1.should be_valid
     profile2.should be_valid
   end
 
   if defined?(EnjuQuestion)
-    it "should reset answer_feed_token" do
+    it 'should reset answer_feed_token' do
       profiles(:user1).reset_answer_feed_token
       profiles(:user1).answer_feed_token.should be_truthy
     end
 
-    it "should delete answer_feed_token" do
+    it 'should delete answer_feed_token' do
       profiles(:user1).delete_answer_feed_token
       profiles(:user1).answer_feed_token.should be_nil
     end
   end
 
   if defined?(EnjuCirculation)
-    it "should reset checkout_icalendar_token" do
+    it 'should reset checkout_icalendar_token' do
       profiles(:user1).reset_checkout_icalendar_token
       profiles(:user1).checkout_icalendar_token.should be_truthy
     end
 
-    it "should delete checkout_icalendar_token" do
+    it 'should delete checkout_icalendar_token' do
       profiles(:user1).delete_checkout_icalendar_token
       profiles(:user1).checkout_icalendar_token.should be_nil
     end
   end
 
   if defined?(EnjuCirculation)
-    it "should send_message" do
+    it 'should send_message' do
       assert profiles(:librarian1).user.send_message('reservation_expired_for_patron', manifestations: profiles(:librarian1).user.reserves.not_sent_expiration_notice_to_patron.collect(&:manifestation))
       profiles(:librarian1).reload
       profiles(:librarian1).user.reserves.not_sent_expiration_notice_to_patron.should be_empty
@@ -75,18 +75,17 @@ end
 #
 # Table name: profiles
 #
-#  id                       :integer          not null, primary key
-#  user_id                  :integer
-#  user_group_id            :integer
-#  library_id               :integer
+#  id                       :uuid             not null, primary key
+#  user_group_id            :uuid
+#  library_id               :uuid
 #  locale                   :string
 #  user_number              :string
 #  full_name                :text
 #  note                     :text
 #  keyword_list             :text
 #  required_role_id         :integer
-#  created_at               :datetime
-#  updated_at               :datetime
+#  created_at               :datetime         not null
+#  updated_at               :datetime         not null
 #  checkout_icalendar_token :string
 #  save_checkout_history    :boolean          default(FALSE), not null
 #  expired_at               :datetime

data/spec/models/role_spec.rb

@@ -1,26 +1,25 @@
-# -*- encoding: utf-8 -*-
-require 'spec_helper'
+require 'rails_helper'
 
 describe Role do
-  #pending "add some examples to (or delete) #{__FILE__}"
+  # pending "add some examples to (or delete) #{__FILE__}"
   fixtures :roles
 
-  it "should not be saved if name is blank" do
+  it 'should not be saved if name is blank' do
     role = Role.first
     role.name = ''
-    lambda{role.save!}.should raise_error(ActiveRecord::RecordInvalid)
+    -> { role.save! }.should raise_error(ActiveRecord::RecordInvalid)
   end
 
-  it "should not be saved if name is not unique" do
+  it 'should not be saved if name is not unique' do
     role = Role.first
-    lambda{Role.create!(name: role.name)}.should raise_error(ActiveRecord::RecordInvalid)
+    -> { Role.create!(name: role.name) }.should raise_error(ActiveRecord::RecordInvalid)
   end
 
-  it "should respond to localized_name" do
-    roles(:role_00001).localized_name.should eq 'Guest'
+  it 'should respond to localized_name' do
+    roles(:role_00001).display_name.should eq 'Guest'
   end
 
-  it "should respond to default_role" do
+  it 'should respond to default_role' do
     Role.default_role.should eq roles(:role_00001)
   end
 end
@@ -29,12 +28,12 @@ end
 #
 # Table name: roles
 #
-#  id           :integer          not null, primary key
-#  name         :string           not null
-#  display_name :string
-#  note         :text
-#  created_at   :datetime
-#  updated_at   :datetime
-#  score        :integer          default(0), not null
-#  position     :integer
+#  id                        :integer          not null, primary key
+#  name                      :string           not null
+#  display_name_translations :jsonb
+#  note                      :text
+#  created_at                :datetime         not null
+#  updated_at                :datetime         not null
+#  score                     :integer          default(0), not null
+#  position                  :integer
 #

data/spec/models/user_has_role_spec.rb

@@ -1,8 +1,7 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe UserHasRole do
-  #pending "add some examples to (or delete) #{__FILE__}"
-
+  # pending "add some examples to (or delete) #{__FILE__}"
 end
 
 # == Schema Information
@@ -12,6 +11,6 @@ end
 #  id         :integer          not null, primary key
 #  user_id    :integer          not null
 #  role_id    :integer          not null
-#  created_at :datetime
-#  updated_at :datetime
+#  created_at :datetime         not null
+#  updated_at :datetime         not null
 #

data/spec/models/user_spec.rb

@@ -1,8 +1,7 @@
-# -*- encoding: utf-8 -*-
 require 'rails_helper'
 
 describe User do
-  #pending "add some examples to (or delete) #{__FILE__}"
+  # pending "add some examples to (or delete) #{__FILE__}"
   fixtures :all
 
   it 'should create an user' do
@@ -48,12 +47,12 @@ describe User do
     user.active_for_authentication?.should be_truthy
   end
 
-  it "should create user" do
+  it 'should create user' do
     user = FactoryBot.create(:user)
-    assert !user.new_record?, "#{user.errors.full_messages.to_sentence}"
+    assert !user.new_record?, user.errors.full_messages.to_sentence.to_s
   end
 
-  it "should require username" do
+  it 'should require username' do
     old_count = User.count
     user = FactoryBot.build(:user, username: nil)
     user.save
@@ -61,26 +60,26 @@ describe User do
     User.count.should eq old_count
   end
 
-  it "should require password" do
+  it 'should require password' do
     user = FactoryBot.build(:user, password: nil)
     user.save
     user.errors[:password].should be_truthy
   end
 
-  it "should not require password_confirmation on create" do
+  it 'should not require password_confirmation on create' do
     user = FactoryBot.build(:user, password: 'new_password', password_confirmation: nil)
     user.save
     user.errors[:email].should be_empty
   end
 
-  it "should reset password" do
+  it 'should reset password' do
     users(:user1).password = 'new password'
     users(:user1).password_confirmation = 'new password'
     users(:user1).save
     users(:user1).valid_password?('new password').should be_truthy
   end
 
-  it "should set temporary_password" do
+  it 'should set temporary_password' do
     user = users(:user1)
     old_password = user.encrypted_password
     user.set_auto_generated_password
@@ -89,16 +88,16 @@ describe User do
     user.valid_password?('user1password').should be_falsy
   end
 
-  it "should get highest_role" do
+  it 'should get highest_role' do
     users(:admin).role.name.should eq 'Administrator'
   end
 
-  it "should lock all expired users" do
+  it 'should lock all expired users' do
     User.lock_expired_users
     users(:user4).active_for_authentication?.should be_falsy
   end
 
-  it "should lock_expired users" do
+  it 'should lock_expired users' do
     user = users(:user1)
     users(:user1).active_for_authentication?.should be_truthy
     user.expired_at = 1.day.ago
@@ -107,18 +106,18 @@ describe User do
   end
 
   if defined?(EnjuQuestion)
-    it "should reset answer_feed_token" do
+    it 'should reset answer_feed_token' do
       users(:user1).reset_answer_feed_token
       users(:user1).answer_feed_token.should be_truthy
     end
 
-    it "should delete answer_feed_token" do
+    it 'should delete answer_feed_token' do
       users(:user1).delete_answer_feed_token
       users(:user1).answer_feed_token.should be_nil
     end
   end
 
-  describe ".export" do
+  describe '.export' do
     it "should export all user's information" do
       lines = User.export
       CSV.parse(lines, col_sep: "\t")
@@ -172,4 +171,3 @@ end
 #  save_search_history      :boolean         default(FALSE), not null
 #  answer_feed_token        :string(255)
 #
-

data/spec/rails_helper.rb

@@ -1,10 +1,11 @@
-require 'coveralls'
-Coveralls.wear!
+require 'simplecov'
+SimpleCov.start
+
 # This file is copied to spec/ when you run 'rails generate rspec:install'
 ENV['RAILS_ENV'] ||= 'test'
 require File.expand_path('../../spec/dummy/config/environment', __FILE__)
 # Prevent database truncation if the environment is production
-abort("The Rails environment is running in production mode!") if Rails.env.production?
+abort('The Rails environment is running in production mode!') if Rails.env.production?
 require 'spec_helper'
 require 'rspec/rails'
 require 'factory_bot'
@@ -67,12 +68,6 @@ RSpec.configure do |config|
     Sunspot.session = SunspotMatchers::SunspotSessionSpy.new(Sunspot.session)
   end
   config.include SunspotMatchers
-
-  config.before(:each) do |example|
-    if example.metadata[:type] == :system
-      driven_by :selenium, using: :headless_chrome, screen_size: [1400, 1400]
-    end
-  end
 end
 
 FactoryBot.definition_file_paths << "#{::Rails.root}/../../spec/factories"

data/spec/requests/profiles_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
-describe "Profiles" do
-  describe "GET /profiles" do
-    it "works! (now write some real specs)" do
+describe 'Profiles' do
+  describe 'GET /profiles' do
+    it 'works! (now write some real specs)' do
       get profiles_path
     end
   end

data/spec/routing/profiles_routing_spec.rb

@@ -1,35 +1,33 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe ProfilesController do
-  describe "routing" do
-
-    it "recognizes and generates #index" do
-      { get: "/profiles" }.should route_to(controller: "profiles", action: "index")
+  describe 'routing' do
+    it 'recognizes and generates #index' do
+      { get: '/profiles' }.should route_to(controller: 'profiles', action: 'index')
     end
 
-    it "recognizes and generates #new" do
-      { get: "/profiles/new" }.should route_to(controller: "profiles", action: "new")
+    it 'recognizes and generates #new' do
+      { get: '/profiles/new' }.should route_to(controller: 'profiles', action: 'new')
     end
 
-    it "recognizes and generates #show" do
-      { get: "/profiles/1" }.should route_to(controller: "profiles", action: "show", id: "1")
+    it 'recognizes and generates #show' do
+      { get: '/profiles/1' }.should route_to(controller: 'profiles', action: 'show', id: '1')
     end
 
-    it "recognizes and generates #edit" do
-      { get: "/profiles/1/edit" }.should route_to(controller: "profiles", action: "edit", id: "1")
+    it 'recognizes and generates #edit' do
+      { get: '/profiles/1/edit' }.should route_to(controller: 'profiles', action: 'edit', id: '1')
     end
 
-    it "recognizes and generates #create" do
-      { post: "/profiles" }.should route_to(controller: "profiles", action: "create")
+    it 'recognizes and generates #create' do
+      { post: '/profiles' }.should route_to(controller: 'profiles', action: 'create')
     end
 
-    it "recognizes and generates #update" do
-      { put: "/profiles/1" }.should route_to(controller: "profiles", action: "update", id: "1")
+    it 'recognizes and generates #update' do
+      { put: '/profiles/1' }.should route_to(controller: 'profiles', action: 'update', id: '1')
     end
 
-    it "recognizes and generates #destroy" do
-      { delete: "/profiles/1" }.should route_to(controller: "profiles", action: "destroy", id: "1")
+    it 'recognizes and generates #destroy' do
+      { delete: '/profiles/1' }.should route_to(controller: 'profiles', action: 'destroy', id: '1')
     end
-
   end
 end

data/spec/routing/roles_routing_spec.rb

@@ -1,35 +1,33 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe RolesController do
-  describe "routing" do
-
-    it "recognizes and generates #index" do
-      { get: "/roles" }.should route_to(controller: "roles", action: "index")
+  describe 'routing' do
+    it 'recognizes and generates #index' do
+      { get: '/roles' }.should route_to(controller: 'roles', action: 'index')
     end
 
-    #it "recognizes and generates #new" do
+    # it "recognizes and generates #new" do
     #  { :get => "/roles/new" }.should route_to(:controller => "roles", :action => "new")
-    #end
+    # end
 
-    it "recognizes and generates #show" do
-      { get: "/roles/1" }.should route_to(controller: "roles", action: "show", id: "1")
+    it 'recognizes and generates #show' do
+      { get: '/roles/1' }.should route_to(controller: 'roles', action: 'show', id: '1')
     end
 
-    it "recognizes and generates #edit" do
-      { get: "/roles/1/edit" }.should route_to(controller: "roles", action: "edit", id: "1")
+    it 'recognizes and generates #edit' do
+      { get: '/roles/1/edit' }.should route_to(controller: 'roles', action: 'edit', id: '1')
     end
 
-    #it "recognizes and generates #create" do
+    # it "recognizes and generates #create" do
     #  { :post => "/roles" }.should route_to(:controller => "roles", :action => "create")
-    #end
+    # end
 
-    it "recognizes and generates #update" do
-      { put: "/roles/1" }.should route_to(controller: "roles", action: "update", id: "1")
+    it 'recognizes and generates #update' do
+      { put: '/roles/1' }.should route_to(controller: 'roles', action: 'update', id: '1')
     end
 
-    #it "recognizes and generates #destroy" do
+    # it "recognizes and generates #destroy" do
     #  { :delete => "/roles/1" }.should route_to(:controller => "roles", :action => "destroy", :id => "1")
-    #end
-
+    # end
   end
 end

data/spec/routing/users_spec.rb

@@ -1,14 +1,13 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe ProfilesController do
-  describe "routing" do
-
-    it "recognizes and generates #new" do
-      { get: "/users/sign_in" }.should route_to(controller: "devise/sessions", action: "new")
+  describe 'routing' do
+    it 'recognizes and generates #new' do
+      { get: '/users/sign_in' }.should route_to(controller: 'devise/sessions', action: 'new')
     end
 
-    it "recognizes and generates #destroy" do
-      { delete: "/users/sign_out" }.should route_to(controller: "devise/sessions", action: "destroy")
+    it 'recognizes and generates #destroy' do
+      { delete: '/users/sign_out' }.should route_to(controller: 'devise/sessions', action: 'destroy')
     end
   end
 end

data/spec/spec_helper.rb

@@ -47,53 +47,51 @@ RSpec.configure do |config|
   # triggering implicit auto-inclusion in groups with matching metadata.
   config.shared_context_metadata_behavior = :apply_to_host_groups
 
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
-  # This allows you to limit a spec run to individual examples or groups
-  # you care about by tagging them with `:focus` metadata. When nothing
-  # is tagged with `:focus`, all examples get run. RSpec also provides
-  # aliases for `it`, `describe`, and `context` that include `:focus`
-  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
-  config.filter_run_when_matching :focus
-
-  # Allows RSpec to persist some state between runs in order to support
-  # the `--only-failures` and `--next-failure` CLI options. We recommend
-  # you configure your source control system to ignore this file.
-  config.example_status_persistence_file_path = "spec/examples.txt"
-
-  # Limits the available syntax to the non-monkey patched syntax that is
-  # recommended. For more details, see:
-  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
-  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
-  config.disable_monkey_patching!
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-=end
+  # The settings below are suggested to provide a good initial experience
+  # with RSpec, but feel free to customize to your heart's content.
+  #   # This allows you to limit a spec run to individual examples or groups
+  #   # you care about by tagging them with `:focus` metadata. When nothing
+  #   # is tagged with `:focus`, all examples get run. RSpec also provides
+  #   # aliases for `it`, `describe`, and `context` that include `:focus`
+  #   # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  #   config.filter_run_when_matching :focus
+  #
+  #   # Allows RSpec to persist some state between runs in order to support
+  #   # the `--only-failures` and `--next-failure` CLI options. We recommend
+  #   # you configure your source control system to ignore this file.
+  #   config.example_status_persistence_file_path = "spec/examples.txt"
+  #
+  #   # Limits the available syntax to the non-monkey patched syntax that is
+  #   # recommended. For more details, see:
+  #   #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
+  #   #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
+  #   config.disable_monkey_patching!
+  #
+  #   # Many RSpec users commonly either run the entire suite or an individual
+  #   # file, and it's useful to allow more verbose output when running an
+  #   # individual spec file.
+  #   if config.files_to_run.one?
+  #     # Use the documentation formatter for detailed output,
+  #     # unless a formatter has already been configured
+  #     # (e.g. via a command-line flag).
+  #     config.default_formatter = 'doc'
+  #   end
+  #
+  #   # Print the 10 slowest examples and example groups at the
+  #   # end of the spec run, to help surface which specs are running
+  #   # particularly slow.
+  #   config.profile_examples = 10
+  #
+  #   # Run specs in random order to surface order dependencies. If you find an
+  #   # order dependency and want to debug it, you can fix the order by providing
+  #   # the seed, which is printed after each run.
+  #   #     --seed 1234
+  #   config.order = :random
+  #
+  #   # Seed global randomization in this process using the `--seed` CLI option.
+  #   # Setting this allows you to use `--seed` to deterministically reproduce
+  #   # test failures related to randomization by passing the same `--seed` value
+  #   # as the one that triggered the failure.
+  #   Kernel.srand config.seed
 end

data/spec/support/controller_macros.rb

@@ -1,28 +1,28 @@
 module ControllerMacros
   def login_admin
     before(:each) do
-      @request.env["devise.mapping"] = Devise.mappings[:admin]
+      @request.env['devise.mapping'] = Devise.mappings[:admin]
       sign_in FactoryBot.create(:admin)
     end
   end
 
   def login_librarian
     before(:each) do
-      @request.env["devise.mapping"] = Devise.mappings[:librarian]
+      @request.env['devise.mapping'] = Devise.mappings[:librarian]
       sign_in FactoryBot.create(:librarian)
     end
   end
 
   def login_user
     before(:each) do
-      @request.env["devise.mapping"] = Devise.mappings[:user]
+      @request.env['devise.mapping'] = Devise.mappings[:user]
       sign_in FactoryBot.create(:user)
     end
   end
 
   def login_fixture_admin
     before(:each) do
-      @request.env["devise.mapping"] = Devise.mappings[:admin]
+      @request.env['devise.mapping'] = Devise.mappings[:admin]
       @user = users(:admin)
       sign_in @user
     end
@@ -30,7 +30,7 @@ module ControllerMacros
 
   def login_fixture_librarian
     before(:each) do
-      @request.env["devise.mapping"] = Devise.mappings[:librarian]
+      @request.env['devise.mapping'] = Devise.mappings[:librarian]
       @user = users(:librarian1)
       sign_in @user
     end
@@ -38,7 +38,7 @@ module ControllerMacros
 
   def login_fixture_user
     before(:each) do
-      @request.env["devise.mapping"] = Devise.mappings[:user]
+      @request.env['devise.mapping'] = Devise.mappings[:user]
       @user = users(:user1)
       sign_in @user
     end

data/spec/views/my_accounts/show.html.erb_spec.rb

@@ -1,39 +1,39 @@
 require 'spec_helper'
 
-describe "my_accounts/show" do
+describe 'my_accounts/show' do
   fixtures :all
 
   before(:each) do
     @profile = assign(:profile, profiles(:admin))
   end
 
-  describe "when logged in as Librarian" do
+  describe 'when logged in as Librarian' do
     before(:each) do
       @profile = assign(:profile, profiles(:librarian2))
       user = users(:librarian1)
       view.stub(:current_user).and_return(user)
     end
 
-    it "renders attributes in <p>" do
+    it 'renders attributes in <p>' do
       allow(view).to receive(:policy).and_return double(update?: true, destroy?: true)
       render
       # Run the generator again with the --webrat flag if you want to use webrat matchers
     end
 
-    it "cannot be deletable by other librarian" do
+    it 'cannot be deletable by other librarian' do
       allow(view).to receive(:policy).and_return double(update?: true, destroy?: true)
       render
     end
   end
 
-  describe "when logged in as User" do
+  describe 'when logged in as User' do
     before(:each) do
       @profile = assign(:profile, profiles(:user2))
       user = users(:librarian1)
       view.stub(:current_user).and_return(user)
     end
 
-    it "renders attributes in <p>" do
+    it 'renders attributes in <p>' do
       allow(view).to receive(:policy).and_return double(update?: true, destroy?: true)
       render
     end