enju_question 0.2.0.beta.4 → 0.3.2

data/spec/controllers/questions_controller_spec.rb

@@ -41,25 +41,25 @@ describe QuestionsController do
 
       it "should get my index feed" do
         get :index, format: :rss
-        response.should be_success
+        response.should be_successful
         assigns(:questions).should eq Question.public_questions.order(:updated_at).page(1)
       end
 
       it "should redirect_to my index feed if user_id is specified" do
-        get :index, user_id: users(:user1).username, format: 'rss'
-        response.should be_success
+        get :index, params: { user_id: users(:user1).username, format: 'rss' }
+        response.should be_successful
         assigns(:questions).should eq users(:user1).questions
       end
 
       it "should get other user's index" do
-        get :index, user_id: users(:user2).username
-        response.should be_success
+        get :index, params: { user_id: users(:user2).username }
+        response.should be_successful
         assigns(:questions).should_not be_empty
       end
 
       it "should get other user's index feed" do
-        get :index, user_id: users(:user2).username, format: 'rss'
-        response.should be_success
+        get :index, params: { user_id: users(:user2).username, format: 'rss' }
+        response.should be_successful
         assigns(:questions).should_not be_empty
       end
     end
@@ -70,16 +70,16 @@ describe QuestionsController do
         assigns(:questions).should_not be_nil
       end
 
-      it "should get index with query", :vcr => true do
-        get :index, :query => 'Yahoo'
-        response.should be_success
+      it "should get index with query", vcr: true do
+        get :index, params: { query: 'Yahoo' }
+        response.should be_successful
         assigns(:questions).should_not be_nil
         assigns(:crd_results).should_not be_nil
       end
 
-      it "should render crd_xml template", :vcr => true do
-        get :index, :query => 'Yahoo', :mode => 'crd', format: :xml
-        response.should be_success
+      it "should render crd_xml template", vcr: true do
+        get :index, params: { query: 'Yahoo', mode: 'crd', format: :xml }
+        response.should be_successful
         response.should render_template("questions/index_crd")
       end
     end
@@ -87,14 +87,14 @@ describe QuestionsController do
 
   describe "GET show" do
     before(:each) do
-      @question = FactoryGirl.create(:question)
+      @question = FactoryBot.create(:question)
     end
 
     describe "When logged in as Administrator" do
       login_fixture_admin
 
       it "assigns the requested question as @question" do
-        get :show, id: @question.id
+        get :show, params: { id: @question.id }
         assigns(:question).should eq(@question)
       end
     end
@@ -103,7 +103,7 @@ describe QuestionsController do
       login_fixture_librarian
 
       it "assigns the requested question as @question" do
-        get :show, id: @question.id
+        get :show, params: { id: @question.id }
         assigns(:question).should eq(@question)
       end
     end
@@ -112,44 +112,44 @@ describe QuestionsController do
       login_fixture_user
 
       it "assigns the requested question as @question" do
-        get :show, id: @question.id
+        get :show, params: { id: @question.id }
         assigns(:question).should eq(@question)
       end
 
       it "should show other user's question" do
-        get :show, id: 5
-        response.should be_success
+        get :show, params: { id: 5 }
+        response.should be_successful
       end
 
       it "should not show missing question" do
-        lambda{
-          get :show, id: 'missing'
+        lambda {
+          get :show, params: { id: 'missing' }
         }.should raise_error(ActiveRecord::RecordNotFound)
-        #response.should be_missing
+        # response.should be_missing
       end
 
       it "should show my question" do
-        get :show, id: 3
+        get :show, params: { id: 3 }
         assigns(:question).should eq Question.find(3)
-        response.should be_success
+        response.should be_successful
       end
 
       it "should show other user's shared question" do
-        get :show, id: 5
+        get :show, params: { id: 5 }
         assigns(:question).should eq Question.find(5)
-        response.should be_success
+        response.should be_successful
       end
     end
 
     describe "When not logged in" do
       it "assigns the requested question as @question" do
-        get :show, id: @question.id
+        get :show, params: { id: @question.id }
         assigns(:question).should eq(@question)
       end
 
       it "should show crd xml" do
-        get :show, id: @question.id, :mode => 'crd', format: :xml
-        response.should be_success
+        get :show, params: { id: @question.id, mode: 'crd', format: :xml }
+        response.should be_successful
         response.should render_template("questions/show_crd")
       end
     end
@@ -194,14 +194,14 @@ describe QuestionsController do
 
   describe "GET edit" do
     before(:each) do
-      @question = FactoryGirl.create(:question)
+      @question = FactoryBot.create(:question)
     end
 
     describe "When logged in as Administrator" do
       login_fixture_admin
 
       it "assigns the requested question as @question" do
-        get :edit, id: @question.id
+        get :edit, params: { id: @question.id }
         assigns(:question).should eq(@question)
       end
     end
@@ -210,7 +210,7 @@ describe QuestionsController do
       login_fixture_librarian
 
       it "assigns the requested question as @question" do
-        get :edit, id: @question.id
+        get :edit, params: { id: @question.id }
         assigns(:question).should eq(@question)
       end
     end
@@ -219,31 +219,31 @@ describe QuestionsController do
       login_fixture_user
 
       it "assigns the requested question as @question" do
-        get :edit, id: @question.id
+        get :edit, params: { id: @question.id }
         response.should be_forbidden
       end
 
       it "should not edit other user's question" do
-        get :edit, id: 5
+        get :edit, params: { id: 5 }
         response.should be_forbidden
       end
 
       it "should not edit missing question" do
-        lambda{
-          get :edit, id: 'missing'
+        lambda {
+          get :edit, params: { id: 'missing' }
         }.should raise_error(ActiveRecord::RecordNotFound)
-        #response.should be_missing
+        # response.should be_missing
       end
-  
+
       it "should edit my question" do
-        get :edit, id: 3
-        response.should be_success
+        get :edit, params: { id: 3 }
+        response.should be_successful
       end
     end
 
     describe "When not logged in" do
       it "should not assign the requested question as @question" do
-        get :edit, id: @question.id
+        get :edit, params: { id: @question.id }
         response.should redirect_to(new_user_session_url)
       end
     end
@@ -251,8 +251,8 @@ describe QuestionsController do
 
   describe "POST create" do
     before(:each) do
-      @attrs = FactoryGirl.attributes_for(:question)
-      @invalid_attrs = {body: ''}
+      @attrs = FactoryBot.attributes_for(:question)
+      @invalid_attrs = { body: '' }
     end
 
     describe "When logged in as Administrator" do
@@ -260,24 +260,24 @@ describe QuestionsController do
 
       describe "with valid params" do
         it "assigns a newly created question as @question" do
-          post :create, question: @attrs
+          post :create, params: { question: @attrs }
           assigns(:question).should be_valid
         end
 
         it "redirects to the created question" do
-          post :create, question: @attrs
+          post :create, params: { question: @attrs }
           response.should redirect_to(question_url(assigns(:question)))
         end
       end
 
       describe "with invalid params" do
         it "assigns a newly created but unsaved question as @question" do
-          post :create, question: @invalid_attrs
+          post :create, params: { question: @invalid_attrs }
           assigns(:question).should_not be_valid
         end
 
         it "re-renders the 'new' template" do
-          post :create, question: @invalid_attrs
+          post :create, params: { question: @invalid_attrs }
           response.should render_template("new")
         end
       end
@@ -288,25 +288,25 @@ describe QuestionsController do
 
       describe "with valid params" do
         it "assigns a newly created question as @question" do
-          post :create, question: @attrs
+          post :create, params: { question: @attrs }
           assigns(:question).user.save!
           assigns(:question).should be_valid
         end
 
         it "redirects to the created question" do
-          post :create, question: @attrs
+          post :create, params: { question: @attrs }
           response.should redirect_to(question_url(assigns(:question)))
         end
       end
 
       describe "with invalid params" do
         it "assigns a newly created but unsaved question as @question" do
-          post :create, question: @invalid_attrs
+          post :create, params: { question: @invalid_attrs }
           assigns(:question).should_not be_valid
         end
 
         it "re-renders the 'new' template" do
-          post :create, question: @invalid_attrs
+          post :create, params: { question: @invalid_attrs }
           response.should render_template("new")
         end
       end
@@ -317,24 +317,24 @@ describe QuestionsController do
 
       describe "with valid params" do
         it "assigns a newly created question as @question" do
-          post :create, question: @attrs
+          post :create, params: { question: @attrs }
           assigns(:question).should be_valid
         end
 
         it "redirects to the created question" do
-          post :create, question: @attrs
+          post :create, params: { question: @attrs }
           response.should redirect_to(question_url(assigns(:question)))
         end
       end
 
       describe "with invalid params" do
         it "assigns a newly created but unsaved question as @question" do
-          post :create, question: @invalid_attrs
+          post :create, params: { question: @invalid_attrs }
           assigns(:question).should_not be_valid
         end
 
         it "re-renders the 'new' template" do
-          post :create, question: @invalid_attrs
+          post :create, params: { question: @invalid_attrs }
           response.should render_template("new")
         end
       end
@@ -343,24 +343,24 @@ describe QuestionsController do
     describe "When not logged in" do
       describe "with valid params" do
         it "assigns a newly created question as @question" do
-          post :create, question: @attrs
+          post :create, params: { question: @attrs }
           assigns(:question).should be_nil
         end
 
         it "should be forbidden" do
-          post :create, question: @attrs
+          post :create, params: { question: @attrs }
           response.should redirect_to(new_user_session_url)
         end
       end
 
       describe "with invalid params" do
         it "assigns a newly created but unsaved question as @question" do
-          post :create, question: @invalid_attrs
+          post :create, params: { question: @invalid_attrs }
           assigns(:question).should be_nil
         end
 
         it "should be forbidden" do
-          post :create, question: @invalid_attrs
+          post :create, params: { question: @invalid_attrs }
           response.should redirect_to(new_user_session_url)
         end
       end
@@ -369,9 +369,9 @@ describe QuestionsController do
 
   describe "PUT update" do
     before(:each) do
-      @question = FactoryGirl.create(:question)
-      @attrs = FactoryGirl.attributes_for(:question)
-      @invalid_attrs = {body: ''}
+      @question = FactoryBot.create(:question)
+      @attrs = FactoryBot.attributes_for(:question)
+      @invalid_attrs = { body: '' }
     end
 
     describe "When logged in as Administrator" do
@@ -379,37 +379,37 @@ describe QuestionsController do
 
       describe "with valid params" do
         it "updates the requested question" do
-          put :update, id: @question.id, question: @attrs
+          put :update, params: { id: @question.id, question: @attrs }
         end
 
         it "assigns the requested question as @question" do
-          put :update, id: @question.id, question: @attrs
+          put :update, params: { id: @question.id, question: @attrs }
           assigns(:question).should eq(@question)
         end
       end
 
       describe "with invalid params" do
         it "assigns the requested question as @question" do
-          put :update, id: @question.id, question: @invalid_attrs
+          put :update, params: { id: @question.id, question: @invalid_attrs }
         end
 
         it "re-renders the 'edit' template" do
-          put :update, id: @question.id, question: @invalid_attrs
+          put :update, params: { id: @question.id, question: @invalid_attrs }
           response.should render_template("edit")
         end
       end
 
       it "should not update my question without body" do
-        put :update, id: 3, question: {body: ""}
+        put :update, params: { id: 3, question: { body: "" } }
         assigns(:question).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
 
       it "should not update missing question" do
-        lambda{
-          put :update, id: 'missing', question: { }
+        lambda {
+          put :update, params: { id: 'missing', question: {} }
         }.should raise_error(ActiveRecord::RecordNotFound)
-        #response.should be_missing
+        # response.should be_missing
       end
     end
 
@@ -418,11 +418,11 @@ describe QuestionsController do
 
       describe "with valid params" do
         it "updates the requested question" do
-          put :update, id: @question.id, question: @attrs
+          put :update, params: { id: @question.id, question: @attrs }
         end
 
         it "assigns the requested question as @question" do
-          put :update, id: @question.id, question: @attrs
+          put :update, params: { id: @question.id, question: @attrs }
           assigns(:question).should eq(@question)
           response.should redirect_to(@question)
         end
@@ -430,12 +430,12 @@ describe QuestionsController do
 
       describe "with invalid params" do
         it "assigns the question as @question" do
-          put :update, id: @question.id, question: @invalid_attrs
+          put :update, params: { id: @question.id, question: @invalid_attrs }
           assigns(:question).should_not be_valid
         end
 
         it "re-renders the 'edit' template" do
-          put :update, id: @question.id, question: @invalid_attrs
+          put :update, params: { id: @question.id, question: @invalid_attrs }
           response.should render_template("edit")
         end
       end
@@ -446,11 +446,11 @@ describe QuestionsController do
 
       describe "with valid params" do
         it "updates the requested question" do
-          put :update, id: @question.id, question: @attrs
+          put :update, params: { id: @question.id, question: @attrs }
         end
 
         it "should be forbidden" do
-          put :update, id: @question.id, question: @attrs
+          put :update, params: { id: @question.id, question: @attrs }
           assigns(:question).should eq(@question)
           response.should be_forbidden
         end
@@ -458,17 +458,17 @@ describe QuestionsController do
 
       describe "with invalid params" do
         it "assigns the question as @question" do
-          put :update, id: @question.id, question: @invalid_attrs
+          put :update, params: { id: @question.id, question: @invalid_attrs }
         end
 
         it "should be forbidden" do
-          put :update, id: @question.id, question: @invalid_attrs
+          put :update, params: { id: @question.id, question: @invalid_attrs }
           response.should be_forbidden
         end
       end
 
       it "should update my question" do
-        put :update, id: 3, question: {body: 'test'}
+        put :update, params: { id: 3, question: { body: 'test' } }
         assigns(:question).should eq Question.find(3)
         response.should redirect_to(assigns(:question))
       end
@@ -477,18 +477,18 @@ describe QuestionsController do
     describe "When not logged in" do
       describe "with valid params" do
         it "updates the requested question" do
-          put :update, id: @question.id, question: @attrs
+          put :update, params: { id: @question.id, question: @attrs }
         end
 
         it "should be forbidden" do
-          put :update, id: @question.id, question: @attrs
+          put :update, params: { id: @question.id, question: @attrs }
           response.should redirect_to(new_user_session_url)
         end
       end
 
       describe "with invalid params" do
         it "assigns the requested question as @question" do
-          put :update, id: @question.id, question: @invalid_attrs
+          put :update, params: { id: @question.id, question: @invalid_attrs }
           response.should redirect_to(new_user_session_url)
         end
       end
@@ -497,26 +497,26 @@ describe QuestionsController do
 
   describe "DELETE destroy" do
     before(:each) do
-      @question = FactoryGirl.create(:question)
+      @question = FactoryBot.create(:question)
     end
 
     describe "When logged in as Administrator" do
       login_fixture_admin
 
       it "destroys the requested question" do
-        delete :destroy, id: @question.id
+        delete :destroy, params: { id: @question.id }
       end
 
       it "redirects to the questions list" do
-        delete :destroy, id: @question.id
+        delete :destroy, params: { id: @question.id }
         response.should redirect_to(user_questions_url(assigns(:question).user))
       end
 
       it "should not destroy missing question" do
-        lambda{
-          delete :destroy, id: 'missing'
+        lambda {
+          delete :destroy, params: { id: 'missing' }
         }.should raise_error(ActiveRecord::RecordNotFound)
-        #response.should be_missing
+        # response.should be_missing
       end
     end
 
@@ -524,11 +524,11 @@ describe QuestionsController do
       login_fixture_librarian
 
       it "destroys the requested question" do
-        delete :destroy, id: @question.id
+        delete :destroy, params: { id: @question.id }
       end
 
       it "redirects to the questions list" do
-        delete :destroy, id: @question.id
+        delete :destroy, params: { id: @question.id }
         response.should redirect_to(user_questions_url(assigns(:question).user))
       end
     end
@@ -537,32 +537,32 @@ describe QuestionsController do
       login_fixture_user
 
       it "destroys the requested question" do
-        delete :destroy, id: @question.id
+        delete :destroy, params: { id: @question.id }
       end
 
       it "should be forbidden" do
-        delete :destroy, id: @question.id
+        delete :destroy, params: { id: @question.id }
         response.should be_forbidden
       end
 
       it "should destroy my question" do
-        delete :destroy, id: 3
+        delete :destroy, params: { id: 3 }
         response.should redirect_to user_questions_url(assigns(:question).user)
       end
-  
+
       it "should not destroy other question" do
-        delete :destroy, id: 5
+        delete :destroy, params: { id: 5 }
         response.should be_forbidden
       end
     end
 
     describe "When not logged in" do
       it "destroys the requested question" do
-        delete :destroy, id: @question.id
+        delete :destroy, params: { id: @question.id }
       end
 
       it "should be forbidden" do
-        delete :destroy, id: @question.id
+        delete :destroy, params: { id: @question.id }
         response.should redirect_to(new_user_session_url)
       end
     end