enju_purchase_request 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1b1242c2f9b0e229e2d70f38d67f97b51c574203
-  data.tar.gz: 4a91c0a18bdb3d469d71167852990590a3f11a55
+  metadata.gz: f15866e9a20e24c71efe5a00fff44acb23e6bf91
+  data.tar.gz: a0e97b4a23f5e37c9291793b4fd8a44ebd064996
 SHA512:
-  metadata.gz: 042ef6886ef775fd04ae03b644315fc0272dd99be2962fbf93521d94ebb86cf7d8b6a99d6882d440572707453fe22067616661200372f966001caa33d328c0d6
-  data.tar.gz: d0ba37661bcbcad59c37692b652868be31c9ebebef0b525b63b1ca22278b37325ba9283706a1cd71f2a724c873f28f154158bdf03c816c87e90f9cafab61a94c
+  metadata.gz: 62d55ab2f64163e57b9a6eda569904577079546df5718d57e1150455c3f44aed5992576a1f5e266db24fe49ed1316571c4d8ab5b6db61b448fa9312fed01164d
+  data.tar.gz: 9774a6a0853cb106cb13c69931d1cd2b667c3b5afa1ab97eeaddcb752a32a72003da4910758d06abc74b17133c89c0d7dfe55ee9439df814110ca708220ac1ae

data/app/models/order_list.rb

@@ -23,7 +23,7 @@ class OrderList < ActiveRecord::Base
     OrderListStateMachine.new(self, transition_class: OrderListTransition)
   end
 
-  has_many :order_list_transitions
+  has_many :order_list_transitions, autosave: false
 
   delegate :can_transition_to?, :transition_to!, :transition_to, :current_state,
     to: :state_machine

data/app/models/order_list_transition.rb

@@ -16,5 +16,5 @@ end
 #  order_list_id :integer
 #  created_at    :datetime
 #  updated_at    :datetime
-#  most_recent   :boolean
+#  most_recent   :boolean          not null
 #

data/db/migrate/20180107155817_add_constraints_to_most_recent_for_order_list_transitions.rb

@@ -0,0 +1,13 @@
+class AddConstraintsToMostRecentForOrderListTransitions < ActiveRecord::Migration
+  disable_ddl_transaction!
+
+  def up
+    add_index :order_list_transitions, [:order_list_id, :most_recent], unique: true, where: "most_recent", name: "index_order_list_transitions_parent_most_recent" #, algorithm: :concurrently
+    change_column_null :order_list_transitions, :most_recent, false
+  end
+
+  def down
+    remove_index :order_list_transitions, name: "index_order_list_transitions_parent_most_recent"
+    change_column_null :order_list_transitions, :most_recent, true
+  end
+end

data/lib/enju_purchase_request/version.rb

@@ -1,3 +1,3 @@
 module EnjuPurchaseRequest
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/lib/generators/enju_purchase_request/setup/setup_generator.rb

@@ -5,4 +5,5 @@ class EnjuPurchaseRequest::SetupGenerator < Rails::Generators::Base
     rake("enju_purchase_request_engine:install:migrations")
     inject_into_file 'app/models/user.rb',
       "  enju_purchase_request_user_model\n", :after => "enju_leaf_user_model\n"
+    generate("enju_purchase_request:update")
 end

data/lib/generators/enju_purchase_request/update/update_generator.rb

@@ -0,0 +1,8 @@
+class EnjuPurchaseRequest::UpdateGenerator < Rails::Generators::Base
+  source_root File.expand_path('../templates', __FILE__)
+  desc "Create files for updating Next-L Enju"
+
+  def copy_statesman_migration_files
+    generate('statesman:add_constraints_to_most_recent', 'OrderList', 'OrderListTransition')
+  end
+end

data/spec/controllers/order_lists_controller_spec.rb

@@ -8,7 +8,7 @@ describe OrderListsController do
   describe "GET index" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns all order_lists as @order_lists" do
@@ -19,7 +19,7 @@ describe OrderListsController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns all order_lists as @order_lists" do
@@ -30,7 +30,7 @@ describe OrderListsController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "assigns empty as @order_lists" do
@@ -50,11 +50,11 @@ describe OrderListsController do
   describe "GET show" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns the requested order_list as @order_list" do
-        order_list = FactoryGirl.create(:order_list)
+        order_list = FactoryBot.create(:order_list)
         get :show, :id => order_list.id
         assigns(:order_list).should eq(order_list)
       end
@@ -62,11 +62,11 @@ describe OrderListsController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns the requested order_list as @order_list" do
-        order_list = FactoryGirl.create(:order_list)
+        order_list = FactoryBot.create(:order_list)
         get :show, :id => order_list.id
         assigns(:order_list).should eq(order_list)
       end
@@ -74,11 +74,11 @@ describe OrderListsController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "assigns the requested order_list as @order_list" do
-        order_list = FactoryGirl.create(:order_list)
+        order_list = FactoryBot.create(:order_list)
         get :show, :id => order_list.id
         assigns(:order_list).should eq(order_list)
       end
@@ -86,7 +86,7 @@ describe OrderListsController do
 
     describe "When not logged in" do
       it "assigns the requested order_list as @order_list" do
-        order_list = FactoryGirl.create(:order_list)
+        order_list = FactoryBot.create(:order_list)
         get :show, :id => order_list.id
         assigns(:order_list).should eq(order_list)
       end
@@ -96,7 +96,7 @@ describe OrderListsController do
   describe "GET new" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns the requested order_list as @order_list" do
@@ -108,7 +108,7 @@ describe OrderListsController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns the requested order_list as @order_list" do
@@ -120,7 +120,7 @@ describe OrderListsController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "should not assign the requested order_list as @order_list" do
@@ -142,11 +142,11 @@ describe OrderListsController do
   describe "GET edit" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns the requested order_list as @order_list" do
-        order_list = FactoryGirl.create(:order_list)
+        order_list = FactoryBot.create(:order_list)
         get :edit, :id => order_list.id
         assigns(:order_list).should eq(order_list)
       end
@@ -154,11 +154,11 @@ describe OrderListsController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns the requested order_list as @order_list" do
-        order_list = FactoryGirl.create(:order_list)
+        order_list = FactoryBot.create(:order_list)
         get :edit, :id => order_list.id
         assigns(:order_list).should eq(order_list)
       end
@@ -166,11 +166,11 @@ describe OrderListsController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "assigns the requested order_list as @order_list" do
-        order_list = FactoryGirl.create(:order_list)
+        order_list = FactoryBot.create(:order_list)
         get :edit, :id => order_list.id
         response.should be_forbidden
       end
@@ -178,7 +178,7 @@ describe OrderListsController do
 
     describe "When not logged in" do
       it "should not assign the requested order_list as @order_list" do
-        order_list = FactoryGirl.create(:order_list)
+        order_list = FactoryBot.create(:order_list)
         get :edit, :id => order_list.id
         response.should redirect_to(new_user_session_url)
       end
@@ -187,13 +187,13 @@ describe OrderListsController do
 
   describe "POST create" do
     before(:each) do
-      @attrs = FactoryGirl.attributes_for(:order_list)
+      @attrs = FactoryBot.attributes_for(:order_list)
       @invalid_attrs = {:bookstore_id => ''}
     end
 
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       describe "with valid params" do
@@ -223,7 +223,7 @@ describe OrderListsController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       describe "with valid params" do
@@ -253,7 +253,7 @@ describe OrderListsController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       describe "with valid params" do
@@ -310,14 +310,14 @@ describe OrderListsController do
 
   describe "PUT update" do
     before(:each) do
-      @order_list = FactoryGirl.create(:order_list)
-      @attrs = FactoryGirl.attributes_for(:order_list)
+      @order_list = FactoryBot.create(:order_list)
+      @attrs = FactoryBot.attributes_for(:order_list)
       @invalid_attrs = {:bookstore_id => ''}
     end
 
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       describe "with valid params" do
@@ -341,7 +341,7 @@ describe OrderListsController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       describe "with valid params" do
@@ -371,7 +371,7 @@ describe OrderListsController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       describe "with valid params" do
@@ -417,12 +417,12 @@ describe OrderListsController do
 
   describe "DELETE destroy" do
     before(:each) do
-      @order_list = FactoryGirl.create(:order_list)
+      @order_list = FactoryBot.create(:order_list)
     end
 
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "destroys the requested order_list" do
@@ -437,7 +437,7 @@ describe OrderListsController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "destroys the requested order_list" do
@@ -452,7 +452,7 @@ describe OrderListsController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "destroys the requested order_list" do

data/spec/controllers/orders_controller_spec.rb

@@ -7,12 +7,12 @@ describe OrdersController do
 
   describe "GET index" do
     before(:each) do
-      FactoryGirl.create(:order)
+      FactoryBot.create(:order)
     end
 
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns all orders as @orders" do
@@ -23,7 +23,7 @@ describe OrdersController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns all orders as @orders" do
@@ -34,7 +34,7 @@ describe OrdersController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "should be forbidden" do
@@ -56,11 +56,11 @@ describe OrdersController do
   describe "GET show" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns the requested order as @order" do
-        order = FactoryGirl.create(:order)
+        order = FactoryBot.create(:order)
         get :show, :id => order.id
         assigns(:order).should eq(order)
       end
@@ -68,11 +68,11 @@ describe OrdersController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns the requested order as @order" do
-        order = FactoryGirl.create(:order)
+        order = FactoryBot.create(:order)
         get :show, :id => order.id
         assigns(:order).should eq(order)
       end
@@ -80,11 +80,11 @@ describe OrdersController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "assigns the requested order as @order" do
-        order = FactoryGirl.create(:order)
+        order = FactoryBot.create(:order)
         get :show, :id => order.id
         assigns(:order).should eq(order)
       end
@@ -92,7 +92,7 @@ describe OrdersController do
 
     describe "When not logged in" do
       it "assigns the requested order as @order" do
-        order = FactoryGirl.create(:order)
+        order = FactoryBot.create(:order)
         get :show, :id => order.id
         assigns(:order).should eq(order)
       end
@@ -102,7 +102,7 @@ describe OrdersController do
   describe "GET new" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns the requested order as @order" do
@@ -126,7 +126,7 @@ describe OrdersController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns the requested order as @order" do
@@ -138,7 +138,7 @@ describe OrdersController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "should not assign the requested order as @order" do
@@ -160,11 +160,11 @@ describe OrdersController do
   describe "GET edit" do
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "assigns the requested order as @order" do
-        order = FactoryGirl.create(:order)
+        order = FactoryBot.create(:order)
         get :edit, :id => order.id
         assigns(:order).should eq(order)
       end
@@ -172,11 +172,11 @@ describe OrdersController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "assigns the requested order as @order" do
-        order = FactoryGirl.create(:order)
+        order = FactoryBot.create(:order)
         get :edit, :id => order.id
         assigns(:order).should eq(order)
       end
@@ -184,11 +184,11 @@ describe OrdersController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "assigns the requested order as @order" do
-        order = FactoryGirl.create(:order)
+        order = FactoryBot.create(:order)
         get :edit, :id => order.id
         response.should be_forbidden
       end
@@ -196,7 +196,7 @@ describe OrdersController do
 
     describe "When not logged in" do
       it "should not assign the requested order as @order" do
-        order = FactoryGirl.create(:order)
+        order = FactoryBot.create(:order)
         get :edit, :id => order.id
         response.should redirect_to(new_user_session_url)
       end
@@ -205,13 +205,13 @@ describe OrdersController do
 
   describe "POST create" do
     before(:each) do
-      @attrs = FactoryGirl.attributes_for(:order)
+      @attrs = FactoryBot.attributes_for(:order)
       @invalid_attrs = {:order_list_id => ''}
     end
 
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       describe "with valid params" do
@@ -241,7 +241,7 @@ describe OrdersController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       describe "with valid params" do
@@ -271,7 +271,7 @@ describe OrdersController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       describe "with valid params" do
@@ -328,14 +328,14 @@ describe OrdersController do
 
   describe "PUT update" do
     before(:each) do
-      @order = FactoryGirl.create(:order)
-      @attrs = FactoryGirl.attributes_for(:order)
+      @order = FactoryBot.create(:order)
+      @attrs = FactoryBot.attributes_for(:order)
       @invalid_attrs = {:order_list_id => ''}
     end
 
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       describe "with valid params" do
@@ -360,7 +360,7 @@ describe OrdersController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       describe "with valid params" do
@@ -385,7 +385,7 @@ describe OrdersController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       describe "with valid params" do
@@ -431,12 +431,12 @@ describe OrdersController do
 
   describe "DELETE destroy" do
     before(:each) do
-      @order = FactoryGirl.create(:order)
+      @order = FactoryBot.create(:order)
     end
 
     describe "When logged in as Administrator" do
       before(:each) do
-        sign_in FactoryGirl.create(:admin)
+        sign_in FactoryBot.create(:admin)
       end
 
       it "destroys the requested order" do
@@ -451,7 +451,7 @@ describe OrdersController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        sign_in FactoryGirl.create(:librarian)
+        sign_in FactoryBot.create(:librarian)
       end
 
       it "destroys the requested order" do
@@ -466,7 +466,7 @@ describe OrdersController do
 
     describe "When logged in as User" do
       before(:each) do
-        sign_in FactoryGirl.create(:user)
+        sign_in FactoryBot.create(:user)
       end
 
       it "destroys the requested order" do