enju_purchase_request 0.2.0 → 0.2.1

data/spec/controllers/purchase_requests_controller_spec.rb

@@ -244,7 +244,7 @@ describe PurchaseRequestsController do
 
   describe "POST create" do
     before(:each) do
-      @attrs = FactoryGirl.attributes_for(:purchase_request)
+      @attrs = FactoryBot.attributes_for(:purchase_request)
       @invalid_attrs = {:title => ''}
     end
 
@@ -373,13 +373,13 @@ describe PurchaseRequestsController do
   describe "PUT update" do
     before(:each) do
       @purchase_request = purchase_requests(:purchase_request_00001)
-      @attrs = FactoryGirl.attributes_for(:purchase_request)
+      @attrs = FactoryBot.attributes_for(:purchase_request)
       @invalid_attrs = {:title => ''}
     end
 
     describe "When logged in as Administrator" do
       before(:each) do
-        @user = FactoryGirl.create(:admin)
+        @user = FactoryBot.create(:admin)
         sign_in @user
       end
 
@@ -409,7 +409,7 @@ describe PurchaseRequestsController do
 
     describe "When logged in as Librarian" do
       before(:each) do
-        @user = FactoryGirl.create(:librarian)
+        @user = FactoryBot.create(:librarian)
         sign_in @user
       end
 

data/spec/dummy/db/migrate/005_create_manifestations.rb

@@ -13,7 +13,6 @@ class CreateManifestations < ActiveRecord::Migration
       t.string :access_address
       t.integer :language_id, :default => 1, :null => false
       t.integer :carrier_type_id, :default => 1, :null => false
-      t.integer :extent_id, :default => 1, :null => false
       t.integer :start_page
       t.integer :end_page
       t.integer :height

data/spec/dummy/db/migrate/059_create_libraries.rb

@@ -1,9 +1,9 @@
 class CreateLibraries < ActiveRecord::Migration
   def change
     create_table :libraries do |t|
-      t.string :name, :null => false
+      t.string :name, index: true, null: false
       t.text :display_name
-      t.string :short_display_name, :null => false
+      t.string :short_display_name, null: false
       t.string :zip_code
       t.text :street
       t.text :locality
@@ -12,17 +12,15 @@ class CreateLibraries < ActiveRecord::Migration
       t.string :telephone_number_2
       t.string :fax_number
       t.text :note
-      t.integer :call_number_rows, :default => 1, :null => false
-      t.string :call_number_delimiter, :default => "|", :null => false
-      t.integer :library_group_id, :default => 1, :null => false
-      t.integer :users_count, :default => 0, :null => false
+      t.integer :call_number_rows, default: 1, null: false
+      t.string :call_number_delimiter, default: "|", null: false
+      t.references :library_group, index: true, null: false
+      t.integer :users_count, default: 0, null: false
       t.integer :position
-      t.integer :country_id
+      t.references :country
 
       t.timestamps
       t.datetime :deleted_at
     end
-    add_index :libraries, :library_group_id
-    add_index :libraries, :name, :unique => true
   end
 end

data/spec/dummy/db/migrate/069_create_shelves.rb

@@ -1,15 +1,14 @@
 class CreateShelves < ActiveRecord::Migration
   def change
     create_table :shelves do |t|
-      t.string :name, :null => false
+      t.string :name, null: false
       t.text :display_name
       t.text :note
-      t.integer :library_id, :default => 1, :null => false
-      t.integer :items_count, :default => 0, :null => false
+      t.references :library, index: true, null: false
+      t.integer :items_count, default: 0, null: false
       t.integer :position
       t.timestamps
       t.datetime :deleted_at
     end
-    add_index :shelves, :library_id
   end
 end

data/spec/dummy/db/migrate/080_create_library_groups.rb

@@ -1,9 +1,9 @@
 class CreateLibraryGroups < ActiveRecord::Migration
   def change
     create_table :library_groups do |t|
-      t.string :name, :null => false
+      t.string :name, null: false
       t.text :display_name
-      t.string :short_name, :null => false
+      t.string :short_name, index: true, null: false
       t.text :my_networks
       t.text :login_banner
       t.text :note
@@ -12,6 +12,5 @@ class CreateLibraryGroups < ActiveRecord::Migration
 
       t.timestamps
     end
-    add_index :library_groups, :short_name
   end
 end

data/spec/dummy/db/migrate/120_create_baskets.rb

@@ -1,12 +1,11 @@
 class CreateBaskets < ActiveRecord::Migration
   def change
     create_table :baskets do |t|
-      t.integer :user_id
+      t.references :user, index: true
       t.text :note
-      t.integer :lock_version, :default => 0, :null => false
+      t.integer :lock_version, default: 0, null: false
 
       t.timestamps
     end
-    add_index :baskets, :user_id
   end
 end

data/spec/dummy/db/migrate/20081006090811_create_subscriptions.rb

@@ -1,17 +1,14 @@
 class CreateSubscriptions < ActiveRecord::Migration
   def change
     create_table :subscriptions do |t|
-      t.text :title, :null => false
+      t.text :title, null: false
       t.text :note
-      #t.integer :subscription_list_id, :integer
-      t.integer :user_id
-      t.integer :order_list_id
+      t.references :user, index: true
+      t.references :order_list, index: true
       t.datetime :deleted_at
-      t.integer :subscribes_count, :default => 0, :null => false
+      t.integer :subscribes_count, default: 0, null: false
 
       t.timestamps
     end
-    add_index :subscriptions, :user_id
-    add_index :subscriptions, :order_list_id
   end
 end

data/spec/dummy/db/migrate/20081006093246_create_subscribes.rb

@@ -1,14 +1,13 @@
 class CreateSubscribes < ActiveRecord::Migration
   def change
     create_table :subscribes do |t|
-      t.integer :subscription_id, :null => false
-      t.integer :work_id, :null => false
-      t.datetime :start_at, :null => false
-      t.datetime :end_at, :null => false
+      t.references :subscription, index: true, null: false
+      t.integer :work_id, null: false
+      t.datetime :start_at, null: false
+      t.datetime :end_at, null: false
 
       t.timestamps
     end
-    add_index :subscribes, :subscription_id
     add_index :subscribes, :work_id
   end
 end

data/spec/dummy/db/migrate/20091012101112_add_dcndl_schema.rb

@@ -8,7 +8,7 @@ class AddDcndlSchema < ActiveRecord::Migration
     add_column :manifestations, :valid_until, :timestamp
     add_column :manifestations, :date_submitted, :timestamp
     add_column :manifestations, :date_accepted, :timestamp
-    add_column :manifestations, :date_caputured, :timestamp
+    add_column :manifestations, :date_captured, :timestamp
     rename_column :manifestations, :copyright_date, :date_copyrighted
   end
 
@@ -21,7 +21,7 @@ class AddDcndlSchema < ActiveRecord::Migration
     remove_column :manifestations, :valid_until
     remove_column :manifestations, :date_submitted
     remove_column :manifestations, :date_accepted
-    remove_column :manifestations, :date_caputured
+    remove_column :manifestations, :date_captured
     rename_column :manifestations, :date_copyrighted, :copyright_date
   end
 end

data/spec/dummy/db/migrate/20100925074559_create_agent_import_results.rb

@@ -3,7 +3,6 @@ class CreateAgentImportResults < ActiveRecord::Migration
     create_table :agent_import_results do |t|
       t.integer :agent_import_file_id
       t.integer :agent_id
-      t.integer :user_id
       t.text :body
 
       t.timestamps

data/spec/dummy/db/migrate/20120319173203_create_accepts.rb

@@ -1,14 +1,11 @@
 class CreateAccepts < ActiveRecord::Migration
   def change
     create_table :accepts do |t|
-      t.integer :basket_id
-      t.integer :item_id
-      t.integer :librarian_id
+      t.references :basket, index: true
+      t.references :item, index: true
+      t.references :librarian, index: true
 
       t.timestamps
     end
-
-    add_index :accepts, :basket_id
-    add_index :accepts, :item_id
   end
 end

data/spec/dummy/db/migrate/20140110122216_create_user_import_files.rb

@@ -1,7 +1,7 @@
 class CreateUserImportFiles < ActiveRecord::Migration
   def change
     create_table :user_import_files do |t|
-      t.integer :user_id
+      t.references :user, index: true
       t.text :note
       t.datetime :executed_at
       t.string :user_import_file_name

data/spec/dummy/db/migrate/20140110131010_create_user_import_results.rb

@@ -1,8 +1,8 @@
 class CreateUserImportResults < ActiveRecord::Migration
   def change
     create_table :user_import_results do |t|
-      t.integer :user_import_file_id
-      t.integer :user_id
+      t.references :user_import_file, index: true
+      t.references :user, index: true
       t.text :body
 
       t.timestamps

data/spec/dummy/db/migrate/20140519170214_create_resource_import_file_transitions.rb

@@ -2,7 +2,11 @@ class CreateResourceImportFileTransitions < ActiveRecord::Migration
   def change
     create_table :resource_import_file_transitions do |t|
       t.string :to_state
-      t.text :metadata, default: "{}"
+      if ActiveRecord::Base.configurations[Rails.env]["adapter"].try(:match, /mysql/)
+        t.text :metadata
+      else
+        t.text :metadata, default: "{}"
+      end
       t.integer :sort_key
       t.integer :resource_import_file_id
       t.timestamps

data/spec/dummy/db/migrate/20140519171220_create_import_request_transitions.rb

@@ -2,7 +2,11 @@ class CreateImportRequestTransitions < ActiveRecord::Migration
   def change
     create_table :import_request_transitions do |t|
       t.string :to_state
-      t.text :metadata, default: "{}"
+      if ActiveRecord::Base.configurations[Rails.env]["adapter"].try(:match, /mysql/)
+        t.text :metadata
+      else
+        t.text :metadata, default: "{}"
+      end
       t.integer :sort_key
       t.integer :import_request_id
       t.timestamps

data/spec/dummy/db/migrate/20140524020735_create_agent_import_file_transitions.rb

@@ -2,7 +2,11 @@ class CreateAgentImportFileTransitions < ActiveRecord::Migration
   def change
     create_table :agent_import_file_transitions do |t|
       t.string :to_state
-      t.text :metadata, default: "{}"
+      if ActiveRecord::Base.configurations[Rails.env]["adapter"].try(:match, /mysql/)
+        t.text :metadata
+      else
+        t.text :metadata, default: "{}"
+      end
       t.integer :sort_key
       t.integer :agent_import_file_id
       t.timestamps

data/spec/dummy/db/migrate/20140524074813_create_user_import_file_transitions.rb

@@ -8,11 +8,10 @@ class CreateUserImportFileTransitions < ActiveRecord::Migration
         t.text :metadata, default: "{}"
       end
       t.integer :sort_key
-      t.integer :user_import_file_id
+      t.references :user_import_file, index: true
       t.timestamps
     end
 
-    add_index :user_import_file_transitions, :user_import_file_id
     add_index :user_import_file_transitions, [:sort_key, :user_import_file_id], unique: true, name: "index_user_import_file_transitions_on_sort_key_and_file_id"
   end
 end

data/spec/dummy/db/migrate/20140614141500_create_resource_export_file_transitions.rb

@@ -2,7 +2,11 @@ class CreateResourceExportFileTransitions < ActiveRecord::Migration
   def change
     create_table :resource_export_file_transitions do |t|
       t.string :to_state
-      t.text :metadata, default: "{}"
+      if ActiveRecord::Base.configurations[Rails.env]["adapter"].try(:match, /mysql/)
+        t.text :metadata
+      else
+        t.text :metadata, default: "{}"
+      end
       t.integer :sort_key
       t.integer :resource_export_file_id
       t.timestamps

data/spec/dummy/db/migrate/20140709113413_create_user_export_files.rb

@@ -1,7 +1,7 @@
 class CreateUserExportFiles < ActiveRecord::Migration
   def change
     create_table :user_export_files do |t|
-      t.integer :user_id
+      t.references :user, index: true
       t.attachment :user_export
       t.datetime :executed_at
 

data/spec/dummy/db/migrate/20140709113905_create_user_export_file_transitions.rb

@@ -8,7 +8,7 @@ class CreateUserExportFileTransitions < ActiveRecord::Migration
         t.text :metadata, default: "{}"
       end
       t.integer :sort_key
-      t.integer :user_export_file_id
+      t.references :user_export_file, index: true
       t.timestamps
     end
 

data/spec/dummy/db/migrate/20140720170714_add_default_library_id_to_user_import_file.rb

@@ -1,5 +1,5 @@
 class AddDefaultLibraryIdToUserImportFile < ActiveRecord::Migration
   def change
-    add_column :user_import_files, :default_library_id, :integer
+    add_reference :user_import_files, :default_library
   end
 end

data/spec/dummy/db/migrate/20140720170735_add_default_user_group_id_to_user_import_file.rb

@@ -1,5 +1,5 @@
 class AddDefaultUserGroupIdToUserImportFile < ActiveRecord::Migration
   def change
-    add_column :user_import_files, :default_user_group_id, :integer
+    add_reference :user_import_files, :default_user_group
   end
 end

data/spec/dummy/db/migrate/20140821151023_create_colors.rb

@@ -1,14 +1,12 @@
 class CreateColors < ActiveRecord::Migration
   def change
     create_table :colors do |t|
-      t.integer :library_group_id
+      t.references :library_group, index: true
       t.string :property
       t.string :code
       t.integer :position
 
       t.timestamps
     end
-
-    add_index :colors, :library_group_id
   end
 end

data/spec/dummy/db/migrate/20140822114527_add_error_message_to_resource_import_result.rb

@@ -0,0 +1,5 @@
+class AddErrorMessageToResourceImportResult < ActiveRecord::Migration
+  def change
+    add_column :resource_import_results, :error_message, :text
+  end
+end

data/spec/dummy/db/migrate/20140823083524_add_extent_to_manifestation.rb

@@ -0,0 +1,5 @@
+class AddExtentToManifestation < ActiveRecord::Migration
+  def change
+    add_column :manifestations, :extent, :text
+  end
+end

data/spec/dummy/db/migrate/20140823094847_add_dimensions_to_manifestation.rb

@@ -0,0 +1,5 @@
+class AddDimensionsToManifestation < ActiveRecord::Migration
+  def change
+    add_column :manifestations, :dimensions, :text
+  end
+end

data/spec/dummy/db/migrate/20140823095740_rename_manifestation_periodical_to_serial.rb

@@ -0,0 +1,9 @@
+class RenameManifestationPeriodicalToSerial < ActiveRecord::Migration
+  def up
+    rename_column :manifestations, :periodical, :serial
+  end
+
+  def down
+    rename_column :manifestations, :serial, :periodical
+  end
+end

data/spec/dummy/db/migrate/20150117111136_add_foreign_key_to_items_referencing_manifestations.rb

@@ -0,0 +1,5 @@
+class AddForeignKeyToItemsReferencingManifestations < ActiveRecord::Migration
+  def change
+    add_foreign_key :items, :manifestations
+  end
+end

data/spec/dummy/db/migrate/20150924115059_create_withdraws.rb

@@ -1,13 +1,11 @@
 class CreateWithdraws < ActiveRecord::Migration
   def change
     create_table :withdraws do |t|
-      t.integer :basket_id
-      t.integer :item_id
-      t.integer :librarian_id
+      t.references :basket, index: true
+      t.references :item, index: true
+      t.references :librarian, index: true
 
       t.timestamps null: false
     end
-    add_index :withdraws, :basket_id
-    add_index :withdraws, :item_id
   end
 end

data/spec/dummy/db/migrate/20151125004028_add_profile_id_to_agent.rb

@@ -0,0 +1,6 @@
+class AddProfileIdToAgent < ActiveRecord::Migration
+  def change
+    add_column :agents, :profile_id, :integer
+    add_index :agents, :profile_id
+  end
+end

data/spec/dummy/db/migrate/20151213070943_add_translation_table_to_library_group.rb

@@ -1,13 +1,26 @@
+# This migration comes from enju_library_engine (originally 20151213070943)
 class AddTranslationTableToLibraryGroup < ActiveRecord::Migration
   def up
-    LibraryGroup.create_translation_table!({
-      login_banner: :text
-    }, {
-      migrate_data: true
-    })
+    if defined?(Globalize)
+      LibraryGroup.create_translation_table!({
+        login_banner: :text
+      }, {
+        migrate_data: true
+      })
+    end
+
+    if defined?(AwesomeHstoreTranslate)
+      add_column :library_groups, :login_banner, :hstore
+    end
   end
 
   def down
-    LibraryGroup.drop_translation_table! migrate_data: true
+    if defined?(Globalize)
+      LibraryGroup.drop_translation_table! migrate_data: true
+    end
+
+    if defined?(AwesomeHstoreTranslate)
+      remove_column :library_groups, :login_banner
+    end
   end
 end