enju_message 0.3.0.beta.1 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e75af30f09ac93f59585860221a94ba9236b3e2d
-  data.tar.gz: 9d3eb4ac9e0ea0bf7703e4d7c170747827739ae9
+SHA256:
+  metadata.gz: 130ddb20f59265f2d8be22eb8a4bb49a4866ac7e764a9444077b6a92e8d01174
+  data.tar.gz: 5a8b99d000b3e04431eef716f279171a72e10e636580edbc9920c733a9d3bac8
 SHA512:
-  metadata.gz: 207d25d934a7d825adb0e2ed0c2b0ecc0e9116b934e24523ca6e5b0c27945861b97687a18f846094dbecfc3b7df51da4b16c1c8acc55b13660df874ef7e650cc
-  data.tar.gz: c7222db7109beb1c3f3cfc6ab2b92f58fd8a9b2c254c0b5dc90483ba299230a9a6dddd85129604328f158a2a5294913a2b8f6392e23da1676f278300651e65d6
+  metadata.gz: 4f1f078caab25997a3649ec20d42ad5e319c55acd64bed805dc0c97fae19ad412e11af718eb7a75dfb7982a50caa573cb0520617482aa0c7e0b2dd57ee8651d8
+  data.tar.gz: 8e1a1826362b0c657ac8c7fa4e0f18a479e1824ab1125feafe28f96e2882b693fd148bd9550d45efd6d3cae272178aa64d7c18f43c8d4aefe394145b635dba48

data/README.md

@@ -0,0 +1,10 @@
+# EnjuMessage
+[![Travis CI](https://travis-ci.com/next-l/enju_message.svg?branch=1.3)](https://travis-ci.com/next-l/enju_message)
+[![Coverage Status](https://coveralls.io/repos/github/next-l/enju_message/badge.svg?branch=1.3)](https://coveralls.io/github/next-l/enju_message?branch=1.3)
+[![security](https://hakiri.io/github/next-l/enju_message/1.3.svg)](https://hakiri.io/github/next-l/enju_message/1.3)
+
+This project rocks and uses MIT-LICENSE.
+
+## 製作者・貢献者 (Authors and contributors)
+* [TANABE, Kosuke](https://github.com/nabeta) ([@nabeta](https://twitter.com/nabeta))
+* [Project Next-L](https://www.next-l.jp) ([@ProjectNextL](https://twitter.com/ProjectNextL))

data/app/models/message.rb

@@ -1,4 +1,4 @@
-class Message < ActiveRecord::Base
+class Message < ApplicationRecord
   include Statesman::Adapters::ActiveRecordQueries
   scope :unread, -> {in_state('unread')}
   belongs_to :message_request, optional: true
@@ -42,7 +42,7 @@ class Message < ActiveRecord::Base
 
   def set_receiver
     if recipient
-      self.receiver = User.where(username: recipient).first
+      self.receiver = User.find_by(username: recipient)
     end
   end
 
@@ -80,14 +80,14 @@ end
 #
 #  id                 :integer          not null, primary key
 #  read_at            :datetime
-#  receiver_id        :integer
 #  sender_id          :integer
+#  receiver_id        :integer
 #  subject            :string           not null
 #  body               :text
 #  message_request_id :integer
 #  parent_id          :integer
-#  created_at         :datetime
-#  updated_at         :datetime
+#  created_at         :datetime         not null
+#  updated_at         :datetime         not null
 #  lft                :integer
 #  rgt                :integer
 #  depth              :integer

data/app/models/message_request.rb

@@ -1,4 +1,4 @@
-class MessageRequest < ActiveRecord::Base
+class MessageRequest < ApplicationRecord
   include Statesman::Adapters::ActiveRecordQueries
   scope :not_sent, -> {in_state(:pending).where('sent_at IS NULL')}
   scope :sent, -> {in_state(:sent)}
@@ -83,8 +83,7 @@ end
 #  receiver_id         :integer
 #  message_template_id :integer
 #  sent_at             :datetime
-#  deleted_at          :datetime
 #  body                :text
-#  created_at          :datetime
-#  updated_at          :datetime
+#  created_at          :datetime         not null
+#  updated_at          :datetime         not null
 #

data/app/models/message_request_transition.rb

@@ -1,6 +1,5 @@
-class MessageRequestTransition < ActiveRecord::Base
+class MessageRequestTransition < ApplicationRecord
   include Statesman::Adapters::ActiveRecordTransition
-
   
   belongs_to :message_request, inverse_of: :message_request_transitions
   # attr_accessible :to_state, :sort_key, :metadata
@@ -15,7 +14,7 @@ end
 #  metadata           :text             default({})
 #  sort_key           :integer
 #  message_request_id :integer
-#  created_at         :datetime
-#  updated_at         :datetime
+#  created_at         :datetime         not null
+#  updated_at         :datetime         not null
 #  most_recent        :boolean          not null
 #

data/app/models/message_template.rb

@@ -1,4 +1,4 @@
-class MessageTemplate < ActiveRecord::Base
+class MessageTemplate < ApplicationRecord
   has_many :message_requests
 
   validates :status, uniqueness: true
@@ -31,6 +31,6 @@ end
 #  body       :text             not null
 #  position   :integer
 #  locale     :string           default("en")
-#  created_at :datetime
-#  updated_at :datetime
+#  created_at :datetime         not null
+#  updated_at :datetime         not null
 #

data/app/models/message_transition.rb

@@ -1,6 +1,5 @@
-class MessageTransition < ActiveRecord::Base
+class MessageTransition < ApplicationRecord
   include Statesman::Adapters::ActiveRecordTransition
-
   
   belongs_to :message, inverse_of: :message_transitions
   # attr_accessible :to_state, :sort_key, :metadata
@@ -15,7 +14,7 @@ end
 #  metadata    :text             default({})
 #  sort_key    :integer
 #  message_id  :integer
-#  created_at  :datetime
-#  updated_at  :datetime
+#  created_at  :datetime         not null
+#  updated_at  :datetime         not null
 #  most_recent :boolean          not null
 #

data/app/views/message_templates/_form.html.erb

@@ -8,7 +8,7 @@
 
   <div class="field">
     <%= f.label :locale %><br />
-    <%= f.select(:locale, @available_languages.collect{|language| [language.display_name.localize, language.iso_639_1]}) %>
+    <%= f.select(:locale, @available_languages.collect{|language| [language.display_name, language.iso_639_1]}) %>
   </div>
 
   <div class="field">

data/app/views/messages/index.rss.builder

@@ -7,7 +7,7 @@ xml.rss('version' => "2.0",
       xml.title t('message.user_message', login_name: @user.username)
       xml.link messages_url(@user, format: :rss)
     else
-      xml.title t('message.library_group_message', library_group_name: @library_group.display_name.localize)
+      xml.title t('message.library_group_message', library_group_name: @library_group.display_name)
       xml.link messages_url(format: :rss)
     end
     xml.description "Next-L Enju, an open source integrated library system developed by Project Next-L"
@@ -16,7 +16,7 @@ xml.rss('version' => "2.0",
     xml.tag! "atom:link", rel: 'self', href: messages_url(format: :rss)
     xml.tag! "atom:link", rel: 'alternate', href: messages_url
     # xml.tag! "atom:link", rel: 'search', type: 'application/opensearchdescription+xml', href: "http://#{request.host_with_port}/page/opensearch"
-    unless params[:query].blank?
+    if params[:query].present?
       xml.tag! "opensearch:totalResults", @messages.total_entries
       xml.tag! "opensearch:startIndex", @messages.offset + 1
       xml.tag! "opensearch:itemsPerPage", @messages.per_page

data/db/migrate/149_create_message_templates.rb

@@ -1,7 +1,7 @@
-class CreateMessageTemplates < ActiveRecord::Migration[4.2]
-  def self.up
+class CreateMessageTemplates < ActiveRecord::Migration[5.2]
+  def change
     create_table :message_templates do |t|
-      t.string :status, null: false
+      t.string :status, null: false, index: {unique: true}
       t.text :title, null: false
       t.text :body, null: false
       t.integer :position
@@ -9,10 +9,5 @@ class CreateMessageTemplates < ActiveRecord::Migration[4.2]
 
       t.timestamps
     end
-    add_index :message_templates, :status, unique: true
-  end
-
-  def self.down
-    drop_table :message_templates
   end
 end

data/db/migrate/154_create_messages.rb

@@ -1,19 +1,15 @@
-class CreateMessages < ActiveRecord::Migration[4.2]
-  def self.up
-    create_table :messages, force: true do |t|
+class CreateMessages < ActiveRecord::Migration[5.2]
+  def change
+    create_table :messages do |t|
       t.datetime :read_at
       t.references :sender, index: true
       t.references :receiver, index: true
       t.string   :subject, null: false
       t.text     :body
       t.references :message_request, index: true
-      t.references :parent, index: true
+      t.references :parent, foreign_key: {to_table: :messages}
 
       t.timestamps
     end
   end
-
-  def self.down
-    drop_table :messages
-  end
 end

data/db/migrate/20080819181903_create_message_requests.rb

@@ -1,18 +1,13 @@
-class CreateMessageRequests < ActiveRecord::Migration[4.2]
-  def self.up
+class CreateMessageRequests < ActiveRecord::Migration[5.2]
+  def change
     create_table :message_requests do |t|
       t.references :sender
       t.references :receiver
       t.references :message_template
       t.datetime :sent_at
-      t.datetime :deleted_at
       t.text :body
 
       t.timestamps
     end
   end
-
-  def self.down
-    drop_table :message_requests
-  end
 end

data/db/migrate/20110913115320_add_lft_and_rgt_to_message.rb

@@ -1,11 +1,6 @@
-class AddLftAndRgtToMessage < ActiveRecord::Migration[4.2]
-  def self.up
+class AddLftAndRgtToMessage < ActiveRecord::Migration[5.2]
+  def change
     add_column :messages, :lft, :integer
     add_column :messages, :rgt, :integer
   end
-
-  def self.down
-    remove_column :messages, :rgt
-    remove_column :messages, :lft
-  end
 end

data/db/migrate/20120125050502_add_depth_to_message.rb

@@ -1,6 +1,5 @@
-class AddDepthToMessage < ActiveRecord::Migration[4.2]
+class AddDepthToMessage < ActiveRecord::Migration[5.2]
   def change
     add_column :messages, :depth, :integer
-
   end
 end

data/db/migrate/20140518111006_create_message_transitions.rb

@@ -1,18 +1,13 @@
-class CreateMessageTransitions < ActiveRecord::Migration[4.2]
+class CreateMessageTransitions < ActiveRecord::Migration[5.2]
   def change
     create_table :message_transitions do |t|
       t.string :to_state
-      if ActiveRecord::Base.configurations[Rails.env]["adapter"].try(:match, /mysql/)
-        t.text :metadata
-      else
-        t.text :metadata, default: "{}"
-      end
+      t.text :metadata, default: '{}'
       t.integer :sort_key
-      t.integer :message_id
+      t.references :message
       t.timestamps
     end
 
-    add_index :message_transitions, :message_id
     add_index :message_transitions, [:sort_key, :message_id], unique: true
   end
 end

data/db/migrate/20140518135713_create_message_request_transitions.rb

@@ -1,18 +1,13 @@
-class CreateMessageRequestTransitions < ActiveRecord::Migration[4.2]
+class CreateMessageRequestTransitions < ActiveRecord::Migration[5.2]
   def change
     create_table :message_request_transitions do |t|
       t.string :to_state
-      if ActiveRecord::Base.configurations[Rails.env]["adapter"].try(:match, /mysql/)
-        t.text :metadata
-      else
-        t.text :metadata, default: "{}"
-      end
+      t.text :metadata, default: '{}'
       t.integer :sort_key
-      t.integer :message_request_id
+      t.references :message_request
       t.timestamps
     end
 
-    add_index :message_request_transitions, :message_request_id
     add_index :message_request_transitions, [:sort_key, :message_request_id], unique: true, name: "index_message_request_transitions_on_sort_key_and_request_id"
   end
 end

data/db/migrate/20160703185015_add_most_recent_to_message_transitions.rb

@@ -1,4 +1,4 @@
-class AddMostRecentToMessageTransitions < ActiveRecord::Migration[4.2]
+class AddMostRecentToMessageTransitions < ActiveRecord::Migration[5.2]
   def up
     add_column :message_transitions, :most_recent, :boolean, null: true
   end

data/db/migrate/20160814165332_add_most_recent_to_message_request_transitions.rb

@@ -1,4 +1,4 @@
-class AddMostRecentToMessageRequestTransitions < ActiveRecord::Migration[4.2]
+class AddMostRecentToMessageRequestTransitions < ActiveRecord::Migration[5.2]
   def up
     add_column :message_request_transitions, :most_recent, :boolean, null: true
   end

data/db/migrate/20180107162659_add_constraints_to_most_recent_for_message_transitions.rb

@@ -1,4 +1,4 @@
-class AddConstraintsToMostRecentForMessageTransitions < ActiveRecord::Migration[4.2]
+class AddConstraintsToMostRecentForMessageTransitions < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up

data/db/migrate/20180107162711_add_constraints_to_most_recent_for_message_request_transitions.rb

@@ -1,4 +1,4 @@
-class AddConstraintsToMostRecentForMessageRequestTransitions < ActiveRecord::Migration[4.2]
+class AddConstraintsToMostRecentForMessageRequestTransitions < ActiveRecord::Migration[5.2]
   disable_ddl_transaction!
 
   def up

data/lib/enju_message/version.rb

@@ -1,3 +1,3 @@
 module EnjuMessage
-  VERSION = "0.3.0.beta.1"
+  VERSION = "0.3.3".freeze
 end

data/spec/controllers/messages_controller_spec.rb

@@ -14,7 +14,7 @@ describe MessagesController do
       it 'should get its own messages' do
         get :index
         assigns(:messages).should_not be_nil
-        response.should be_success
+        response.should be_successful
       end
 
       describe 'When user_id is specified' do
@@ -31,7 +31,7 @@ describe MessagesController do
       it 'should get its own messages' do
         get :index
         assigns(:messages).should_not be_nil
-        response.should be_success
+        response.should be_successful
       end
 
       describe 'When user_id is specified' do
@@ -55,13 +55,13 @@ describe MessagesController do
       it 'should get its own messages' do
         get :index
         assigns(:messages).should_not be_nil
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should get index with query' do
         get :index, params: { query: 'you' }
         assigns(:messages).first.receiver.should eq users(:user1)
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -106,7 +106,7 @@ describe MessagesController do
 
       it 'should show my message' do
         get :show, params: { id: messages(:user2_to_user1_1).id }
-        response.should be_success
+        response.should be_successful
       end
 
       it "should should not show other user's message" do
@@ -141,7 +141,7 @@ describe MessagesController do
       it 'should not assign the requested message as @message' do
         get :new
         assigns(:message).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -189,7 +189,7 @@ describe MessagesController do
           get :edit, params: { id: message.id }
         end.should raise_error(ActiveRecord::RecordNotFound)
         assigns(:message).should be_nil
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -202,7 +202,7 @@ describe MessagesController do
           get :edit, params: { id: message.id }
         end.should raise_error(ActiveRecord::RecordNotFound)
         assigns(:message).should be_nil
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -215,7 +215,7 @@ describe MessagesController do
           get :edit, params: { id: message.id }
         end.should raise_error(ActiveRecord::RecordNotFound)
         assigns(:message).should be_nil
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -261,18 +261,20 @@ describe MessagesController do
         it "re-renders the 'new' template" do
           post :create, params: { message: @invalid_attrs, user_id: users(:user1).username }
           response.should render_template('new')
-          response.should be_success
+          response.should be_successful
         end
       end
+
       describe 'with invalid recipient' do
         it "re-renders the 'new' template" do
           post :create, params: { message: @invalid_user_attrs }
           message = assigns(:message)
           message.should_not be_valid
           message.errors.should have_key :receiver
-          message.errors.added?(:receiver, :invalid).should be_truthy
+          message.errors.added?(:receiver, :blank).should be_truthy
           response.should render_template('new')
         end
+
         it "re-renders the 'new' template" do
           post :create, params: { message: @blank_user_attrs }
           message = assigns(:message)
@@ -371,7 +373,7 @@ describe MessagesController do
           lambda do
             put :update, params: { id: @message.id, message: @invalid_attrs }
           end.should raise_error(ActiveRecord::RecordNotFound)
-          response.should be_success
+          response.should be_successful
         end
       end
     end
@@ -391,7 +393,7 @@ describe MessagesController do
             put :update, params: { id: @message.id, message: @attrs }
           end.should raise_error(ActiveRecord::RecordNotFound)
           assigns(:message).should be_nil
-          response.should be_success
+          response.should be_successful
         end
       end
 
@@ -406,7 +408,7 @@ describe MessagesController do
           lambda do
             put :update, params: { id: @message.id, message: @invalid_attrs }
           end.should raise_error(ActiveRecord::RecordNotFound)
-          response.should be_success
+          response.should be_successful
         end
       end
     end
@@ -426,7 +428,7 @@ describe MessagesController do
             put :update, params: { id: @message.id, message: @attrs }
           end.should raise_error(ActiveRecord::RecordNotFound)
           assigns(:message).should be_nil
-          response.should be_success
+          response.should be_successful
         end
       end
 
@@ -441,26 +443,26 @@ describe MessagesController do
           lambda do
             put :update, params: { id: @message.id, message: @invalid_attrs }
           end.should raise_error(ActiveRecord::RecordNotFound)
-          response.should be_success
+          response.should be_successful
         end
       end
 
       it 'should not update my message' do
-        put :update, params: { id: 2, message: {} }
+        put :update, params: { id: messages(:user2_to_user1_1), message: {} }
         response.should be_forbidden
       end
 
       it "should not update other user's message" do
         lambda do
-          put :update, params: { id: 1, message: {} }
+          put :update, params: { id: messages(:user1_to_user2_1), message: {} }
         end.should raise_error(ActiveRecord::RecordNotFound)
-        response.should be_success
+        response.should be_successful
       end
     end
 
     describe 'When not logged in' do
       it 'assigns the requested message as @message' do
-        put :update, params: { id: 2, message: {} }
+        put :update, params: { id: messages(:user2_to_user1_1), message: {} }
         response.should redirect_to new_user_session_url
       end
     end
@@ -480,27 +482,27 @@ describe MessagesController do
       login_fixture_user
 
       it 'should destroy own message' do
-        delete :destroy, params: { id: 2 }
+        delete :destroy, params: { id: messages(:user2_to_user1_1) }
         response.should redirect_to messages_url
         response.should_not be_forbidden
       end
 
       it "should not destroy other user's message" do
         lambda do
-          delete :destroy, params: { id: 1 }
+          delete :destroy, params: { id: messages(:user1_to_user2_1) }
         end.should raise_error(ActiveRecord::RecordNotFound)
-        response.should be_success
+        response.should be_successful
       end
     end
 
     describe 'When not logged in' do
       it 'destroys the requested message' do
-        delete :destroy, params: { id: 1 }
+        delete :destroy, params: { id: messages(:user1_to_user2_1) }
         response.should redirect_to(new_user_session_url)
       end
 
       it 'should be redirected to new_user_session_url' do
-        delete :destroy, params: { id: 1 }
+        delete :destroy, params: { id: messages(:user1_to_user2_1) }
         response.should redirect_to(new_user_session_url)
       end
     end