enju_message 0.2.0 → 0.2.1

data/spec/controllers/messages_controller_spec.rb

@@ -3,70 +3,70 @@ require 'rails_helper'
 describe MessagesController do
   fixtures :all
 
-  describe "GET index", :solr => true do
+  describe 'GET index', solr: true do
     before do
       Message.reindex
     end
 
-    describe "When logged in as Administrator" do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "should get its own messages" do
+      it 'should get its own messages' do
         get :index
         assigns(:messages).should_not be_nil
         response.should be_success
       end
 
-      describe "When user_id is specified" do
-        it "assigns all messages as @messages" do
-          get :index, :user_id => @user.username
+      describe 'When user_id is specified' do
+        it 'assigns all messages as @messages' do
+          get :index, user_id: @user.username
           assigns(:messages).should_not be_nil
         end
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "should get its own messages" do
+      it 'should get its own messages' do
         get :index
         assigns(:messages).should_not be_nil
         response.should be_success
       end
 
-      describe "When user_id is specified" do
-        it "assigns all messages as @messages" do
-          get :index, :user_id => @user.username
+      describe 'When user_id is specified' do
+        it 'assigns all messages as @messages' do
+          get :index, user_id: @user.username
           assigns(:messages).should_not be_nil
         end
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      describe "When user_id is specified" do
-        it "assigns all messages as @messages" do
+      describe 'When user_id is specified' do
+        it 'assigns all messages as @messages' do
           get :index
           assigns(:messages).should_not be_nil
         end
       end
 
-      it "should get its own messages" do
+      it 'should get its own messages' do
         get :index
         assigns(:messages).should_not be_nil
         response.should be_success
       end
 
-      it "should get index with query" do
-        get :index, :query => 'you'
+      it 'should get index with query' do
+        get :index, query: 'you'
         assigns(:messages).first.receiver.should eq users(:user1)
         response.should be_success
       end
     end
 
-    describe "When not logged in" do
-      it "assigns all messages as @messages" do
+    describe 'When not logged in' do
+      it 'assigns all messages as @messages' do
         get :index
         assigns(:messages).should be_nil
         response.should redirect_to(new_user_session_url)
@@ -74,104 +74,104 @@ describe MessagesController do
     end
   end
 
-  describe "GET show" do
-    describe "When logged in as Administrator" do
+  describe 'GET show' do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "assigns the requested message as @message" do
+      it 'assigns the requested message as @message' do
         message = messages(:user1_to_user2_1)
-        lambda{
-          get :show, :id => message.id
-        }.should raise_error(ActiveRecord::RecordNotFound)
+        lambda do
+          get :show, id: message.id
+        end.should raise_error(ActiveRecord::RecordNotFound)
         assigns(:message).should be_nil
-        #response.should be_missing
+        # response.should be_missing
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "assigns the requested message as @message" do
+      it 'assigns the requested message as @message' do
         message = messages(:user1_to_user2_1)
-        lambda{
-          get :show, :id => message.id
-        }.should raise_error(ActiveRecord::RecordNotFound)
+        lambda do
+          get :show, id: message.id
+        end.should raise_error(ActiveRecord::RecordNotFound)
         assigns(:message).should be_nil
-        #response.should be_forbidden
+        # response.should be_forbidden
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_user
 
-      it "should show my message" do
-        get :show, :id => messages(:user2_to_user1_1).id
+      it 'should show my message' do
+        get :show, id: messages(:user2_to_user1_1).id
         response.should be_success
       end
 
       it "should should not show other user's message" do
-        lambda{
-          get :show, :id => messages(:user1_to_user2_1).id
-        }.should raise_error(ActiveRecord::RecordNotFound)
-        #response.should be_missing
+        lambda do
+          get :show, id: messages(:user1_to_user2_1).id
+        end.should raise_error(ActiveRecord::RecordNotFound)
+        # response.should be_missing
       end
     end
 
-    describe "When not logged in" do
-      it "assigns the requested message as @message" do
-        get :show, :id => messages(:user1_to_user2_1).id
+    describe 'When not logged in' do
+      it 'assigns the requested message as @message' do
+        get :show, id: messages(:user1_to_user2_1).id
         response.should redirect_to new_user_session_url
       end
     end
   end
-  
-  describe "GET new" do
-    describe "When logged in as Administrator" do
+
+  describe 'GET new' do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "assigns the requested message as @message" do
+      it 'assigns the requested message as @message' do
         get :new
         assigns(:message).should_not be_valid
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "should not assign the requested message as @message" do
+      it 'should not assign the requested message as @message' do
         get :new
         assigns(:message).should_not be_valid
         response.should be_success
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "should not assign the requested message as @message" do
+      it 'should not assign the requested message as @message' do
         get :new
         assigns(:message).should be_nil
         response.should be_forbidden
       end
 
-      it "should not get new template without parent_id" do
+      it 'should not get new template without parent_id' do
         get :new
         response.should be_forbidden
       end
-  
-      it "should not get new template with invalid parent_id" do
-        get :new, :parent_id => 1
+
+      it 'should not get new template with invalid parent_id' do
+        get :new, parent_id: 1
         response.should be_forbidden
       end
-  
-      it "should not get new template with valid parent_id" do
-        get :new, :parent_id => 2
+
+      it 'should not get new template with valid parent_id' do
+        get :new, parent_id: 2
         response.should be_forbidden
       end
     end
 
-    describe "When not logged in" do
-      it "should not assign the requested message as @message" do
+    describe 'When not logged in' do
+      it 'should not assign the requested message as @message' do
         get :new
         assigns(:message).should be_nil
         response.should redirect_to(new_user_session_url)
@@ -179,349 +179,349 @@ describe MessagesController do
     end
   end
 
-  describe "GET edit" do
-    describe "When logged in as Administrator" do
+  describe 'GET edit' do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "assigns the requested message as @message" do
+      it 'assigns the requested message as @message' do
         message = messages(:user1_to_user2_1)
-        lambda{
-          get :edit, :id => message.id
-        }.should raise_error(ActiveRecord::RecordNotFound)
+        lambda do
+          get :edit, id: message.id
+        end.should raise_error(ActiveRecord::RecordNotFound)
         assigns(:message).should be_nil
         response.should be_success
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "assigns the requested message as @message" do
+      it 'assigns the requested message as @message' do
         message = messages(:user1_to_user2_1)
-        lambda{
-          get :edit, :id => message.id
-        }.should raise_error(ActiveRecord::RecordNotFound)
+        lambda do
+          get :edit, id: message.id
+        end.should raise_error(ActiveRecord::RecordNotFound)
         assigns(:message).should be_nil
         response.should be_success
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "assigns the requested message as @message" do
+      it 'assigns the requested message as @message' do
         message = messages(:user1_to_user2_1)
-        lambda{
-          get :edit, :id => message.id
-        }.should raise_error(ActiveRecord::RecordNotFound)
+        lambda do
+          get :edit, id: message.id
+        end.should raise_error(ActiveRecord::RecordNotFound)
         assigns(:message).should be_nil
         response.should be_success
       end
     end
 
-    describe "When not logged in" do
-      it "assigns the requested message as @message" do
+    describe 'When not logged in' do
+      it 'assigns the requested message as @message' do
         message = FactoryGirl.create(:message)
-        get :edit, :id => message.id
+        get :edit, id: message.id
         assigns(:message).should be_nil
         response.should redirect_to new_user_session_url
       end
     end
   end
 
-  describe "POST create" do
+  describe 'POST create' do
     before(:each) do
-      @attrs = {:recipient => users(:user1).username, :subject => 'test',:body => 'test'}
-      @invalid_attrs = {:recipient => users(:user1).username, :subject => 'test', :body => ''}
-      @invalid_user_attrs = {:recipient => "invalid_user", :subject => 'test', :body => 'test'}
-      @blank_user_attrs   = {:recipient => "", :subject => 'test', :body => 'test'}
+      @attrs = { recipient: users(:user1).username, subject: 'test', body: 'test' }
+      @invalid_attrs = { recipient: users(:user1).username, subject: 'test', body: '' }
+      @invalid_user_attrs = { recipient: 'invalid_user', subject: 'test', body: 'test' }
+      @blank_user_attrs   = { recipient: '', subject: 'test', body: 'test' }
     end
 
-    describe "When logged in as Administrator" do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      describe "with valid params" do
-        it "assigns a newly created message as @message" do
-          post :create, :message => @attrs, :user_id => users(:user1).username
+      describe 'with valid params' do
+        it 'assigns a newly created message as @message' do
+          post :create, message: @attrs, user_id: users(:user1).username
           assigns(:message).should be_valid
         end
 
-        it "redirects to the created message" do
-          post :create, :message => @attrs, :user_id => users(:user1).username
+        it 'redirects to the created message' do
+          post :create, message: @attrs, user_id: users(:user1).username
           response.should redirect_to(messages_url)
         end
       end
 
-      describe "with invalid params" do
-        it "assigns a newly created but unsaved message as @message" do
-          post :create, :message => @invalid_attrs, :user_id => users(:user1).username
+      describe 'with invalid params' do
+        it 'assigns a newly created but unsaved message as @message' do
+          post :create, message: @invalid_attrs, user_id: users(:user1).username
           assigns(:message).should_not be_valid
         end
 
         it "re-renders the 'new' template" do
-          post :create, :message => @invalid_attrs, :user_id => users(:user1).username
-          response.should render_template("new")
+          post :create, message: @invalid_attrs, user_id: users(:user1).username
+          response.should render_template('new')
           response.should be_success
         end
       end
-      describe "with invalid recipient" do
+      describe 'with invalid recipient' do
         it "re-renders the 'new' template" do
-          post :create, :message => @invalid_user_attrs
+          post :create, message: @invalid_user_attrs
           message = assigns(:message)
           message.should_not be_valid
           message.errors.should have_key :receiver
           message.errors.added?(:receiver, :invalid).should be_truthy
-          response.should render_template("new")
+          response.should render_template('new')
         end
         it "re-renders the 'new' template" do
-          post :create, :message => @blank_user_attrs
+          post :create, message: @blank_user_attrs
           message = assigns(:message)
           message.should_not be_valid
           message.errors.should have_key :recipient
           message.errors.added?(:recipient, :blank).should be_truthy
-          response.should render_template("new")
+          response.should render_template('new')
         end
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "should create message without parent_id" do
-        post :create, :message => {:recipient => 'user2', :subject => "test", :body => "test", :parent_id => 2}
+      it 'should create message without parent_id' do
+        post :create, message: { recipient: 'user2', subject: 'test', body: 'test' }
         response.should redirect_to messages_url
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "should not create message without parent_id" do
-        post :create, :message => {:recipient => 'user2', :subject => "test", :body => "test"}
+      it 'should not create message without parent_id' do
+        post :create, message: { recipient: 'user2', subject: 'test', body: 'test' }
         response.should be_forbidden
       end
-  
-      it "should not create message with parent_id" do
-        post :create, :message => {:recipient => 'user2', :subject => "test", :body => "test", :parent_id => 2}
+
+      it 'should not create message with parent_id' do
+        post :create, message: { recipient: 'user2', subject: 'test', body: 'test', parent_id: 2 }
         response.should be_forbidden
       end
     end
 
-    describe "When not logged in" do
-      describe "with valid params" do
-        it "assigns a newly created message as @message" do
-          post :create, :message => @attrs
+    describe 'When not logged in' do
+      describe 'with valid params' do
+        it 'assigns a newly created message as @message' do
+          post :create, message: @attrs
           assigns(:message).should be_nil
         end
 
-        it "should redirect to new_user_session_url" do
-          post :create, :message => @attrs
+        it 'should redirect to new_user_session_url' do
+          post :create, message: @attrs
           response.should redirect_to(new_user_session_url)
         end
       end
 
-      describe "with invalid params" do
-        it "assigns a newly created but unsaved message as @message" do
-          post :create, :message => @invalid_attrs
+      describe 'with invalid params' do
+        it 'assigns a newly created but unsaved message as @message' do
+          post :create, message: @invalid_attrs
           assigns(:message).should be_nil
         end
 
-        it "should redirect to new_user_session_url" do
-          post :create, :message => @invalid_attrs
+        it 'should redirect to new_user_session_url' do
+          post :create, message: @invalid_attrs
           response.should redirect_to(new_user_session_url)
         end
       end
     end
   end
 
-  describe "PUT update" do
+  describe 'PUT update' do
     before(:each) do
       @message = messages(:user1_to_user2_1)
       @attrs = FactoryGirl.attributes_for(:message)
-      @invalid_attrs = {:sender_id => ''}
+      @invalid_attrs = { sender_id: '' }
     end
 
-    describe "When logged in as Administrator" do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      describe "with valid params" do
-        it "updates the requested message" do
-          lambda{
-            put :update, :id => @message.id, :message => @attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+      describe 'with valid params' do
+        it 'updates the requested message' do
+          lambda do
+            put :update, id: @message.id, message: @attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
         end
 
-        it "assigns the requested message as @message" do
-          lambda{
-            put :update, :id => @message.id, :message => @attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+        it 'assigns the requested message as @message' do
+          lambda do
+            put :update, id: @message.id, message: @attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
           assigns(:message).should be_nil
-          #response.should be_missing
+          # response.should be_missing
         end
       end
 
-      describe "with invalid params" do
-        it "assigns the requested message as @message" do
-          lambda{
-            put :update, :id => @message.id, :message => @invalid_attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+      describe 'with invalid params' do
+        it 'assigns the requested message as @message' do
+          lambda do
+            put :update, id: @message.id, message: @invalid_attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
         end
 
         it "re-renders the 'edit' template" do
-          lambda{
-            put :update, :id => @message.id, :message => @invalid_attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+          lambda do
+            put :update, id: @message.id, message: @invalid_attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
           response.should be_success
         end
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      describe "with valid params" do
-        it "updates the requested message" do
-          lambda{
-            put :update, :id => @message.id, :message => @attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+      describe 'with valid params' do
+        it 'updates the requested message' do
+          lambda do
+            put :update, id: @message.id, message: @attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
         end
 
-        it "assigns the requested message as @message" do
-          lambda{
-            put :update, :id => @message.id, :message => @attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+        it 'assigns the requested message as @message' do
+          lambda do
+            put :update, id: @message.id, message: @attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
           assigns(:message).should be_nil
           response.should be_success
         end
       end
 
-      describe "with invalid params" do
-        it "assigns the requested message as @message" do
-          lambda{
-            put :update, :id => @message.id, :message => @invalid_attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+      describe 'with invalid params' do
+        it 'assigns the requested message as @message' do
+          lambda do
+            put :update, id: @message.id, message: @invalid_attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
         end
 
         it "re-renders the 'edit' template" do
-          lambda{
-            put :update, :id => @message.id, :message => @invalid_attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+          lambda do
+            put :update, id: @message.id, message: @invalid_attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
           response.should be_success
         end
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      describe "with valid params" do
-        it "updates the requested message" do
-          lambda{
-            put :update, :id => @message.id, :message => @attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+      describe 'with valid params' do
+        it 'updates the requested message' do
+          lambda do
+            put :update, id: @message.id, message: @attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
         end
 
-        it "assigns the requested message as @message" do
-          lambda{
-            put :update, :id => @message.id, :message => @attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+        it 'assigns the requested message as @message' do
+          lambda do
+            put :update, id: @message.id, message: @attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
           assigns(:message).should be_nil
           response.should be_success
         end
       end
 
-      describe "with invalid params" do
-        it "assigns the requested message as @message" do
-          lambda{
-            put :update, :id => @message.id, :message => @invalid_attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+      describe 'with invalid params' do
+        it 'assigns the requested message as @message' do
+          lambda do
+            put :update, id: @message.id, message: @invalid_attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
         end
 
         it "re-renders the 'edit' template" do
-          lambda{
-            put :update, :id => @message.id, :message => @invalid_attrs
-          }.should raise_error(ActiveRecord::RecordNotFound)
+          lambda do
+            put :update, id: @message.id, message: @invalid_attrs
+          end.should raise_error(ActiveRecord::RecordNotFound)
           response.should be_success
         end
       end
 
-      it "should not update my message" do
-        put :update, :id => 2, :message => { }
+      it 'should not update my message' do
+        put :update, id: 2, message: {}
         response.should be_forbidden
       end
 
       it "should not update other user's message" do
-        lambda{
-          put :update, :id => 1, :message => { }
-        }.should raise_error(ActiveRecord::RecordNotFound)
+        lambda do
+          put :update, id: 1, message: {}
+        end.should raise_error(ActiveRecord::RecordNotFound)
         response.should be_success
       end
     end
 
-    describe "When not logged in" do
-      it "assigns the requested message as @message" do
-        put :update, :id => 2, :message => { }
+    describe 'When not logged in' do
+      it 'assigns the requested message as @message' do
+        put :update, id: 2, message: {}
         response.should redirect_to new_user_session_url
       end
     end
   end
 
-  describe "DELETE destroy" do
-    describe "When logged in as Librarian" do
+  describe 'DELETE destroy' do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "should destroy own message" do
+      it 'should destroy own message' do
         @message = FactoryGirl.create(:message, recipient: @user.username)
-        delete :destroy, :id => @message.id
+        delete :destroy, id: @message.id
         response.should redirect_to messages_url
       end
     end
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "should destroy own message" do
-        delete :destroy, :id => 2
+      it 'should destroy own message' do
+        delete :destroy, id: 2
         response.should redirect_to messages_url
         response.should_not be_forbidden
       end
 
       it "should not destroy other user's message" do
-        lambda {
-          delete :destroy, :id => 1
-        }.should raise_error(ActiveRecord::RecordNotFound)
+        lambda do
+          delete :destroy, id: 1
+        end.should raise_error(ActiveRecord::RecordNotFound)
         response.should be_success
       end
     end
 
-    describe "When not logged in" do
-      it "destroys the requested message" do
-        delete :destroy, :id => 1
+    describe 'When not logged in' do
+      it 'destroys the requested message' do
+        delete :destroy, id: 1
         response.should redirect_to(new_user_session_url)
       end
 
-      it "should be redirected to new_user_session_url" do
-        delete :destroy, :id =>  1
+      it 'should be redirected to new_user_session_url' do
+        delete :destroy, id: 1
         response.should redirect_to(new_user_session_url)
       end
     end
   end
 
-  describe "POST destroy_selected" do
-    describe "When logged in as Librarian" do
+  describe 'POST destroy_selected' do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
-      it "should destroy own message" do
+      it 'should destroy own message' do
         message = FactoryGirl.create(:message, recipient: @user.username)
-        post :destroy_selected, delete: [ message.id ]
+        post :destroy_selected, delete: [message.id]
         response.should_not be_forbidden
         response.should redirect_to(messages_url)
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
-      it "should destroy own message" do
+      it 'should destroy own message' do
         message = FactoryGirl.create(:message, recipient: @user.username)
-        post :destroy_selected, delete: [ message.id ]
+        post :destroy_selected, delete: [message.id]
         response.should_not be_forbidden
         response.should redirect_to(messages_url)
       end