enju_message 0.1.16 → 0.2.0.beta.1

data/spec/controllers/messages_controller_spec.rb

@@ -150,7 +150,7 @@ describe MessagesController do
 
       it "should not assign the requested message as @message" do
         get :new
-        assigns(:message).should_not be_valid
+        assigns(:message).should be_nil
         response.should be_forbidden
       end
 
@@ -173,7 +173,7 @@ describe MessagesController do
     describe "When not logged in" do
       it "should not assign the requested message as @message" do
         get :new
-        assigns(:message).should_not be_valid
+        assigns(:message).should be_nil
         response.should redirect_to(new_user_session_url)
       end
     end
@@ -188,8 +188,8 @@ describe MessagesController do
         lambda{
           get :edit, :id => message.id
         }.should raise_error(ActiveRecord::RecordNotFound)
-        assigns(:message).should eq(message)
-        #response.should be_missing
+        assigns(:message).should be_nil
+        response.should be_success
       end
     end
 
@@ -198,9 +198,11 @@ describe MessagesController do
 
       it "assigns the requested message as @message" do
         message = messages(:user1_to_user2_1)
-        get :edit, :id => message.id
-        assigns(:message).should eq(message)
-        response.should be_forbidden
+        lambda{
+          get :edit, :id => message.id
+        }.should raise_error(ActiveRecord::RecordNotFound)
+        assigns(:message).should be_nil
+        response.should be_success
       end
     end
 
@@ -209,9 +211,11 @@ describe MessagesController do
 
       it "assigns the requested message as @message" do
         message = messages(:user1_to_user2_1)
-        get :edit, :id => message.id
-        assigns(:message).should eq(message)
-        response.should be_forbidden
+        lambda{
+          get :edit, :id => message.id
+        }.should raise_error(ActiveRecord::RecordNotFound)
+        assigns(:message).should be_nil
+        response.should be_success
       end
     end
 
@@ -219,7 +223,7 @@ describe MessagesController do
       it "assigns the requested message as @message" do
         message = FactoryGirl.create(:message)
         get :edit, :id => message.id
-        assigns(:message).should eq(message)
+        assigns(:message).should be_nil
         response.should redirect_to new_user_session_url
       end
     end
@@ -307,7 +311,7 @@ describe MessagesController do
       describe "with valid params" do
         it "assigns a newly created message as @message" do
           post :create, :message => @attrs
-          assigns(:message).should be_valid
+          assigns(:message).should be_nil
         end
 
         it "should redirect to new_user_session_url" do
@@ -319,7 +323,7 @@ describe MessagesController do
       describe "with invalid params" do
         it "assigns a newly created but unsaved message as @message" do
           post :create, :message => @invalid_attrs
-          assigns(:message).should_not be_valid
+          assigns(:message).should be_nil
         end
 
         it "should redirect to new_user_session_url" do
@@ -351,7 +355,7 @@ describe MessagesController do
           lambda{
             put :update, :id => @message.id, :message => @attrs
           }.should raise_error(ActiveRecord::RecordNotFound)
-          assigns(:message).should eq(@message)
+          assigns(:message).should be_nil
           #response.should be_missing
         end
       end
@@ -367,7 +371,7 @@ describe MessagesController do
           lambda{
             put :update, :id => @message.id, :message => @invalid_attrs
           }.should raise_error(ActiveRecord::RecordNotFound)
-          #response.should be_missing
+          response.should be_success
         end
       end
     end
@@ -377,24 +381,32 @@ describe MessagesController do
 
       describe "with valid params" do
         it "updates the requested message" do
-          put :update, :id => @message.id, :message => @attrs
+          lambda{
+            put :update, :id => @message.id, :message => @attrs
+          }.should raise_error(ActiveRecord::RecordNotFound)
         end
 
         it "assigns the requested message as @message" do
-          put :update, :id => @message.id, :message => @attrs
-          assigns(:message).should eq(@message)
-          response.should be_forbidden
+          lambda{
+            put :update, :id => @message.id, :message => @attrs
+          }.should raise_error(ActiveRecord::RecordNotFound)
+          assigns(:message).should be_nil
+          response.should be_success
         end
       end
 
       describe "with invalid params" do
         it "assigns the requested message as @message" do
-          put :update, :id => @message.id, :message => @invalid_attrs
+          lambda{
+            put :update, :id => @message.id, :message => @invalid_attrs
+          }.should raise_error(ActiveRecord::RecordNotFound)
         end
 
         it "re-renders the 'edit' template" do
-          put :update, :id => @message.id, :message => @invalid_attrs
-          response.should be_forbidden
+          lambda{
+            put :update, :id => @message.id, :message => @invalid_attrs
+          }.should raise_error(ActiveRecord::RecordNotFound)
+          response.should be_success
         end
       end
     end
@@ -404,24 +416,32 @@ describe MessagesController do
 
       describe "with valid params" do
         it "updates the requested message" do
-          put :update, :id => @message.id, :message => @attrs
+          lambda{
+            put :update, :id => @message.id, :message => @attrs
+          }.should raise_error(ActiveRecord::RecordNotFound)
         end
 
         it "assigns the requested message as @message" do
-          put :update, :id => @message.id, :message => @attrs
-          assigns(:message).should eq(@message)
-          response.should be_forbidden
+          lambda{
+            put :update, :id => @message.id, :message => @attrs
+          }.should raise_error(ActiveRecord::RecordNotFound)
+          assigns(:message).should be_nil
+          response.should be_success
         end
       end
 
       describe "with invalid params" do
         it "assigns the requested message as @message" do
-          put :update, :id => @message.id, :message => @invalid_attrs
+          lambda{
+            put :update, :id => @message.id, :message => @invalid_attrs
+          }.should raise_error(ActiveRecord::RecordNotFound)
         end
 
         it "re-renders the 'edit' template" do
-          put :update, :id => @message.id, :message => @invalid_attrs
-          response.should be_forbidden
+          lambda{
+            put :update, :id => @message.id, :message => @invalid_attrs
+          }.should raise_error(ActiveRecord::RecordNotFound)
+          response.should be_success
         end
       end
 
@@ -431,8 +451,10 @@ describe MessagesController do
       end
 
       it "should not update other user's message" do
-        put :update, :id => 1, :message => { }
-        response.should be_forbidden
+        lambda{
+          put :update, :id => 1, :message => { }
+        }.should raise_error(ActiveRecord::RecordNotFound)
+        response.should be_success
       end
     end
 
@@ -464,8 +486,10 @@ describe MessagesController do
       end
 
       it "should not destroy other user's message" do
-        delete :destroy, :id => 1
-        response.should be_forbidden
+        lambda {
+          delete :destroy, :id => 1
+        }.should raise_error(ActiveRecord::RecordNotFound)
+        response.should be_success
       end
     end
 

data/spec/dummy/app/controllers/application_controller.rb

@@ -1,6 +1,10 @@
 class ApplicationController < ActionController::Base
   protect_from_forgery
 
-  enju_leaf
-  enju_library
+  include EnjuLeaf::Controller
+  include EnjuLibrary::Controller
+  before_action :set_paper_trail_whodunnit
+  after_action :verify_authorized
+
+  include Pundit
 end

data/spec/dummy/app/models/user.rb

@@ -6,6 +6,6 @@ class User < ActiveRecord::Base
          :lockable, :lock_strategy => :none, :unlock_strategy => :none
 
   # Setup accessible (or protected) attributes for your model
-  enju_leaf_user_model
-  enju_message_user_model
+  include EnjuLeaf::EnjuUser
+  include EnjuMessage::EnjuUser
 end

data/spec/dummy/config/application.rb

@@ -2,8 +2,10 @@ require File.expand_path('../boot', __FILE__)
 
 require 'rails/all'
 
-Bundler.require
-require "enju_message"
+Bundler.require(*Rails.groups)
+require 'enju_message'
+require 'enju_leaf'
+require 'resque_mailer'
 
 module Dummy
   class Application < Rails::Application
@@ -11,16 +13,6 @@ module Dummy
     # Application configuration should go into files in config/initializers
     # -- all .rb files in that directory are automatically loaded.
 
-    # Custom directories with classes and modules you want to be autoloadable.
-    # config.autoload_paths += %W(#{config.root}/extras)
-
-    # Only load the plugins named here, in the order given (default is alphabetical).
-    # :all can be used as a placeholder for all plugins not explicitly named.
-    # config.plugins = [ :exception_notification, :ssl_requirement, :all ]
-
-    # Activate observers that should always be running.
-    # config.active_record.observers = :cacher, :garbage_collector, :forum_observer
-
     # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
     # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
     # config.time_zone = 'Central Time (US & Canada)'
@@ -29,18 +21,8 @@ module Dummy
     # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
     # config.i18n.default_locale = :de
 
-    # Configure the default encoding used in templates for Ruby 1.9.
-    config.encoding = "utf-8"
-
-    # Configure sensitive parameters which will be filtered from the log file.
-    config.filter_parameters += [:password]
-
-    # Enable the asset pipeline
-    config.assets.enabled = true
-
-    # Version of your assets, change this if you want to expire all your assets
-    config.assets.version = '1.0'
+    # Do not swallow errors in after_commit/after_rollback callbacks.
+    config.active_record.raise_in_transactional_callbacks = true
   end
 end
 
-require 'enju_leaf'

data/spec/dummy/config/environments/development.rb

@@ -1,30 +1,41 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+Rails.application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
 
   # In the development environment your application's code is reloaded on
-  # every request.  This slows down response time but is perfect for development
+  # every request. This slows down response time but is perfect for development
   # since you don't have to restart the web server when you make code changes.
   config.cache_classes = false
 
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
+  # Do not eager load code on boot.
+  config.eager_load = false
 
-  # Show full error reports and disable caching
+  # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
 
-  # Don't care if the mailer can't send
+  # Don't care if the mailer can't send.
   config.action_mailer.raise_delivery_errors = false
 
-  # Print deprecation notices to the Rails logger
+  # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 
-  # Only use best-standards-support built into browsers
-  config.action_dispatch.best_standards_support = :builtin
+  # Raise an error on page load if there are pending migrations.
+  config.active_record.migration_error = :page_load
 
-  # Do not compress assets
-  config.assets.compress = false
-
-  # Expands the lines which load the assets
+  # Debug mode disables concatenation and preprocessing of assets.
+  # This option may cause significant delays in view rendering with a large
+  # number of complex assets.
   config.assets.debug = true
+
+  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
+  # yet still be able to expire them through the digest params.
+  config.assets.digest = true
+
+  # Adds additional error checking when serving assets at runtime.
+  # Checks for improperly declared sprockets dependencies.
+  # Raises helpful error messages.
+  config.assets.raise_runtime_errors = true
+
+  # Raises error for missing translations
+  # config.action_view.raise_on_missing_translations = true
 end

data/spec/dummy/config/environments/production.rb

@@ -1,60 +1,79 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+Rails.application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
 
-  # Code is not reloaded between requests
+  # Code is not reloaded between requests.
   config.cache_classes = true
 
-  # Full error reports are disabled and caching is turned on
+  # Eager load code on boot. This eager loads most of Rails and
+  # your application in memory, allowing both threaded web servers
+  # and those relying on copy on write to perform better.
+  # Rake tasks automatically ignore this option for performance.
+  config.eager_load = true
+
+  # Full error reports are disabled and caching is turned on.
   config.consider_all_requests_local       = false
   config.action_controller.perform_caching = true
 
-  # Disable Rails's static asset server (Apache or nginx will already do this)
-  config.serve_static_assets = false
+  # Enable Rack::Cache to put a simple HTTP cache in front of your application
+  # Add `rack-cache` to your Gemfile before enabling this.
+  # For large-scale production use, consider using a caching reverse proxy like
+  # NGINX, varnish or squid.
+  # config.action_dispatch.rack_cache = true
+
+  # Disable serving static files from the `/public` folder by default since
+  # Apache or NGINX already handles this.
+  config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?
 
-  # Compress JavaScripts and CSS
-  config.assets.compress = true
+  # Compress JavaScripts and CSS.
+  config.assets.js_compressor = :uglifier
+  # config.assets.css_compressor = :sass
 
-  # Don't fallback to assets pipeline if a precompiled asset is missed
+  # Do not fallback to assets pipeline if a precompiled asset is missed.
   config.assets.compile = false
 
-  # Generate digests for assets URLs
+  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
+  # yet still be able to expire them through the digest params.
   config.assets.digest = true
 
-  # Defaults to Rails.root.join("public/assets")
-  # config.assets.manifest = YOUR_PATH
+  # `config.assets.precompile` and `config.assets.version` have moved to config/initializers/assets.rb
 
-  # Specifies the header that your server uses for sending files
-  # config.action_dispatch.x_sendfile_header = "X-Sendfile" # for apache
-  # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for nginx
+  # Specifies the header that your server uses for sending files.
+  # config.action_dispatch.x_sendfile_header = 'X-Sendfile' # for Apache
+  # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for NGINX
 
   # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
   # config.force_ssl = true
 
-  # See everything in the log (default is :info)
-  # config.log_level = :debug
+  # Use the lowest log level to ensure availability of diagnostic information
+  # when problems arise.
+  config.log_level = :debug
 
-  # Use a different logger for distributed setups
-  # config.logger = SyslogLogger.new
+  # Prepend all log lines with the following tags.
+  # config.log_tags = [ :subdomain, :uuid ]
 
-  # Use a different cache store in production
-  # config.cache_store = :mem_cache_store
+  # Use a different logger for distributed setups.
+  # config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new)
 
-  # Enable serving of images, stylesheets, and JavaScripts from an asset server
-  # config.action_controller.asset_host = "http://assets.example.com"
+  # Use a different cache store in production.
+  # config.cache_store = :mem_cache_store
 
-  # Precompile additional assets (application.js, application.css, and all non-JS/CSS are already added)
-  # config.assets.precompile += %w( search.js )
+  # Enable serving of images, stylesheets, and JavaScripts from an asset server.
+  # config.action_controller.asset_host = 'http://assets.example.com'
 
-  # Disable delivery errors, bad email addresses will be ignored
+  # Ignore bad email addresses and do not raise email delivery errors.
+  # Set this to true and configure the email server for immediate delivery to raise delivery errors.
   # config.action_mailer.raise_delivery_errors = false
 
-  # Enable threaded mode
-  # config.threadsafe!
-
   # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
-  # the I18n.default_locale when a translation can not be found)
+  # the I18n.default_locale when a translation cannot be found).
   config.i18n.fallbacks = true
 
-  # Send deprecation notices to registered listeners
+  # Send deprecation notices to registered listeners.
   config.active_support.deprecation = :notify
+
+  # Use default logging formatter so that PID and timestamp are not suppressed.
+  config.log_formatter = ::Logger::Formatter.new
+
+  # Do not dump schema after migrations.
+  config.active_record.dump_schema_after_migration = false
 end

data/spec/dummy/config/environments/test.rb

@@ -1,41 +1,44 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+Rails.application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
 
   # The test environment is used exclusively to run your application's
-  # test suite.  You never need to work with it otherwise.  Remember that
+  # test suite. You never need to work with it otherwise. Remember that
   # your test database is "scratch space" for the test suite and is wiped
-  # and recreated between test runs.  Don't rely on the data there!
+  # and recreated between test runs. Don't rely on the data there!
   config.cache_classes = true
 
-  # Configure static asset server for tests with Cache-Control for performance
-  config.serve_static_assets = true
-  config.static_cache_control = "public, max-age=3600"
+  # Do not eager load code on boot. This avoids loading your whole application
+  # just for the purpose of running a single test. If you are using a tool that
+  # preloads Rails for running tests, you may have to set it to true.
+  config.eager_load = false
 
-  # Log error messages when you accidentally call methods on nil
-  config.whiny_nils = true
+  # Configure static file server for tests with Cache-Control for performance.
+  config.serve_static_files   = true
+  config.static_cache_control = 'public, max-age=3600'
 
-  # Show full error reports and disable caching
+  # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
 
-  # Raise exceptions instead of rendering exception templates
+  # Raise exceptions instead of rendering exception templates.
   config.action_dispatch.show_exceptions = false
 
-  # Disable request forgery protection in test environment
-  config.action_controller.allow_forgery_protection    = false
+  # Disable request forgery protection in test environment.
+  config.action_controller.allow_forgery_protection = false
 
   # Tell Action Mailer not to deliver emails to the real world.
   # The :test delivery method accumulates sent emails in the
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
-  # Use SQL instead of Active Record's schema dumper when creating the test database.
-  # This is necessary if your schema can't be completely dumped by the schema dumper,
-  # like if you have constraints or database-specific column types
-  # config.active_record.schema_format = :sql
+  # Randomize the order test cases are executed.
+  config.active_support.test_order = :random
 
-  # Print deprecation notices to the stderr
+  # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
 
+  # Raises error for missing translations
+  # config.action_view.raise_on_missing_translations = true
+
   config.action_mailer.default_url_options = {:host => 'localhost:3000'}
 end

data/spec/dummy/db/migrate/20140821151023_create_colors.rb

@@ -0,0 +1,14 @@
+class CreateColors < ActiveRecord::Migration
+  def change
+    create_table :colors do |t|
+      t.integer :library_group_id
+      t.string :property
+      t.string :code
+      t.integer :position
+
+      t.timestamps
+    end
+
+    add_index :colors, :library_group_id
+  end
+end

data/spec/dummy/db/migrate/20150924115059_create_withdraws.rb

@@ -0,0 +1,13 @@
+class CreateWithdraws < ActiveRecord::Migration
+  def change
+    create_table :withdraws do |t|
+      t.integer :basket_id
+      t.integer :item_id
+      t.integer :librarian_id
+
+      t.timestamps null: false
+    end
+    add_index :withdraws, :basket_id
+    add_index :withdraws, :item_id
+  end
+end

data/spec/dummy/db/migrate/20151213070943_add_translation_table_to_library_group.rb

@@ -0,0 +1,13 @@
+class AddTranslationTableToLibraryGroup < ActiveRecord::Migration
+  def up
+    LibraryGroup.create_translation_table!({
+      login_banner: :text
+    }, {
+      migrate_data: true
+    })
+  end
+
+  def down
+    LibraryGroup.drop_translation_table! migrate_data: true
+  end
+end

data/spec/dummy/db/migrate/20151213072705_add_footer_banner_to_library_group.rb

@@ -0,0 +1,9 @@
+class AddFooterBannerToLibraryGroup < ActiveRecord::Migration
+  def up
+    LibraryGroup.add_translation_fields! footer_banner: :text
+  end
+
+  def down
+    remove_column :library_group_translations, :footer_banner
+  end
+end

data/spec/dummy/db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20150221063719) do
+ActiveRecord::Schema.define(version: 20160703185015) do
 
   create_table "accepts", force: :cascade do |t|
     t.integer  "basket_id"
@@ -208,6 +208,17 @@ ActiveRecord::Schema.define(version: 20150221063719) do
     t.datetime "updated_at"
   end
 
+  create_table "colors", force: :cascade do |t|
+    t.integer  "library_group_id"
+    t.string   "property"
+    t.string   "code"
+    t.integer  "position"
+    t.datetime "created_at"
+    t.datetime "updated_at"
+  end
+
+  add_index "colors", ["library_group_id"], name: "index_colors_on_library_group_id"
+
   create_table "content_types", force: :cascade do |t|
     t.string   "name",         null: false
     t.text     "display_name"
@@ -423,6 +434,18 @@ ActiveRecord::Schema.define(version: 20150221063719) do
   add_index "libraries", ["library_group_id"], name: "index_libraries_on_library_group_id"
   add_index "libraries", ["name"], name: "index_libraries_on_name", unique: true
 
+  create_table "library_group_translations", force: :cascade do |t|
+    t.integer  "library_group_id", null: false
+    t.string   "locale",           null: false
+    t.datetime "created_at",       null: false
+    t.datetime "updated_at",       null: false
+    t.text     "login_banner"
+    t.text     "footer_banner"
+  end
+
+  add_index "library_group_translations", ["library_group_id"], name: "index_library_group_translations_on_library_group_id"
+  add_index "library_group_translations", ["locale"], name: "index_library_group_translations_on_locale"
+
   create_table "library_groups", force: :cascade do |t|
     t.string   "name",                                              null: false
     t.text     "display_name"
@@ -584,11 +607,12 @@ ActiveRecord::Schema.define(version: 20150221063719) do
 
   create_table "message_transitions", force: :cascade do |t|
     t.string   "to_state"
-    t.text     "metadata",   default: "{}"
+    t.text     "metadata",    default: "{}"
     t.integer  "sort_key"
     t.integer  "message_id"
     t.datetime "created_at"
     t.datetime "updated_at"
+    t.boolean  "most_recent"
   end
 
   add_index "message_transitions", ["message_id"], name: "index_message_transitions_on_message_id"
@@ -1023,4 +1047,15 @@ ActiveRecord::Schema.define(version: 20150221063719) do
 
   add_index "versions", ["item_type", "item_id"], name: "index_versions_on_item_type_and_item_id"
 
+  create_table "withdraws", force: :cascade do |t|
+    t.integer  "basket_id"
+    t.integer  "item_id"
+    t.integer  "librarian_id"
+    t.datetime "created_at",   null: false
+    t.datetime "updated_at",   null: false
+  end
+
+  add_index "withdraws", ["basket_id"], name: "index_withdraws_on_basket_id"
+  add_index "withdraws", ["item_id"], name: "index_withdraws_on_item_id"
+
 end

data/spec/support/devise.rb

@@ -1,4 +1,4 @@
 RSpec.configure do |config|
-  config.include Devise::TestHelpers, :type => :controller
-  config.include Devise::TestHelpers, :type => :view
+  config.include Devise::Test::ControllerHelpers, type: :controller
+  config.include Devise::Test::ControllerHelpers, type: :view
 end