enju_library 0.1.2 → 0.2.0.beta.1

data/spec/controllers/subscriptions_controller_spec.rb

@@ -36,14 +36,14 @@ describe SubscriptionsController do
 
       it "assigns all subscriptions as @subscriptions" do
         get :index
-        assigns(:subscriptions).should be_empty
+        assigns(:subscriptions).should be_nil
       end
     end
 
     describe "When not logged in" do
       it "assigns all subscriptions as @subscriptions" do
         get :index
-        assigns(:subscriptions).should be_empty
+        assigns(:subscriptions).should be_nil
       end
     end
   end
@@ -112,7 +112,7 @@ describe SubscriptionsController do
 
       it "should not assign the requested subscription as @subscription" do
         get :new
-        assigns(:subscription).should_not be_valid
+        assigns(:subscription).should be_nil
         response.should be_forbidden
       end
     end
@@ -120,7 +120,7 @@ describe SubscriptionsController do
     describe "When not logged in" do
       it "should not assign the requested subscription as @subscription" do
         get :new
-        assigns(:subscription).should_not be_valid
+        assigns(:subscription).should be_nil
         response.should redirect_to(new_user_session_url)
       end
     end
@@ -234,7 +234,7 @@ describe SubscriptionsController do
       describe "with valid params" do
         it "assigns a newly created subscription as @subscription" do
           post :create, :subscription => @attrs
-          assigns(:subscription).should be_valid
+          assigns(:subscription).should be_nil
         end
 
         it "should be forbidden" do
@@ -246,7 +246,7 @@ describe SubscriptionsController do
       describe "with invalid params" do
         it "assigns a newly created but unsaved subscription as @subscription" do
           post :create, :subscription => @invalid_attrs
-          assigns(:subscription).should_not be_valid
+          assigns(:subscription).should be_nil
         end
 
         it "should be forbidden" do
@@ -260,7 +260,7 @@ describe SubscriptionsController do
       describe "with valid params" do
         it "assigns a newly created subscription as @subscription" do
           post :create, :subscription => @attrs
-          assigns(:subscription).should be_valid
+          assigns(:subscription).should be_nil
         end
 
         it "should be forbidden" do
@@ -272,7 +272,7 @@ describe SubscriptionsController do
       describe "with invalid params" do
         it "assigns a newly created but unsaved subscription as @subscription" do
           post :create, :subscription => @invalid_attrs
-          assigns(:subscription).should_not be_valid
+          assigns(:subscription).should be_nil
         end
 
         it "should be forbidden" do

data/spec/controllers/withdraws_controller_spec.rb

@@ -46,7 +46,7 @@ RSpec.describe WithdrawsController, type: :controller do
       login_fixture_admin
       it "assigns all withdraws as @withdraws" do
         withdraw = Withdraw.create! valid_attributes
-        get :index, :basket_id => 1
+        get :index, basket_id: 1
         expect(assigns(:withdraws)).to eq baskets(:basket_00001).withdraws.order('withdraws.created_at DESC').page(1)
       end
     end
@@ -95,16 +95,24 @@ RSpec.describe WithdrawsController, type: :controller do
           post :create, valid_create_attributes
           expect(response).to redirect_to(withdraws_path(basket_id: valid_create_attributes[:basket_id]))
         end
+
+        it "should not withdraw a checked-out item" do
+          post :create, {basket_id: valid_create_attributes[:basket_id],
+            withdraw: { item_identifier: '00001' }
+          }
+          expect(assigns(:withdraw)).to be_a(Withdraw)
+          expect(response).to be_success
+        end
       end
 
       context "with invalid params" do
         it "assigns a newly created but unsaved withdraw as @withdraw" do
-          post :create, {:basket_id => valid_create_attributes[:basket_id], :withdraw => {item_id: nil}}
+          post :create, {basket_id: valid_create_attributes[:basket_id], withdraw: {item_id: nil}}
           expect(assigns(:withdraw)).to be_a_new(Withdraw)
         end
 
         it "re-renders the 'new' template" do
-          post :create, {:basket_id => valid_create_attributes[:basket_id], :withdraw => {item_id: nil}}
+          post :create, {basket_id: valid_create_attributes[:basket_id], withdraw: {item_id: nil}}
           expect(response).to render_template("index")
         end
       end

data/spec/dummy/app/controllers/application_controller.rb

@@ -1,6 +1,9 @@
 class ApplicationController < ActionController::Base
   protect_from_forgery
-  enju_leaf
-  enju_biblio
-  enju_library
+  include EnjuLeaf::Controller
+  include EnjuBiblio::Controller
+  include EnjuLibrary::Controller
+  after_action :verify_authorized
+
+  include Pundit
 end

data/spec/dummy/app/models/user.rb

@@ -3,6 +3,6 @@ class User < ActiveRecord::Base
     :recoverable, :rememberable, :trackable, #, :validatable
     :lockable, :lock_strategy => :none, :unlock_strategy => :none
 
-  enju_leaf_user_model
-  enju_circulation_user_model
+  include EnjuLeaf::EnjuUser
+  include EnjuCirculation::EnjuUser
 end

data/spec/dummy/config/application.rb

@@ -2,8 +2,12 @@ require File.expand_path('../boot', __FILE__)
 
 require 'rails/all'
 
-Bundler.require
-require "enju_library"
+Bundler.require(*Rails.groups)
+require 'enju_leaf'
+require 'enju_circulation'
+require 'enju_event'
+require 'enju_inter_library_loan'
+require 'enju_library'
 
 module Dummy
   class Application < Rails::Application
@@ -11,16 +15,6 @@ module Dummy
     # Application configuration should go into files in config/initializers
     # -- all .rb files in that directory are automatically loaded.
 
-    # Custom directories with classes and modules you want to be autoloadable.
-    # config.autoload_paths += %W(#{config.root}/extras)
-
-    # Only load the plugins named here, in the order given (default is alphabetical).
-    # :all can be used as a placeholder for all plugins not explicitly named.
-    # config.plugins = [ :exception_notification, :ssl_requirement, :all ]
-
-    # Activate observers that should always be running.
-    # config.active_record.observers = :cacher, :garbage_collector, :forum_observer
-
     # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
     # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
     # config.time_zone = 'Central Time (US & Canada)'
@@ -29,32 +23,8 @@ module Dummy
     # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
     # config.i18n.default_locale = :de
 
-    # Configure the default encoding used in templates for Ruby 1.9.
-    config.encoding = "utf-8"
-
-    # Configure sensitive parameters which will be filtered from the log file.
-    config.filter_parameters += [:password]
-
-    # Use SQL instead of Active Record's schema dumper when creating the database.
-    # This is necessary if your schema can't be completely dumped by the schema dumper,
-    # like if you have constraints or database-specific column types
-    # config.active_record.schema_format = :sql
-
-    # Enforce whitelist mode for mass assignment.
-    # This will create an empty whitelist of attributes available for mass-assignment for all models
-    # in your app. As such, your models will need to explicitly whitelist or blacklist accessible
-    # parameters by using an attr_accessible or attr_protected declaration.
-    #config.active_record.whitelist_attributes = true
-
-    # Enable the asset pipeline
-    config.assets.enabled = true
-
-    # Version of your assets, change this if you want to expire all your assets
-    config.assets.version = '1.0'
+    # Do not swallow errors in after_commit/after_rollback callbacks.
+    config.active_record.raise_in_transactional_callbacks = true
   end
 end
 
-require 'enju_leaf'
-require 'enju_circulation'
-require "enju_event"
-require "enju_inter_library_loan"

data/spec/dummy/config/environments/development.rb

@@ -1,37 +1,41 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+Rails.application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
 
   # In the development environment your application's code is reloaded on
   # every request. This slows down response time but is perfect for development
   # since you don't have to restart the web server when you make code changes.
   config.cache_classes = false
 
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
+  # Do not eager load code on boot.
+  config.eager_load = false
 
-  # Show full error reports and disable caching
+  # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
 
-  # Don't care if the mailer can't send
+  # Don't care if the mailer can't send.
   config.action_mailer.raise_delivery_errors = false
 
-  # Print deprecation notices to the Rails logger
+  # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 
-  # Only use best-standards-support built into browsers
-  config.action_dispatch.best_standards_support = :builtin
+  # Raise an error on page load if there are pending migrations.
+  config.active_record.migration_error = :page_load
 
-  # Raise exception on mass assignment protection for Active Record models
-  config.active_record.mass_assignment_sanitizer = :strict
+  # Debug mode disables concatenation and preprocessing of assets.
+  # This option may cause significant delays in view rendering with a large
+  # number of complex assets.
+  config.assets.debug = true
 
-  # Log the query plan for queries taking more than this (works
-  # with SQLite, MySQL, and PostgreSQL)
-  config.active_record.auto_explain_threshold_in_seconds = 0.5
+  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
+  # yet still be able to expire them through the digest params.
+  config.assets.digest = true
 
-  # Do not compress assets
-  config.assets.compress = false
+  # Adds additional error checking when serving assets at runtime.
+  # Checks for improperly declared sprockets dependencies.
+  # Raises helpful error messages.
+  config.assets.raise_runtime_errors = true
 
-  # Expands the lines which load the assets
-  config.assets.debug = true
+  # Raises error for missing translations
+  # config.action_view.raise_on_missing_translations = true
 end

data/spec/dummy/config/environments/production.rb

@@ -1,67 +1,79 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+Rails.application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
 
-  # Code is not reloaded between requests
+  # Code is not reloaded between requests.
   config.cache_classes = true
 
-  # Full error reports are disabled and caching is turned on
+  # Eager load code on boot. This eager loads most of Rails and
+  # your application in memory, allowing both threaded web servers
+  # and those relying on copy on write to perform better.
+  # Rake tasks automatically ignore this option for performance.
+  config.eager_load = true
+
+  # Full error reports are disabled and caching is turned on.
   config.consider_all_requests_local       = false
   config.action_controller.perform_caching = true
 
-  # Disable Rails's static asset server (Apache or nginx will already do this)
-  config.serve_static_assets = false
+  # Enable Rack::Cache to put a simple HTTP cache in front of your application
+  # Add `rack-cache` to your Gemfile before enabling this.
+  # For large-scale production use, consider using a caching reverse proxy like
+  # NGINX, varnish or squid.
+  # config.action_dispatch.rack_cache = true
+
+  # Disable serving static files from the `/public` folder by default since
+  # Apache or NGINX already handles this.
+  config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?
 
-  # Compress JavaScripts and CSS
-  config.assets.compress = true
+  # Compress JavaScripts and CSS.
+  config.assets.js_compressor = :uglifier
+  # config.assets.css_compressor = :sass
 
-  # Don't fallback to assets pipeline if a precompiled asset is missed
+  # Do not fallback to assets pipeline if a precompiled asset is missed.
   config.assets.compile = false
 
-  # Generate digests for assets URLs
+  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
+  # yet still be able to expire them through the digest params.
   config.assets.digest = true
 
-  # Defaults to Rails.root.join("public/assets")
-  # config.assets.manifest = YOUR_PATH
+  # `config.assets.precompile` and `config.assets.version` have moved to config/initializers/assets.rb
 
-  # Specifies the header that your server uses for sending files
-  # config.action_dispatch.x_sendfile_header = "X-Sendfile" # for apache
-  # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for nginx
+  # Specifies the header that your server uses for sending files.
+  # config.action_dispatch.x_sendfile_header = 'X-Sendfile' # for Apache
+  # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for NGINX
 
   # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
   # config.force_ssl = true
 
-  # See everything in the log (default is :info)
-  # config.log_level = :debug
+  # Use the lowest log level to ensure availability of diagnostic information
+  # when problems arise.
+  config.log_level = :debug
 
-  # Prepend all log lines with the following tags
+  # Prepend all log lines with the following tags.
   # config.log_tags = [ :subdomain, :uuid ]
 
-  # Use a different logger for distributed setups
+  # Use a different logger for distributed setups.
   # config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new)
 
-  # Use a different cache store in production
+  # Use a different cache store in production.
   # config.cache_store = :mem_cache_store
 
-  # Enable serving of images, stylesheets, and JavaScripts from an asset server
-  # config.action_controller.asset_host = "http://assets.example.com"
-
-  # Precompile additional assets (application.js, application.css, and all non-JS/CSS are already added)
-  # config.assets.precompile += %w( search.js )
+  # Enable serving of images, stylesheets, and JavaScripts from an asset server.
+  # config.action_controller.asset_host = 'http://assets.example.com'
 
-  # Disable delivery errors, bad email addresses will be ignored
+  # Ignore bad email addresses and do not raise email delivery errors.
+  # Set this to true and configure the email server for immediate delivery to raise delivery errors.
   # config.action_mailer.raise_delivery_errors = false
 
-  # Enable threaded mode
-  # config.threadsafe!
-
   # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
-  # the I18n.default_locale when a translation can not be found)
+  # the I18n.default_locale when a translation cannot be found).
   config.i18n.fallbacks = true
 
-  # Send deprecation notices to registered listeners
+  # Send deprecation notices to registered listeners.
   config.active_support.deprecation = :notify
 
-  # Log the query plan for queries taking more than this (works
-  # with SQLite, MySQL, and PostgreSQL)
-  # config.active_record.auto_explain_threshold_in_seconds = 0.5
+  # Use default logging formatter so that PID and timestamp are not suppressed.
+  config.log_formatter = ::Logger::Formatter.new
+
+  # Do not dump schema after migrations.
+  config.active_record.dump_schema_after_migration = false
 end

data/spec/dummy/config/environments/test.rb

@@ -1,5 +1,5 @@
-Dummy::Application.configure do
-  # Settings specified here will take precedence over those in config/application.rb
+Rails.application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
 
   # The test environment is used exclusively to run your application's
   # test suite. You never need to work with it otherwise. Remember that
@@ -7,31 +7,38 @@ Dummy::Application.configure do
   # and recreated between test runs. Don't rely on the data there!
   config.cache_classes = true
 
-  # Configure static asset server for tests with Cache-Control for performance
-  config.serve_static_assets = true
-  config.static_cache_control = "public, max-age=3600"
+  # Do not eager load code on boot. This avoids loading your whole application
+  # just for the purpose of running a single test. If you are using a tool that
+  # preloads Rails for running tests, you may have to set it to true.
+  config.eager_load = false
 
-  # Log error messages when you accidentally call methods on nil
-  config.whiny_nils = true
+  # Configure static file server for tests with Cache-Control for performance.
+  config.serve_static_files   = true
+  config.static_cache_control = 'public, max-age=3600'
 
-  # Show full error reports and disable caching
+  # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false
 
-  # Raise exceptions instead of rendering exception templates
+  # Raise exceptions instead of rendering exception templates.
   config.action_dispatch.show_exceptions = false
 
-  # Disable request forgery protection in test environment
-  config.action_controller.allow_forgery_protection    = false
+  # Disable request forgery protection in test environment.
+  config.action_controller.allow_forgery_protection = false
 
   # Tell Action Mailer not to deliver emails to the real world.
   # The :test delivery method accumulates sent emails in the
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
-  # Raise exception on mass assignment protection for Active Record models
-  #config.active_record.mass_assignment_sanitizer = :strict
+  # Randomize the order test cases are executed.
+  config.active_support.test_order = :random
 
-  # Print deprecation notices to the stderr
+  # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
+
+  # Raises error for missing translations
+  # config.action_view.raise_on_missing_translations = true
+
+  config.action_mailer.default_url_options = {:host => 'localhost:3000'}
 end

data/spec/dummy/config/initializers/enju_leaf.rb

@@ -0,0 +1,6 @@
+Accept.include(EnjuCirculation::EnjuAccept)
+Basket.include(EnjuCirculation::EnjuBasket)
+Manifestation.include(EnjuCirculation::EnjuManifestation)
+Item.include(EnjuCirculation::EnjuItem)
+Item.include(EnjuLibrary::EnjuItem)
+Withdraw.include(EnjuCirculation::EnjuWithdraw)

data/spec/dummy/db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20150924115059) do
+ActiveRecord::Schema.define(version: 20151213072705) do
 
   create_table "accepts", force: :cascade do |t|
     t.integer  "basket_id"
@@ -659,6 +659,18 @@ ActiveRecord::Schema.define(version: 20150924115059) do
   add_index "libraries", ["library_group_id"], name: "index_libraries_on_library_group_id"
   add_index "libraries", ["name"], name: "index_libraries_on_name", unique: true
 
+  create_table "library_group_translations", force: :cascade do |t|
+    t.integer  "library_group_id", null: false
+    t.string   "locale",           null: false
+    t.datetime "created_at",       null: false
+    t.datetime "updated_at",       null: false
+    t.text     "login_banner"
+    t.text     "footer_banner"
+  end
+
+  add_index "library_group_translations", ["library_group_id"], name: "index_library_group_translations_on_library_group_id"
+  add_index "library_group_translations", ["locale"], name: "index_library_group_translations_on_locale"
+
   create_table "library_groups", force: :cascade do |t|
     t.string   "name",                                              null: false
     t.text     "display_name"

data/spec/models/withdraw_spec.rb

@@ -1,6 +1,8 @@
 require 'rails_helper'
 
 RSpec.describe Withdraw, type: :model do
+  fixtures :all
+
   it "should change circulation_status" do
     withdraw = FactoryGirl.create(:withdraw)
     withdraw.item.circulation_status.name.should eq 'Removed'

data/spec/spec_helper.rb

@@ -37,7 +37,7 @@ RSpec.configure do |config|
     # Prevents you from mocking or stubbing a method that does not exist on
     # a real object. This is generally recommended, and will default to
     # `true` in RSpec 4.
-    mocks.verify_partial_doubles = true
+    mocks.verify_partial_doubles = false
   end
 
 # The settings below are suggested to provide a good initial experience

data/spec/views/accepts/index.html.erb_spec.rb

@@ -20,6 +20,7 @@ describe "accepts/index" do
   end
 
   it "renders a list of accepts" do
+    allow(view).to receive(:policy).and_return double(create?: true, destroy?: true)
     render
     # Run the generator again with the --webrat flag if you want to use webrat matchers
     assert_select "tr>td"

data/spec/views/budget_types/index.html.erb_spec.rb

@@ -19,6 +19,7 @@ describe "budget_types/index" do
   end
 
   it "renders a list of budget_types" do
+    allow(view).to receive(:policy).and_return double(create?: true, update?: true, destroy?: true)
     render
     # Run the generator again with the --webrat flag if you want to use webrat matchers
     assert_select "tr>td", :text => "Public funds".to_s, :count => 1

data/spec/views/budget_types/show.html.erb_spec.rb

@@ -11,6 +11,7 @@ describe "budget_types/show" do
   end
 
   it "renders attributes in <p>" do
+    allow(view).to receive(:policy).and_return double(update?: true)
     render
     # Run the generator again with the --webrat flag if you want to use webrat matchers
     rendered.should match(/Name/)

data/spec/views/libraries/show.html.erb_spec.rb

@@ -4,10 +4,11 @@ describe "libraries/show" do
   fixtures :all
   before(:each) do
     @events = Kaminari::paginate_array([]).page(1)
+    assign(:library, FactoryGirl.create(:library, :street => "\tStreet 1-2"))
   end
 
   it "renders a library detail" do
-    assign(:library, FactoryGirl.create(:library, :street => "\tStreet 1-2"))
+    allow(view).to receive(:policy).and_return double(create?: true, update?: true)
     render
     expect(rendered).to include "library"
   end

data/spec/views/library_groups/edit.html.erb_spec.rb

@@ -3,6 +3,7 @@ require 'spec_helper'
 describe "library_groups/edit" do
   before(:each) do
     @library_group = LibraryGroup.site_config
+    @available_languages = Language.where(iso_639_1: I18n.available_locales.map{|l| l.to_s})
     @countries = Country.all
   end
 

data/spec/views/library_groups/show.html.erb_spec.rb

@@ -3,9 +3,11 @@ require 'spec_helper'
 describe "library_groups/show" do
   before(:each) do
     @library_group = LibraryGroup.site_config
+    view.stub(:current_user).and_return(User.friendly.find('enjuadmin'))
   end
 
   it "renders attributes in <p>" do
+    allow(view).to receive(:policy).and_return double(update?: true)
     render
   end
 end

data/spec/views/withdraws/index.html.erb_spec.rb

@@ -17,9 +17,11 @@ RSpec.describe "withdraws/index", type: :view do
     basket = FactoryGirl.create(:basket)
     assign(:basket, basket)
     assign(:withdraw, basket.withdraws.new)
+    view.stub(:current_user).and_return(User.friendly.find('enjuadmin'))
   end
 
   it "renders a list of withdraws" do
+    allow(view).to receive(:policy).and_return double(destroy?: true)
     render
     assert_select "tr>td"
   end