enju_event 0.2.3 → 0.3.0.beta.1

data/lib/tasks/enju_event_tasks.rake

@@ -1,19 +1,19 @@
 require 'active_record/fixtures'
 desc "create initial records for enju_event"
 namespace :enju_event do
-  task :setup => :environment do
+  task setup: :environment do
     Dir.glob(Rails.root.to_s + '/db/fixtures/enju_event/*.yml').each do |file|
       ActiveRecord::FixtureSet.create_fixtures('db/fixtures/enju_event', File.basename(file, '.*'))
     end
   end
 
   desc "import events from a TSV file"
-  task :event_import => :environment do
+  task event_import: :environment do
     EventImportFile.import
   end
 
   desc "upgrade enju_circulation"
-  task :upgrade => :environment do
+  task upgrade: :environment do
     Rake::Task['statesman:backfill_most_recent'].invoke('EventExportFile')
     Rake::Task['statesman:backfill_most_recent'].invoke('EventImportFile')
   end

data/spec/controllers/event_categories_controller_spec.rb

@@ -55,7 +55,7 @@ describe EventCategoriesController do
 
       it "assigns the requested event_category as @event_category" do
         event_category = FactoryBot.create(:event_category)
-        get :show, id: event_category.id
+        get :show, params: { id: event_category.id }
         assigns(:event_category).should eq(event_category)
       end
     end
@@ -65,7 +65,7 @@ describe EventCategoriesController do
 
       it "assigns the requested event_category as @event_category" do
         event_category = FactoryBot.create(:event_category)
-        get :show, id: event_category.id
+        get :show, params: { id: event_category.id }
         assigns(:event_category).should eq(event_category)
       end
     end
@@ -75,7 +75,7 @@ describe EventCategoriesController do
 
       it "assigns the requested event_category as @event_category" do
         event_category = FactoryBot.create(:event_category)
-        get :show, id: event_category.id
+        get :show, params: { id: event_category.id }
         assigns(:event_category).should eq(event_category)
       end
     end
@@ -83,7 +83,7 @@ describe EventCategoriesController do
     describe "When not logged in" do
       it "assigns the requested event_category as @event_category" do
         event_category = FactoryBot.create(:event_category)
-        get :show, id: event_category.id
+        get :show, params: { id: event_category.id }
         assigns(:event_category).should eq(event_category)
       end
     end
@@ -135,7 +135,7 @@ describe EventCategoriesController do
 
       it "assigns the requested event_category as @event_category" do
         event_category = FactoryBot.create(:event_category)
-        get :edit, id: event_category.id
+        get :edit, params: { id: event_category.id }
         assigns(:event_category).should eq(event_category)
       end
     end
@@ -145,7 +145,7 @@ describe EventCategoriesController do
 
       it "assigns the requested event_category as @event_category" do
         event_category = FactoryBot.create(:event_category)
-        get :edit, id: event_category.id
+        get :edit, params: { id: event_category.id }
         response.should be_forbidden
       end
     end
@@ -155,7 +155,7 @@ describe EventCategoriesController do
 
       it "assigns the requested event_category as @event_category" do
         event_category = FactoryBot.create(:event_category)
-        get :edit, id: event_category.id
+        get :edit, params: { id: event_category.id }
         response.should be_forbidden
       end
     end
@@ -163,7 +163,7 @@ describe EventCategoriesController do
     describe "When not logged in" do
       it "should not assign the requested event_category as @event_category" do
         event_category = FactoryBot.create(:event_category)
-        get :edit, id: event_category.id
+        get :edit, params: { id: event_category.id }
         response.should redirect_to(new_user_session_url)
       end
     end
@@ -172,7 +172,7 @@ describe EventCategoriesController do
   describe "POST create" do
     before(:each) do
       @attrs = valid_attributes
-      @invalid_attrs = {:name => ''}
+      @invalid_attrs = {name: ''}
     end
 
     describe "When logged in as Administrator" do
@@ -180,24 +180,24 @@ describe EventCategoriesController do
 
       describe "with valid params" do
         it "assigns a newly created event_category as @event_category" do
-          post :create, event_category: @attrs
+          post :create, params: { event_category: @attrs }
           assigns(:event_category).should be_valid
         end
 
         it "redirects to the created patron" do
-          post :create, event_category: @attrs
+          post :create, params: { event_category: @attrs }
           response.should redirect_to(assigns(:event_category))
         end
       end
 
       describe "with invalid params" do
         it "assigns a newly created but unsaved event_category as @event_category" do
-          post :create, event_category: @invalid_attrs
+          post :create, params: { event_category: @invalid_attrs }
           assigns(:event_category).should_not be_valid
         end
 
         it "should be successful" do
-          post :create, event_category: @invalid_attrs
+          post :create, params: { event_category: @invalid_attrs }
           response.should be_success
         end
       end
@@ -208,24 +208,24 @@ describe EventCategoriesController do
 
       describe "with valid params" do
         it "assigns a newly created event_category as @event_category" do
-          post :create, event_category: @attrs
+          post :create, params: { event_category: @attrs }
           assigns(:event_category).should be_nil
         end
 
         it "should be forbidden" do
-          post :create, event_category: @attrs
+          post :create, params: { event_category: @attrs }
           response.should be_forbidden
         end
       end
 
       describe "with invalid params" do
         it "assigns a newly created but unsaved event_category as @event_category" do
-          post :create, event_category: @invalid_attrs
+          post :create, params: { event_category: @invalid_attrs }
           assigns(:event_category).should be_nil
         end
 
         it "should be forbidden" do
-          post :create, event_category: @invalid_attrs
+          post :create, params: { event_category: @invalid_attrs }
           response.should be_forbidden
         end
       end
@@ -236,24 +236,24 @@ describe EventCategoriesController do
 
       describe "with valid params" do
         it "assigns a newly created event_category as @event_category" do
-          post :create, event_category: @attrs
+          post :create, params: { event_category: @attrs }
           assigns(:event_category).should be_nil
         end
 
         it "should be forbidden" do
-          post :create, event_category: @attrs
+          post :create, params: { event_category: @attrs }
           response.should be_forbidden
         end
       end
 
       describe "with invalid params" do
         it "assigns a newly created but unsaved event_category as @event_category" do
-          post :create, event_category: @invalid_attrs
+          post :create, params: { event_category: @invalid_attrs }
           assigns(:event_category).should be_nil
         end
 
         it "should be forbidden" do
-          post :create, event_category: @invalid_attrs
+          post :create, params: { event_category: @invalid_attrs }
           response.should be_forbidden
         end
       end
@@ -262,24 +262,24 @@ describe EventCategoriesController do
     describe "When not logged in" do
       describe "with valid params" do
         it "assigns a newly created event_category as @event_category" do
-          post :create, event_category: @attrs
+          post :create, params: { event_category: @attrs }
           assigns(:event_category).should be_nil
         end
 
         it "should be forbidden" do
-          post :create, event_category: @attrs
+          post :create, params: { event_category: @attrs }
           response.should redirect_to(new_user_session_url)
         end
       end
 
       describe "with invalid params" do
         it "assigns a newly created but unsaved event_category as @event_category" do
-          post :create, event_category: @invalid_attrs
+          post :create, params: { event_category: @invalid_attrs }
           assigns(:event_category).should be_nil
         end
 
         it "should be forbidden" do
-          post :create, event_category: @invalid_attrs
+          post :create, params: { event_category: @invalid_attrs }
           response.should redirect_to(new_user_session_url)
         end
       end
@@ -290,7 +290,7 @@ describe EventCategoriesController do
     before(:each) do
       @event_category = FactoryBot.create(:event_category)
       @attrs = valid_attributes
-      @invalid_attrs = {:name => ''}
+      @invalid_attrs = {name: ''}
     end
 
     describe "When logged in as Administrator" do
@@ -298,23 +298,23 @@ describe EventCategoriesController do
 
       describe "with valid params" do
         it "updates the requested event_category" do
-          put :update, id: @event_category.id, event_category: @attrs
+          put :update, params: { id: @event_category.id, event_category: @attrs }
         end
 
         it "assigns the requested event_category as @event_category" do
-          put :update, id: @event_category.id, event_category: @attrs
+          put :update, params: { id: @event_category.id, event_category: @attrs }
           assigns(:event_category).should eq(@event_category)
         end
 
         it "moves its position when specified" do
-          put :update, id: @event_category.id, event_category: @attrs, :move => 'lower'
+          put :update, params: { id: @event_category.id, event_category: @attrs, move: 'lower' }
           response.should redirect_to(event_categories_url)
         end
       end
 
       describe "with invalid params" do
         it "assigns the requested event_category as @event_category" do
-          put :update, id: @event_category.id, event_category: @invalid_attrs
+          put :update, params: { id: @event_category.id, event_category: @invalid_attrs }
           response.should render_template("edit")
         end
       end
@@ -325,11 +325,11 @@ describe EventCategoriesController do
 
       describe "with valid params" do
         it "updates the requested event_category" do
-          put :update, id: @event_category.id, event_category: @attrs
+          put :update, params: { id: @event_category.id, event_category: @attrs }
         end
 
         it "assigns the requested event_category as @event_category" do
-          put :update, id: @event_category.id, event_category: @attrs
+          put :update, params: { id: @event_category.id, event_category: @attrs }
           assigns(:event_category).should eq(@event_category)
           response.should be_forbidden
         end
@@ -337,7 +337,7 @@ describe EventCategoriesController do
 
       describe "with invalid params" do
         it "assigns the requested event_category as @event_category" do
-          put :update, id: @event_category.id, event_category: @invalid_attrs
+          put :update, params: { id: @event_category.id, event_category: @invalid_attrs }
           response.should be_forbidden
         end
       end
@@ -348,11 +348,11 @@ describe EventCategoriesController do
 
       describe "with valid params" do
         it "updates the requested event_category" do
-          put :update, id: @event_category.id, event_category: @attrs
+          put :update, params: { id: @event_category.id, event_category: @attrs }
         end
 
         it "assigns the requested event_category as @event_category" do
-          put :update, id: @event_category.id, event_category: @attrs
+          put :update, params: { id: @event_category.id, event_category: @attrs }
           assigns(:event_category).should eq(@event_category)
           response.should be_forbidden
         end
@@ -360,7 +360,7 @@ describe EventCategoriesController do
 
       describe "with invalid params" do
         it "assigns the requested event_category as @event_category" do
-          put :update, id: @event_category.id, event_category: @invalid_attrs
+          put :update, params: { id: @event_category.id, event_category: @invalid_attrs }
           response.should be_forbidden
         end
       end
@@ -369,18 +369,18 @@ describe EventCategoriesController do
     describe "When not logged in" do
       describe "with valid params" do
         it "updates the requested event_category" do
-          put :update, id: @event_category.id, event_category: @attrs
+          put :update, params: { id: @event_category.id, event_category: @attrs }
         end
 
         it "should be forbidden" do
-          put :update, id: @event_category.id, event_category: @attrs
+          put :update, params: { id: @event_category.id, event_category: @attrs }
           response.should redirect_to(new_user_session_url)
         end
       end
 
       describe "with invalid params" do
         it "assigns the requested event_category as @event_category" do
-          put :update, id: @event_category.id, event_category: @invalid_attrs
+          put :update, params: { id: @event_category.id, event_category: @invalid_attrs }
           response.should redirect_to(new_user_session_url)
         end
       end
@@ -396,11 +396,11 @@ describe EventCategoriesController do
       login_fixture_admin
 
       it "destroys the requested event_category" do
-        delete :destroy, id: @event_category.id
+        delete :destroy, params: { id: @event_category.id }
       end
 
       it "redirects to the event_categories list" do
-        delete :destroy, id: @event_category.id
+        delete :destroy, params: { id: @event_category.id }
         response.should redirect_to(event_categories_url)
       end
     end
@@ -409,11 +409,11 @@ describe EventCategoriesController do
       login_fixture_librarian
 
       it "destroys the requested event_category" do
-        delete :destroy, id: @event_category.id
+        delete :destroy, params: { id: @event_category.id }
       end
 
       it "should be forbidden" do
-        delete :destroy, id: @event_category.id
+        delete :destroy, params: { id: @event_category.id }
         response.should be_forbidden
       end
     end
@@ -422,22 +422,22 @@ describe EventCategoriesController do
       login_fixture_user
 
       it "destroys the requested event_category" do
-        delete :destroy, id: @event_category.id
+        delete :destroy, params: { id: @event_category.id }
       end
 
       it "should be forbidden" do
-        delete :destroy, id: @event_category.id
+        delete :destroy, params: { id: @event_category.id }
         response.should be_forbidden
       end
     end
 
     describe "When not logged in" do
       it "destroys the requested event_category" do
-        delete :destroy, id: @event_category.id
+        delete :destroy, params: { id: @event_category.id }
       end
 
       it "should be forbidden" do
-        delete :destroy, id: @event_category.id
+        delete :destroy, params: { id: @event_category.id }
         response.should redirect_to(new_user_session_url)
       end
     end

data/spec/controllers/event_export_files_controller_spec.rb

@@ -46,7 +46,7 @@ describe EventExportFilesController do
       login_fixture_admin
 
       it "assigns the requested event_export_file as @event_export_file" do
-        get :show, :id => event_export_files(:event_export_file_00003).id
+        get :show, params: { id: event_export_files(:event_export_file_00003).id }
         assigns(:event_export_file).should eq(event_export_files(:event_export_file_00003))
         response.should be_success
       end
@@ -56,7 +56,7 @@ describe EventExportFilesController do
       login_fixture_librarian
 
       it "assigns the requested event_export_file as @event_export_file" do
-        get :show, :id => event_export_files(:event_export_file_00003).id
+        get :show, params: { id: event_export_files(:event_export_file_00003).id }
         assigns(:event_export_file).should eq(event_export_files(:event_export_file_00003))
         response.should be_success
       end
@@ -66,7 +66,7 @@ describe EventExportFilesController do
       login_fixture_user
 
       it "assigns the requested event_export_file as @event_export_file" do
-        get :show, :id => event_export_files(:event_export_file_00003).id
+        get :show, params: { id: event_export_files(:event_export_file_00003).id }
         assigns(:event_export_file).should eq(event_export_files(:event_export_file_00003))
         response.should be_forbidden
       end
@@ -74,7 +74,7 @@ describe EventExportFilesController do
 
     describe "When not logged in" do
       it "assigns the requested event_export_file as @event_export_file" do
-        get :show, :id => event_export_files(:event_export_file_00003).id
+        get :show, params: { id: event_export_files(:event_export_file_00003).id }
         assigns(:event_export_file).should eq(event_export_files(:event_export_file_00003))
         response.should redirect_to(new_user_session_url)
       end
@@ -126,7 +126,7 @@ describe EventExportFilesController do
       login_fixture_librarian
 
       it "should create agent_export_file" do
-        post :create, :event_export_file => { event_export_file_name: 'test.txt' }
+        post :create, params: { event_export_file: { event_export_file_name: 'test.txt' } }
         assigns(:event_export_file).should be_valid
         assigns(:event_export_file).user.username.should eq @user.username
         response.should redirect_to event_export_file_url(assigns(:event_export_file))
@@ -137,7 +137,7 @@ describe EventExportFilesController do
       login_fixture_user
 
       it "should be forbidden" do
-        post :create, :event_export_file => { event_export_file_name: 'test.txt' }
+        post :create, params: { event_export_file: { event_export_file_name: 'test.txt' } }
         assigns(:event_export_file).should be_nil
         response.should be_forbidden
       end
@@ -145,7 +145,7 @@ describe EventExportFilesController do
 
     describe "When not logged in" do
       it "should be redirected to new session url" do
-        post :create, :event_export_file => { event_export_file_name: 'test.txt' }
+        post :create, params: { event_export_file: { event_export_file_name: 'test.txt' } }
         assigns(:event_export_file).should be_nil
         response.should redirect_to new_user_session_url
       end
@@ -158,7 +158,7 @@ describe EventExportFilesController do
 
       it "assigns the requested event_export_file as @event_export_file" do
         event_export_file = event_export_files(:event_export_file_00001)
-        get :edit, :id => event_export_file.id
+        get :edit, params: { id: event_export_file.id }
         assigns(:event_export_file).should eq(event_export_file)
       end
     end
@@ -168,7 +168,7 @@ describe EventExportFilesController do
 
       it "assigns the requested event_export_file as @event_export_file" do
         event_export_file = event_export_files(:event_export_file_00001)
-        get :edit, :id => event_export_file.id
+        get :edit, params: { id: event_export_file.id }
         assigns(:event_export_file).should eq(event_export_file)
       end
     end
@@ -178,7 +178,7 @@ describe EventExportFilesController do
 
       it "assigns the requested event_export_file as @event_export_file" do
         event_export_file = event_export_files(:event_export_file_00001)
-        get :edit, :id => event_export_file.id
+        get :edit, params: { id: event_export_file.id }
         response.should be_forbidden
       end
     end
@@ -186,7 +186,7 @@ describe EventExportFilesController do
     describe "When not logged in" do
       it "should not assign the requested event_export_file as @event_export_file" do
         event_export_file = event_export_files(:event_export_file_00001)
-        get :edit, :id => event_export_file.id
+        get :edit, params: { id: event_export_file.id }
         response.should redirect_to(new_user_session_url)
       end
     end
@@ -197,7 +197,7 @@ describe EventExportFilesController do
       login_fixture_admin
 
       it "should update event_export_file" do
-        put :update, :id => event_export_files(:event_export_file_00003).id, :event_export_file => { event_export_file_name: 'test.txt' }
+        put :update, params: { id: event_export_files(:event_export_file_00003).id, event_export_file: { event_export_file_name: 'test.txt' } }
         response.should redirect_to event_export_file_url(assigns(:event_export_file))
       end
     end
@@ -206,7 +206,7 @@ describe EventExportFilesController do
       login_fixture_librarian
 
       it "should update event_export_file" do
-        put :update, :id => event_export_files(:event_export_file_00003).id, :event_export_file => { event_export_file_name: 'test.txt' }
+        put :update, params: { id: event_export_files(:event_export_file_00003).id, event_export_file: { event_export_file_name: 'test.txt' } }
         response.should redirect_to event_export_file_url(assigns(:event_export_file))
       end
     end
@@ -215,14 +215,14 @@ describe EventExportFilesController do
       login_fixture_user
 
       it "should not update event_export_file" do
-        put :update, :id => event_export_files(:event_export_file_00003).id, :event_export_file => { }
+        put :update, params: { id: event_export_files(:event_export_file_00003).id, event_export_file: { } }
         response.should be_forbidden
       end
     end
 
     describe "When not logged in" do
       it "should not update event_export_file" do
-        put :update, :id => event_export_files(:event_export_file_00003).id, :event_export_file => { }
+        put :update, params: { id: event_export_files(:event_export_file_00003).id, event_export_file: { } }
         response.should redirect_to new_user_session_url
       end
     end
@@ -237,11 +237,11 @@ describe EventExportFilesController do
       login_fixture_admin
 
       it "destroys the requested event_export_file" do
-        delete :destroy, :id => @event_export_file.id
+        delete :destroy, params: { id: @event_export_file.id }
       end
 
       it "redirects to the event_export_files list" do
-        delete :destroy, :id => @event_export_file.id
+        delete :destroy, params: { id: @event_export_file.id }
         response.should redirect_to(event_export_files_url)
       end
     end
@@ -250,11 +250,11 @@ describe EventExportFilesController do
       login_fixture_librarian
 
       it "destroys the requested event_export_file" do
-        delete :destroy, :id => @event_export_file.id
+        delete :destroy, params: { id: @event_export_file.id }
       end
 
       it "redirects to the event_export_files list" do
-        delete :destroy, :id => @event_export_file.id
+        delete :destroy, params: { id: @event_export_file.id }
         response.should redirect_to(event_export_files_url)
       end
     end
@@ -263,22 +263,22 @@ describe EventExportFilesController do
       login_fixture_user
 
       it "destroys the requested event_export_file" do
-        delete :destroy, :id => @event_export_file.id
+        delete :destroy, params: { id: @event_export_file.id }
       end
 
       it "should be forbidden" do
-        delete :destroy, :id => @event_export_file.id
+        delete :destroy, params: { id: @event_export_file.id }
         response.should be_forbidden
       end
     end
 
     describe "When not logged in" do
       it "destroys the requested event_export_file" do
-        delete :destroy, :id => @event_export_file.id
+        delete :destroy, params: { id: @event_export_file.id }
       end
 
       it "should be forbidden" do
-        delete :destroy, :id => @event_export_file.id
+        delete :destroy, params: { id: @event_export_file.id }
         response.should redirect_to(new_user_session_url)
       end
     end