enju_circulation 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b71a1452b3731a885beeb265f9f5d3db20604cb7f4397cdddd9269b4e235a7c
-  data.tar.gz: 79273b205450724cc144ac839d09d82069755f5f84fc78f37948ce396ea292a2
+  metadata.gz: b38f62123745a87848e27bea905ec42fc17e30df0fc0ba9853cf7fe98db6d79b
+  data.tar.gz: f951bd48af2901ffca4a3a1499f0bbe88595498ceeecdd185909aa0580cdffd6
 SHA512:
-  metadata.gz: 4df0bfd6a17b48bdbdf08177ee991c0f8dcebbe1d6e7237e9f41b7eb39e65b32e7d38c9c0b08bfa41add718bc8f5ec26e29dc364003ef4ef9518d8ca8864f246
-  data.tar.gz: f5e812a6fa13aebc8b642d44d78cbb7a303ca761df3afeef33650fdd9820dc3c9cec390b7a551135088d7fa027244d23b4010b1bf70f83f4c4092e3c3e2c9e0c
+  metadata.gz: c0d8649b6101178444596fde67c8574651881d8794bbd0656461fcef65a0fdce66bb67354089842be21412c673c2b1cf98a9ec0d39607ef811f6be8836d23b4e
+  data.tar.gz: f6345684a0fc171f5c78b1d41ff764a47fd4b02e97825c16afa5118eccc7e7498ff6b3b0822374203f60557e6c2c5a2315e77b33f6c5806429f736e0462dd1b7

data/app/policies/checkout_policy.rb

@@ -24,7 +24,7 @@ class CheckoutPolicy < ApplicationPolicy
   end
 
   def destroy?
-    if record.checkin
+    if record.checkin && record.user
       if user.try(:has_role?, 'Librarian')
         true
       elsif user && (user == record.user)

data/lib/enju_circulation/version.rb

@@ -1,3 +1,3 @@
 module EnjuCirculation
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

data/spec/controllers/checkouts_controller_spec.rb

@@ -453,6 +453,12 @@ describe CheckoutsController do
         delete :destroy, params: { id: @returned_checkout.id }
         response.should redirect_to(checkouts_url(user_id: @returned_checkout.user.username))
       end
+
+      it 'should be forbidden to delete a checkout if its user is not set' do
+        delete :destroy, params: { id: @returned_checkout.id }
+        delete :destroy, params: { id: @returned_checkout.id }
+        expect(response).to be_forbidden
+      end
     end
 
     describe 'When logged in as Librarian' do

data/spec/fixtures/circulation_statuses.yml

@@ -1,26 +1,26 @@
 --- 
 circulation_status_00001: 
-  name: Available For Pickup  
+  name: Available For Pickup
   display_name: "en: Available For Pickup\r\n\
     ja: 持ち出し可能"
   id: 1
   note: ""
   position: 1
 circulation_status_00002: 
-  name: Available On Shelf  
+  name: Available On Shelf
   display_name: "en: Available on Shelf\r\n\
     ja: 在架（利用可能）"
   id: 2
   note: ""
   position: 2
 circulation_status_00003: 
-  name: Circulation Status Undefined  
+  name: Circulation Status Undefined
   display_name: Circulation Status Undefined
   id: 3
   note: ""
   position: 3
 circulation_status_00004: 
-  name: Claimed Returned Or Never Borrowed  
+  name: Claimed Returned Or Never Borrowed
   display_name: Claimed Returned Or Never Borrowed
   id: 4
   note: ""
@@ -60,7 +60,7 @@ circulation_status_00009:
   note: ""
   position: 9
 circulation_status_00010: 
-  name: On Loan  
+  name: On Loan
   display_name: "en: On Loan\r\n\
     ja: 貸出中"
   id: 10
@@ -79,13 +79,13 @@ circulation_status_00012:
   note: ""
   position: 12
 circulation_status_00013: 
-  name: Recalled  
+  name: Recalled
   display_name: Recalled
   id: 13
   note: ""
   position: 13
 circulation_status_00014: 
-  name: Waiting To Be Reshelved  
+  name: Waiting To Be Reshelved
   display_name: Waiting To Be Reshelved
   id: 14
   note: ""

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: enju_circulation
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Kosuke Tanabe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-28 00:00:00.000000000 Z
+date: 2019-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: enju_biblio