enju_circulation 0.3.11 → 0.4.0.beta.1

data/spec/controllers/baskets_controller_spec.rb

@@ -0,0 +1,379 @@
+require 'rails_helper'
+
+describe BasketsController do
+  fixtures :all
+
+  describe 'GET index' do
+    describe 'When logged in as Administrator' do
+      login_fixture_admin
+
+      it 'assigns all baskets as @baskets' do
+        get :index, params: { user_id: users(:user1).username }
+        assigns(:baskets).should_not be_empty
+        response.should be_successful
+      end
+
+      it 'should get index without user_id' do
+        get :index
+        response.should be_successful
+      end
+    end
+
+    describe 'When logged in as Librarian' do
+      login_fixture_librarian
+
+      it 'assigns all baskets as @baskets' do
+        get :index, params: { user_id: users(:user1).username }
+        assigns(:baskets).should_not be_empty
+        response.should be_successful
+      end
+    end
+
+    describe 'When logged in as User' do
+      login_fixture_user
+
+      it 'assigns all baskets as @baskets' do
+        get :index, params: { user_id: users(:user1).username }
+        assigns(:baskets).should be_nil
+        response.should be_forbidden
+      end
+    end
+
+    describe 'When not logged in' do
+      it 'assigns all baskets as @baskets' do
+        get :index, params: { user_id: users(:user1).username }
+        assigns(:baskets).should be_nil
+        response.should redirect_to(new_user_session_url)
+      end
+    end
+  end
+
+  describe 'GET show' do
+    describe 'When logged in as Administrator' do
+      login_fixture_admin
+
+      it 'assigns the requested basket as @basket' do
+        get :show, params: { id: baskets(:basket_00001).id, user_id: users(:admin).username }
+        assigns(:basket).should eq(baskets(:basket_00001))
+      end
+    end
+
+    describe 'When logged in as Librarian' do
+      login_fixture_librarian
+
+      it 'assigns the requested basket as @basket' do
+        get :show, params: { id: baskets(:basket_00001).id, user_id: users(:admin).username }
+        assigns(:basket).should eq(baskets(:basket_00001))
+      end
+    end
+
+    describe 'When logged in as User' do
+      login_fixture_user
+
+      it 'assigns the requested basket as @basket' do
+        get :show, params: { id: baskets(:basket_00001).id, user_id: users(:admin).username }
+        assigns(:basket).should eq(baskets(:basket_00001))
+        response.should be_forbidden
+      end
+    end
+
+    describe 'When not logged in' do
+      it 'assigns the requested basket as @basket' do
+        get :show, params: { id: baskets(:basket_00001).id, user_id: users(:admin).username }
+        assigns(:basket).should eq(baskets(:basket_00001))
+        response.should redirect_to(new_user_session_url)
+      end
+    end
+  end
+
+  describe 'GET new' do
+    describe 'When logged in as Administrator' do
+      login_fixture_admin
+
+      it 'assigns the requested basket as @basket' do
+        get :new
+        assigns(:basket).should_not be_valid
+      end
+    end
+
+    describe 'When logged in as Librarian' do
+      login_fixture_librarian
+
+      it 'assigns the requested basket as @basket' do
+        get :new
+        assigns(:basket).should_not be_valid
+      end
+    end
+
+    describe 'When logged in as User' do
+      login_fixture_user
+
+      it 'should not assign the requested basket as @basket' do
+        get :new
+        assigns(:basket).should be_nil
+        response.should be_forbidden
+      end
+    end
+
+    describe 'When not logged in' do
+      it 'should not assign the requested basket as @basket' do
+        get :new
+        assigns(:basket).should be_nil
+        response.should redirect_to(new_user_session_url)
+      end
+    end
+  end
+
+  describe 'GET edit' do
+    describe 'When logged in as Administrator' do
+      login_fixture_admin
+      before(:each) do
+        @basket = baskets(:basket_00001)
+      end
+
+      it 'assigns the requested basket as @basket' do
+        get :edit, params: { id: @basket.id }
+        assigns(:basket).should eq(@basket)
+      end
+    end
+
+    describe 'When logged in as Librarian' do
+      login_fixture_librarian
+      before(:each) do
+        @basket = baskets(:basket_00001)
+      end
+
+      it 'assigns the requested basket as @basket' do
+        get :edit, params: { id: @basket.id }
+        assigns(:basket).should eq(@basket)
+      end
+    end
+
+    describe 'When logged in as User' do
+      login_fixture_user
+      before(:each) do
+        @basket = baskets(:basket_00001)
+      end
+
+      it 'should not assign the requested basket as @basket' do
+        get :edit, params: { id: @basket.id }
+        assigns(:basket).should eq(@basket)
+        response.should be_forbidden
+      end
+    end
+
+    describe 'When not logged in' do
+      before(:each) do
+        @basket = baskets(:basket_00001)
+      end
+
+      it 'should not assign the requested basket as @basket' do
+        get :edit, params: { id: @basket.id }
+        assigns(:basket).should eq(@basket)
+        response.should redirect_to new_user_session_url
+      end
+    end
+  end
+
+  describe 'POST create' do
+    before(:each) do
+      @attrs = { user_number: users(:user1).profile.user_number }
+      @invalid_attrs = { user_number: 'invalid' }
+    end
+
+    describe 'When logged in as Administrator' do
+      login_fixture_admin
+
+      describe 'with valid params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, params: { basket: { user_number: users(:user1).profile.user_number } }
+          assigns(:basket).should be_valid
+        end
+      end
+
+      describe 'with blank params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, params: { basket: { note: 'test' } }
+          assigns(:basket).should_not be_valid
+        end
+      end
+
+      describe 'with invalid params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, params: { basket: @invalid_attrs }
+          assigns(:basket).should_not be_valid
+        end
+      end
+    end
+
+    describe 'When logged in as Librarian' do
+      login_fixture_librarian
+
+      describe 'with valid params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, params: { basket: { user_number: users(:user1).profile.user_number } }
+          assigns(:basket).should be_valid
+        end
+      end
+
+      describe 'with blank params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, params: { basket: { note: 'test' } }
+          assigns(:basket).should_not be_valid
+        end
+      end
+
+      describe 'with invalid params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, params: { basket: @invalid_attrs }
+          assigns(:basket).should_not be_valid
+        end
+      end
+
+      it 'should not create basket when user is suspended' do
+        post :create, params: { basket: { user_number: users(:user4).profile.user_number } }
+        assigns(:basket).should_not be_valid
+        assigns(:basket).errors['base'].include?(I18n.t('basket.this_account_is_suspended')).should be_truthy
+        response.should be_successful
+      end
+
+      it 'should not create basket when user is not found' do
+        post :create, params: { basket: { user_number: 'not found' } }
+        assigns(:basket).should_not be_valid
+        assigns(:basket).errors['base'].include?(I18n.t('user.not_found')).should be_truthy
+        response.should be_successful
+      end
+
+      it 'should not create basket without user_number' do
+        post :create, params: { basket: { note: 'test' } }
+        assigns(:basket).should_not be_valid
+        response.should be_successful
+      end
+
+      it 'should create basket' do
+        post :create, params: { basket: { user_number: users(:user1).profile.user_number } }
+        assigns(:basket).should be_valid
+        response.should redirect_to new_checked_item_url(basket_id: assigns(:basket).id)
+      end
+
+      it 'should not create basket without user_number' do
+        post :create, params: { basket: { note: 'test' } }
+        assigns(:basket).should_not be_valid
+        response.should be_successful
+      end
+    end
+
+    describe 'When logged in as User' do
+      login_fixture_user
+
+      describe 'with valid params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, params: { basket: { user_number: users(:user1).profile.user_number } }
+          assigns(:basket).should be_nil
+        end
+
+        it 'should be forbidden' do
+          post :create, params: { basket: { user_number: users(:user1).profile.user_number } }
+          response.should be_forbidden
+        end
+      end
+
+      it 'should not create basket' do
+        post :create, params: { basket: { user_number: users(:user1).profile.user_number } }
+        response.should be_forbidden
+      end
+    end
+
+    describe 'When not logged in' do
+      describe 'with blank params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, params: { basket: { note: 'test' } }
+          assigns(:basket).should be_nil
+        end
+
+        it 'should be redirected to new_user_session_url' do
+          post :create, params: { basket: { note: 'test' } }
+          assigns(:basket).should be_nil
+          assert_response :redirect
+          response.should redirect_to new_user_session_url
+        end
+      end
+    end
+  end
+
+  describe 'PUT update' do
+    before(:each) do
+      @attrs = { user_id: users(:user1).username }
+    end
+
+    describe 'When logged in as Librarian' do
+      login_fixture_librarian
+
+      describe 'with valid params' do
+        it 'updates the requested basket' do
+          put :update, params: { id: baskets(:basket_00008).id, basket: @attrs }
+        end
+
+        it 'assigns the requested basket as @basket' do
+          put :update, params: { id: baskets(:basket_00008).id, basket: @attrs }
+          assigns(:basket).checkouts.order('created_at DESC').first.item.circulation_status.name.should eq 'On Loan'
+          response.should redirect_to(checkouts_url(user_id: assigns(:basket).user.username))
+        end
+      end
+    end
+  end
+
+  describe 'DELETE destroy' do
+    before(:each) do
+      @basket = FactoryBot.create(:basket)
+    end
+
+    describe 'When logged in as Administrator' do
+      login_fixture_admin
+
+      it 'should destroy basket without user_id' do
+        delete :destroy, params: { id: baskets(:basket_00001).id, basket: { user_id: nil }, user_id: users(:user1).username }
+        response.should redirect_to(checkouts_url(user_id: assigns(:basket).user.username))
+      end
+
+      it 'should destroy basket' do
+        delete :destroy, params: { id: baskets(:basket_00001).id, basket: {}, user_id: users(:user1).username }
+        response.should redirect_to(checkouts_url(user_id: assigns(:basket).user.username))
+      end
+    end
+
+    describe 'When logged in as Librarian' do
+      login_fixture_librarian
+
+      it 'should destroy basket without user_id' do
+        delete :destroy, params: { id: baskets(:basket_00001).id, basket: { user_id: nil }, user_id: users(:user1).username }
+        response.should redirect_to(checkouts_url(user_id: assigns(:basket).user.username))
+      end
+
+      it 'should destroy basket' do
+        delete :destroy, params: { id: baskets(:basket_00001).id, basket: {}, user_id: users(:user1).username }
+        response.should redirect_to(checkouts_url(user_id: assigns(:basket).user.username))
+      end
+    end
+
+    describe 'When logged in as User' do
+      login_fixture_user
+
+      it 'should not destroy basket' do
+        delete :destroy, params: { id: baskets(:basket_00003).id, user_id: users(:user1).username }
+        response.should be_forbidden
+      end
+    end
+
+    describe 'When not logged in' do
+      it 'destroys the requested basket' do
+        delete :destroy, params: { id: @basket.id }
+      end
+
+      it 'should be forbidden' do
+        delete :destroy, params: { id: @basket.id }
+        response.should redirect_to new_user_session_url
+      end
+    end
+  end
+end

data/spec/controllers/checkins_controller_spec.rb

@@ -201,14 +201,14 @@ describe CheckinsController do
           it 'redirects to the created checkin' do
             post :create, params: { checkin: @attrs, basket_id: 9 }
             response.should redirect_to(checkins_url(basket_id: assigns(:checkin).basket_id))
-            assigns(:checkin).checkout.item.circulation_status.name.should eq 'Available On Shelf'
+            assigns(:checkin).item.circulation_status.name.should eq 'Available On Shelf'
           end
 
           it 'should checkin the overdue item' do
             post :create, params: { checkin: { item_identifier: '00014' }, basket_id: 9 }
             response.should redirect_to(checkins_url(basket_id: assigns(:checkin).basket_id))
             assigns(:checkin).checkout.should be_valid
-            assigns(:checkin).checkout.item.circulation_status.name.should eq 'Available On Shelf'
+            assigns(:checkin).item.circulation_status.name.should eq 'Available On Shelf'
           end
         end
       end
@@ -249,14 +249,14 @@ describe CheckinsController do
         it 'should show notification when it is reserved' do
           post :create, params: { checkin: { item_identifier: '00008' }, basket_id: 9 }
           flash[:message].to_s.index(I18n.t('item.this_item_is_reserved')).should be_truthy
-          assigns(:checkin).checkout.item.should be_retained
-          assigns(:checkin).checkout.item.circulation_status.name.should eq 'Available On Shelf'
+          assigns(:checkin).item.should be_retained
+          assigns(:checkin).item.circulation_status.name.should eq 'Available On Shelf'
           response.should redirect_to(checkins_url(basket_id: assigns(:basket).id))
         end
 
         it 'should show notification when an item includes supplements' do
           post :create, params: { checkin: { item_identifier: '00004' }, basket_id: 9 }
-          assigns(:checkin).checkout.item.circulation_status.name.should eq 'Available On Shelf'
+          assigns(:checkin).item.circulation_status.name.should eq 'Available On Shelf'
           flash[:message].to_s.index(I18n.t('item.this_item_include_supplement')).should be_truthy
           response.should redirect_to(checkins_url(basket_id: assigns(:basket).id))
         end
@@ -306,128 +306,6 @@ describe CheckinsController do
     end
   end
 
-  describe 'POST create (json format)' do
-    before(:each) do
-      @attrs = { item_identifier: '00003' }
-      @invalid_attrs = { item_identifier: 'invalid' }
-      request.env["HTTP_ACCEPT"] = 'application/json'
-    end
-
-    describe 'When logged in as Administrator' do
-      login_fixture_admin
-
-      describe 'with valid params' do
-        it 'assigns a newly created checkin as @checkin' do
-          post :create, params: { checkin: @attrs }
-          assigns(:checkin).should be_nil
-        end
-
-        it 'should not create checkin without basket_id' do
-          post :create, params: { checkin: @attrs }
-          json = JSON.parse(response.body)
-          expect(json['error']).to eq('forbidden')
-        end
-
-        describe 'When basket_id is specified' do
-          it 'redirects to the created checkin' do
-            post :create, params: { checkin: @attrs, basket_id: 9 }
-            expect(response).to have_http_status(:created)
-            json = JSON.parse(response.body)
-            expect(json['result']['basket_id']).to eq(9)
-            assigns(:checkin).checkout.item.circulation_status.name.should eq 'Available On Shelf'
-          end
-
-          it 'should checkin the overdue item' do
-            post :create, params: { checkin: { item_identifier: '00014' }, basket_id: 9 }
-            expect(response).to have_http_status(:created)
-            assigns(:checkin).checkout.should be_valid
-            assigns(:checkin).checkout.item.circulation_status.name.should eq 'Available On Shelf'
-          end
-        end
-      end
-
-      describe 'with invalid params' do
-        it 'assigns a newly created but unsaved checkin as @checkin' do
-          post :create, params: { checkin: @invalid_attrs }
-          assigns(:checkin).should be_nil
-        end
-
-        it 'should be forbidden' do
-          post :create, params: { checkin: @invalid_attrs }
-          json = JSON.parse(response.body)
-          expect(json['error']).to eq('forbidden')
-        end
-      end
-
-      it 'should not create checkin without item_id' do
-        post :create, params: { checkin: { item_identifier: nil }, basket_id: 9 }
-        assigns(:checkin).should_not be_valid
-        expect(response).to have_http_status(:unprocessable_entity)
-        json = JSON.parse(response.body)
-        expect(json['messages']['base']).to match_array([I18n.t('checkin.item_not_found')])
-        expect(json['messages']['item_id']).to match_array([I18n.t('errors.messages.blank')])
-      end
-    end
-
-    describe 'When logged in as Librarian' do
-      login_fixture_librarian
-
-      describe 'with valid params' do
-        it 'assigns a newly created checkin as @checkin' do
-          post :create, params: { checkin: @attrs }
-          assigns(:checkin).should be_nil
-        end
-
-        it 'should not create checkin without basket_id' do
-          post :create, params: { checkin: @attrs }
-          json = JSON.parse(response.body)
-          expect(json['error']).to eq('forbidden')
-        end
-
-        it 'should show notification when it is reserved' do
-          post :create, params: { checkin: { item_identifier: '00008' }, basket_id: 9 }
-          flash[:message].to_s.index(I18n.t('item.this_item_is_reserved')).should be_truthy
-          assigns(:checkin).checkout.item.should be_retained
-          assigns(:checkin).checkout.item.circulation_status.name.should eq 'Available On Shelf'
-          expect(response).to have_http_status(:created)
-        end
-
-        it 'should show notification when an item includes supplements' do
-          post :create, params: { checkin: { item_identifier: '00004' }, basket_id: 9 }
-          assigns(:checkin).checkout.item.circulation_status.name.should eq 'Available On Shelf'
-          flash[:message].to_s.index(I18n.t('item.this_item_include_supplement')).should be_truthy
-          expect(response).to have_http_status(:created)
-        end
-      end
-
-      it "should show notice when other library's item is checked in" do
-        sign_in users(:librarian2)
-        post :create, params: { checkin: { item_identifier: '00009' }, basket_id: 9 }
-        assigns(:checkin).should be_valid
-        flash[:message].to_s.index(I18n.t('checkin.other_library_item')).should be_truthy
-        expect(response).to have_http_status(:created)
-      end
-    end
-
-    describe 'When not logged in' do
-      before(:each) do
-        @attrs = { item_identifier: '00003' }
-        @invalid_attrs = { item_identifier: 'invalid' }
-      end
-
-      describe 'with valid params' do
-        it 'assigns a newly created checkin as @checkin' do
-          post :create, params: { checkin: @attrs }
-        end
-
-        it 'should redirect to new session url' do
-          post :create, params: { checkin: @attrs }
-          expect(response).to have_http_status(:ok)
-        end
-      end
-    end
-  end
-
   describe 'PUT update' do
     before(:each) do
       @checkin = checkins(:checkin_00001)
@@ -457,7 +335,7 @@ describe CheckinsController do
 
         it "re-renders the 'edit' template" do
           put :update, params: { id: @checkin.id, checkin: @invalid_attrs }
-          expect(response).to be_successful
+          response.should render_template('edit')
         end
 
         it 'should not update checkin without item_identifier' do
@@ -486,12 +364,12 @@ describe CheckinsController do
       describe 'with invalid params' do
         it 'assigns the checkin as @checkin' do
           put :update, params: { id: @checkin.id, checkin: @invalid_attrs }
-          expect(assigns(:checkin)).not_to be_valid
+          assigns(:checkin).should_not be_valid
         end
 
         it "re-renders the 'edit' template" do
           put :update, params: { id: @checkin.id, checkin: @invalid_attrs }
-          expect(response).to be_successful
+          response.should render_template('edit')
         end
       end
     end

data/spec/controllers/checkouts_controller_spec.rb

@@ -45,8 +45,8 @@ describe CheckoutsController do
         response.should be_successful
       end
 
-      it 'should get index text' do
-        get :index, format: :text
+      it 'should get index txt' do
+        get :index, format: 'txt'
         assigns(:checkouts).count.should eq assigns(:checkouts).total_entries
         response.should be_successful
       end
@@ -117,9 +117,9 @@ describe CheckoutsController do
         response.should redirect_to checkouts_url
       end
 
-      it 'should get my index in text format' do
-        get :index, params: { user_id: users(:user1).username, format: :text }
-        response.should redirect_to checkouts_url(format: :text)
+      it 'should get my index in txt format' do
+        get :index, params: { user_id: users(:user1).username, format: 'txt' }
+        response.should redirect_to checkouts_url(format: :txt)
         assigns(:checkouts).should be_nil
       end
 

data/spec/controllers/items_controller_spec.rb

@@ -3,6 +3,10 @@ require 'rails_helper'
 describe ItemsController do
   fixtures :all
 
+  def valid_attributes
+    FactoryBot.attributes_for(:item)
+  end
+
   describe 'POST create' do
     before(:each) do
       manifestation = FactoryBot.create(:manifestation)
@@ -13,58 +17,34 @@ describe ItemsController do
     describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      describe 'with valid params' do
-        it 'should create reserved item' do
-          post :create, params: { item: { circulation_status_id: 1, manifestation_id: 2 } }
-          expect(assigns(:item)).to be_valid
-
-          expect(response).to redirect_to item_url(assigns(:item))
-          flash[:message].should eq I18n.t('item.this_item_is_reserved')
-          assigns(:item).manifestation.should eq Manifestation.find(2)
-          assigns(:item).should be_retained
-        end
-
-        it "should create another item with already retained" do
-          reserve = FactoryBot.create(:reserve)
-          reserve.transition_to!(:requested)
-          post :create, params: { item: FactoryBot.attributes_for(:item, manifestation_id: reserve.manifestation.id) }
-          expect(assigns(:item)).to be_valid
-          expect(response).to redirect_to item_url(assigns(:item))
-          post :create, params: { item: FactoryBot.attributes_for(:item, manifestation_id: reserve.manifestation.id) }
-          expect(assigns(:item)).to be_valid
-          expect(response).to redirect_to item_url(assigns(:item))
-        end
-
-        it 'should create a lending policy' do
-          old_lending_policy_count = LendingPolicy.count
-          post :create, params: { item: @attrs }
-          LendingPolicy.count.should eq old_lending_policy_count
-        end
-      end
-    end
-  end
-
-  describe 'PUT update' do
-    describe 'When logged in as Administrator' do
-      login_fixture_admin
+      it 'should create reserved item' do
+        post :create, params: { item: { circulation_status_id: 1, manifestation_id: 2 } }
+        expect(assigns(:item)).to be_valid
 
-      it 'should remove an item' do
-        item = FactoryBot.create(:item)
-        put :update, params: { id: item.id, item: {circulation_status_id: CirculationStatus.find_by(name: 'Removed').id } }
-        expect(assigns(:item).valid?).to be_truthy
         expect(response).to redirect_to item_url(assigns(:item))
+        flash[:message].should eq I18n.t('item.this_item_is_reserved')
+        assigns(:item).manifestation.should eq Manifestation.find(2)
+        assigns(:item).should be_retained
       end
 
-      it 'should not remove a reserved item' do
-        item = FactoryBot.create(:reserve).item
-        put :update, params: { id: item.id, item: {circulation_status_id: CirculationStatus.find_by(name: 'Removed').id } }
-        expect(assigns(:item).valid?).to be_falsy
-        expect(response).to be_successful
+      it "should create another item with already retained" do
+        reserve = FactoryBot.create(:reserve)
+        reserve.transition_to!(:requested)
+        post :create, params: { item: FactoryBot.attributes_for(:item, manifestation_id: reserve.manifestation.id) }
+        expect(assigns(:item)).to be_valid
+        expect(response).to redirect_to item_url(assigns(:item))
+        post :create, params: { item: FactoryBot.attributes_for(:item, manifestation_id: reserve.manifestation.id) }
+        expect(assigns(:item)).to be_valid
+        expect(response).to redirect_to item_url(assigns(:item))
       end
     end
   end
 
   describe 'DELETE destroy' do
+    before(:each) do
+      @item = FactoryBot.create(:item)
+    end
+
     describe 'When logged in as Administrator' do
       login_fixture_admin