enju_circulation 0.3.0.beta.1 → 0.3.0.rc.1

data/spec/controllers/checked_items_controller_spec.rb

@@ -10,13 +10,13 @@ describe CheckedItemsController do
       it 'assigns all checked_items as @checked_items' do
         get :index
         assigns(:checked_items).should_not be_empty
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should get index without basket_id' do
         get :index, params: { item_id: 1 }
         assigns(:checked_items).should_not be_empty
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -26,14 +26,14 @@ describe CheckedItemsController do
       it 'should be forbidden' do
         get :index
         assigns(:checked_items).should_not be_empty
-        response.should be_success
+        response.should be_successful
       end
 
       describe 'When basket is specified' do
         it 'assigns checked_items as @checked_items' do
           get :index, params: { basket_id: 1 }
           assigns(:checked_items).should_not be_empty
-          response.should be_success
+          response.should be_successful
         end
       end
     end
@@ -75,7 +75,7 @@ describe CheckedItemsController do
       it 'assigns the requested checked_item as @checked_item' do
         get :show, params: { id: 1 }
         assigns(:checked_item).should eq(checked_items(:checked_item_00001))
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -85,7 +85,7 @@ describe CheckedItemsController do
       it 'assigns the requested checked_item as @checked_item' do
         get :show, params: { id: 1 }
         assigns(:checked_item).should eq(checked_items(:checked_item_00001))
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -131,7 +131,7 @@ describe CheckedItemsController do
       it 'assigns the requested checked_item as @checked_item' do
         get :new, params: { basket_id: 3 }
         assigns(:checked_item).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -172,7 +172,7 @@ describe CheckedItemsController do
         checked_item = checked_items(:checked_item_00001)
         get :edit, params: { id: checked_item.id }
         assigns(:checked_item).should eq(checked_item)
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -245,7 +245,7 @@ describe CheckedItemsController do
 
       it 'should not create checked_item without item_id' do
         post :create, params: { checked_item: { item_identifier: '00004' }, basket_id: 1 }
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -276,12 +276,12 @@ describe CheckedItemsController do
         post :create, params: { checked_item: { item_identifier: '00011', due_date_string: 'invalid' }, basket_id: 3 }
         assigns(:checked_item).should_not be_valid
         assigns(:checked_item).due_date.should be_nil
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should not create checked_item if excessed checkout_limit' do
         post :create, params: { checked_item: { item_identifier: '00011' }, basket_id: 1 }
-        response.should be_success
+        response.should be_successful
         assigns(:checked_item).errors['base'].include?(I18n.t('activerecord.errors.messages.checked_item.excessed_checkout_limit')).should be_truthy
       end
 

data/spec/controllers/checkins_controller_spec.rb

@@ -16,14 +16,14 @@ describe CheckinsController do
       it 'assigns all checkins as @checkins' do
         get :index
         assigns(:checkins).should eq Checkin.page(1)
-        response.should be_success
+        response.should be_successful
       end
 
       describe 'When basket_id is specified' do
         it 'assigns all checkins as @checkins' do
           get :index, params: { basket_id: 10 }
           assigns(:checkins).should eq Basket.find(10).checkins.page(1)
-          response.should be_success
+          response.should be_successful
         end
       end
     end
@@ -34,14 +34,14 @@ describe CheckinsController do
       it 'assigns all checkins as @checkins' do
         get :index
         assigns(:checkins).should eq Checkin.page(1)
-        response.should be_success
+        response.should be_successful
       end
 
       describe 'When basket_id is specified' do
         it 'assigns all checkins as @checkins' do
           get :index, params: { basket_id: 9 }
           assigns(:checkins).should eq Basket.find(9).checkins.page(1)
-          response.should be_success
+          response.should be_successful
         end
       end
     end
@@ -228,7 +228,7 @@ describe CheckinsController do
       it 'should not create checkin without item_id' do
         post :create, params: { checkin: { item_identifier: nil }, basket_id: 9 }
         assigns(:checkin).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
     end
 

data/spec/controllers/checkout_types_controller_spec.rb

@@ -92,7 +92,7 @@ describe CheckoutTypesController do
       it 'assigns the requested checkout_type as @checkout_type' do
         get :new
         assigns(:checkout_type).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -194,7 +194,7 @@ describe CheckoutTypesController do
 
         it 'should be successful' do
           post :create, params: { checkout_type: @invalid_attrs }
-          response.should be_success
+          response.should be_successful
         end
       end
     end

data/spec/controllers/checkouts_controller_spec.rb

@@ -23,7 +23,7 @@ describe CheckoutsController do
 
       it "should get other user's index" do
         get :index, params: { user_id: users(:admin).username }
-        response.should be_success
+        response.should be_successful
         assigns(:checkouts).should eq users(:admin).checkouts.not_returned.order('checkouts.id DESC').page(1)
       end
 
@@ -42,48 +42,48 @@ describe CheckoutsController do
 
       it 'should get index' do
         get :index
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should get index txt' do
         get :index, format: 'txt'
         assigns(:checkouts).count.should eq assigns(:checkouts).total_entries
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should get index rss' do
         get :index, format: 'rss'
         assigns(:checkouts).count.should eq assigns(:checkouts).total_entries
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should get overdue index' do
         get :index, params: { days_overdue: 1 }
         assigns(:checkouts).should eq Checkout.overdue(1.day.ago.beginning_of_day).order('checkouts.id DESC').page(1)
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should get overdue index with number of days_overdue' do
         get :index, params: { days_overdue: 2 }
-        response.should be_success
+        response.should be_successful
         assigns(:checkouts).size.should > 0
       end
 
       it 'should get overdue index with invalid number of days_overdue' do
         get :index, params: { days_overdue: 'invalid days' }
-        response.should be_success
+        response.should be_successful
         assigns(:checkouts).size.should > 0
       end
 
       it "should get other user's index" do
         get :index, params: { user_id: users(:admin).username }
-        response.should be_success
+        response.should be_successful
         assigns(:checkouts).should eq users(:admin).checkouts.not_returned.order('checkouts.id DESC').page(1)
       end
 
       it 'should get index with item_id' do
         get :index, params: { item_id: 1 }
-        response.should be_success
+        response.should be_successful
         assigns(:checkouts).should eq items(:item_00001).checkouts.order('checkouts.id DESC').page(1)
       end
     end
@@ -95,7 +95,7 @@ describe CheckoutsController do
         get :index
         assigns(:checkouts).should eq(users(:user1).checkouts.order('checkouts.created_at DESC').page(1))
         assigns(:checkouts).total_entries.should eq users(:user1).checkouts.count
-        response.should be_success
+        response.should be_successful
       end
 
       it "should be forbidden if other's username is specified" do
@@ -107,7 +107,7 @@ describe CheckoutsController do
 
       it 'should get my index feed' do
         get :index, format: 'rss'
-        response.should be_success
+        response.should be_successful
         assigns(:checkouts).should eq(users(:user1).checkouts.order('checkouts.created_at DESC').page(1))
       end
 
@@ -147,7 +147,7 @@ describe CheckoutsController do
         user = Profile.where(checkout_icalendar_token: token).first.user
         get :index, params: { icalendar_token: token }
         assigns(:checkouts).should eq user.checkouts.not_returned.order('checkouts.id DESC')
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should get ics template' do
@@ -155,7 +155,7 @@ describe CheckoutsController do
         user = Profile.where(checkout_icalendar_token: token).first.user
         get :index, params: { icalendar_token: token, format: :ics }
         assigns(:checkouts).should eq user.checkouts.not_returned.order('checkouts.id DESC')
-        response.should be_success
+        response.should be_successful
       end
     end
   end
@@ -166,7 +166,7 @@ describe CheckoutsController do
 
       it "should show other user's content" do
         get :show, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -175,7 +175,7 @@ describe CheckoutsController do
 
       it "should show other user's content" do
         get :show, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -184,7 +184,7 @@ describe CheckoutsController do
 
       it 'should show my account' do
         get :show, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
         assigns(:checkout).should eq checkouts(:checkout_00003)
       end
 
@@ -209,7 +209,7 @@ describe CheckoutsController do
 
       it "should edit other user's checkout" do
         get :edit, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -218,7 +218,7 @@ describe CheckoutsController do
 
       it "should edit other user's checkout" do
         get :edit, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -228,7 +228,7 @@ describe CheckoutsController do
       it 'should edit my checkout' do
         sign_in users(:user1)
         get :edit, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
 
       it "should not edit other user's checkout" do
@@ -283,7 +283,7 @@ describe CheckoutsController do
         it 'should not accept invalid date' do
           put :update, params: { id: @checkout.id, checkout: @invalid_attrs.merge(due_date: '2017-03-151') }
           assigns(:checkout).changed?.should be_truthy
-          response.should be_success
+          response.should be_successful
         end
       end
 
@@ -330,7 +330,7 @@ describe CheckoutsController do
       it 'should update checkout item that is reserved' do
         put :update, params: { id: 8, checkout: {} }
         assigns(:checkout).errors[:base].include?(I18n.t('checkout.this_item_is_reserved')).should be_truthy
-        response.should be_success
+        response.should be_successful
       end
 
       it "should update other user's checkout" do
@@ -381,7 +381,7 @@ describe CheckoutsController do
       it 'should not update checkout already renewed' do
         put :update, params: { id: 9, checkout: {} }
         assigns(:checkout).errors[:base].include?(I18n.t('checkout.excessed_renewal_limit')).should be_truthy
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should update my checkout' do

data/spec/controllers/item_has_use_restrictions_controller_spec.rb

@@ -98,7 +98,7 @@ describe ItemHasUseRestrictionsController do
       it 'assigns the requested item_has_use_restriction as @item_has_use_restriction' do
         get :new
         assigns(:item_has_use_restriction).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
     end
 

data/spec/controllers/lending_policies_controller_spec.rb

@@ -60,7 +60,7 @@ describe LendingPoliciesController do
       it 'assigns the requested lending_policy as @lending_policy' do
         get :show, params: { id: @lending_policy.id }
         assigns(:lending_policy).should eq(@lending_policy)
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -70,7 +70,7 @@ describe LendingPoliciesController do
       it 'assigns the requested lending_policy as @lending_policy' do
         get :show, params: { id: @lending_policy.id }
         assigns(:lending_policy).should eq(@lending_policy)
-        response.should be_success
+        response.should be_successful
       end
     end
 

data/spec/controllers/reserves_controller_spec.rb

@@ -18,7 +18,7 @@ describe ReservesController do
 
       it "should get other user's reservation" do
         get :index, params: { user_id: users(:user1).username }
-        response.should be_success
+        response.should be_successful
         assigns(:reserves).should eq(users(:user1).reserves.order('reserves.id DESC').includes(:manifestation).page(1))
       end
     end
@@ -33,39 +33,39 @@ describe ReservesController do
 
       it 'should get index feed without user_id' do
         get :index, format: 'rss'
-        response.should be_success
+        response.should be_successful
         assigns(:reserves).count.should eq assigns(:reserves).total_entries
         assigns(:reserves).should eq(Reserve.order('reserves.id DESC').includes(:manifestation))
       end
 
       it 'should get index txt without user_id' do
         get :index, format: 'txt'
-        response.should be_success
+        response.should be_successful
         assigns(:reserves).count.should eq assigns(:reserves).total_entries
         assigns(:reserves).should eq(Reserve.order('reserves.id DESC').includes(:manifestation))
       end
 
       it 'should get index feed with user_id' do
         get :index, params: { user_id: users(:user1).username, format: 'rss' }
-        response.should be_success
+        response.should be_successful
         assigns(:reserves).should eq(users(:user1).reserves.order('reserves.id DESC').includes(:manifestation).page(1))
       end
 
       it 'should get index txt with user_id' do
         get :index, params: { user_id: users(:user1).username, format: 'txt' }
-        response.should be_success
+        response.should be_successful
         assigns(:reserves).should eq(users(:user1).reserves.order('reserves.id DESC').includes(:manifestation))
       end
 
       it "should get other user's index" do
         get :index, params: { user_id: users(:user1).username }
-        response.should be_success
+        response.should be_successful
         assigns(:reserves).should eq(users(:user1).reserves.order('reserves.id DESC').includes(:manifestation).page(1))
       end
 
       it "should get other user's index feed" do
         get :index, params: { user_id: users(:user1).username, format: :rss }
-        response.should be_success
+        response.should be_successful
         assigns(:reserves).should eq(users(:user1).reserves.order('reserves.id DESC').includes(:manifestation).page(1))
       end
     end
@@ -80,18 +80,18 @@ describe ReservesController do
 
       it 'should be redirected to my index' do
         get :index
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should get my index feed' do
         get :index, format: :rss
-        response.should be_success
+        response.should be_successful
         response.should render_template('index')
       end
 
       it 'should get my index txt' do
         get :index, format: :txt
-        response.should be_success
+        response.should be_successful
         response.should render_template('index')
       end
 
@@ -150,7 +150,7 @@ describe ReservesController do
 
       it "should show other user's reservation" do
         get :show, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -165,7 +165,7 @@ describe ReservesController do
 
       it "should show other user's reservation" do
         get :show, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -180,7 +180,7 @@ describe ReservesController do
 
       it 'should show my reservation' do
         get :show, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
 
       it "should not show other user's reservation" do
@@ -218,7 +218,7 @@ describe ReservesController do
       it "should get other user's reservation" do
         get :new, params: { user_id: users(:user1).username, manifestation_id: 3 }
         assigns(:reserve).user.should eq users(:user1)
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -232,13 +232,13 @@ describe ReservesController do
 
       it 'should get new template without user_id' do
         get :new, params: { manifestation_id: 3 }
-        response.should be_success
+        response.should be_successful
       end
 
       it "should get other user's reservation" do
         get :new, params: { user_id: users(:user1).username, manifestation_id: 3 }
         assigns(:reserve).user.should eq users(:user1)
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -248,12 +248,12 @@ describe ReservesController do
       it 'should not assign the requested reserve as @reserve' do
         get :new
         assigns(:reserve).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should get my new reservation' do
         get :new, params: { manifestation_id: 3 }
-        response.should be_success
+        response.should be_successful
       end
 
       it "should not get other user's new reservation" do
@@ -289,7 +289,7 @@ describe ReservesController do
 
       it "should edit other user's reservation" do
         get :edit, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -304,7 +304,7 @@ describe ReservesController do
 
       it 'should edit reserve without user_id' do
         get :edit, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -319,7 +319,7 @@ describe ReservesController do
 
       it 'should edit my reservation' do
         get :edit, params: { id: 3 }
-        response.should be_success
+        response.should be_successful
       end
 
       it "should not edit other user's reservation" do
@@ -369,14 +369,14 @@ describe ReservesController do
           post :create, params: { reserve: @invalid_attrs }
           assigns(:reserve).expired_at.should be_nil
           response.should render_template('new')
-          response.should be_success
+          response.should be_successful
         end
       end
 
       it 'should not create reservation with past date' do
         post :create, params: { reserve: { user_number: users(:user1).profile.user_number, manifestation_id: 5, expired_at: '1901-01-01' } }
         assigns(:reserve).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
 
       it "should create other user's reserve" do
@@ -387,13 +387,13 @@ describe ReservesController do
 
       it 'should not create reserve without manifestation_id' do
         post :create, params: { reserve: { user_number: users(:admin).profile.user_number } }
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should not create reserve with missing user_number' do
         post :create, params: { reserve: { user_number: 'missing', manifestation_id: 5 } }
         response.should render_template('new')
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -429,7 +429,7 @@ describe ReservesController do
           post :create, params: { reserve: @invalid_attrs }
           assigns(:reserve).expired_at.should be_nil
           response.should render_template('new')
-          response.should be_success
+          response.should be_successful
         end
       end
 
@@ -472,7 +472,7 @@ describe ReservesController do
           post :create, params: { reserve: @invalid_attrs }
           assigns(:reserve).expired_at.should be_nil
           response.should render_template('new')
-          response.should be_success
+          response.should be_successful
         end
       end
 
@@ -547,7 +547,7 @@ describe ReservesController do
       it 'should not update reserve without manifestation_id' do
         put :update, params: { id: 1, reserve: { user_number: users(:admin).profile.user_number, manifestation_id: nil } }
         assigns(:reserve).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
 
       it "should update other user's reservation without user_id" do
@@ -559,13 +559,13 @@ describe ReservesController do
       it 'should not update retained reservations if item_identifier is invalid' do
         put :update, params: { id: 14, reserve: { item_identifier: 'invalid' } }
         assigns(:reserve).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
 
       it 'should not update retained reservations if force_retaining is disabled' do
         put :update, params: { id: 15, reserve: { item_identifier: '00021' } }
         assigns(:reserve).should_not be_valid
-        response.should be_success
+        response.should be_successful
         assigns(:reserve).current_state.should eq 'requested'
         reserves(:reserve_00014).current_state.should eq 'retained'
       end