enju_bookmark 0.2.2 → 0.3.2

data/spec/controllers/tags_controller_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 describe TagsController do
   fixtures :all
 
-  describe "GET index", :solr => true do
+  describe "GET index", solr: true do
     before do
       Tag.reindex
     end
@@ -49,7 +49,7 @@ describe TagsController do
 
       it "assigns the requested tag as @tag" do
         tag = FactoryBot.create(:tag)
-        get :show, :id => tag.name
+        get :show, params: { id: tag.name }
         expect(assigns(:tag)).to eq(tag)
       end
     end
@@ -59,7 +59,7 @@ describe TagsController do
 
       it "assigns the requested tag as @tag" do
         tag = FactoryBot.create(:tag)
-        get :show, :id => tag.name
+        get :show, params: { id: tag.name }
         expect(assigns(:tag)).to eq(tag)
       end
     end
@@ -69,7 +69,7 @@ describe TagsController do
 
       it "assigns the requested tag as @tag" do
         tag = FactoryBot.create(:tag)
-        get :show, :id => tag.name
+        get :show, params: { id: tag.name }
         expect(assigns(:tag)).to eq(tag)
       end
     end
@@ -77,7 +77,7 @@ describe TagsController do
     describe "When not logged in" do
       it "assigns the requested tag as @tag" do
         tag = FactoryBot.create(:tag)
-        get :show, :id => tag.name
+        get :show, params: { id: tag.name }
         expect(assigns(:tag)).to eq(tag)
       end
     end
@@ -89,7 +89,7 @@ describe TagsController do
 
       it "assigns the requested tag as @tag" do
         tag = FactoryBot.create(:tag)
-        get :edit, :id => tag.name
+        get :edit, params: { id: tag.name }
         expect(assigns(:tag)).to eq(tag)
       end
     end
@@ -99,7 +99,7 @@ describe TagsController do
 
       it "assigns the requested tag as @tag" do
         tag = FactoryBot.create(:tag)
-        get :edit, :id => tag.name
+        get :edit, params: { id: tag.name }
         expect(assigns(:tag)).to eq(tag)
       end
     end
@@ -109,7 +109,7 @@ describe TagsController do
 
       it "assigns the requested tag as @tag" do
         tag = FactoryBot.create(:tag)
-        get :edit, :id => tag.name
+        get :edit, params: { id: tag.name }
         expect(response).to be_forbidden
       end
     end
@@ -117,7 +117,7 @@ describe TagsController do
     describe "When not logged in" do
       it "should not assign the requested tag as @tag" do
         tag = FactoryBot.create(:tag)
-        get :edit, :id => tag.name
+        get :edit, params: { id: tag.name }
         expect(response).to redirect_to(new_user_session_url)
       end
     end
@@ -127,7 +127,7 @@ describe TagsController do
     before(:each) do
       @tag = FactoryBot.create(:tag)
       @attrs = FactoryBot.attributes_for(:tag)
-      @invalid_attrs = {:name => ''}
+      @invalid_attrs = {name: ''}
     end
 
     describe "When logged in as Administrator" do
@@ -135,11 +135,11 @@ describe TagsController do
 
       describe "with valid params" do
         it "updates the requested tag" do
-          put :update, :id => @tag.name, :tag => @attrs
+          put :update, params: { id: @tag.name, tag: @attrs }
         end
 
         it "assigns the requested tag as @tag" do
-          put :update, :id => @tag.name, :tag => @attrs
+          put :update, params: { id: @tag.name, tag: @attrs }
           expect(assigns(:tag)).to eq(@tag)
           expect(response).to redirect_to(assigns(:tag))
         end
@@ -147,11 +147,11 @@ describe TagsController do
 
       describe "with invalid params" do
         it "assigns the requested tag as @tag" do
-          put :update, :id => @tag.name, :tag => @invalid_attrs
+          put :update, params: { id: @tag.name, tag: @invalid_attrs }
         end
 
         it "re-renders the 'edit' template" do
-          put :update, :id => @tag.name, :tag => @invalid_attrs
+          put :update, params: { id: @tag.name, tag: @invalid_attrs }
           expect(response).to render_template("edit")
         end
       end
@@ -162,11 +162,11 @@ describe TagsController do
 
       describe "with valid params" do
         it "updates the requested tag" do
-          put :update, :id => @tag.name, :tag => @attrs
+          put :update, params: { id: @tag.name, tag: @attrs }
         end
 
         it "assigns the requested tag as @tag" do
-          put :update, :id => @tag.name, :tag => @attrs
+          put :update, params: { id: @tag.name, tag: @attrs }
           expect(assigns(:tag)).to eq(@tag)
           expect(response).to redirect_to(assigns(:tag))
         end
@@ -174,12 +174,12 @@ describe TagsController do
 
       describe "with invalid params" do
         it "assigns the tag as @tag" do
-          put :update, :id => @tag.name, :tag => @invalid_attrs
+          put :update, params: { id: @tag.name, tag: @invalid_attrs }
           expect(assigns(:tag)).not_to be_valid
         end
 
         it "re-renders the 'edit' template" do
-          put :update, :id => @tag.name, :tag => @invalid_attrs
+          put :update, params: { id: @tag.name, tag: @invalid_attrs }
           expect(response).to render_template("edit")
         end
       end
@@ -190,11 +190,11 @@ describe TagsController do
 
       describe "with valid params" do
         it "updates the requested tag" do
-          put :update, :id => @tag.name, :tag => @attrs
+          put :update, params: { id: @tag.name, tag: @attrs }
         end
 
         it "assigns the requested tag as @tag" do
-          put :update, :id => @tag.name, :tag => @attrs
+          put :update, params: { id: @tag.name, tag: @attrs }
           expect(assigns(:tag)).to eq(@tag)
           expect(response).to be_forbidden
         end
@@ -202,7 +202,7 @@ describe TagsController do
 
       describe "with invalid params" do
         it "assigns the requested tag as @tag" do
-          put :update, :id => @tag.name, :tag => @invalid_attrs
+          put :update, params: { id: @tag.name, tag: @invalid_attrs }
           expect(response).to be_forbidden
         end
       end
@@ -211,18 +211,18 @@ describe TagsController do
     describe "When not logged in" do
       describe "with valid params" do
         it "updates the requested tag" do
-          put :update, :id => @tag.name, :tag => @attrs
+          put :update, params: { id: @tag.name, tag: @attrs }
         end
 
         it "should be forbidden" do
-          put :update, :id => @tag.name, :tag => @attrs
+          put :update, params: { id: @tag.name, tag: @attrs }
           expect(response).to redirect_to(new_user_session_url)
         end
       end
 
       describe "with invalid params" do
         it "assigns the requested tag as @tag" do
-          put :update, :id => @tag.name, :tag => @invalid_attrs
+          put :update, params: { id: @tag.name, tag: @invalid_attrs }
           expect(response).to redirect_to(new_user_session_url)
         end
       end
@@ -238,11 +238,11 @@ describe TagsController do
       login_fixture_admin
 
       it "destroys the requested tag" do
-        delete :destroy, :id => @tag.name
+        delete :destroy, params: { id: @tag.name }
       end
 
       it "redirects to the tags list" do
-        delete :destroy, :id => @tag.name
+        delete :destroy, params: { id: @tag.name }
         expect(response).to redirect_to(tags_url)
       end
     end
@@ -251,11 +251,11 @@ describe TagsController do
       login_fixture_librarian
 
       it "destroys the requested tag" do
-        delete :destroy, :id => @tag.name
+        delete :destroy, params: { id: @tag.name }
       end
 
       it "redirects to the tags list" do
-        delete :destroy, :id => @tag.name
+        delete :destroy, params: { id: @tag.name }
         expect(response).to redirect_to(tags_url)
       end
     end
@@ -264,22 +264,22 @@ describe TagsController do
       login_fixture_user
 
       it "destroys the requested tag" do
-        delete :destroy, :id => @tag.name
+        delete :destroy, params: { id: @tag.name }
       end
 
       it "should be forbidden" do
-        delete :destroy, :id => @tag.name
+        delete :destroy, params: { id: @tag.name }
         expect(response).to be_forbidden
       end
     end
 
     describe "When not logged in" do
       it "destroys the requested tag" do
-        delete :destroy, :id => @tag.name
+        delete :destroy, params: { id: @tag.name }
       end
 
       it "should be forbidden" do
-        delete :destroy, :id => @tag.name
+        delete :destroy, params: { id: @tag.name }
         expect(response).to redirect_to(new_user_session_url)
       end
     end

data/spec/dummy/app/models/application_record.rb

@@ -0,0 +1,3 @@
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end

data/spec/dummy/app/models/user.rb

@@ -1,7 +1,7 @@
 class User < ActiveRecord::Base
   devise :database_authenticatable, #:registerable,
     :recoverable, :rememberable, :trackable, #, :validatable
-    :lockable, :lock_strategy => :none, :unlock_strategy => :none
+    :lockable, lock_strategy: :none, unlock_strategy: :none
 
   include EnjuSeed::EnjuUser
   include EnjuBookmark::EnjuUser

data/spec/dummy/bin/rails

@@ -1,4 +1,4 @@
 #!/usr/bin/env ruby
-APP_PATH = File.expand_path('../../config/application', __FILE__)
+APP_PATH = File.expand_path('../config/application', __dir__)
 require_relative '../config/boot'
 require 'rails/commands'

data/spec/dummy/bin/setup

@@ -1,29 +1,38 @@
 #!/usr/bin/env ruby
 require 'pathname'
+require 'fileutils'
+include FileUtils
 
 # path to your application root.
-APP_ROOT = Pathname.new File.expand_path('../../',  __FILE__)
+APP_ROOT = Pathname.new File.expand_path('../../', __FILE__)
 
-Dir.chdir APP_ROOT do
+def system!(*args)
+  system(*args) || abort("\n== Command #{args} failed ==")
+end
+
+chdir APP_ROOT do
   # This script is a starting point to setup your application.
-  # Add necessary setup steps to this file:
+  # Add necessary setup steps to this file.
+
+  puts '== Installing dependencies =='
+  system! 'gem install bundler --conservative'
+  system('bundle check') || system!('bundle install')
+
+  # Install JavaScript dependencies if using Yarn
+  # system('bin/yarn')
 
-  puts "== Installing dependencies =="
-  system "gem install bundler --conservative"
-  system "bundle check || bundle install"
 
   # puts "\n== Copying sample files =="
-  # unless File.exist?("config/database.yml")
-  #   system "cp config/database.yml.sample config/database.yml"
+  # unless File.exist?('config/database.yml')
+  #   cp 'config/database.yml.sample', 'config/database.yml'
   # end
 
   puts "\n== Preparing database =="
-  system "bin/rake db:setup"
+  system! 'bin/rails db:setup'
 
   puts "\n== Removing old logs and tempfiles =="
-  system "rm -f log/*"
-  system "rm -rf tmp/cache"
+  system! 'bin/rails log:clear tmp:clear'
 
   puts "\n== Restarting application server =="
-  system "touch tmp/restart.txt"
+  system! 'bin/rails restart'
 end

data/spec/dummy/bin/update

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+require 'pathname'
+require 'fileutils'
+include FileUtils
+
+# path to your application root.
+APP_ROOT = Pathname.new File.expand_path('../../', __FILE__)
+
+def system!(*args)
+  system(*args) || abort("\n== Command #{args} failed ==")
+end
+
+chdir APP_ROOT do
+  # This script is a way to update your development environment automatically.
+  # Add necessary update steps to this file.
+
+  puts '== Installing dependencies =='
+  system! 'gem install bundler --conservative'
+  system('bundle check') || system!('bundle install')
+
+  puts "\n== Updating database =="
+  system! 'bin/rails db:migrate'
+
+  puts "\n== Removing old logs and tempfiles =="
+  system! 'bin/rails log:clear tmp:clear'
+
+  puts "\n== Restarting application server =="
+  system! 'bin/rails restart'
+end

data/spec/dummy/bin/yarn

@@ -0,0 +1,11 @@
+#!/usr/bin/env ruby
+VENDOR_PATH = File.expand_path('..', __dir__)
+Dir.chdir(VENDOR_PATH) do
+  begin
+    exec "yarnpkg #{ARGV.join(" ")}"
+  rescue Errno::ENOENT
+    $stderr.puts "Yarn executable was not detected in the system."
+    $stderr.puts "Download Yarn at https://yarnpkg.com/en/docs/install"
+    exit 1
+  end
+end

data/spec/dummy/config/application.rb

@@ -1,29 +1,19 @@
-require File.expand_path('../boot', __FILE__)
+require_relative 'boot'
 
 require 'rails/all'
 
 Bundler.require(*Rails.groups)
-require 'enju_bookmark'
-require 'enju_leaf'
-require 'globalize'
-require 'globalize-accessors'
+require "enju_bookmark"
+require "enju_leaf"
 
 module Dummy
   class Application < Rails::Application
+    # Initialize configuration defaults for originally generated Rails version.
+    config.load_defaults 5.2
+
     # Settings in config/environments/* take precedence over those specified here.
     # Application configuration should go into files in config/initializers
     # -- all .rb files in that directory are automatically loaded.
-
-    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
-    # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
-    # config.time_zone = 'Central Time (US & Canada)'
-
-    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
-    # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
-    # config.i18n.default_locale = :de
-
-    # Do not swallow errors in after_commit/after_rollback callbacks.
-    config.active_record.raise_in_transactional_callbacks = true
   end
 end
 

data/spec/dummy/config/boot.rb

@@ -1,10 +1,5 @@
-require 'rubygems'
-gemfile = ENV['BUNDLE_GEMFILE'] || File.expand_path('../../../../Gemfile', __FILE__)
+# Set up gems listed in the Gemfile.
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../Gemfile', __dir__)
 
-if File.exist?(gemfile)
-  ENV['BUNDLE_GEMFILE'] = gemfile
-  require 'bundler'
-  Bundler.setup
-end
-
-$:.unshift File.expand_path('../../../../lib', __FILE__)
+require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])
+$LOAD_PATH.unshift File.expand_path('../../../lib', __dir__)

data/spec/dummy/config/cable.yml

@@ -0,0 +1,10 @@
+development:
+  adapter: async
+
+test:
+  adapter: async
+
+production:
+  adapter: redis
+  url: redis://localhost:6379/1
+  channel_prefix: dummy_production

data/spec/dummy/config/database.yml

@@ -1,30 +1,25 @@
-sqlite: &sqlite
+# SQLite version 3.x
+#   gem install sqlite3
+#
+#   Ensure the SQLite 3 gem is defined in your Gemfile
+#   gem 'sqlite3'
+#
+default: &default
   adapter: sqlite3
-  database: db/<%= Rails.env %>.sqlite3
-
-mysql: &mysql
-  adapter: mysql2
-  username: root
-  password:
-  database: enju_<%= Rails.env %>
-
-postgresql: &postgresql
-  adapter: postgresql
-  username: postgres
-  password:
-  database: enju_<%= Rails.env %>
-
-defaults: &defaults
-  pool: 5
+  pool: <%= ENV.fetch("RAILS_MAX_THREADS") { 5 } %>
   timeout: 5000
-  host: localhost
-  <<: *<%= ENV['DB'] || "sqlite" %>
 
 development:
-  <<: *defaults
+  <<: *default
+  database: db/development.sqlite3
 
+# Warning: The database defined as "test" will be erased and
+# re-generated from your development database when you run "rake".
+# Do not set this db to the same as development or production.
 test:
-  <<: *defaults
+  <<: *default
+  database: db/test.sqlite3
 
 production:
-  <<: *defaults
+  <<: *default
+  database: db/production.sqlite3

data/spec/dummy/config/environment.rb

@@ -1,5 +1,5 @@
-# Load the rails application
-require File.expand_path('../application', __FILE__)
+# Load the Rails application.
+require_relative 'application'
 
-# Initialize the rails application
-Dummy::Application.initialize!
+# Initialize the Rails application.
+Rails.application.initialize!

data/spec/dummy/config/environments/development.rb

@@ -9,13 +9,28 @@ Rails.application.configure do
   # Do not eager load code on boot.
   config.eager_load = false
 
-  # Show full error reports and disable caching.
-  config.consider_all_requests_local       = true
-  config.action_controller.perform_caching = false
+  # Show full error reports.
+  config.consider_all_requests_local = true
+
+  # Enable/disable caching. By default caching is disabled.
+  if Rails.root.join('tmp/caching-dev.txt').exist?
+    config.action_controller.perform_caching = true
+
+    config.cache_store = :memory_store
+    config.public_file_server.headers = {
+      'Cache-Control' => "public, max-age=#{2.days.seconds.to_i}"
+    }
+  else
+    config.action_controller.perform_caching = false
+
+    config.cache_store = :null_store
+  end
 
   # Don't care if the mailer can't send.
   config.action_mailer.raise_delivery_errors = false
 
+  config.action_mailer.perform_caching = false
+
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log
 
@@ -27,15 +42,13 @@ Rails.application.configure do
   # number of complex assets.
   config.assets.debug = true
 
-  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
-  # yet still be able to expire them through the digest params.
-  config.assets.digest = true
-
-  # Adds additional error checking when serving assets at runtime.
-  # Checks for improperly declared sprockets dependencies.
-  # Raises helpful error messages.
-  config.assets.raise_runtime_errors = true
+  # Suppress logger output for asset requests.
+  config.assets.quiet = true
 
   # Raises error for missing translations
   # config.action_view.raise_on_missing_translations = true
+
+  # Use an evented file watcher to asynchronously detect changes in source code,
+  # routes, locales, etc. This feature depends on the listen gem.
+  # config.file_watcher = ActiveSupport::EventedFileUpdateChecker
 end

data/spec/dummy/config/environments/production.rb

@@ -14,15 +14,14 @@ Rails.application.configure do
   config.consider_all_requests_local       = false
   config.action_controller.perform_caching = true
 
-  # Enable Rack::Cache to put a simple HTTP cache in front of your application
-  # Add `rack-cache` to your Gemfile before enabling this.
-  # For large-scale production use, consider using a caching reverse proxy like
-  # NGINX, varnish or squid.
-  # config.action_dispatch.rack_cache = true
+  # Attempt to read encrypted secrets from `config/secrets.yml.enc`.
+  # Requires an encryption key in `ENV["RAILS_MASTER_KEY"]` or
+  # `config/secrets.yml.key`.
+  config.read_encrypted_secrets = true
 
   # Disable serving static files from the `/public` folder by default since
   # Apache or NGINX already handles this.
-  config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?
+  config.public_file_server.enabled = ENV['RAILS_SERVE_STATIC_FILES'].present?
 
   # Compress JavaScripts and CSS.
   config.assets.js_compressor = :uglifier
@@ -31,16 +30,20 @@ Rails.application.configure do
   # Do not fallback to assets pipeline if a precompiled asset is missed.
   config.assets.compile = false
 
-  # Asset digests allow you to set far-future HTTP expiration dates on all assets,
-  # yet still be able to expire them through the digest params.
-  config.assets.digest = true
-
   # `config.assets.precompile` and `config.assets.version` have moved to config/initializers/assets.rb
 
+  # Enable serving of images, stylesheets, and JavaScripts from an asset server.
+  # config.action_controller.asset_host = 'http://assets.example.com'
+
   # Specifies the header that your server uses for sending files.
   # config.action_dispatch.x_sendfile_header = 'X-Sendfile' # for Apache
   # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for NGINX
 
+  # Mount Action Cable outside main process or domain
+  # config.action_cable.mount_path = nil
+  # config.action_cable.url = 'wss://example.com/cable'
+  # config.action_cable.allowed_request_origins = [ 'http://example.com', /http:\/\/example.*/ ]
+
   # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
   # config.force_ssl = true
 
@@ -49,16 +52,15 @@ Rails.application.configure do
   config.log_level = :debug
 
   # Prepend all log lines with the following tags.
-  # config.log_tags = [ :subdomain, :uuid ]
-
-  # Use a different logger for distributed setups.
-  # config.logger = ActiveSupport::TaggedLogging.new(SyslogLogger.new)
+  config.log_tags = [ :request_id ]
 
   # Use a different cache store in production.
   # config.cache_store = :mem_cache_store
 
-  # Enable serving of images, stylesheets, and JavaScripts from an asset server.
-  # config.action_controller.asset_host = 'http://assets.example.com'
+  # Use a real queuing backend for Active Job (and separate queues per environment)
+  # config.active_job.queue_adapter     = :resque
+  # config.active_job.queue_name_prefix = "dummy_#{Rails.env}"
+  config.action_mailer.perform_caching = false
 
   # Ignore bad email addresses and do not raise email delivery errors.
   # Set this to true and configure the email server for immediate delivery to raise delivery errors.
@@ -74,6 +76,16 @@ Rails.application.configure do
   # Use default logging formatter so that PID and timestamp are not suppressed.
   config.log_formatter = ::Logger::Formatter.new
 
+  # Use a different logger for distributed setups.
+  # require 'syslog/logger'
+  # config.logger = ActiveSupport::TaggedLogging.new(Syslog::Logger.new 'app-name')
+
+  if ENV["RAILS_LOG_TO_STDOUT"].present?
+    logger           = ActiveSupport::Logger.new(STDOUT)
+    logger.formatter = config.log_formatter
+    config.logger    = ActiveSupport::TaggedLogging.new(logger)
+  end
+
   # Do not dump schema after migrations.
   config.active_record.dump_schema_after_migration = false
 end

data/spec/dummy/config/environments/test.rb

@@ -12,9 +12,11 @@ Rails.application.configure do
   # preloads Rails for running tests, you may have to set it to true.
   config.eager_load = false
 
-  # Configure static file server for tests with Cache-Control for performance.
-  config.serve_static_files   = true
-  config.static_cache_control = 'public, max-age=3600'
+  # Configure public file server for tests with Cache-Control for performance.
+  config.public_file_server.enabled = true
+  config.public_file_server.headers = {
+    'Cache-Control' => "public, max-age=#{1.hour.seconds.to_i}"
+  }
 
   # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
@@ -25,20 +27,16 @@ Rails.application.configure do
 
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false
+  config.action_mailer.perform_caching = false
 
   # Tell Action Mailer not to deliver emails to the real world.
   # The :test delivery method accumulates sent emails in the
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
-  # Randomize the order test cases are executed.
-  config.active_support.test_order = :random
-
   # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr
 
   # Raises error for missing translations
   # config.action_view.raise_on_missing_translations = true
-
-  config.action_mailer.default_url_options = {:host => 'localhost:3000'}
 end

data/spec/dummy/config/initializers/application_controller_renderer.rb

@@ -0,0 +1,8 @@
+# Be sure to restart your server when you modify this file.
+
+# ActiveSupport::Reloader.to_prepare do
+#   ApplicationController.renderer.defaults.merge!(
+#     http_host: 'example.org',
+#     https: false
+#   )
+# end