enju_biblio 0.3.9 → 0.3.11

data/spec/models/resource_import_file_spec.rb

@@ -9,7 +9,8 @@ describe ResourceImportFile do
         @file = ResourceImportFile.create(
           resource_import: File.new("#{Rails.root}/../../examples/resource_import_file_sample1.tsv"),
           default_shelf_id: 3,
-          user: users(:admin)
+          user: users(:admin),
+          edit_mode: 'create'
         )
       end
 
@@ -29,7 +30,7 @@ describe ResourceImportFile do
         Manifestation.count.should eq old_manifestations_count + 10
         Item.count.should eq old_items_count + 10
         Agent.count.should eq old_agents_count + 9
-        @file.resource_import_results.order(:id).first.body.split("\t").first.should eq 'manifestation_identifier'
+        @file.resource_import_results.order(:id).first.body.split("\t").first.should eq 'imported_manifestation_id'
         ResourceImportResult.count.should eq old_import_results_count + 23
 
         manifestation_101 = Manifestation.find_by(manifestation_identifier: '101')
@@ -156,6 +157,16 @@ describe ResourceImportFile do
         expect(manifestation.identifier_contents(:isbn)).to include("9784840239219")
         expect(manifestation.identifier_contents(:isbn)).to include("9784043898039")
       end
+
+      it "should import custom values", vcr: true do
+        @file.import_start
+        item_10102 = Item.find_by(item_identifier: '10102')
+        expect(item_10102.manifestation.manifestation_custom_values.pluck(:value)).to eq ['カスタム項目テスト1', 'カスタム項目テスト2']
+        expect(item_10102.item_custom_values.pluck(:value)).to eq []
+        item_10103 = Item.find_by(item_identifier: '10103')
+        expect(item_10103.manifestation.manifestation_custom_values.pluck(:value)).to eq ["カスタム項目テスト1", "カスタム項目テスト2"]
+        expect(item_10103.item_custom_values.pluck(:value)).to eq ['カスタム項目テスト3', 'カスタム項目テスト4']
+      end
     end
 
     describe "ISBN import" do
@@ -216,15 +227,15 @@ describe ResourceImportFile do
         old_items_count = Item.count
         old_agents_count = Agent.count
         old_import_results_count = ResourceImportResult.count
-        @file.import_start.should eq({manifestation_imported: 9, item_imported: 8, manifestation_found: 5, item_found: 3, failed: 7})
+        @file.import_start.should eq({manifestation_imported: 10, item_imported: 10, manifestation_found: 6, item_found: 3, failed: 7})
         manifestation = Item.find_by(item_identifier: '11111').manifestation
         manifestation.publishers.first.full_name.should eq 'test4'
         manifestation.publishers.first.full_name_transcription.should eq 'てすと4'
         manifestation.publishers.second.full_name_transcription.should eq 'てすと5'
-        Manifestation.count.should eq old_manifestations_count + 9
-        Item.count.should eq old_items_count + 8
+        Manifestation.count.should eq old_manifestations_count + 10
+        Item.count.should eq old_items_count + 10
         Agent.count.should eq old_agents_count + 9
-        ResourceImportResult.count.should eq old_import_results_count + 21
+        ResourceImportResult.count.should eq old_import_results_count + 23
         Item.find_by(item_identifier: '10101').manifestation.creators.size.should eq 2
         Item.find_by(item_identifier: '10101').manifestation.date_of_publication.should eq Time.zone.parse('2001-01-01')
         Item.find_by(item_identifier: '10102').manifestation.date_of_publication.should eq Time.zone.parse('2001-01-01')
@@ -335,20 +346,28 @@ resource_import_file_test_description	test\\ntest	test\\ntest	test_description	t
         expect(manifestation.items.first.note).to eq "test\ntest"
       end
     end
+
+    describe "when it contains custom properties" do
+      xit "should be imported" do
+      end
+    end
   end
 
   describe "when its mode is 'update'" do
-    it "should update items", vcr: true do
-      file = ResourceImportFile.create!(
+    before(:each) do
+      @file = ResourceImportFile.create!(
         resource_import: File.new("#{Rails.root}/../../examples/item_update_file.tsv"),
         user: users(:admin),
         edit_mode: 'update'
       )
-      file.modify
-      expect(file.resource_import_results.first).to be_truthy
-      expect(file.resource_import_results.first.body).to match /item_identifier/
+    end
+
+    it "should update items", vcr: true do
+      @file.modify
+      expect(@file.resource_import_results.first).to be_truthy
+      expect(@file.resource_import_results.first.body).to match /item_identifier/
       item_00001 = Item.find_by(item_identifier: '00001')
-      item_00001.manifestation.creators.order('agents.id').collect(&:full_name).should eq ['たなべ', 'こうすけ']
+      item_00001.manifestation.creators.order('agents.id').pluck(:full_name).should eq ['たなべ', 'こうすけ']
       item_00001.binding_item_identifier.should eq '900001'
       item_00001.binding_call_number.should eq '336|A'
       item_00001.binded_at.should eq Time.zone.parse('2014-08-16')
@@ -361,7 +380,18 @@ resource_import_file_test_description	test\\ntest	test\\ntest	test_description	t
       item_00003.include_supplements.should be_truthy
 
       Item.find_by(item_identifier: '00004').include_supplements.should be_falsy
-      Item.find_by(item_identifier: '00025').call_number.should eq "547|ヤ"
+
+      item_00025 = Item.find_by(item_identifier: '00025')
+      expect(item_00025.manifestation.original_title).to eq "テスト4"
+      expect(item_00025.manifestation.subjects.pluck(:term)).to eq ['test2', 'test3']
+      expect(item_00025.call_number).to eq "547|ヤ"
+    end
+
+    it "should update custom values", vcr: true do
+      @file.import_start
+      item_00001 = Item.find_by(item_identifier: '00001')
+      expect(item_00001.manifestation.manifestation_custom_values.pluck(:manifestation_custom_property_id, :value)).to eq [[2, "カスタム項目5"]]
+      expect(item_00001.item_custom_values.order(:item_custom_property_id).first.value).to eq "カスタム項目6"
     end
 
     # it "should update series_statement", vcr: true do

data/spec/requests/item_custom_properties_spec.rb

@@ -0,0 +1,129 @@
+ require 'rails_helper'
+
+# This spec was generated by rspec-rails when you ran the scaffold generator.
+# It demonstrates how one might use RSpec to test the controller code that
+# was generated by Rails when you ran the scaffold generator.
+#
+# It assumes that the implementation code is generated by the rails scaffold
+# generator. If you are using any extension libraries to generate different
+# controller code, this generated spec may or may not pass.
+#
+# It only uses APIs available in rails and/or rspec-rails. There are a number
+# of tools you can use to make these specs even more expressive, but we're
+# sticking to rails and rspec-rails APIs to keep things simple and stable.
+
+RSpec.describe "/item_custom_properties", type: :request do
+  # ItemCustomProperty. As you add validations to ItemCustomProperty, be sure to
+  # adjust the attributes here as well.
+  let(:valid_attributes) {
+    skip("Add a hash of attributes valid for your model")
+  }
+
+  let(:invalid_attributes) {
+    skip("Add a hash of attributes invalid for your model")
+  }
+
+  describe "GET /index" do
+    it "renders a successful response" do
+      ItemCustomProperty.create! valid_attributes
+      get item_custom_properties_url
+      response.status.should redirect_to(new_user_session_url)
+    end
+  end
+
+  describe "GET /show" do
+    it "renders a successful response" do
+      item_custom_property = ItemCustomProperty.create! valid_attributes
+      get item_custom_property_url(item_custom_property)
+      expect(response).to redirect_to(new_user_session_url)
+    end
+  end
+
+  describe "GET /new" do
+    it "renders a successful response" do
+      get new_item_custom_property_url
+      expect(response).to redirect_to(new_user_session_url)
+    end
+  end
+
+  describe "GET /edit" do
+    it "render a successful response" do
+      item_custom_property = ItemCustomProperty.create! valid_attributes
+      get edit_item_custom_property_url(item_custom_property)
+      expect(response).to redirect_to(new_user_session_url)
+    end
+  end
+
+  describe "POST /create" do
+    context "with valid parameters" do
+      it "creates a new ItemCustomProperty" do
+        expect {
+          post item_custom_properties_url, params: { item_custom_property: valid_attributes }
+        }.to change(ItemCustomProperty, :count).by(1)
+      end
+
+      it "redirects to the created item_custom_property" do
+        post item_custom_properties_url, params: { item_custom_property: valid_attributes }
+        expect(response).to redirect_to(item_custom_property_url(ItemCustomProperty.last))
+      end
+    end
+
+    context "with invalid parameters" do
+      it "does not create a new ItemCustomProperty" do
+        expect {
+          post item_custom_properties_url, params: { item_custom_property: invalid_attributes }
+        }.to change(ItemCustomProperty, :count).by(0)
+      end
+
+      it "renders a successful response (i.e. to display the 'new' template)" do
+        post item_custom_properties_url, params: { item_custom_property: invalid_attributes }
+        expect(response).to redirect_to(new_user_session_url)
+      end
+    end
+  end
+
+  describe "PATCH /update" do
+    context "with valid parameters" do
+      let(:new_attributes) {
+        skip("Add a hash of attributes valid for your model")
+      }
+
+      it "updates the requested item_custom_property" do
+        item_custom_property = ItemCustomProperty.create! valid_attributes
+        patch item_custom_property_url(item_custom_property), params: { item_custom_property: new_attributes }
+        item_custom_property.reload
+        skip("Add assertions for updated state")
+      end
+
+      it "redirects to the item_custom_property" do
+        item_custom_property = ItemCustomProperty.create! valid_attributes
+        patch item_custom_property_url(item_custom_property), params: { item_custom_property: new_attributes }
+        item_custom_property.reload
+        expect(response).to redirect_to(item_custom_property_url(item_custom_property))
+      end
+    end
+
+    context "with invalid parameters" do
+      it "renders a successful response (i.e. to display the 'edit' template)" do
+        item_custom_property = ItemCustomProperty.create! valid_attributes
+        patch item_custom_property_url(item_custom_property), params: { item_custom_property: invalid_attributes }
+        expect(response).to redirect_to(new_user_session_url)
+      end
+    end
+  end
+
+  describe "DELETE /destroy" do
+    it "destroys the requested item_custom_property" do
+      item_custom_property = ItemCustomProperty.create! valid_attributes
+      expect {
+        delete item_custom_property_url(item_custom_property)
+      }.to change(ItemCustomProperty, :count).by(-1)
+    end
+
+    it "redirects to the item_custom_properties list" do
+      item_custom_property = ItemCustomProperty.create! valid_attributes
+      delete item_custom_property_url(item_custom_property)
+      expect(response).to redirect_to(item_custom_properties_url)
+    end
+  end
+end

data/spec/requests/manifestation_custom_properties_spec.rb

@@ -0,0 +1,129 @@
+ require 'rails_helper'
+
+# This spec was generated by rspec-rails when you ran the scaffold generator.
+# It demonstrates how one might use RSpec to test the controller code that
+# was generated by Rails when you ran the scaffold generator.
+#
+# It assumes that the implementation code is generated by the rails scaffold
+# generator. If you are using any extension libraries to generate different
+# controller code, this generated spec may or may not pass.
+#
+# It only uses APIs available in rails and/or rspec-rails. There are a number
+# of tools you can use to make these specs even more expressive, but we're
+# sticking to rails and rspec-rails APIs to keep things simple and stable.
+
+RSpec.describe "/manifestation_custom_properties", type: :request do
+  # ManifestationCustomProperty. As you add validations to ManifestationCustomProperty, be sure to
+  # adjust the attributes here as well.
+  let(:valid_attributes) {
+    skip("Add a hash of attributes valid for your model")
+  }
+
+  let(:invalid_attributes) {
+    skip("Add a hash of attributes invalid for your model")
+  }
+
+  describe "GET /index" do
+    it "renders a successful response" do
+      ManifestationCustomProperty.create! valid_attributes
+      get manifestation_custom_properties_url
+      response.status.should redirect_to(new_user_session_url)
+    end
+  end
+
+  describe "GET /show" do
+    it "renders a successful response" do
+      manifestation_custom_property = ManifestationCustomProperty.create! valid_attributes
+      get manifestation_custom_property_url(manifestation_custom_property)
+      expect(response).to redirect_to(new_user_session_url)
+    end
+  end
+
+  describe "GET /new" do
+    it "renders a successful response" do
+      get new_manifestation_custom_property_url
+      expect(response).to redirect_to(new_user_session_url)
+    end
+  end
+
+  describe "GET /edit" do
+    it "render a successful response" do
+      manifestation_custom_property = ManifestationCustomProperty.create! valid_attributes
+      get edit_manifestation_custom_property_url(manifestation_custom_property)
+      expect(response).to redirect_to(new_user_session_url)
+    end
+  end
+
+  describe "POST /create" do
+    context "with valid parameters" do
+      it "creates a new ManifestationCustomProperty" do
+        expect {
+          post manifestation_custom_properties_url, params: { manifestation_custom_property: valid_attributes }
+        }.to change(ManifestationCustomProperty, :count).by(1)
+      end
+
+      it "redirects to the created manifestation_custom_property" do
+        post manifestation_custom_properties_url, params: { manifestation_custom_property: valid_attributes }
+        expect(response).to redirect_to(manifestation_custom_property_url(ManifestationCustomProperty.last))
+      end
+    end
+
+    context "with invalid parameters" do
+      it "does not create a new ManifestationCustomProperty" do
+        expect {
+          post manifestation_custom_properties_url, params: { manifestation_custom_property: invalid_attributes }
+        }.to change(ManifestationCustomProperty, :count).by(0)
+      end
+
+      it "renders a successful response (i.e. to display the 'new' template)" do
+        post manifestation_custom_properties_url, params: { manifestation_custom_property: invalid_attributes }
+        expect(response).to redirect_to(new_user_session_url)
+      end
+    end
+  end
+
+  describe "PATCH /update" do
+    context "with valid parameters" do
+      let(:new_attributes) {
+        skip("Add a hash of attributes valid for your model")
+      }
+
+      it "updates the requested manifestation_custom_property" do
+        manifestation_custom_property = ManifestationCustomProperty.create! valid_attributes
+        patch manifestation_custom_property_url(manifestation_custom_property), params: { manifestation_custom_property: new_attributes }
+        manifestation_custom_property.reload
+        skip("Add assertions for updated state")
+      end
+
+      it "redirects to the manifestation_custom_property" do
+        manifestation_custom_property = ManifestationCustomProperty.create! valid_attributes
+        patch manifestation_custom_property_url(manifestation_custom_property), params: { manifestation_custom_property: new_attributes }
+        manifestation_custom_property.reload
+        expect(response).to redirect_to(manifestation_custom_property_url(manifestation_custom_property))
+      end
+    end
+
+    context "with invalid parameters" do
+      it "renders a successful response (i.e. to display the 'edit' template)" do
+        manifestation_custom_property = ManifestationCustomProperty.create! valid_attributes
+        patch manifestation_custom_property_url(manifestation_custom_property), params: { manifestation_custom_property: invalid_attributes }
+        expect(response).to redirect_to(new_user_session_url)
+      end
+    end
+  end
+
+  describe "DELETE /destroy" do
+    it "destroys the requested manifestation_custom_property" do
+      manifestation_custom_property = ManifestationCustomProperty.create! valid_attributes
+      expect {
+        delete manifestation_custom_property_url(manifestation_custom_property)
+      }.to change(ManifestationCustomProperty, :count).by(-1)
+    end
+
+    it "redirects to the manifestation_custom_properties list" do
+      manifestation_custom_property = ManifestationCustomProperty.create! valid_attributes
+      delete manifestation_custom_property_url(manifestation_custom_property)
+      expect(response).to redirect_to(manifestation_custom_properties_url)
+    end
+  end
+end

data/spec/routing/item_custom_properties_routing_spec.rb

@@ -0,0 +1,38 @@
+require "rails_helper"
+
+RSpec.describe ItemCustomPropertiesController, type: :routing do
+  describe "routing" do
+    it "routes to #index" do
+      expect(get: "/item_custom_properties").to route_to("item_custom_properties#index")
+    end
+
+    it "routes to #new" do
+      expect(get: "/item_custom_properties/new").to route_to("item_custom_properties#new")
+    end
+
+    it "routes to #show" do
+      expect(get: "/item_custom_properties/1").to route_to("item_custom_properties#show", id: "1")
+    end
+
+    it "routes to #edit" do
+      expect(get: "/item_custom_properties/1/edit").to route_to("item_custom_properties#edit", id: "1")
+    end
+
+
+    it "routes to #create" do
+      expect(post: "/item_custom_properties").to route_to("item_custom_properties#create")
+    end
+
+    it "routes to #update via PUT" do
+      expect(put: "/item_custom_properties/1").to route_to("item_custom_properties#update", id: "1")
+    end
+
+    it "routes to #update via PATCH" do
+      expect(patch: "/item_custom_properties/1").to route_to("item_custom_properties#update", id: "1")
+    end
+
+    it "routes to #destroy" do
+      expect(delete: "/item_custom_properties/1").to route_to("item_custom_properties#destroy", id: "1")
+    end
+  end
+end

data/spec/routing/manifestation_custom_properties_routing_spec.rb

@@ -0,0 +1,38 @@
+require "rails_helper"
+
+RSpec.describe ManifestationCustomPropertiesController, type: :routing do
+  describe "routing" do
+    it "routes to #index" do
+      expect(get: "/manifestation_custom_properties").to route_to("manifestation_custom_properties#index")
+    end
+
+    it "routes to #new" do
+      expect(get: "/manifestation_custom_properties/new").to route_to("manifestation_custom_properties#new")
+    end
+
+    it "routes to #show" do
+      expect(get: "/manifestation_custom_properties/1").to route_to("manifestation_custom_properties#show", id: "1")
+    end
+
+    it "routes to #edit" do
+      expect(get: "/manifestation_custom_properties/1/edit").to route_to("manifestation_custom_properties#edit", id: "1")
+    end
+
+
+    it "routes to #create" do
+      expect(post: "/manifestation_custom_properties").to route_to("manifestation_custom_properties#create")
+    end
+
+    it "routes to #update via PUT" do
+      expect(put: "/manifestation_custom_properties/1").to route_to("manifestation_custom_properties#update", id: "1")
+    end
+
+    it "routes to #update via PATCH" do
+      expect(patch: "/manifestation_custom_properties/1").to route_to("manifestation_custom_properties#update", id: "1")
+    end
+
+    it "routes to #destroy" do
+      expect(delete: "/manifestation_custom_properties/1").to route_to("manifestation_custom_properties#destroy", id: "1")
+    end
+  end
+end

data/spec/system/items_spec.rb

@@ -39,6 +39,12 @@ RSpec.describe 'Manifestations', type: :system do
       visit item_path(@item.id, locale: :ja)
       expect(page).to have_content bookstore.name
     end
+
+    it 'should show custom properties' do
+      @item.item_custom_values << FactoryBot.build(:item_custom_value)
+      visit item_path(@item.id, locale: :ja)
+      expect(page).to have_content @item.item_custom_values.first.value
+    end
   end
 
   describe 'When logged in as User' do
@@ -71,6 +77,12 @@ RSpec.describe 'Manifestations', type: :system do
       visit item_path(@item.id, locale: :ja)
       expect(page).not_to have_content bookstore.name
     end
+
+    it 'should not show custom properties' do
+      @item.item_custom_values << FactoryBot.build(:item_custom_value)
+      visit item_path(@item.id, locale: :ja)
+      expect(page).not_to have_content @item.item_custom_values.first.value
+    end
   end
 
   describe 'When not logged in' do