enju_biblio 0.3.0.beta.2 → 0.3.0.rc.1

data/spec/controllers/owns_controller_spec.rb

@@ -96,7 +96,7 @@ describe OwnsController do
       it 'assigns the requested own as @own' do
         get :new
         expect(assigns(:own)).not_to be_valid
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -106,7 +106,7 @@ describe OwnsController do
       it 'assigns the requested own as @own' do
         get :new
         expect(assigns(:own)).not_to be_valid
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 

data/spec/controllers/resource_export_files_controller_spec.rb

@@ -48,7 +48,7 @@ describe ResourceExportFilesController do
       it 'assigns the requested resource_export_file as @resource_export_file' do
         get :show, params: { id: resource_export_files(:resource_export_file_00003).id }
         expect(assigns(:resource_export_file)).to eq(resource_export_files(:resource_export_file_00003))
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -58,7 +58,7 @@ describe ResourceExportFilesController do
       it 'assigns the requested resource_export_file as @resource_export_file' do
         get :show, params: { id: resource_export_files(:resource_export_file_00003).id }
         expect(assigns(:resource_export_file)).to eq(resource_export_files(:resource_export_file_00003))
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -88,7 +88,7 @@ describe ResourceExportFilesController do
       it 'assigns the requested resource_export_file as @resource_export_file' do
         get :new
         expect(assigns(:resource_export_file)).to be_valid
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -98,7 +98,7 @@ describe ResourceExportFilesController do
       it 'should not assign the requested resource_export_file as @resource_export_file' do
         get :new
         expect(assigns(:resource_export_file)).to be_valid
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 

data/spec/controllers/resource_import_files_controller_spec.rb

@@ -48,7 +48,7 @@ describe ResourceImportFilesController do
       it 'assigns the requested resource_import_file as @resource_import_file' do
         get :show, params: { id: resource_import_files(:resource_import_file_00003).id }
         expect(assigns(:resource_import_file)).to eq(resource_import_files(:resource_import_file_00003))
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -58,7 +58,7 @@ describe ResourceImportFilesController do
       it 'assigns the requested resource_import_file as @resource_import_file' do
         get :show, params: { id: resource_import_files(:resource_import_file_00003).id }
         expect(assigns(:resource_import_file)).to eq(resource_import_files(:resource_import_file_00003))
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -88,7 +88,7 @@ describe ResourceImportFilesController do
       it 'assigns the requested resource_import_file as @resource_import_file' do
         get :new
         expect(assigns(:resource_import_file)).not_to be_valid
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -98,7 +98,7 @@ describe ResourceImportFilesController do
       it 'should not assign the requested resource_import_file as @resource_import_file' do
         get :new
         expect(assigns(:resource_import_file)).not_to be_valid
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -139,7 +139,7 @@ describe ResourceImportFilesController do
         post :create, params: { resource_import_file: { resource_import: fixture_file_upload('/../../examples/resource_import_file_sample1.tsv', 'text/csv'), edit_mode: 'create' } }
         expect(assigns(:resource_import_file)).not_to be_valid
         assigns(:resource_import_file).user.username.should eq @user.username
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 

data/spec/controllers/series_statement_merges_controller_spec.rb

@@ -88,7 +88,7 @@ describe SeriesStatementMergesController do
       it 'assigns the requested series_statement_merge as @series_statement_merge' do
         get :new
         assigns(:series_statement_merge).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
     end
 
@@ -98,7 +98,7 @@ describe SeriesStatementMergesController do
       it 'assigns the requested series_statement_merge as @series_statement_merge' do
         get :new
         assigns(:series_statement_merge).should_not be_valid
-        response.should be_success
+        response.should be_successful
       end
     end
 

data/spec/controllers/series_statements_controller_spec.rb

@@ -55,7 +55,7 @@ describe SeriesStatementsController do
         series_statement = FactoryBot.create(:series_statement)
         get :show, params: { id: series_statement.id }
         expect(assigns(:series_statement)).to eq(series_statement)
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -66,7 +66,7 @@ describe SeriesStatementsController do
         series_statement = FactoryBot.create(:series_statement)
         get :show, params: { id: series_statement.id }
         expect(assigns(:series_statement)).to eq(series_statement)
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -77,7 +77,7 @@ describe SeriesStatementsController do
         series_statement = FactoryBot.create(:series_statement)
         get :show, params: { id: series_statement.id }
         expect(assigns(:series_statement)).to eq(series_statement)
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
 
@@ -86,7 +86,7 @@ describe SeriesStatementsController do
         series_statement = FactoryBot.create(:series_statement)
         get :show, params: { id: series_statement.id }
         expect(assigns(:series_statement)).to eq(series_statement)
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
   end

data/spec/dummy/app/helpers/application_helper.rb

@@ -3,7 +3,7 @@ module ApplicationHelper
   include EnjuLeaf::ApplicationHelper
   include EnjuBiblio::ApplicationHelper if defined?(EnjuBiblio)
   if defined?(EnjuManifestationViewer)
-    include EnjuManifestationViewer::BookJacketHelper
     include EnjuManifestationViewer::ManifestationViewerHelper
+    include EnjuManifestationViewer::BookJacketHelper
   end
 end

data/spec/dummy/config/application.rb

@@ -4,6 +4,7 @@ require 'rails/all'
 
 Bundler.require(*Rails.groups)
 require "enju_biblio"
+require "enju_leaf"
 require "enju_manifestation_viewer"
 require "enju_circulation"
 require "enju_ndl"

data/spec/dummy/db/migrate/002_devise_create_users.rb

@@ -33,7 +33,6 @@ class DeviseCreateUsers < ActiveRecord::Migration[4.2]
       ## Token authenticatable
       # t.string :authentication_token
 
-
       t.timestamps
     end
 

data/spec/dummy/db/migrate/033_create_checkouts.rb

@@ -14,7 +14,7 @@ class CreateCheckouts < ActiveRecord::Migration[4.2]
     add_index :checkouts, :user_id
     add_index :checkouts, :item_id
     add_index :checkouts, :basket_id
-    add_index :checkouts, [:item_id, :basket_id], unique: true
+    add_index :checkouts, %i[item_id basket_id], unique: true
     add_index :checkouts, :librarian_id
     add_index :checkouts, :checkin_id
   end

data/spec/dummy/db/migrate/20090831220301_create_lending_policies.rb

@@ -12,7 +12,7 @@ class CreateLendingPolicies < ActiveRecord::Migration[4.2]
 
       t.timestamps
     end
-    add_index :lending_policies, [:item_id, :user_group_id], unique: true
+    add_index :lending_policies, %i[item_id user_group_id], unique: true
   end
 
   def self.down

data/spec/dummy/db/migrate/20091202124834_create_versions.rb

@@ -8,11 +8,11 @@ class CreateVersions < ActiveRecord::Migration[4.2]
       t.text     :object
       t.datetime :created_at
     end
-    add_index :versions, [:item_type, :item_id]
+    add_index :versions, %i[item_type item_id]
   end
 
   def self.down
-    remove_index :versions, [:item_type, :item_id]
+    remove_index :versions, %i[item_type item_id]
     drop_table :versions
   end
 end

data/spec/dummy/db/migrate/20100525171356_acts_as_taggable_on_migration.rb

@@ -20,7 +20,7 @@ class ActsAsTaggableOnMigration < ActiveRecord::Migration[4.2]
     end
 
     add_index :taggings, :tag_id
-    add_index :taggings, [:taggable_id, :taggable_type, :context]
+    add_index :taggings, %i[taggable_id taggable_type context]
   end
 
   def self.down

data/spec/dummy/db/migrate/20120125050502_add_depth_to_message.rb

@@ -1,6 +1,5 @@
 class AddDepthToMessage < ActiveRecord::Migration[4.2]
   def change
     add_column :messages, :depth, :integer
-
   end
 end

data/spec/dummy/db/migrate/20130221154434_add_additional_attributes_to_user.rb

@@ -11,6 +11,6 @@ class AddAdditionalAttributesToUser < ActiveRecord::Migration[4.2]
     add_column :users, :confirmed_at, :datetime
 
     add_index :users, :username, unique: true
-    add_index :users, :unlock_token,         unique: true
+    add_index :users, :unlock_token, unique: true
   end
 end

data/spec/dummy/db/migrate/20140518050147_create_reserve_transitions.rb

@@ -13,6 +13,6 @@ class CreateReserveTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :reserve_transitions, :reserve_id
-    add_index :reserve_transitions, [:sort_key, :reserve_id], unique: true
+    add_index :reserve_transitions, %i[sort_key reserve_id], unique: true
   end
 end

data/spec/dummy/db/migrate/20140518111006_create_message_transitions.rb

@@ -13,6 +13,6 @@ class CreateMessageTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :message_transitions, :message_id
-    add_index :message_transitions, [:sort_key, :message_id], unique: true
+    add_index :message_transitions, %i[sort_key message_id], unique: true
   end
 end

data/spec/dummy/db/migrate/20140518135713_create_message_request_transitions.rb

@@ -13,6 +13,6 @@ class CreateMessageRequestTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :message_request_transitions, :message_request_id
-    add_index :message_request_transitions, [:sort_key, :message_request_id], unique: true, name: "index_message_request_transitions_on_sort_key_and_request_id"
+    add_index :message_request_transitions, %i[sort_key message_request_id], unique: true, name: "index_message_request_transitions_on_sort_key_and_request_id"
   end
 end

data/spec/dummy/db/migrate/20140523171309_create_event_import_file_transitions.rb

@@ -13,6 +13,6 @@ class CreateEventImportFileTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :event_import_file_transitions, :event_import_file_id
-    add_index :event_import_file_transitions, [:sort_key, :event_import_file_id], unique: true, name: "index_event_import_file_transitions_on_sort_key_and_file_id"
+    add_index :event_import_file_transitions, %i[sort_key event_import_file_id], unique: true, name: "index_event_import_file_transitions_on_sort_key_and_file_id"
   end
 end

data/spec/dummy/db/migrate/20140524074813_create_user_import_file_transitions.rb

@@ -12,6 +12,6 @@ class CreateUserImportFileTransitions < ActiveRecord::Migration[4.2]
       t.timestamps
     end
 
-    add_index :user_import_file_transitions, [:sort_key, :user_import_file_id], unique: true, name: "index_user_import_file_transitions_on_sort_key_and_file_id"
+    add_index :user_import_file_transitions, %i[sort_key user_import_file_id], unique: true, name: "index_user_import_file_transitions_on_sort_key_and_file_id"
   end
 end

data/spec/dummy/db/migrate/20140524135607_create_bookmark_stat_transitions.rb

@@ -13,6 +13,6 @@ class CreateBookmarkStatTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :bookmark_stat_transitions, :bookmark_stat_id
-    add_index :bookmark_stat_transitions, [:sort_key, :bookmark_stat_id], unique: true, name: "index_bookmark_stat_transitions_on_sort_key_and_stat_id"
+    add_index :bookmark_stat_transitions, %i[sort_key bookmark_stat_id], unique: true, name: "index_bookmark_stat_transitions_on_sort_key_and_stat_id"
   end
 end

data/spec/dummy/db/migrate/20140528045518_create_user_checkout_stat_transitions.rb

@@ -13,6 +13,6 @@ class CreateUserCheckoutStatTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :user_checkout_stat_transitions, :user_checkout_stat_id
-    add_index :user_checkout_stat_transitions, [:sort_key, :user_checkout_stat_id], unique: true, name: "index_user_checkout_stat_transitions_on_sort_key_and_stat_id"
+    add_index :user_checkout_stat_transitions, %i[sort_key user_checkout_stat_id], unique: true, name: "index_user_checkout_stat_transitions_on_sort_key_and_stat_id"
   end
 end

data/spec/dummy/db/migrate/20140528045539_create_user_reserve_stat_transitions.rb

@@ -13,6 +13,6 @@ class CreateUserReserveStatTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :user_reserve_stat_transitions, :user_reserve_stat_id
-    add_index :user_reserve_stat_transitions, [:sort_key, :user_reserve_stat_id], unique: true, name: "index_user_reserve_stat_transitions_on_sort_key_and_stat_id"
+    add_index :user_reserve_stat_transitions, %i[sort_key user_reserve_stat_id], unique: true, name: "index_user_reserve_stat_transitions_on_sort_key_and_stat_id"
   end
 end

data/spec/dummy/db/migrate/20140528045600_create_manifestation_checkout_stat_transitions.rb

@@ -13,6 +13,6 @@ class CreateManifestationCheckoutStatTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :manifestation_checkout_stat_transitions, :manifestation_checkout_stat_id, name: "index_manifestation_checkout_stat_transitions_on_stat_id"
-    add_index :manifestation_checkout_stat_transitions, [:sort_key, :manifestation_checkout_stat_id], unique: true, name: "index_manifestation_checkout_stat_transitions_on_transition"
+    add_index :manifestation_checkout_stat_transitions, %i[sort_key manifestation_checkout_stat_id], unique: true, name: "index_manifestation_checkout_stat_transitions_on_transition"
   end
 end

data/spec/dummy/db/migrate/20140528045617_create_manifestation_reserve_stat_transitions.rb

@@ -13,6 +13,6 @@ class CreateManifestationReserveStatTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :manifestation_reserve_stat_transitions, :manifestation_reserve_stat_id, name: "index_manifestation_reserve_stat_transitions_on_stat_id"
-    add_index :manifestation_reserve_stat_transitions, [:sort_key, :manifestation_reserve_stat_id], unique: true, name: "index_manifestation_reserve_stat_transitions_on_transition"
+    add_index :manifestation_reserve_stat_transitions, %i[sort_key manifestation_reserve_stat_id], unique: true, name: "index_manifestation_reserve_stat_transitions_on_transition"
   end
 end

data/spec/dummy/db/migrate/20140709113905_create_user_export_file_transitions.rb

@@ -13,6 +13,6 @@ class CreateUserExportFileTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :user_export_file_transitions, :user_export_file_id, name: "index_user_export_file_transitions_on_file_id"
-    add_index :user_export_file_transitions, [:sort_key, :user_export_file_id], unique: true, name: "index_user_export_file_transitions_on_sort_key_and_file_id"
+    add_index :user_export_file_transitions, %i[sort_key user_export_file_id], unique: true, name: "index_user_export_file_transitions_on_sort_key_and_file_id"
   end
 end

data/spec/dummy/db/migrate/20140812153137_create_event_export_file_transitions.rb

@@ -13,6 +13,6 @@ class CreateEventExportFileTransitions < ActiveRecord::Migration[4.2]
     end
 
     add_index :event_export_file_transitions, :event_export_file_id, name: "index_event_export_file_transitions_on_file_id"
-    add_index :event_export_file_transitions, [:sort_key, :event_export_file_id], unique: true, name: "index_event_export_file_transitions_on_sort_key_and_file_id"
+    add_index :event_export_file_transitions, %i[sort_key event_export_file_id], unique: true, name: "index_event_export_file_transitions_on_sort_key_and_file_id"
   end
 end

data/spec/dummy/db/migrate/20151213070943_add_translation_table_to_library_group.rb

@@ -3,10 +3,9 @@ class AddTranslationTableToLibraryGroup < ActiveRecord::Migration[4.2]
   def up
     if defined?(Globalize)
       LibraryGroup.create_translation_table!({
-        login_banner: :text
-      }, {
-        migrate_data: true
-      })
+                                               login_banner: :text
+                                             },
+                                             migrate_data: true)
     end
 
     if defined?(AwesomeHstoreTranslate)

data/spec/dummy/db/migrate/20180107160726_add_constraints_to_most_recent_for_user_import_file_transitions.rb

@@ -2,7 +2,7 @@ class AddConstraintsToMostRecentForUserImportFileTransitions < ActiveRecord::Mig
   disable_ddl_transaction!
 
   def up
-    add_index :user_import_file_transitions, [:user_import_file_id, :most_recent], unique: true, where: "most_recent", name: "index_user_import_file_transitions_parent_most_recent" #, algorithm: :concurrently
+    add_index :user_import_file_transitions, %i[user_import_file_id most_recent], unique: true, where: "most_recent", name: "index_user_import_file_transitions_parent_most_recent" # , algorithm: :concurrently
     change_column_null :user_import_file_transitions, :most_recent, false
   end
 

data/spec/dummy/db/migrate/20180107160740_add_constraints_to_most_recent_for_user_export_file_transitions.rb

@@ -2,7 +2,7 @@ class AddConstraintsToMostRecentForUserExportFileTransitions < ActiveRecord::Mig
   disable_ddl_transaction!
 
   def up
-    add_index :user_export_file_transitions, [:user_export_file_id, :most_recent], unique: true, where: "most_recent", name: "index_user_export_file_transitions_parent_most_recent" #, algorithm: :concurrently
+    add_index :user_export_file_transitions, %i[user_export_file_id most_recent], unique: true, where: "most_recent", name: "index_user_export_file_transitions_parent_most_recent" # , algorithm: :concurrently
     change_column_null :user_export_file_transitions, :most_recent, false
   end
 

data/spec/factories/checkout.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :checkout, class: Checkout do |f|
-    f.due_date Time.zone.now.next_week
+    f.due_date { Time.zone.now.next_week }
     f.association :item, factory: :item
     f.association :user, factory: :user
     f.association :librarian, factory: :librarian

data/spec/factories/create_types.rb

@@ -2,9 +2,9 @@
 
 FactoryBot.define do
   factory :create_type do
-    name "mystring"
-    display_name "MyText"
-    note "MyText"
+    name { "mystring" }
+    display_name { "MyText" }
+    note { "MyText" }
   end
 end
 

data/spec/factories/produce_types.rb

@@ -2,9 +2,9 @@
 
 FactoryBot.define do
   factory :produce_type do
-    name "mystring"
-    display_name "MyText"
-    note "MyText"
+    name { "mystring" }
+    display_name { "MyText" }
+    note { "MyText" }
   end
 end
 

data/spec/factories/profile.rb

@@ -3,8 +3,8 @@ FactoryBot.define do
     f.user_group_id {UserGroup.first.id}
     f.required_role_id {Role.where(name: 'User').first.id}
     f.sequence(:user_number){|n| "user_number_#{n}"}
-    f.library_id 2
-    f.locale "ja"
+    f.library_id { 2 }
+    f.locale { "ja" }
     f.user_id {FactoryBot.create(:user).id}
   end
 end

data/spec/factories/realize_types.rb

@@ -2,9 +2,9 @@
 
 FactoryBot.define do
   factory :realize_type do
-    name "mystring"
-    display_name "MyText"
-    note "MyText"
+    name { "mystring" }
+    display_name { "MyText" }
+    note { "MyText" }
   end
 end