enhanced_errors 2.0.3 → 2.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e2de1d0aba8d7c6c9d2749315f47f06f78c512adefb7aa4177cf42943823827
-  data.tar.gz: 9afab2c281e0d7ef2e1e36c3329446f0b2fec46fa1534c3f562ca6f18bf465f2
+  metadata.gz: 3897d29e868998ef225633f9f0f0f99a994b55563d65bff843ade348e7229bb9
+  data.tar.gz: 37f1db45f0c18c64846d396088f71bab2312b89da1a375b4d325309832983efc
 SHA512:
-  metadata.gz: 6b500dc5833a15bb7e40998ba6574ae5c2cc1dda5f58c57f020cc3b30bd61d4d174b86744bcca5bde0146183ab5ad7693a4df8dabd863a7eea48b6f23ed5f29d
-  data.tar.gz: ed1841c47b7eea81e7fda7d462b47f15b9f10426a0224601551a81c18cbb88ff1cf0a0a60ea073d9f83e9e0df2d174bf2c4f90608d39574b9afe1fa359d5f69d
+  metadata.gz: b156387888d9479f5d474808a922127fbfc5c6ed7035c6d8ef552dabca39b550655e191bfc6f0f11d64db36ded66fe03619cca7eaff2f5b725abb3d106f07d87
+  data.tar.gz: ce0fcadb20a8be1f0b53921cf990e5c458ce6ba1099dc5b9ceff1c8459ab82b707234bfbf964b10036a5b37a33b0248337d0289005b0f32c61933efa25ef44de

data/.yardoc/checksums

@@ -1,4 +1,4 @@
-lib/enhanced/colors.rb 4fdbc5803b62201392c6a2ee46c5012a6f79685e
-lib/enhanced_errors.rb 9572612271c977a4063fab6a9c9bee75198e9166
-lib/enhanced/exception.rb 72c62e85ce9cea875bc3e835240059bbf1b00f0b
-lib/enhanced/integrations/rspec_error_failure_message.rb 3404247ebb2c7cf6b7dc9abb215c59c46a041cee
+lib/colors.rb a4314ef9531d4713907c3fea22955c943fdb8cf3
+lib/binding.rb fdd7d5a2dd2edde22e3b10773510738dcdce4aeb
+lib/enhanced_errors.rb d12ce0629f2565e5179ae5076be8a495e19ecda2
+lib/error_enhancements.rb a97d0f139d35f6e1b5bf49386271b1f4cf71761c

data/enhanced_errors.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name = "enhanced_errors"
-  spec.version = "2.0.3"
+  spec.version = "2.0.5"
   spec.authors = ["Eric Beland"]
 
   spec.summary = "Automatically enhance your errors with messages containing variable values from the moment they were raised."

data/lib/enhanced/colors.rb

@@ -1,6 +1,7 @@
 module Enhanced
   class Colors
-    COLORS = { red: 31, green: 32, yellow: 33, blue: 34, purple: 35, cyan: 36, white: 0 }
+    COLORS = { red: 31, green: 32, yellow: 33, blue: 34, purple: 35, cyan: 36, white: 0 }.freeze
+    RESET_CODE = "\e[0m".freeze
 
     class << self
       def enabled?
@@ -12,11 +13,12 @@ module Enhanced
       end
 
       def color(num, string)
-        @enabled ? "#{code(num)}#{string}#{code(0)}" : string
+        return string unless @enabled
+        "#{code(num)}#{string}#{RESET_CODE}"
       end
 
       def code(num)
-        "\e[#{num}m"
+        "\e[#{num}m".freeze
       end
 
       COLORS.each do |color, code|

data/lib/enhanced_errors.rb

@@ -12,7 +12,6 @@ IGNORED_EXCEPTIONS = %w[SystemExit NoMemoryError SignalException Interrupt
                         RSpec::Matchers::BuiltIn::RaiseError
                         SystemStackError Psych::BadAlias]
 
-
 class EnhancedErrors
   extend ::Enhanced
 
@@ -22,17 +21,19 @@ class EnhancedErrors
                   :override_messages
 
     GEMS_REGEX = %r{[\/\\]gems[\/\\]}
-    DEFAULT_MAX_LENGTH = 3000
+    RSPEC_EXAMPLE_REGEXP = /RSpec::ExampleGroups::[A-Z0-9]+.*/
+    DEFAULT_MAX_LENGTH = 2000
 
     # Maximum binding infos we will track per-exception instance. This is intended as an extra
     # safety rail, not a normal scenario.
-    MAX_BINDING_INFOS = 10
+    MAX_BINDING_INFOS = 3
 
     # Add @__memoized and @__inspect_output to the skip list so they don't appear in output
     RSPEC_SKIP_LIST = Set.new([
                                 :@assertions,
                                 :@integration_session,
                                 :@example,
+                                :@assertion_delegator,
                                 :@fixture_cache,
                                 :@fixture_cache_key,
                                 :@fixture_connections,
@@ -45,7 +46,7 @@ class EnhancedErrors
                                 :@matcher_definitions,
                                 :@__memoized,
                                 :@__inspect_output
-                              ])
+                              ]).freeze
 
     RAILS_SKIP_LIST = Set.new([
                                 :@new_record,
@@ -53,8 +54,11 @@ class EnhancedErrors
                                 :@association_cache,
                                 :@readonly,
                                 :@previously_new_record,
-                                :@routes, # usually just shows #<ActionDispatch::Routing::RouteSet:0x000000016087d708>
+                                :@_routes, # usually just shows #<ActionDispatch::Routing::RouteSet:0x000000016087d708>
+                                :@routes,
+                                :@app,
                                 :@destroyed,
+                                :@response, #usually big, gets truncated anyway
                                 :@marked_for_destruction,
                                 :@destroyed_by_association,
                                 :@primary_key,
@@ -63,13 +67,16 @@ class EnhancedErrors
                                 :@strict_loading_mode,
                                 :@mutations_before_last_save,
                                 :@mutations_from_database,
+                                :@integration_session,
                                 :@relation_delegate_cache,
                                 :@predicate_builder,
                                 :@generated_relation_method,
                                 :@find_by_statement_cache,
                                 :@arel_table,
                                 :@response_klass,
-                              ])
+                              ]).freeze
+
+    DEFAULT_SKIP_LIST = (RAILS_SKIP_LIST + RSPEC_SKIP_LIST).freeze
 
     @enabled = false
 
@@ -92,11 +99,7 @@ class EnhancedErrors
     end
 
     def skip_list
-      @skip_list ||= default_skip_list
-    end
-
-    def default_skip_list
-      Set.new(RAILS_SKIP_LIST).merge(RSPEC_SKIP_LIST)
+      @skip_list ||= DEFAULT_SKIP_LIST.dup
     end
 
     # takes an exception and bindings, calculates the variables message
@@ -125,21 +128,19 @@ class EnhancedErrors
       @original_global_variables = nil
       @override_messages = override_messages
 
-      if enabled == false
+      if !enabled
         @original_global_variables = nil
         @enabled = false
         @trace&.disable
-        @trace = nil
       else
         # if there's an old one, disable it before replacing it
         # this seems to actually matter, although it seems like it
         # shouldn't
         @trace&.disable
-        @trace = nil
 
         @enabled = true
         @debug = debug
-        @original_global_variables = global_variables
+        @original_global_variables = global_variables if @debug
 
         options.each do |key, value|
           setter_method = "#{key}="
@@ -177,16 +178,15 @@ class EnhancedErrors
 
     def safely_prepend_rspec_custom_failure_message
       return if @rspec_failure_message_loaded
-      if defined?(RSpec::Core::Example)
+      if defined?(RSpec::Core::Example) && !RSpec::Core::Example < Enhanced::Integrations::RSpecErrorFailureMessage
         RSpec::Core::Example.prepend(Enhanced::Integrations::RSpecErrorFailureMessage)
         @rspec_failure_message_loaded = true
-      else
-
       end
     rescue => e
-      puts "Failed "
+      puts "Failed to prepend RSpec custom failure message: #{e.message}"
     end
 
+
     def start_rspec_binding_capture
       @rspec_example_binding = nil
 
@@ -194,27 +194,25 @@ class EnhancedErrors
       # the tracepoint without disabling it seemed to accumulate traces
       # in the test suite where things are disabled and re-enabled often.
       @rspec_tracepoint&.disable
-      @rspec_tracepoint = nil
 
       @rspec_tracepoint = TracePoint.new(:b_return) do |tp|
         # This is super-kluge-y and should be replaced with... something TBD
 
-        # fixes cases where class and name are screwed up or overridden
-        name = determine_object_name(tp)
-
-        if name =~ /RSpec::ExampleGroups::[A-Z0-9]+.*/ &&
-           tp.method_id.nil? &&
-           !(tp.path.to_s =~ /rspec/) &&
-           tp.path.to_s =~ /_spec\.rb$/
-          @rspec_example_binding = tp.binding
+        # early easy checks to nope out of the object name and other checks
+        if tp.method_id.nil? && !(tp.path.include?('rspec')) && tp.path.end_with?('_spec.rb')
+         # fixes cases where class and name are screwed up or overridden
+          if determine_object_name(tp) =~ RSPEC_EXAMPLE_REGEXP
+            @rspec_example_binding = tp.binding
+          end
         end
+
       end
+
       @rspec_tracepoint.enable
     end
 
     def stop_rspec_binding_capture
       @rspec_tracepoint&.disable
-      @rspec_tracepoint = nil
       binding_info = convert_binding_to_binding_info(@rspec_example_binding) if @rspec_example_binding
       @rspec_example_binding = nil
       binding_info
@@ -261,8 +259,7 @@ class EnhancedErrors
 
       # Apply skip list to remove @__memoized and @__inspect_output from output
       # but only after extracting let variables.
-      binding_info = default_on_capture(binding_info)
-      binding_info
+      default_on_capture(binding_info)
     end
 
     def eligible_for_capture(&block)
@@ -358,12 +355,11 @@ class EnhancedErrors
     end
 
     def apply_skip_list(binding_info)
-      unless @debug
-        variables = binding_info[:variables]
-        variables[:instances]&.reject! { |var, _| skip_list.include?(var) || (var.to_s.start_with?('@_') && !@debug) }
-        variables[:locals]&.reject! { |var, _| skip_list.include?(var) }
-        variables[:globals]&.reject! { |var, _| skip_list.include?(var) }
-      end
+      variables = binding_info[:variables]
+      variables[:instances]&.reject! { |var, _| skip_list.include?(var) || (var.to_s.start_with?('@_') && !@debug) }
+      variables[:locals]&.reject! { |var, _| skip_list.include?(var) }
+      return binding_info unless @debug
+      variables[:globals]&.reject! { |var, _| skip_list.include?(var) }
       binding_info
     end
 
@@ -394,7 +390,7 @@ class EnhancedErrors
 
       instance_vars_to_display = variables[:instances] || {}
 
-      if instance_vars_to_display && !instance_vars_to_display.empty?
+      unless instance_vars_to_display.empty?
         result += "\n#{Colors.green('Instances:')}\n#{variable_description(instance_vars_to_display)}"
       end
 
@@ -520,11 +516,12 @@ class EnhancedErrors
     end
 
     def default_capture_events
+      return @default_capture_events if @default_capture_events
       events = [:raise]
       if capture_rescue && Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.3.0')
         events << :rescue
       end
-      Set.new(events)
+      @default_capture_events = events
     end
 
     def validate_and_set_capture_events(capture_events)
@@ -647,15 +644,20 @@ class EnhancedErrors
     end
 
     def safe_inspect(variable)
-      variable.inspect
+      str = variable.inspect
+      if str.length > 1200
+        str[0...1200] + '...'
+      else
+        str
+      end
     rescue
       safe_to_s(variable)
     end
 
     def safe_to_s(variable)
       str = variable.to_s
-      if str.length > 140
-        str[0...140] + '...'
+      if str.length > 120
+        str[0...120] + '...'
       else
         str
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: enhanced_errors
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.5
 platform: ruby
 authors:
 - Eric Beland
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-10 00:00:00.000000000 Z
+date: 2024-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: awesome_print