enhanced_errors 2.0.2 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 70b9bd7350206b35123f8475f484f039214a2ce13003fbd1c94988e7aa1d0c84
-  data.tar.gz: 57f683a995c2347284943370445ae0d6a32c6e1e15457cbd82758e67bbd1567d
+  metadata.gz: a8930564c886592e2009e80692afc91e246a3568c5aa3014cc8c75cc9707ab79
+  data.tar.gz: 50f4106e4f94eaaadde9a0e1a1ef3f6783863edfbba7a40a95453c3fb82b6f9d
 SHA512:
-  metadata.gz: 34c46fe729c5e7c8b28a15a174c7175502df28949eb079344582582a5b7c26203f052aab55e05e4197a12b084de82a93017dfb01fdd3f7dfae7cec846b5ad127
-  data.tar.gz: 0cb2a347a54e18538f6dbb26c596d3b20e50bfd2b1cbd67c2eff9c0a64ac5297cef2276c2453e9ed4668f44ddc7f2ce1613894c84c0d726654dc2354bdf46a42
+  metadata.gz: c1e15a12dc7fe9823160a57d989fc281dd53bdbdfac17dc249be8f6e821c44cf2c089c1c7414b42245dc9be2c63ff98efb723ef26cb63550d019f8d48e7457d0
+  data.tar.gz: cda1322bd0d6371ed9f12a7faf165dfd4f838387b98c1d34c22c03c89534e5b2de4570894d941ef22c7019278cad0ee569984e6abc6632403e563051044acbcb

data/enhanced_errors.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name = "enhanced_errors"
-  spec.version = "2.0.2"
+  spec.version = "2.0.4"
   spec.authors = ["Eric Beland"]
 
   spec.summary = "Automatically enhance your errors with messages containing variable values from the moment they were raised."

data/lib/enhanced_errors.rb

@@ -199,16 +199,16 @@ class EnhancedErrors
       @rspec_tracepoint = TracePoint.new(:b_return) do |tp|
         # This is super-kluge-y and should be replaced with... something TBD
 
-        # fixes cases where class and name are screwed up or overridden
-        name = determine_object_name(tp)
-
-        if name =~ /RSpec::ExampleGroups::[A-Z0-9]+.*/ &&
-           tp.method_id.nil? &&
-           !(tp.path.to_s =~ /rspec/) &&
-           tp.path.to_s =~ /_spec\.rb$/
-          @rspec_example_binding = tp.binding
+        # early easy checks to nope out of the object name and other checks
+        if tp.method_id.nil? && !(tp.path.to_s =~ /rspec/) && tp.path.to_s =~ /_spec\.rb$/
+         # fixes cases where class and name are screwed up or overridden
+          if determine_object_name(tp) =~ /RSpec::ExampleGroups::[A-Z0-9]+.*/ &&
+            @rspec_example_binding = tp.binding
+          end
         end
+
       end
+
       @rspec_tracepoint.enable
     end
 
@@ -580,17 +580,29 @@ class EnhancedErrors
     end
 
     def determine_object_name(tp, method_name = '')
-      if tp.self&.is_a?(Class) && tp.self&.singleton_class == tp.defined_class
-        object_identifier = safe_to_s(tp.self)
-        method_suffix = method_name && !method_name.empty? ? ".#{method_name}" : ""
-        "#{object_identifier}#{method_suffix}"
-      else
-        object_class_name = safe_to_s(tp.self&.class&.name || 'UnknownClass')
-        method_suffix = method_name && !method_name.empty? ? "##{method_name}" : ""
-        "#{object_class_name}#{method_suffix}"
+      begin
+        # These tricks are used to get around the fact that `tp.self` can be a class that is
+        # wired up with method_missing where every direct call alters the class. This is true
+        # on certain builders or config objects and caused problems.
+
+        # Directly bind and call the `class` method to avoid triggering `method_missing`
+        self_class = Object.instance_method(:class).bind(tp.self).call
+
+        # Similarly, bind and call `singleton_class` safely
+        singleton_class = Object.instance_method(:singleton_class).bind(tp.self).call
+
+        if self_class && tp.defined_class == singleton_class
+          object_identifier = safe_to_s(tp.self)
+          method_suffix = method_name && !method_name.empty? ? ".#{method_name}" : ""
+          "#{object_identifier}#{method_suffix}"
+        else
+          object_class_name = safe_to_s(self_class.name || 'UnknownClass')
+          method_suffix = method_name && !method_name.empty? ? "##{method_name}" : ""
+          "#{object_class_name}#{method_suffix}"
+        end
+      rescue Exception => e
+        '[ErrorGettingName]'
       end
-    rescue Exception => e
-      '[ErrorGettingName]'
     end
 
     def get_global_variable_value(var)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: enhanced_errors
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.0.4
 platform: ruby
 authors:
 - Eric Beland