engineyard-serverside 2.6.16 → 2.6.17

data/spec/platform_configure_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe "Deploying an application with platform configure command" do
+  describe "configure script does not exist" do
+    before do
+      @releases_failed = deploy_dir.join('releases_failed')
+      deploy_test_application('default')
+    end
+
+    it "works without warning" do
+      expect(read_output).not_to match(/WARNING/)
+
+      expect(@releases_failed).not_to exist
+    end
+  end
+
+  describe "a succesful deploy" do
+    before do
+      @releases_failed = deploy_dir.join('releases_failed')
+      ENV['EY_SERVERSIDE_CONFIGURE_COMMAND'] = "echo platform_configure_command_ran >&2"
+      deploy_test_application('default')
+    end
+
+    after do
+      ENV.delete('EY_SERVERSIDE_CONFIGURE_COMMAND')
+    end
+
+    it "runs the configure_command during deploy and finishes successfully" do
+      expect(read_output).to match(/platform_configure_command_ran/)
+
+      expect(@releases_failed).not_to exist
+
+      restart = deploy_dir.join('current', 'restart')
+      expect(restart).to exist
+    end
+  end
+
+  describe "a failed configure command" do
+
+    before do
+      ENV['EY_SERVERSIDE_CONFIGURE_COMMAND'] = "echo platform_configure_command_failed >&2 && false"
+    end
+
+    after do
+      ENV.delete('EY_SERVERSIDE_CONFIGURE_COMMAND')
+    end
+
+    it "aborts the deplo when it fails, preventing the app from being restarted" do
+      @releases_failed = deploy_dir.join('releases_failed')
+      expect(@releases_failed).not_to exist
+
+      begin
+        deploy_test_application('default')
+      rescue
+      end
+      expect(read_output).to match(/platform_configure_command_failed/)
+
+      expect(@releases_failed.entries).not_to be_empty
+    end
+  end
+end

data/spec/rails31_deploy_spec.rb

@@ -0,0 +1,172 @@
+require 'spec_helper'
+
+describe "Deploying a Rails 3.1 application" do
+  context "with default production settings" do
+    it "precompiles assets when asset compilation is detected" do
+      deploy_test_application('assets_detected')
+      expect(deploy_dir.join('current', 'precompiled')).to exist
+      expect(deploy_dir.join('current', 'public', 'assets')).to exist
+      expect(deploy_dir.join('current', 'public', 'assets', 'compiled_asset')).to exist
+      expect(read_output).to include("Precompiling assets. ('app/assets' exists, 'public/assets' not found, not disabled in config.)")
+    end
+
+    it "precompiles assets, then reuses them on the next deploy if nothing has changed" do
+      deploy_test_application('assets_enabled_in_ey_yml')
+      expect(deploy_dir.join('current', 'precompiled')).to exist
+      expect(deploy_dir.join('current', 'public', 'assets')).to exist
+      expect(deploy_dir.join('current', 'public', 'assets', 'compiled_asset')).to exist
+
+      redeploy_test_application
+      expect(deploy_dir.join('current', 'precompiled')).not_to exist # doesn't run the task
+      expect(deploy_dir.join('current', 'public', 'assets')).to exist # but the assets are there
+      expect(deploy_dir.join('current', 'public', 'assets', 'compiled_asset')).to exist
+      expect(read_output).to match(%r#Reusing existing assets\. \(configured asset_dependencies unchanged from \w{7}..\w{7}\)#)
+
+      redeploy_test_application('config' => {'precompile_unchanged_assets' => 'true'})
+      expect(deploy_dir.join('current', 'precompiled')).to exist # doesn't run the task
+      expect(deploy_dir.join('current', 'public', 'assets')).to exist # but the assets are there
+      expect(deploy_dir.join('current', 'public', 'assets', 'compiled_asset')).to exist
+      expect(read_output).not_to include("Reusing existing assets")
+    end
+
+    it "raises error in a experimental_sync_assets mode and stops deployment" do
+      expect do
+        deploy_test_application('assets_error')
+      end.to raise_error(RuntimeError)
+      expect(deploy_dir.join('current', 'precompiled')).not_to exist
+      expect(deploy_dir.join('current', 'public', 'assets')).not_to exist
+    end
+
+    it "precompile assets again when redeploying a ref with changes" do
+      deploy_test_application('assets_enabled_in_ey_yml')
+      expect(deploy_dir.join('current', 'precompiled')).to exist
+      expect(deploy_dir.join('current', 'public', 'assets')).to exist
+      expect(deploy_dir.join('current', 'public', 'assets', 'compiled_asset')).to exist
+      expect(deploy_dir.join('current', 'tmp', 'cache')).to exist
+      expect(deploy_dir.join('current', 'tmp')).to be_a_symlink
+      expect(deploy_dir.join('current', 'cache_compiled')).not_to exist
+      expect(read_output).to include("Precompiling assets. (precompile_assets: true)")
+
+      # changing the ref stands in for actually having assets change (see Strategies::IntegrationSpec#same?)
+      redeploy_test_application('branch' => 'somenewref')
+      expect(deploy_dir.join('current', 'precompiled')).to exist # it does runs the task
+      expect(deploy_dir.join('current', 'public', 'assets')).to exist
+      expect(deploy_dir.join('current', 'public', 'assets', 'compiled_asset')).to exist
+      expect(deploy_dir.join('current', 'tmp')).to be_a_symlink
+      expect(deploy_dir.join('current', 'tmp', 'cache')).to exist # preserves tmp dir
+      expect(deploy_dir.join('current', 'cache_compiled')).to exist # uses tmp/cache to compile assets faster
+      expect(read_output).not_to match(%r#Reusing existing assets#)
+    end
+
+    it "precompile assets when redeploying the same ref, but assets were turned off the first time" do
+      deploy_test_application('assets_enabled_in_ey_yml', 'config' => {'precompile_assets' => 'false'})
+      expect(deploy_dir.join('current', 'precompiled')).not_to exist
+      expect(deploy_dir.join('current', 'public', 'assets')).not_to exist
+      expect(deploy_dir.join('current', 'public', 'assets', 'compiled_asset')).not_to exist
+      expect(read_output).not_to include("Precompiling assets. (precompile_assets: true)")
+
+      # assets will show as unchanged, but it should compile them fresh anyway.
+      redeploy_test_application('config' => {'precompile_assets' => 'true'})
+      expect(deploy_dir.join('current', 'precompiled')).to exist # it does runs the task
+      expect(deploy_dir.join('current', 'public', 'assets')).to exist
+      expect(deploy_dir.join('current', 'public', 'assets', 'compiled_asset')).to exist
+      expect(read_output).not_to match(%r#Reusing existing assets#)
+    end
+
+    %w[cleaning shared private].each do |strategy|
+      it "precompiles assets with asset_strategy '#{strategy}', then reuses them on the next deploy if nothing has changed" do
+        deploy_test_application('assets_enabled_in_ey_yml', 'config' => {'asset_strategy' => strategy})
+        expect(deploy_dir.join('current', 'precompiled')).to exist
+        expect(deploy_dir.join('current', 'public', 'assets')).to exist
+        expect(deploy_dir.join('current', 'public', 'assets', 'compiled_asset')).to exist
+
+        redeploy_test_application
+        expect(deploy_dir.join('current', 'precompiled')).not_to exist # doesn't run the task
+        expect(deploy_dir.join('current', 'public', 'assets')).to exist # but the assets are there
+        expect(deploy_dir.join('current', 'public', 'assets', 'compiled_asset')).to exist
+        expect(read_output).to match(%r#Reusing existing assets\. \(configured asset_dependencies unchanged from \w{7}..\w{7}\)#)
+      end
+    end
+  end
+
+  context "with asset compilation enabled in ey.yml, despite not otherwise being enabled" do
+    before(:all) do
+      deploy_test_application('assets_enabled_in_ey_yml')
+    end
+
+    it "precompiles assets" do
+      expect(deploy_dir.join('current', 'precompiled')).to exist
+      expect(read_output).to include("Precompiling assets. (precompile_assets: true)")
+    end
+  end
+
+  context "with asset compilation enabled in ey.yml, but asset_roles is set to only :util" do
+    before(:all) do
+      deploy_test_application('assets_enabled_util_only')
+    end
+
+    it "precompiles assets" do
+      expect(deploy_dir.join('current', 'precompiled')).not_to exist
+      expect(read_output).to include("Precompiling assets. (precompile_assets: true)")
+    end
+  end
+
+  context "with asset compilation enabled in ey.yml, and asset_roles is set to :all, and a custom compile command" do
+    before(:all) do
+      deploy_test_application('assets_enabled_all')
+    end
+
+    it "precompiles assets but never shares the tmp cache because the repository has a committed tmp dir with contents" do
+      expect(deploy_dir.join('current', 'custom_compiled')).to exist
+      expect(deploy_dir.join('current', 'cache_compiled')).not_to exist
+      expect(deploy_dir.join('current', 'tmp', 'cache')).to exist
+      expect(deploy_dir.join('current', 'tmp')).not_to be_a_symlink
+      expect(read_output).to include("Precompiling assets. (precompile_assets: true)")
+
+      redeploy_test_application('config' => {'precompile_unchanged_assets' => 'true'})
+      expect(deploy_dir.join('current', 'tmp', 'cache')).to exist
+      expect(deploy_dir.join('current', 'cache_compiled')).not_to exist
+      expect(deploy_dir.join('current', 'tmp')).not_to be_a_symlink
+    end
+  end
+
+  context "with asset support disabled in config/application.rb" do
+    it "does not precompile assets" do
+      deploy_test_application('assets_disabled')
+      expect(deploy_dir.join('current', 'precompiled')).not_to exist
+      expect(read_output).to include("Skipping asset precompilation. ('config/application.rb' disables assets.)")
+    end
+
+    it "deploys successfully when application.rb has utf-8 encoding" do
+      deploy_test_application('assets_disabled_utf8')
+      expect(deploy_dir.join('current', 'precompiled')).not_to exist
+      expect(read_output).to include("Skipping asset precompilation. ('config/application.rb' disables assets.)")
+    end
+  end
+
+  context "with asset compilation disabled in ey.yml, despite all other configuration would enable assets" do
+    before(:all) do
+      deploy_test_application('assets_disabled_in_ey_yml')
+    end
+
+    it "does not precompile assets" do
+      expect(deploy_dir.join('current', 'precompiled')).not_to exist
+      expect(read_output).to include("Skipping asset precompilation. (precompile_assets: false)")
+    end
+  end
+
+  context "with existing precompilation in a deploy hook" do
+    before(:all) do
+      deploy_test_application('assets_in_hook')
+    end
+
+    it "does not replace the public/assets directory" do
+      expect(deploy_dir.join('current', 'custom_compiled')).to exist
+      expect(deploy_dir.join('current', 'precompiled')).not_to exist
+      expect(deploy_dir.join('current', 'public', 'assets')).to be_directory
+      expect(deploy_dir.join('current', 'public', 'assets')).not_to be_symlink
+      expect(deploy_dir.join('current', 'public', 'assets', 'custom_compiled_asset')).to exist
+      expect(read_output).to include("Skipping asset precompilation. ('public/assets' directory already exists.)")
+    end
+  end
+end

data/spec/restart_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+class TestRestartDeploy < FullTestDeploy
+  attr_reader :call_order
+  def initialize(*a)
+    super
+    @call_order = []
+  end
+
+  def require_custom_tasks()                   @call_order << 'require_custom_tasks'                   end
+  def restart()                                @call_order << 'restart'                                end
+  def enable_maintenance_page()                @call_order << 'enable_maintenance_page'                end
+  def disable_maintenance_page()               @call_order << 'disable_maintenance_page'               end
+end
+
+describe "EY::Serverside::Deploy#restart_with_maintenance_page" do
+
+  class TestRestartWithMaintenancePage < TestRestartDeploy
+    def conditionally_enable_maintenance_page()  @call_order << 'conditionally_enable_maintenance_page'  end
+  end
+
+  it "puts up the maintenance page if necessary, restarts, and takes down the maintenance page" do
+    config = EY::Serverside::Deploy::Configuration.new('deploy_to' => deploy_dir, 'app' => 'app_name')
+    deployer = TestRestartWithMaintenancePage.realnew(test_servers, config, test_shell)
+    deployer.restart_with_maintenance_page
+    expect(deployer.call_order).to eq(%w(
+      require_custom_tasks
+      enable_maintenance_page
+      restart
+      disable_maintenance_page
+    ))
+  end
+end
+
+describe "glassfish stack" do
+
+  it "requires a maintenance page" do
+    config = EY::Serverside::Deploy::Configuration.new('deploy_to' => deploy_dir, 'app' => 'app_name', 'stack' => 'glassfish')
+    deployer = TestRestartDeploy.realnew(test_servers, config, test_shell)
+    deployer.restart_with_maintenance_page
+    expect(deployer.call_order).to include('enable_maintenance_page')
+  end
+end

data/spec/rollback_spec.rb

@@ -0,0 +1,87 @@
+require 'spec_helper'
+
+describe "Rolling back" do
+  def setup_good_and_bad_deploy(repo)
+    deploy_test_application(repo, 'migrate' => nil)
+    @good_revision = deploy_dir.join('current', 'REVISION').read.strip
+    expect(deploy_dir.join('current', 'REVISION')).to exist
+    deploy_dir.join('current', 'restart').delete
+    deploy_test_application(repo, 'migrate' => nil)
+    expect(deploy_dir.join('current', 'REVISION')).to exist
+    deploy_dir.join('current', 'restart').delete
+
+    releases = @deployer.config.paths.all_releases
+    expect(releases.size).to eq(2)
+    @good_release = releases.first
+    @bad_release = releases.last
+  end
+
+  def rollback
+    argv = @adapter.rollback.commands.last.to_argv[2..-1]
+    with_mocked_commands do
+      capture do
+        EY::Serverside::CLI::App.start(argv)
+      end
+    end
+  end
+
+  context "without bundler" do
+    before(:all) do
+      setup_good_and_bad_deploy('not_bundled')
+      rollback
+    end
+
+    it "rolls back to the older deploy" do
+      out = read_output
+      expect(out).to match(/Rolling back to previous release.*#{@good_revision}/)
+      expect(out).to match(/Restarting with previous release./)
+      expect(out).to match(/Finished rollback/)
+
+      expect(deploy_dir.join('current', 'restart')).to exist
+      expect(@bad_release).not_to exist
+      expect(@good_release.join('restart')).to exist
+    end
+  end
+
+  context "with a problematic file in the releases dir" do
+    before(:all) do
+      setup_good_and_bad_deploy('not_bundled')
+      @deployer.config.paths.releases.join('tmp').mkpath
+      expect { rollback }.to raise_error
+    end
+
+    it "rolls back to the older deploy" do
+      out = read_output
+      expect(out).to include("Bad paths found in #{@deployer.config.paths.releases}:")
+      expect(out).to include(@deployer.config.paths.releases.join('tmp').to_s)
+      expect(out).to include("Storing files in this directory will disrupt latest_release, diff detection, rollback, and possibly other features.")
+      expect(out).to_not include("Restarting with previous release.")
+
+      expect(deploy_dir.join('current', 'restart')).not_to exist
+      expect(@bad_release).to exist
+      expect(@good_release).to exist
+    end
+  end
+
+  context "with complex config" do
+    before(:all) do
+      setup_good_and_bad_deploy('ey_yml')
+      rollback
+    end
+
+    it "rolls back to the older deploy" do
+      out = read_output
+      expect(out).to match(/Rolling back to previous release.*#{@good_revision}/)
+      expect(out).to match(/Restarting with previous release./)
+      expect(out).to match(/Finished rollback/)
+
+      expect(deploy_dir.join('current', 'restart')).to exist
+      expect(@bad_release).not_to exist
+      expect(@good_release.join('restart')).to exist
+    end
+
+    it "loads and uses ey.yml during rollback" do
+      expect(read_output).to match(/--without only test/)
+    end
+  end
+end

data/spec/server_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+
+describe EY::Serverside::Server do
+  it "starts off empty" do
+    expect(EY::Serverside::Servers.new([], test_shell)).to be_empty
+  end
+
+  it "loads from hashes" do
+    servers = EY::Serverside::Servers.from_hashes([{:hostname => 'otherhost', :roles => %w[fire water]}], test_shell)
+    expect(servers.size).to eq(1)
+  end
+
+  it "rejects duplicates" do
+    expect do
+      EY::Serverside::Servers.from_hashes([
+        {:hostname => 'otherhost', :roles => [:fire]},
+        {:hostname => 'otherhost', :roles => [:water]},
+      ], test_shell)
+    end.to raise_error(EY::Serverside::Servers::DuplicateHostname)
+  end
+
+  it "makes sure your roles are symbols at creation time" do
+    servers = EY::Serverside::Servers.from_hashes([{:hostname => 'otherhost', :roles => %w[fire water]}], test_shell)
+    servers.each { |server| expect(server.roles).to eq(Set[:fire, :water]) }
+  end
+
+  context "filtering" do
+    before(:each) do
+      @servers = EY::Serverside::Servers.from_hashes([
+        {:hostname => 'localhost', :roles => [:ice, :cold]},
+        {:hostname => 'firewater', :roles => [:fire, :water]},
+        {:hostname => 'icewater',  :roles => [:ice, :water]},
+      ], test_shell)
+    end
+
+    it "#roles works with strings or symbols" do
+      expect(@servers.roles(:fire ).map{|s| s.hostname}).to eq(['firewater'])
+      expect(@servers.roles('fire').map{|s| s.hostname}).to eq(['firewater']) # hits the cache the second time
+    end
+
+    it "#roles finds all servers with the specified role" do
+      expect(@servers.roles(:ice).size).to eq(2)
+      expect(@servers.roles(:ice).map{|s| s.hostname}.sort).to eq(['icewater','localhost'])
+    end
+
+    it "#roles finds all servers with any of the specified roles" do
+      expect(@servers.roles(:ice, :water)).to eq(@servers)
+    end
+
+    it "#roles returns everything when asked for :all" do
+      expect(@servers.roles(:all)).to eq(@servers)
+    end
+
+    it "#roles also yields filtered server set" do
+      @servers.roles(:ice) do |servers|
+        expect(servers.size).to eq(2)
+        expect(servers.map{|s| s.hostname}.sort).to eq(['icewater','localhost'])
+      end
+    end
+
+    it "#localhost returns the localhost server" do
+      expect(@servers.localhost.hostname).to eq('localhost')
+    end
+
+    it "#remote returns non-localhost servers" do
+      expect(@servers.remote.size).to eq(2)
+      expect(@servers.remote.map {|s| s.hostname}.sort).to eq(['firewater','icewater'])
+    end
+  end
+end

data/spec/services_deploy_spec.rb

@@ -0,0 +1,165 @@
+require 'spec_helper'
+
+describe "Deploying an application with services" do
+  let(:shared_services_file) { deploy_dir.join('shared', 'config', 'ey_services_config_deploy.yml') }
+  let(:symlinked_services_file) { deploy_dir.join('current', 'config', 'ey_services_config_deploy.yml') }
+  let(:services_yml) { {"servicio" => {"foo" => "bar"}}.to_yaml }
+
+  describe "without ey_config" do
+    describe "with services and disabled ey_config warnings" do
+      before do
+        deploy_test_application('no_ey_config_no_warning', 'config' => {
+          'services_setup_command' => "echo '#{services_yml}' > #{shared_services_file}"
+        })
+      end
+
+      it "no warns about missing ey_config" do
+        expect(read_stderr).not_to include("WARNING: Gemfile.lock does not contain ey_config")
+      end
+    end
+
+    describe "with services" do
+      before do
+        deploy_test_application('no_ey_config', 'config' => {
+          'services_setup_command' => "echo '#{services_yml}' > #{shared_services_file}"
+        })
+      end
+
+      it "warns about missing ey_config" do
+        expect(read_stderr).to include("WARNING: Gemfile.lock does not contain ey_config")
+      end
+    end
+
+    describe "without services" do
+      before do
+        deploy_test_application('no_ey_config')
+      end
+
+      it "works without warnings" do
+        expect(read_output).not_to match(/WARNING/)
+      end
+    end
+  end
+
+  describe "deploy with invalid yaml ey_services_config_deploy" do
+    before do
+      @invalid_services_yml = "42"
+      deploy_test_application('default', 'config' => {
+        'services_setup_command' => "echo '#{@invalid_services_yml}' > #{shared_services_file}"
+      })
+    end
+
+    it "works without warning" do
+      expect(shared_services_file).to exist
+      expect(shared_services_file).not_to be_symlink
+      expect(shared_services_file.read).to eq("#{@invalid_services_yml}\n")
+
+      expect(symlinked_services_file).to exist
+      expect(symlinked_services_file).to be_symlink
+      expect(shared_services_file.read).to eq("#{@invalid_services_yml}\n")
+
+      expect(read_output).not_to match(/WARNING/)
+    end
+  end
+
+  describe "a succesful deploy" do
+    before do
+      deploy_test_application('default', 'config' => {
+        'services_setup_command' => "echo '#{services_yml}' > #{shared_services_file}"
+      })
+    end
+
+    it "creates and symlinks ey_services_config_deploy.yml" do
+      expect(shared_services_file).to exist
+      expect(shared_services_file).not_to be_symlink
+      expect(shared_services_file.read).to eq("#{services_yml}\n")
+
+      expect(symlinked_services_file).to exist
+      expect(symlinked_services_file).to be_symlink
+      expect(shared_services_file.read).to eq("#{services_yml}\n")
+
+      expect(read_output).not_to match(/WARNING/)
+    end
+  end
+
+  describe "a successful deploy followed by a deploy that can't find the command" do
+    before do
+      deploy_test_application('default', 'config' => {
+        'services_setup_command' => "echo '#{services_yml}' > #{shared_services_file}"
+      })
+      redeploy_test_application('config' => {
+        'services_check_command' => 'false'
+      })
+    end
+
+    it "silently fails" do
+      expect(shared_services_file).to exist
+      expect(shared_services_file).not_to be_symlink
+      expect(shared_services_file.read).to eq("#{services_yml}\n")
+
+      expect(symlinked_services_file).to exist
+      expect(symlinked_services_file).to be_symlink
+      expect(shared_services_file.read).to eq("#{services_yml}\n")
+
+      expect(read_output).not_to match(/WARNING/)
+    end
+
+  end
+
+  describe "a successful followed by a deploy that fails to fetch services" do
+    it "logs a warning and symlinks the existing config file when there is existing services file" do
+      deploy_test_application('default', 'config' => {
+        'services_setup_command' => "echo '#{services_yml}' > #{shared_services_file}"
+      })
+      redeploy_test_application('config' => {'services_setup_command' => 'false'})
+
+      expect(shared_services_file).to exist
+      expect(shared_services_file).not_to be_symlink
+      expect(shared_services_file.read).to eq("#{services_yml}\n")
+
+      expect(symlinked_services_file).to exist
+      expect(symlinked_services_file).to be_symlink
+      expect(shared_services_file.read).to eq("#{services_yml}\n")
+
+      expect(read_output).to include('WARNING: External services configuration not updated')
+    end
+
+    it "does not log a warning or symlink a config file when there is no existing services file" do
+      deploy_test_application('default', 'config' => {
+        'services_setup_command' => "echo '#{services_yml}' > #{shared_services_file}"
+      })
+      shared_services_file.delete
+      redeploy_test_application('config' => {'services_setup_command' => 'false'})
+
+      expect(shared_services_file).not_to exist
+      expect(symlinked_services_file).not_to exist
+
+      expect(read_output).not_to match(/WARNING/)
+    end
+  end
+
+  describe "a successful deploy followed by another successfull deploy" do
+    before do
+      deploy_test_application('default', 'config' => {
+        'services_setup_command' => "echo '#{services_yml}' > #{shared_services_file}"
+      })
+      @new_services_yml = {"servicio" => {"foo" => "bar2"}}.to_yaml
+      redeploy_test_application('config' => {
+        'services_setup_command' => "echo '#{@new_services_yml}' > #{shared_services_file}"
+      })
+    end
+
+    it "replaces the config with the new one (and symlinks)" do
+      expect(shared_services_file).to exist
+      expect(shared_services_file).not_to be_symlink
+      expect(shared_services_file.read).to eq("#{@new_services_yml}\n")
+
+      expect(symlinked_services_file).to exist
+      expect(symlinked_services_file).to be_symlink
+      expect(shared_services_file.read).to eq("#{@new_services_yml}\n")
+
+      expect(read_output).not_to match(/WARNING/)
+    end
+  end
+
+end