engineyard-serverside 1.6.5 → 1.7.0.pre2

data/spec/deprecation_spec.rb

@@ -12,34 +12,12 @@ describe EY::Serverside do
     $stderr = @original_stderr
   end
 
-  def check_deprecation(new_const, prints_warning = true)
-    old_name = new_const.to_s.gsub('EY::Serverside::', 'EY::')
-    eval(old_name).should == new_const
-    @warnings.string.should include(old_name) if prints_warning
-  end
-
-  it "preserves the old constants" do
-    names = %w[CLI Deploy DeployBase Deploy::Configuration
-               DeployHook LockfileParser LoggedOutput Server Task
-               Strategies Strategies::Git]
-
-    names.map do |name|
-      const = eval("::EY::Serverside::#{name}")
-      # The way deprecations are implemented currently, we don't print
-      # warning messages for constants that aren't directly under EY::
-      prints_warning = name.include?('::') ? false : true
-      check_deprecation(const, prints_warning)
-    end
-  end
-
-  it "deprecates EY.dna_json and EY.node" do
-    EY.dna_json.should == EY::Serverside.dna_json
-    @warnings.string.should include("EY.dna_json")
-    EY.node.should == EY::Serverside.node
-    @warnings.string.should include("EY.node")
+  it "deprecates EY::Serverside::LoggedOutput for EY::Serverside::Shell::Helpers" do
+    EY::Serverside::LoggedOutput.should == EY::Serverside::Shell::Helpers
+    @warnings.string.should include("EY::Serverside::LoggedOutput")
   end
 
   it "doesn't interfere with unrelated constants" do
-    lambda{ EY::WTFNotDefined }.should raise_error(NameError, /uninitialized constant.*EY::WTFNotDefined/)
+    lambda{ EY::Serverside::WTFNotDefined }.should raise_error(NameError, /uninitialized constant.*WTFNotDefined/)
   end
 end

data/spec/ey_yml_customized_deploy_spec.rb

@@ -0,0 +1,68 @@
+require 'spec_helper'
+
+describe "Deploying an app with ey.yml" do
+  context "--no-migrate" do
+    before(:all) do
+      deploy_test_application('ey_yml', 'migrate' => nil)
+    end
+
+    it "does not migrate even though ey.yml says migrate: true" do
+      read_output.should_not =~ /Migrating/
+    end
+
+    it "does not enable the maintenance page at all" do
+      @deploy_dir.join('current','maintenance_disabled').should exist
+    end
+  end
+
+
+  context "with migration" do
+    before(:all) do
+      deploy_test_application('ey_yml')
+    end
+
+    it "excludes copy_excludes from releases" do
+      cmd = @deployer.commands.grep(/rsync -aq/).first
+      cmd.should include('rsync -aq --exclude=".git" --exclude="README"')
+      @deploy_dir.join('current', '.git').should_not exist
+      @deploy_dir.join('current', 'README').should_not exist
+    end
+
+    it "loads ey.yml at lower priority than command line options" do
+      @deploy_dir.join('current', 'REVISION').read.should == "somebranch\n"
+    end
+
+    it "loads bundle_without from the config, which overrides the default" do
+      cmd = @deployer.commands.grep(/bundle _\S*_ install/).first
+      cmd.should include('--without only test')
+    end
+
+    it "does not enable the maintenance page during migrations" do
+      @deploy_dir.join('current','maintenance_disabled').should exist
+      @deploy_dir.join('current','maintenance_enabled').should_not exist
+    end
+
+    it "makes custom variables available to hooks" do
+      @deploy_dir.join('current', 'custom_hook').read.should include("custom_from_ey_yml")
+    end
+
+    it "doesn't display the database adapter warning with ignore_database_adapter_warning: true" do
+      read_output.should_not =~ /WARNING/
+    end
+  end
+
+  context "with a different ey.yml" do
+    before(:all) do
+      deploy_test_application('ey_yml_alt')
+    end
+
+    it "always installs maintenance pages" do
+      @deploy_dir.join('current','maintenance_enabled').should exist
+      @deploy_dir.join('current','maintenance_disabled').should_not exist
+    end
+
+    it "displays the database adapter warning without ignore_database_adapter_warning" do
+      read_output.should =~ /WARNING: Gemfile.lock does not contain a recognized database adapter./
+    end
+  end
+end

data/spec/fixtures/repos/assets_disabled/Gemfile

@@ -0,0 +1,6 @@
+source :rubygems
+
+gem 'rake'
+gem 'pg'
+gem 'ey_config'
+gem 'rails'

data/spec/fixtures/repos/assets_disabled/Gemfile.lock

@@ -0,0 +1,90 @@
+GEM
+  remote: http://rubygems.org/
+  specs:
+    actionmailer (3.2.3)
+      actionpack (= 3.2.3)
+      mail (~> 2.4.4)
+    actionpack (3.2.3)
+      activemodel (= 3.2.3)
+      activesupport (= 3.2.3)
+      builder (~> 3.0.0)
+      erubis (~> 2.7.0)
+      journey (~> 1.0.1)
+      rack (~> 1.4.0)
+      rack-cache (~> 1.2)
+      rack-test (~> 0.6.1)
+      sprockets (~> 2.1.2)
+    activemodel (3.2.3)
+      activesupport (= 3.2.3)
+      builder (~> 3.0.0)
+    activerecord (3.2.3)
+      activemodel (= 3.2.3)
+      activesupport (= 3.2.3)
+      arel (~> 3.0.2)
+      tzinfo (~> 0.3.29)
+    activeresource (3.2.3)
+      activemodel (= 3.2.3)
+      activesupport (= 3.2.3)
+    activesupport (3.2.3)
+      i18n (~> 0.6)
+      multi_json (~> 1.0)
+    arel (3.0.2)
+    builder (3.0.0)
+    erubis (2.7.0)
+    ey_config (0.0.5)
+    hike (1.2.1)
+    i18n (0.6.0)
+    journey (1.0.3)
+    json (1.6.6)
+    mail (2.4.4)
+      i18n (>= 0.4.0)
+      mime-types (~> 1.16)
+      treetop (~> 1.4.8)
+    mime-types (1.18)
+    multi_json (1.3.2)
+    pg (0.13.2)
+    polyglot (0.3.3)
+    rack (1.4.1)
+    rack-cache (1.2)
+      rack (>= 0.4)
+    rack-ssl (1.3.2)
+      rack
+    rack-test (0.6.1)
+      rack (>= 1.0)
+    rails (3.2.3)
+      actionmailer (= 3.2.3)
+      actionpack (= 3.2.3)
+      activerecord (= 3.2.3)
+      activeresource (= 3.2.3)
+      activesupport (= 3.2.3)
+      bundler (~> 1.0)
+      railties (= 3.2.3)
+    railties (3.2.3)
+      actionpack (= 3.2.3)
+      activesupport (= 3.2.3)
+      rack-ssl (~> 1.3.2)
+      rake (>= 0.8.7)
+      rdoc (~> 3.4)
+      thor (~> 0.14.6)
+    rake (0.9.2.2)
+    rdoc (3.12)
+      json (~> 1.4)
+    sprockets (2.1.2)
+      hike (~> 1.2)
+      rack (~> 1.0)
+      tilt (~> 1.1, != 1.3.0)
+    thor (0.14.6)
+    tilt (1.3.3)
+    treetop (1.4.10)
+      polyglot
+      polyglot (>= 0.3.1)
+    tzinfo (0.3.33)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  ey_config
+  pg
+  rails
+  rake

data/spec/fixtures/repos/assets_disabled/README

@@ -0,0 +1 @@
+Standard rails31 app with assets disabled.

data/spec/fixtures/repos/assets_disabled/Rakefile

@@ -0,0 +1,5 @@
+desc 'Precompile yar assetz'
+task 'assets:precompile' do
+  sh 'touch precompiled'
+end
+

data/spec/fixtures/repos/assets_disabled/config/application.rb

@@ -0,0 +1,5 @@
+module Rails31
+  class Application < Rails::Application
+    config.assets.enabled = false
+  end
+end

data/spec/fixtures/repos/assets_disabled_in_ey_yml/Gemfile

@@ -0,0 +1,6 @@
+source :rubygems
+
+gem 'rake'
+gem 'pg'
+gem 'ey_config'
+gem 'rails'

data/spec/fixtures/repos/assets_disabled_in_ey_yml/Gemfile.lock

@@ -0,0 +1,90 @@
+GEM
+  remote: http://rubygems.org/
+  specs:
+    actionmailer (3.2.3)
+      actionpack (= 3.2.3)
+      mail (~> 2.4.4)
+    actionpack (3.2.3)
+      activemodel (= 3.2.3)
+      activesupport (= 3.2.3)
+      builder (~> 3.0.0)
+      erubis (~> 2.7.0)
+      journey (~> 1.0.1)
+      rack (~> 1.4.0)
+      rack-cache (~> 1.2)
+      rack-test (~> 0.6.1)
+      sprockets (~> 2.1.2)
+    activemodel (3.2.3)
+      activesupport (= 3.2.3)
+      builder (~> 3.0.0)
+    activerecord (3.2.3)
+      activemodel (= 3.2.3)
+      activesupport (= 3.2.3)
+      arel (~> 3.0.2)
+      tzinfo (~> 0.3.29)
+    activeresource (3.2.3)
+      activemodel (= 3.2.3)
+      activesupport (= 3.2.3)
+    activesupport (3.2.3)
+      i18n (~> 0.6)
+      multi_json (~> 1.0)
+    arel (3.0.2)
+    builder (3.0.0)
+    erubis (2.7.0)
+    ey_config (0.0.5)
+    hike (1.2.1)
+    i18n (0.6.0)
+    journey (1.0.3)
+    json (1.6.6)
+    mail (2.4.4)
+      i18n (>= 0.4.0)
+      mime-types (~> 1.16)
+      treetop (~> 1.4.8)
+    mime-types (1.18)
+    multi_json (1.3.2)
+    pg (0.13.2)
+    polyglot (0.3.3)
+    rack (1.4.1)
+    rack-cache (1.2)
+      rack (>= 0.4)
+    rack-ssl (1.3.2)
+      rack
+    rack-test (0.6.1)
+      rack (>= 1.0)
+    rails (3.2.3)
+      actionmailer (= 3.2.3)
+      actionpack (= 3.2.3)
+      activerecord (= 3.2.3)
+      activeresource (= 3.2.3)
+      activesupport (= 3.2.3)
+      bundler (~> 1.0)
+      railties (= 3.2.3)
+    railties (3.2.3)
+      actionpack (= 3.2.3)
+      activesupport (= 3.2.3)
+      rack-ssl (~> 1.3.2)
+      rake (>= 0.8.7)
+      rdoc (~> 3.4)
+      thor (~> 0.14.6)
+    rake (0.9.2.2)
+    rdoc (3.12)
+      json (~> 1.4)
+    sprockets (2.1.2)
+      hike (~> 1.2)
+      rack (~> 1.0)
+      tilt (~> 1.1, != 1.3.0)
+    thor (0.14.6)
+    tilt (1.3.3)
+    treetop (1.4.10)
+      polyglot
+      polyglot (>= 0.3.1)
+    tzinfo (0.3.33)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  ey_config
+  pg
+  rails
+  rake

data/spec/fixtures/repos/assets_disabled_in_ey_yml/README

@@ -0,0 +1 @@
+rails31 app with asset compilation enabled, but ey.yml turns it off.

data/spec/fixtures/repos/assets_disabled_in_ey_yml/Rakefile

@@ -0,0 +1,5 @@
+desc 'Precompile yar assetz'
+task 'assets:precompile' do
+  sh 'touch precompiled'
+end
+

data/spec/fixtures/repos/assets_disabled_in_ey_yml/config/application.rb

@@ -0,0 +1,5 @@
+module Rails31
+  class Application < Rails::Application
+    config.assets.enabled = true
+  end
+end

data/spec/fixtures/repos/assets_disabled_in_ey_yml/config/ey.yml

@@ -0,0 +1,4 @@
+environments:
+  env:
+    precompile_assets: false
+    maintenance_on_migrate: false

data/spec/fixtures/repos/assets_enabled/Gemfile

@@ -0,0 +1,6 @@
+source :rubygems
+
+gem 'rake'
+gem 'pg'
+gem 'ey_config'
+gem 'rails'

data/spec/fixtures/repos/assets_enabled/Gemfile.lock

@@ -0,0 +1,90 @@
+GEM
+  remote: http://rubygems.org/
+  specs:
+    actionmailer (3.2.3)
+      actionpack (= 3.2.3)
+      mail (~> 2.4.4)
+    actionpack (3.2.3)
+      activemodel (= 3.2.3)
+      activesupport (= 3.2.3)
+      builder (~> 3.0.0)
+      erubis (~> 2.7.0)
+      journey (~> 1.0.1)
+      rack (~> 1.4.0)
+      rack-cache (~> 1.2)
+      rack-test (~> 0.6.1)
+      sprockets (~> 2.1.2)
+    activemodel (3.2.3)
+      activesupport (= 3.2.3)
+      builder (~> 3.0.0)
+    activerecord (3.2.3)
+      activemodel (= 3.2.3)
+      activesupport (= 3.2.3)
+      arel (~> 3.0.2)
+      tzinfo (~> 0.3.29)
+    activeresource (3.2.3)
+      activemodel (= 3.2.3)
+      activesupport (= 3.2.3)
+    activesupport (3.2.3)
+      i18n (~> 0.6)
+      multi_json (~> 1.0)
+    arel (3.0.2)
+    builder (3.0.0)
+    erubis (2.7.0)
+    ey_config (0.0.5)
+    hike (1.2.1)
+    i18n (0.6.0)
+    journey (1.0.3)
+    json (1.6.6)
+    mail (2.4.4)
+      i18n (>= 0.4.0)
+      mime-types (~> 1.16)
+      treetop (~> 1.4.8)
+    mime-types (1.18)
+    multi_json (1.3.2)
+    pg (0.13.2)
+    polyglot (0.3.3)
+    rack (1.4.1)
+    rack-cache (1.2)
+      rack (>= 0.4)
+    rack-ssl (1.3.2)
+      rack
+    rack-test (0.6.1)
+      rack (>= 1.0)
+    rails (3.2.3)
+      actionmailer (= 3.2.3)
+      actionpack (= 3.2.3)
+      activerecord (= 3.2.3)
+      activeresource (= 3.2.3)
+      activesupport (= 3.2.3)
+      bundler (~> 1.0)
+      railties (= 3.2.3)
+    railties (3.2.3)
+      actionpack (= 3.2.3)
+      activesupport (= 3.2.3)
+      rack-ssl (~> 1.3.2)
+      rake (>= 0.8.7)
+      rdoc (~> 3.4)
+      thor (~> 0.14.6)
+    rake (0.9.2.2)
+    rdoc (3.12)
+      json (~> 1.4)
+    sprockets (2.1.2)
+      hike (~> 1.2)
+      rack (~> 1.0)
+      tilt (~> 1.1, != 1.3.0)
+    thor (0.14.6)
+    tilt (1.3.3)
+    treetop (1.4.10)
+      polyglot
+      polyglot (>= 0.3.1)
+    tzinfo (0.3.33)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  ey_config
+  pg
+  rails
+  rake