engine_cart 2.4.0 → 2.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c910fecebf1668fff3496adb5ffbb775f8b26d6172c0bd852a42b2347ab37c5b
-  data.tar.gz: c9f3f648c782203de8dec936e58057432db338ead895ac7f142829b130692e00
+  metadata.gz: 864ca4cc0c524ad80281f92e1dce77df32cb2a2c4b6f27d293721ee8e9305412
+  data.tar.gz: 5c8ec70e88e2a6efd9d919c04c56be20509afebacce106118d3061de56a40cfc
 SHA512:
-  metadata.gz: 2a5b3d945948e1b95120b621085ca3b560ce1ae6e4f1b10b99edfa288e97a8d6a43e98db7b16ece7d736a8878d80384ff76baf3577ee00a509c1fe0d9c5e4473
-  data.tar.gz: 54d05bb765b09739ae6e53816b488efa619d2d5b3730c8b8b30db427c51b33a32a822282c5d4b94f7e5eb841b71d9baad8d9d7707e6d3ea8dd86c74bb50d0d8f
+  metadata.gz: 324a7c844887c7f43923d6d8dadd72f599567158ad6bd8876496865700239be2a28a0314feef816e7ce2b8cb5dff405b4d6bc3ec93d8912ac8e7bb13554e56b1
+  data.tar.gz: f377f63b4585553142802de3451eaaa4882de55bd821976e45c892e820d43bb708ef9c6afba7d166a883d8150be6d03bfdaec62aa93614d9a21ce521eb8e7d10

data/.github/workflows/ci.yml

@@ -12,17 +12,26 @@ jobs:
     strategy:
       matrix:
         ruby:
-          - 2.7
+          - 3.1
         rails_version:
-          - 5.2.6
-          - 6.0.4.1
-          - 6.1.4.1
+          - 6.1.6.1
+          - 7.0.3.1
+        include:
+          - ruby: '2.7.8' # Rails 6.0 will not run on Ruby 3
+            rails_version: '6.0.5.1'
+          - ruby: '2.7.8' # Rails 5.2 will not run on Ruby 3
+            rails_version: '5.2.8.1'
+          - ruby: '3.2.2'
+            rails_version: '7.1.1'
+          - ruby: '3.3.0'
+            rails_version: '7.1.1'
     steps:
     - uses: actions/checkout@v2
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
+        bundler: 'latest'
     - name: Install dependencies
       run: bundle install
       env:

data/Rakefile

@@ -25,12 +25,17 @@ task :generate_test_gem => ['engine_cart:setup'] do
 
   system("mv #{Dir.pwd}/internal_test_gem #{Dir.pwd}/.internal_test_gem")
 
-  IO.write(".internal_test_gem/internal_test_gem.gemspec", File.open(".internal_test_gem/internal_test_gem.gemspec") {|f| f.read.gsub(/FIXME/, "DONTCARE")})
-  IO.write(".internal_test_gem/internal_test_gem.gemspec", File.open(".internal_test_gem/internal_test_gem.gemspec") {|f| f.read.gsub(/TODO/, "DONTCARE")})
-  IO.write(".internal_test_gem/internal_test_gem.gemspec", File.open(".internal_test_gem/internal_test_gem.gemspec") {|f| f.read.gsub(/.*homepage.*/, "")})
-  IO.write(".internal_test_gem/internal_test_gem.gemspec", File.open(".internal_test_gem/internal_test_gem.gemspec") {|f| f.read.gsub(/.*sqlite3.*/, "")})
-  IO.write(".internal_test_gem/internal_test_gem.gemspec", File.open(".internal_test_gem/internal_test_gem.gemspec") {|f| f.read.gsub(/.*source_code_uri.*/, "")})
-  IO.write(".internal_test_gem/internal_test_gem.gemspec", File.open(".internal_test_gem/internal_test_gem.gemspec") {|f| f.read.gsub(/.*changelog_uri.*/, "")})
+  gemspec_data = File.open(".internal_test_gem/internal_test_gem.gemspec") do |f|
+    f.read.gsub(/FIXME/, "DONTCARE")
+          .gsub(/TODO/, "DONTCARE")
+          .gsub(/.*homepage.*/, "")
+          .gsub(/.*sqlite3.*/, "")
+          .gsub(/.*source_code_uri.*/, "")
+          .gsub(/.*changelog_uri.*/, "")
+  end
+
+  IO.write(".internal_test_gem/internal_test_gem.gemspec", gemspec_data)
+  IO.write(".internal_test_gem/Gemfile", File.open(".internal_test_gem/Gemfile") {|f| f.read.gsub(/.*sqlite3.*/, "")})
 
   Rake::Task['engine_cart:inject_gemfile_extras'].invoke
   EngineCart.within_test_app do
@@ -52,12 +57,15 @@ task :generate_test_gem => ['engine_cart:setup'] do
     end
 
     system "echo '\ngem \"rspec-rails\"\n' >> Gemfile"
+    if RUBY_VERSION < '3.0'
+      system "echo '\ngem \"sqlite3\", \"< 1.7.0\"\n' >> Gemfile"
+    end
 
-    Bundler.clean_system "bundle update --quiet"
+    Bundler.unbundled_system "bundle update --quiet"
     system "echo 'require \"engine_cart/rake_task\"\n' >> Rakefile"
 
     system("bundle exec rake engine_cart:prepare")
-    Bundler.clean_system "bundle install --quiet"
+    Bundler.unbundled_system "bundle install --quiet"
   end
 end
 

data/lib/engine_cart/configuration.rb

@@ -1,5 +1,6 @@
 require 'yaml'
 require 'erb'
+require 'shellwords'
 
 module EngineCart
   class Configuration
@@ -86,10 +87,11 @@ module EngineCart
     # Split a string of options into individual options.
     # @example
     #   parse_options('--skip-foo --skip-bar -d postgres --skip-lala')
-    #   # => ["--skip-foo", "--skip-bar", "-d postgres", "--skip-lala"]
+    #   # => ["--skip-foo", "--skip-bar", "-d", "postgres", "--skip-lala"]
     def parse_options(options)
       return if options.nil?
-      options.scan(/(--[^\s]+|-[^\s]+\s+[^\s]+)/).flatten
+
+      Shellwords.shellwords(options)
     end
 
     def read_config(config_file)

data/lib/engine_cart/tasks/engine_cart.rake

@@ -27,6 +27,8 @@ namespace :engine_cart do
   task :create_test_rails_app => [:setup] do
     require 'tmpdir'
     require 'fileutils'
+    require 'rails/version'
+
     Dir.mktmpdir do |dir|
       # Fork into a new process to avoid polluting the current one with the partial Rails environment ...
       pid = fork do
@@ -66,7 +68,7 @@ namespace :engine_cart do
       Rake::Task['engine_cart:clean'].invoke if File.exist? EngineCart.destination
       FileUtils.move "#{dir}/internal", "#{EngineCart.destination}"
 
-      if Gem.loaded_specs['rails'].version.to_s < '5.2.3'
+      if Rails.version < '5.2.3'
         # Hack for https://github.com/rails/rails/issues/35153
         gemfile = File.join(EngineCart.destination, 'Gemfile')
         IO.write(gemfile, File.open(gemfile) do |f|
@@ -74,6 +76,15 @@ namespace :engine_cart do
           text.gsub(/^gem ["']sqlite3["']$/, 'gem "sqlite3", "~> 1.3.0"')
         end)
       end
+
+      if RUBY_VERSION < '3.0'
+        # Hack for https://github.com/cbeer/engine_cart/issues/125
+        gemfile = File.join(EngineCart.destination, 'Gemfile')
+        IO.write(gemfile, File.open(gemfile) do |f|
+          text = f.read
+          text.gsub(/^gem ["']sqlite3["']$/, 'gem "sqlite3", "< 1.7"')
+        end)
+      end
     end
   end
 
@@ -106,18 +117,19 @@ namespace :engine_cart do
 
       # Copy our test app generators into the app and prepare it
       if File.exist? "#{EngineCart.templates_path}/lib/generators"
-        Bundler.clean_system "cp -r #{EngineCart.templates_path}/lib/generators #{EngineCart.destination}/lib"
+        Bundler.unbundled_system "cp -r #{EngineCart.templates_path}/lib/generators #{EngineCart.destination}/lib"
       end
 
       within_test_app do
         unless (system("bundle install --quiet") or system("bundle update --quiet")) and
-              system "(bundle exec rails g | grep test_app) && bundle exec rails generate test_app" and
-              system "bundle exec rake db:migrate db:test:prepare"
+              system "(bin/rails g | grep test_app) && bin/rails generate test_app" and
+              system "bin/rails db:migrate" and
+              system "bin/rails db:test:prepare"
           raise "EngineCart failed on with: #{$?}"
         end
       end
 
-      Bundler.clean_system "bundle install --quiet"
+      Bundler.unbundled_system "bundle install --quiet"
 
       EngineCart.write_fingerprint
 
@@ -128,14 +140,14 @@ namespace :engine_cart do
   desc 'Start the internal test application using `rails server`'
   task :server, [:rails_server_args] => [:generate] do |_, args|
     within_test_app do
-      system "bundle exec rails server #{args[:rails_server_args]}"
+      system "bin/rails server #{args[:rails_server_args]}"
     end
   end
 
   desc 'Start the internal test application using `rails console`'
   task :console, [:rails_console_args] => [:generate] do |_, args|
     within_test_app do
-      system "bundle exec rails console #{args[:rails_console_args]}"
+      system "bin/rails console #{args[:rails_console_args]}"
     end
   end
 end
@@ -143,7 +155,7 @@ end
 def within_test_app
   puts "\rtravis_fold:start:enginecart-bundler-cleanenv\r" if ENV['TRAVIS'] == 'true'
   Dir.chdir(EngineCart.destination) do
-    Bundler.with_clean_env do
+    EngineCart.with_unbundled_env do
       yield
     end
   end

data/lib/engine_cart/version.rb

@@ -1,3 +1,3 @@
 module EngineCart
-  VERSION = '2.4.0'
+  VERSION = '2.6.0'
 end

data/lib/engine_cart.rb

@@ -12,9 +12,21 @@ module EngineCart
     require File.expand_path("config/environment", path || EngineCart.destination)
   end
 
+  def self.with_unbundled_env
+    method = if Bundler.respond_to?(:with_unbundled_env)
+      :with_unbundled_env
+    else
+      :with_clean_env
+    end
+
+    Bundler.public_send(method) do
+      yield
+    end
+  end
+
   def self.within_test_app
     Dir.chdir(EngineCart.destination) do
-      Bundler.with_clean_env do
+      EngineCart.with_unbundled_env do
         yield
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: engine_cart
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.6.0
 platform: ruby
 authors:
 - Chris Beer
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-26 00:00:00.000000000 Z
+date: 2024-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -81,7 +81,7 @@ homepage: https://github.com/cbeer/engine_cart
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -96,8 +96,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key: 
+rubygems_version: 3.4.20
+signing_key:
 specification_version: 4
 summary: Helper for testing Rails Engines sanely
 test_files: