engine_cart 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 761fe334e7ab2a2b346ae57fb6e67ac6de0f6293
-  data.tar.gz: dccb0dfd7c3e931751848d33d1248970549c249a
+  metadata.gz: 813b3a634c45dead4343d6bcea735499e70e930d
+  data.tar.gz: a3f6f5a013a9e978c8807c2aca3578fe5d5c38a3
 SHA512:
-  metadata.gz: eaed33db29668484b7b8a7c290670ed32e7eed04ed00f87ce264fc4db88f1e8da32c4ed07372680ca294c0d1418770f3bbb9a751187f7aafadd4133ed74bcdb5
-  data.tar.gz: e02135843a8dc4d4cebdf66f3a5a70e8f4710082a865e39795a77ad5e4759c68f23b96f305b80f29b760f4ede46fa169a13b2f98a8610fe9d258da9d2fef1fb2
+  metadata.gz: c8db75de72d6e85d16e0617105d561e87c9f3615c6d2c43d4b2a6eda11948d9f20d11af40398c750c8683cb5598c1dc87d91072722bd45fea0b850403f0e0ca7
+  data.tar.gz: d588131b98de57585e760109c3c339c9859e11e624e52f1c070c6e3110356cee19596a5f82a5f42360867429f5eccef532a6bfa0f5195f77c88dd76a1bff6028

data/README.md

@@ -1,3 +1,5 @@
+[![Build Status](https://travis-ci.org/cbeer/engine_cart.svg?branch=master)](https://travis-ci.org/cbeer/engine_cart) [![Gem Version](https://badge.fury.io/rb/engine_cart.svg)](http://badge.fury.io/rb/engine_cart)
+
 # EngineCart
 
 Rake tasks to generate a test application for a Rails Engine gem.

data/Rakefile

@@ -11,6 +11,9 @@ end
 task :generate_test_gem => ['engine_cart:setup'] do
   system("rm -rf spec/internal")
   system("rails plugin new spec/internal_gem")
+  IO.write("spec/internal_gem/internal_gem.gemspec", File.open("spec/internal_gem/internal_gem.gemspec") {|f| f.read.gsub(/TODO/, "DONTCARE")})
+  IO.write("spec/internal_gem/internal_gem.gemspec", File.open("spec/internal_gem/internal_gem.gemspec") {|f| f.read.gsub(/.*homepage.*/, "")})
+
   system("mv spec/internal_gem spec/internal")
   Rake::Task['engine_cart:inject_gemfile_extras'].invoke
   EngineCart.within_test_app do

data/lib/engine_cart/tasks/engine_cart.rake

@@ -40,10 +40,17 @@ namespace :engine_cart do
           raise "Error generating new rails app. Aborting."
         end
       end
-      
-      Rake::Task['engine_cart:clean'].invoke if File.exists? EngineCart.destination
+
+      Rake::Task['engine_cart:clean'].invoke if File.exist? EngineCart.destination
       FileUtils.move "#{dir}/internal", "#{EngineCart.destination}"
 
+      # Hack for https://github.com/rails/web-console/issues/150
+      IO.write("spec/internal/Gemfile", File.open("spec/internal/Gemfile") do |f|
+        f.read.gsub(/.*web-console.*/, "").gsub(/.*IRB console on exception pages.*/, "")
+      end)
+      File.open("spec/internal/Gemfile", "a") do |f|
+        f.puts 'gem "web-console", group: :development'
+      end
     end
   end
 
@@ -53,7 +60,7 @@ namespace :engine_cart do
       gemfile_extras_path = File.expand_path("Gemfile.extra", EngineCart.templates_path)
 
       f.write <<-EOF
-        #{File.read(gemfile_extras_path) if File.exists?(gemfile_extras_path)}
+        #{File.read(gemfile_extras_path) if File.exist?(gemfile_extras_path)}
         gem '#{EngineCart.current_engine_name}', :path => '#{File.expand_path('.')}'
 EOF
     end
@@ -65,7 +72,7 @@ EOF
     args.with_defaults(:fingerprint => EngineCart.fingerprint) unless original_fingerprint
 
     f = File.expand_path('.generated_engine_cart', EngineCart.destination)
-    unless File.exists? f and File.read(f) == args[:fingerprint]
+    unless File.exist?(f) && File.read(f) == args[:fingerprint]
 
       # Create a new test rails app
       Rake::Task['engine_cart:create_test_rails_app'].invoke
@@ -75,7 +82,7 @@ EOF
       Rake::Task['engine_cart:inject_gemfile_extras'].invoke
 
       # Copy our test app generators into the app and prepare it
-      if File.exists? "#{EngineCart.templates_path}/lib/generators"
+      if File.exist? "#{EngineCart.templates_path}/lib/generators"
         system "cp -r #{EngineCart.templates_path}/lib/generators #{EngineCart.destination}/lib"
       end
 

data/lib/engine_cart/version.rb

@@ -1,3 +1,3 @@
 module EngineCart
-  VERSION = "0.6.0"
+  VERSION = "0.7.0"
 end

data/lib/generators/engine_cart/install_generator.rb

@@ -1,7 +1,7 @@
 require 'rails/generators'
 
 ##
-# EngineCartGenerator sets up an engine to 
+# EngineCartGenerator sets up an engine to
 # use engine_cart-generated test apps
 module EngineCart
   class InstallGenerator < Rails::Generators::Base
@@ -35,28 +35,30 @@ module EngineCart
       git_root = (`git rev-parse --show-toplevel` rescue '.').strip
 
       # If we don't have a .gitignore file already, don't worry about it
-      return unless File.exists? File.expand_path('.gitignore', git_root)
+      return unless File.exist? File.expand_path('.gitignore', git_root)
 
       # If the directory is already ignored (somehow) don't worry about it
       return if (system('git', 'check-ignore', TEST_APP, '-q') rescue false)
 
-      append_file  File.expand_path('.gitignore', git_root) do 
+      append_file  File.expand_path('.gitignore', git_root) do
         "\n#{EngineCart.destination}\n"
-      end 
+      end
     end
 
     def add_gemfile_include
       append_file "Gemfile" do
         <<-EOF
 
+  # the below comes from engine_cart, a gem used to test this Rails engine gem in the context of a Rails app
   file = File.expand_path("Gemfile", ENV['ENGINE_CART_DESTINATION'] || ENV['RAILS_ROOT'] || File.expand_path("../spec/internal", __FILE__))
-  if File.exists?(file)
+  if File.exist?(file)
     puts "Loading \#{file} ..." if $DEBUG # `ruby -d` or `bundle -v`
     instance_eval File.read(file)
   else
+    # we get here when we haven't yet generated the testing app via engine_cart
     gem 'rails', ENV['RAILS_VERSION'] if ENV['RAILS_VERSION']
 
-    if ENV['RAILS_VERSION'] and ENV['RAILS_VERSION'] =~ /^4.2/
+    if ENV['RAILS_VERSION'] && ENV['RAILS_VERSION'] =~ /^4.2/
       gem 'responders', "~> 2.0"
       gem 'sass-rails', ">= 5.0"
     else

data/spec/integration/engine_cart_spec.rb

@@ -28,27 +28,27 @@ describe "EngineCart powered application" do
   it "should create a rails app when the engine_cart:generate task is invoked" do
     EngineCart.within_test_app do
       `rake engine_cart:generate`
-      expect(File).to exist(File.expand_path("spec/internal"))
+      expect(File).to exist(File.expand_path(EngineCart.destination))
     end
   end
 
   it "should not recreate an existing rails app when the engine_cart:generate task is reinvoked" do
     EngineCart.within_test_app do
       `rake engine_cart:generate`
-      expect(File).to exist(File.expand_path("spec/internal"))
-      FileUtils.touch "spec/internal/.this_should_still_exist"
+      expect(File).to exist(File.expand_path(EngineCart.destination))
+      FileUtils.touch File.join(EngineCart.destination, ".this_should_still_exist")
       `rake engine_cart:generate`
-      expect(File).to exist(File.expand_path("spec/internal/.this_should_still_exist"))
+      expect(File).to exist(File.expand_path(File.join(EngineCart.destination, ".this_should_still_exist")))
     end
   end
   
   it "should create a rails app when the fingerprint argument is changed" do
     EngineCart.within_test_app do
       `rake engine_cart:generate[this-fingerprint]`
-      expect(File).to exist(File.expand_path("spec/internal"))
-      FileUtils.touch "spec/internal/.this_should_not_exist"
+      expect(File).to exist(File.expand_path(EngineCart.destination))
+      FileUtils.touch File.join(EngineCart.destination, ".this_should_not_exist")
       `rake engine_cart:generate[that-fingerprint]`
-      expect(File).to_not exist(File.expand_path("spec/internal/.this_should_not_exist"))
+      expect(File).to_not exist(File.expand_path(File.join(EngineCart.destination, ".this_should_not_exist")))
     end
   end
   

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: engine_cart
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Chris Beer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-23 00:00:00.000000000 Z
+date: 2015-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails