engine-assets 0.4.2 → 0.5.0

data/features/support/terminal.rb

@@ -0,0 +1,83 @@
+require 'fileutils'
+
+Before do
+  @terminal = Terminal.new
+end
+
+class Terminal
+  attr_reader :output, :status, :result
+  attr_accessor :environment_variables
+
+  def initialize
+    @cwd = FileUtils.pwd
+    @output = ""
+    @result = ""
+    @status = 0
+    @logger = Logger.new(File.join(TEMP_DIR, 'terminal.log'))
+
+    @environment_variables = {
+      "GEM_HOME" => LOCAL_GEM_ROOT,
+      "GEM_PATH" => "#{LOCAL_GEM_ROOT}:#{BUILT_GEM_ROOT}",
+      "PATH"     => "#{gem_bin_path}:#{ENV['PATH']}"
+    }
+  end
+
+  def cd(directory)
+    @cwd = directory
+  end
+
+  def run(command)
+    @output = "#{command}\n"
+
+    FileUtils.cd(@cwd) do
+      cmdline = "#{environment_settings} #{command} 2>&1"
+      logger.debug(cmdline)
+      result = `#{cmdline}`
+      logger.debug(result)
+      output << result
+      @result = clean(result)
+    end
+
+    @status = $?
+  end
+
+  def clean(content)
+    content.split("\n").reject { |line| line.match('deprecated') }.join("\n")
+  end
+
+  def echo(string)
+    logger.debug(string)
+  end
+
+  def build_and_install(gemspec)
+    pkg_dir = File.join(TEMP_DIR, 'pkg')
+    FileUtils.mkdir_p(pkg_dir)
+
+    output = `gem build #{gemspec} 2>&1`
+    gem_file = Dir.glob("*.gem").first
+    unless gem_file
+      raise "Gem didn't build:\n#{output}"
+    end
+
+    target = File.join(pkg_dir, gem_file)
+    FileUtils.mv(gem_file, target)
+    install_to(BUILT_GEM_ROOT, target)
+  end
+
+
+  private
+
+  def install_to(root, gem)
+    `gem install -i #{root} --no-ri --no-rdoc #{gem}` # textmate!! `
+  end
+
+  def environment_settings
+    @environment_variables.map { |key, value| "#{key}=#{value}" }.join(' ')
+  end
+
+  def gem_bin_path
+    File.join(LOCAL_GEM_ROOT, "bin")
+  end
+
+  attr_reader :logger
+end

data/init.rb

@@ -0,0 +1 @@
+require 'engine-assets'

data/lib/engine-assets.rb

@@ -1,5 +1,11 @@
-module EngineAssets ; end
+module EngineAssets
+  class << self
+    def version
+      IO.read(File.join(File.dirname(__FILE__), '..', 'VERSION')).strip
+    end
+  end
+end
 
-require 'action_view' unless defined?(Railss)
+require 'engine_assets/engine' if defined?(Rails) && Rails::VERSION::MAJOR == 3
 require 'engine_assets/public_locator'
 require 'engine_assets/extensions/rails/assets'

data/lib/engine_assets/engine.rb

@@ -0,0 +1,3 @@
+require 'rails' unless defined?(Rails)
+
+class EngineAssets::Engine < Rails::Engine ; end

data/lib/engine_assets/extensions/rails/assets.rb

@@ -1,3 +1,9 @@
+# TODO:
+#   * find a mechanism to do this without monkey-patching Rails
+#   * add an autoload option to load all from plugins, or similar
+#   * allow engines to indicate (automatically when #register is called?)
+#     which assets to include.
+
 module ActionView::Helpers::AssetTagHelper
   def expand_javascript_sources_with_engine_assets(sources, recursive = false)
     if sources.include?(:all)

data/lib/engine_assets/public_locator.rb

@@ -2,20 +2,35 @@ class EngineAssets::PublicLocator
   class << self
     attr_reader :paths
 
+    # TODO: expose this as EngineAssets.register(...)
     def register(full_path)
-      @paths ||= []
+      raise ArgumentError unless File.exist?(full_path)
 
+      @paths ||= []
       public_path = File.join(full_path, 'public')
-      File.open(public_path) {}
 
-      paths << public_path
+      if File.exist?(public_path)
+        # TODO:
+        #   * spec me
+        #   * split me into separate implementations
+
+        if defined?(Rails) && Rails::VERSION::MAJOR == 3
+          # Rails 3
+          Rails.configuration.middleware.use ::ActionDispatch::Static, public_path
+        else
+          # Rails 2
+          paths << public_path
+        end
+      end
     end
 
     def locate(file_path)
-      full_paths = paths.map { |base_path| File.join(base_path, file_path) }
+      full_paths = (paths || []).map { |base_path| File.join(base_path, file_path) }
+
       full_paths.each do |full_path|
         return full_path if File.exist?(full_path)
       end
+
       nil
     end
 
@@ -23,7 +38,7 @@ class EngineAssets::PublicLocator
     private
 
     def clear
-      @paths = []
+      @paths = nil
     end
   end
 end

data/spec/{controllers → app/controllers/engine_assets}/javascripts_controller_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'spec/spec_helper'
 
-describe EngineAssets::JavascriptsController do
+describe EngineAssets::JavascriptsController, :type => :controller do
   before do
     @format = 'js'
   end

data/spec/{controllers → app/controllers/engine_assets}/stylesheets_controller_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'spec/spec_helper'
 
-describe EngineAssets::StylesheetsController do
+describe EngineAssets::StylesheetsController, :type => :controller do
   before do
     @format = 'css'
   end

data/spec/lib/engine-assets_spec.rb

@@ -0,0 +1,7 @@
+require 'spec/spec_helper'
+
+describe EngineAssets do
+  it "is defined" do
+    EngineAssets.should be_a(Module)
+  end
+end

data/spec/lib/engine_assets/public_locator_spec.rb

@@ -5,7 +5,7 @@ describe EngineAssets::PublicLocator do
 
   before do
     @base_path = File.join('fixtures', 'public')
-    @full_path = File.join(basedir, 'spec', 'support', 'fixtures')
+    @full_path = File.join(SPEC_DIR, 'support', 'fixtures')
     @find_path = '/javascripts/dual.js'
     @miss_path = '/javascripts/miss.js'
 
@@ -18,16 +18,30 @@ describe EngineAssets::PublicLocator do
       it "raises an exception" do
         lambda {
           EngineAssets::PublicLocator.register('bogus')
-        }.should raise_error(Errno::ENOENT)
+        }.should raise_error(ArgumentError)
       end
     end
 
     context "when the suggest path does not contain a 'public' directory" do
-      it "raises an exception" do
+      before do
+        EngineAssets::PublicLocator.send(:clear)
+      end
+
+      it "does not raise an exception" do
         lambda {
           EngineAssets::PublicLocator.register(File.dirname(__FILE__))
-        }.should raise_error(Errno::ENOENT)
+        }.should_not raise_error
       end
+
+      it "does not add the path" do
+        EngineAssets::PublicLocator.register(File.dirname(__FILE__))
+        EngineAssets::PublicLocator.paths.should be_empty
+      end
+      # it "raises an exception" do
+      #   lambda {
+      #     EngineAssets::PublicLocator.register(File.dirname(__FILE__))
+      #   }.should raise_error(Errno::ENOENT)
+      # end
     end
 
     context "when the suggest path is valid" do
@@ -49,5 +63,15 @@ describe EngineAssets::PublicLocator do
         EngineAssets::PublicLocator.locate(miss_path).should be_nil
       end
     end
+
+    context "when no asset-providing engines have registered" do
+      before do
+        EngineAssets::PublicLocator.send(:clear)
+      end
+
+      it "returns nil" do
+        EngineAssets::PublicLocator.locate(miss_path).should be_nil
+      end
+    end
   end
 end

data/spec/shared/assets_controller_spec.rb

@@ -0,0 +1,39 @@
+require 'spec/spec_helper'
+
+begin
+  shared_examples_for "A controller acting as an AssetsController" do
+  # describe "A controller acting as an AssetsController", :shared => true do
+    attr_reader :format
+
+    integrate_views
+
+    before do
+      load_view_fixtures(@controller.class)
+    end
+
+    describe "response" do
+      context "with a matching file found in 'public'" do
+        it "renders that file" do
+          get :show, :path => 'dual', :format => format
+          response.body.should match("dual.#{format}, should be rendered")
+        end
+      end
+
+      context "with a matching file found in 'app'" do
+        it "renders that file" do
+          get :show, :path => 'solo', :format => format
+          response.body.should match("solo.#{format}.erb, should be rendered")
+        end
+      end
+
+      context "without a matching file" do
+        it "renders 404" do
+          get :show, :path => 'none', :format => format
+          response.response_code.should == 404
+        end
+      end
+    end
+  end
+rescue ArgumentError
+  puts "WARNING: #{__FILE__}:#{__LINE__} trying to load this file twice, for some reason"
+end

data/spec/shared/assets_routing_spec.rb

@@ -0,0 +1,59 @@
+require 'spec/spec_helper'
+
+begin
+  shared_examples_for "A controller routed as an AssetsController" do
+  # describe "A controller routed as an AssetsController", :shared => true do
+    attr_reader :prefix, :format
+
+    describe "routing" do
+      attr_reader :path, :route
+
+      context "given a simple path" do
+        before do
+          @path  = "/#{prefix}/asset.#{format}"
+          @route = { :controller => "engine_assets/#{prefix}", :action => 'show', :path => 'asset', :format => format }
+        end
+
+        it "recognizes the path" do
+          params_from(:get, path).should == route
+        end
+
+        it "generates the path from a URL helper" do
+          send("#{prefix}_path", :asset, :format => format).should == path
+        end
+      end
+
+      context "given a complex path of nested directories" do
+        before do
+          @path = "/#{prefix}/path/to/asset.#{format}"
+          @route = { :controller => "engine_assets/#{prefix}", :action => 'show', :path => 'path/to/asset', :format => format }
+        end
+
+        it "recognizes the path" do
+          params_from(:get, path).should == route
+        end
+
+        it "generates the path from a URL helper" do
+          CGI.unescape(send("#{prefix}_path", 'path/to/asset', :format => format)).should == CGI.unescape(path)
+        end
+      end
+
+      context "given a complex path of dotted components" do
+        before do
+          @path = "/#{prefix}/path.to/asset.one.#{format}"
+          @route = { :controller => "engine_assets/#{prefix}", :action => 'show', :path => 'path.to/asset.one', :format => format }
+        end
+
+        it "recognizes the path" do
+          params_from(:get, path).should == route
+        end
+
+        it "generates the path from a URL helper" do
+          CGI.unescape(send("#{prefix}_path", 'path.to/asset.one', :format => format)).should == CGI.unescape(path)
+        end
+      end
+    end
+  end
+rescue ArgumentError
+  puts "WARNING: #{__FILE__}:#{__LINE__} trying to load this file twice, for some reason"
+end

data/spec/spec.opts

@@ -1,4 +1,4 @@
 --colour
---loadby
-mtime
+--format progress
+--loadby mtime
 --backtrace

data/spec/spec_helper.rb

@@ -1,35 +1,74 @@
-unless defined?(RAILS_PATH)
-  RAILS_PATH = File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'vanilla'))
+require 'rubygems'
 
-  dir = File.dirname(__FILE__)
-  $LOAD_PATH.unshift(dir)
+unless defined?(PROJECT_ROOT)
+  PROJECT_ROOT   = File.expand_path(File.join(File.dirname(__FILE__), '..')).freeze
+  SPEC_DIR       = File.join(PROJECT_ROOT, 'spec').freeze
+  TEMP_DIR       = File.join(PROJECT_ROOT, 'tmp').freeze
+  BUILT_GEM_ROOT = File.join(TEMP_DIR, 'built_gems').freeze
+  LOCAL_GEM_ROOT = File.join(TEMP_DIR, 'local_gems').freeze
+  WEBAPP_ROOT    = File.join(TEMP_DIR, 'rails_root').freeze
+end
 
-  def require_files(*segments)
-    Dir[File.expand_path(File.join(*segments))].each { |file| require file }
-  end
+Dir[File.join(SPEC_DIR, 'support', '**', '*.rb')].each { |f| require f }
 
-  ENV["RAILS_ENV"] = "test"
+unless @webapp
+  ENV["RAILS_ENV"] ||= 'test'
 
-  require "#{File.join(RAILS_PATH, 'config', 'environment')}"
-  require "#{File.join(File.dirname(__FILE__), '..', 'lib', 'engine-assets')}"
-  require "#{File.join(File.dirname(__FILE__), '..', 'app', 'controllers', 'engine_assets', 'assets_controller.rb')}"
-  require "#{File.join(File.dirname(__FILE__), '..', 'app', 'controllers', 'engine_assets', 'javascripts_controller.rb')}"
-  require "#{File.join(File.dirname(__FILE__), '..', 'app', 'controllers', 'engine_assets', 'stylesheets_controller.rb')}"
-  require 'spec/autorun'
-  require 'spec/rails'
+  @webapp = Support::Rails.new(ENV['RAILS_VERSION'])
+  @webapp.build
+  @webapp.setup
+end
+
+require 'lib/engine-assets'
+%w(app config).each do |dir|
+  Dir[File.join(PROJECT_ROOT, dir, '**', '*.rb')].each { |f| require f }
+end
+
+Dir[File.join(SPEC_DIR, 'shared', '**', '*.rb')].each { |f| require f }
 
-  require_files(dir, 'support', '**', '*.rb')
+begin
+  # RSpec 1.3 (Rails 2)
+  require 'spec/rails'
+  require 'spec/autorun'
+  require 'rr'
 
   Spec::Runner.configure do |config|
     include Support::Helpers
 
-    config.fixture_path = "#{File.dirname(__FILE__)}/../spec/support/fixtures"
+    config.fixture_path = File.join(SPEC_DIR, 'support', 'fixtures')
     config.mock_with :rr
-    config.use_transactional_fixtures = true
-    config.use_instantiated_fixtures  = false
+  end
+rescue LoadError
+  # RSpec 2.0 (Rails 3)
+  require 'rspec'
+  require 'rspec/rails'
+  require 'rr'
+
+  RSpec.configure do |config|
+    include Support::Helpers
 
-    def basedir
-      @basedir ||= "#{File.expand_path(File.join(File.dirname(__FILE__), '..'))}"
-    end
+    # config.fixture_path = File.join(SPEC_DIR, 'support', 'fixtures')
+    config.mock_framework = :rr
   end
 end
+
+
+
+# begin
+#   # RSpec 1.3 (Rails 2)
+#   require 'spec/rails'
+#   require 'spec/autorun'
+# rescue LoadError
+#   # RSpec 2.0 (Rails 3)
+#   require 'rspec'
+#   require 'rspec/rails'
+# end
+# 
+# Dir[File.join(SPEC_DIR, 'shared', '**', '*.rb')].each { |f| require f }
+# 
+# Spec::Runner.configure do |config|
+#   include Support::Helpers
+# 
+#   config.fixture_path = File.join(SPEC_DIR, 'support', 'fixtures')
+#   config.mock_with :rr
+# end