engine-assets 0.3.3 → 0.4.0

data/VERSION

@@ -1 +1 @@
-0.3.3
+0.4.0

data/engine-assets.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{engine-assets}
-  s.version = "0.3.3"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Corey Innis"]
-  s.date = %q{2009-11-17}
+  s.date = %q{2009-11-18}
   s.description = %q{A Rails Engine, which enables Rails Engines to provide assets (javascript, css and images)}
   s.email = %q{support@coolerator.net}
   s.extra_rdoc_files = [
@@ -31,14 +31,10 @@ Gem::Specification.new do |s|
      "engine-assets.gemspec",
      "lib/engine-assets.rb",
      "lib/engine_assets/extensions/rails/assets.rb",
-     "lib/engine_assets/extensions/rails/plugins.rb",
-     "lib/engine_assets/extensions/rails/routes.rb",
      "lib/engine_assets/public_locator.rb",
      "rails/init.rb",
      "spec/controllers/javascripts_controller_spec.rb",
      "spec/controllers/stylesheets_controller_spec.rb",
-     "spec/lib/engine_assets/extensions/rails/plugins_spec.rb",
-     "spec/lib/engine_assets/extensions/rails/routes_spec.rb",
      "spec/lib/engine_assets/public_locator_spec.rb",
      "spec/routing/javascripts_routing_spec.rb",
      "spec/routing/stylesheets_routing_spec.rb",
@@ -64,8 +60,6 @@ Gem::Specification.new do |s|
   s.test_files = [
     "spec/controllers/javascripts_controller_spec.rb",
      "spec/controllers/stylesheets_controller_spec.rb",
-     "spec/lib/engine_assets/extensions/rails/plugins_spec.rb",
-     "spec/lib/engine_assets/extensions/rails/routes_spec.rb",
      "spec/lib/engine_assets/public_locator_spec.rb",
      "spec/routing/javascripts_routing_spec.rb",
      "spec/routing/stylesheets_routing_spec.rb",

data/lib/engine-assets.rb

@@ -2,5 +2,3 @@ module EngineAssets ; end
 
 require 'engine_assets/public_locator'
 require 'engine_assets/extensions/rails/assets'
-require 'engine_assets/extensions/rails/plugins'
-require 'engine_assets/extensions/rails/routes'

data/lib/engine_assets/public_locator.rb

@@ -1,7 +1,14 @@
 class EngineAssets::PublicLocator
   class << self
-    def paths
+    attr_reader :paths
+
+    def register(full_path)
       @paths ||= []
+
+      public_path = File.join(full_path, 'public')
+      File.open(public_path) {}
+
+      paths << public_path
     end
 
     def locate(file_path)
@@ -11,5 +18,12 @@ class EngineAssets::PublicLocator
       end
       nil
     end
+
+
+    private
+
+    def clear
+      @paths = []
+    end
   end
 end

data/spec/lib/engine_assets/public_locator_spec.rb

@@ -5,11 +5,36 @@ describe EngineAssets::PublicLocator do
 
   before do
     @base_path = File.join('fixtures', 'public')
-    @full_path = File.join(basedir, 'spec', 'support', base_path)
+    @full_path = File.join(basedir, 'spec', 'support', 'fixtures')
     @find_path = '/javascripts/dual.js'
     @miss_path = '/javascripts/miss.js'
 
-    EngineAssets::PublicLocator.paths << base_path
+    EngineAssets::PublicLocator.send(:clear)
+    EngineAssets::PublicLocator.register(full_path)
+  end
+
+  describe "#register" do
+    context "when the suggest path does not exist" do
+      it "raises an exception" do
+        lambda {
+          EngineAssets::PublicLocator.register('bogus')
+        }.should raise_error(Errno::ENOENT)
+      end
+    end
+
+    context "when the suggest path does not contain a 'public' directory" do
+      it "raises an exception" do
+        lambda {
+          EngineAssets::PublicLocator.register(File.dirname(__FILE__))
+        }.should raise_error(Errno::ENOENT)
+      end
+    end
+
+    context "when the suggest path is valid" do
+      it "adds the path" do
+        EngineAssets::PublicLocator.paths.should == ["#{full_path}/public"]
+      end
+    end
   end
 
   describe "#locate" do

data/spec/support/shared/assets_routing_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'config/routes'
 
 describe "A controller routed as an AssetsController", :shared => true do
   attr_reader :prefix, :format

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: engine-assets
 version: !ruby/object:Gem::Version 
-  version: 0.3.3
+  version: 0.4.0
 platform: ruby
 authors: 
 - Corey Innis
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-17 00:00:00 -05:00
+date: 2009-11-18 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -46,14 +46,10 @@ files:
 - engine-assets.gemspec
 - lib/engine-assets.rb
 - lib/engine_assets/extensions/rails/assets.rb
-- lib/engine_assets/extensions/rails/plugins.rb
-- lib/engine_assets/extensions/rails/routes.rb
 - lib/engine_assets/public_locator.rb
 - rails/init.rb
 - spec/controllers/javascripts_controller_spec.rb
 - spec/controllers/stylesheets_controller_spec.rb
-- spec/lib/engine_assets/extensions/rails/plugins_spec.rb
-- spec/lib/engine_assets/extensions/rails/routes_spec.rb
 - spec/lib/engine_assets/public_locator_spec.rb
 - spec/routing/javascripts_routing_spec.rb
 - spec/routing/stylesheets_routing_spec.rb
@@ -101,8 +97,6 @@ summary: Rails Engines with assets.
 test_files: 
 - spec/controllers/javascripts_controller_spec.rb
 - spec/controllers/stylesheets_controller_spec.rb
-- spec/lib/engine_assets/extensions/rails/plugins_spec.rb
-- spec/lib/engine_assets/extensions/rails/routes_spec.rb
 - spec/lib/engine_assets/public_locator_spec.rb
 - spec/routing/javascripts_routing_spec.rb
 - spec/routing/stylesheets_routing_spec.rb

data/lib/engine_assets/extensions/rails/plugins.rb

@@ -1,12 +0,0 @@
-class Rails::Plugin
-  class Loader
-    def register_plugin_as_loaded_with_engine_assets(plugin)
-      register_plugin_as_loaded_without_engine_assets(plugin)
-
-      if(plugin.engine? && File.exist?(public_dir = File.join(plugin.directory, 'public')))
-        EngineAssets::PublicLocator.paths << public_dir
-      end
-    end
-    alias_method_chain :register_plugin_as_loaded, :engine_assets
-  end
-end

data/lib/engine_assets/extensions/rails/routes.rb

@@ -1,16 +0,0 @@
-if defined?(ActionController::Routing::RouteSet)
-  class ActionController::Routing::RouteSet
-    def load_routes_with_assets!
-      lib_path      = File.dirname(__FILE__)
-      engine_routes = File.join(lib_path, *%w[.. .. .. .. config routes.rb])
-
-      unless configuration_files.include?(engine_routes)
-        add_configuration_file(engine_routes)
-      end
-
-      load_routes_without_assets!
-    end
-
-    alias_method_chain :load_routes!, :assets
-  end
-end

data/spec/lib/engine_assets/extensions/rails/plugins_spec.rb

@@ -1,52 +0,0 @@
-require 'spec/spec_helper'
-
-describe Rails::Plugin::Loader do
-  attr_reader :loader, :plugin, :directory
-
-  before do
-    @loader = Rails::Plugin::Loader.new(OpenStruct.new({ :loaded_plugins => [] }))
-  end
-
-  describe "#register_plugin_as_loaded" do
-    before do
-      paths = []
-      stub(EngineAssets::PublicLocator).paths { paths }
-    end
-
-    context "given a plugin which is an engine and contains a 'public' directory" do
-      before do
-        @directory = File.join(basedir, 'spec', 'support', 'fixtures')
-        @plugin    = OpenStruct.new({ :engine? => true, :directory => directory })
-      end
-
-      it "registers the plugin with the EngineAssets::PublicLocator" do
-        loader.send(:register_plugin_as_loaded, plugin)
-        EngineAssets::PublicLocator.paths.should == [ "#{directory}/public" ]
-      end
-    end
-
-    context "given a plugin which is an engine and does NOT contain a 'public' directory" do
-      before do
-        @directory = basedir
-        @plugin    = OpenStruct.new({ :engine? => true, :directory => directory })
-      end
-
-      it "does not register the plugin with the EngineAssets::PublicLocator" do
-        loader.send(:register_plugin_as_loaded, plugin)
-        EngineAssets::PublicLocator.paths.should == []
-      end
-    end
-
-    context "given a plugin which is NOT an engine" do
-      before do
-        @directory = File.join(basedir, 'spec', 'support', 'fixtures')
-        @plugin    = OpenStruct.new({ :engine? => false, :directory => directory })
-      end
-
-      it "does not register the plugin with the EngineAssets::PublicLocator" do
-        loader.send(:register_plugin_as_loaded, plugin)
-        EngineAssets::PublicLocator.paths.should == []
-      end
-    end
-  end
-end

data/spec/lib/engine_assets/extensions/rails/routes_spec.rb

@@ -1,28 +0,0 @@
-require 'spec/spec_helper'
-
-describe ActionController::Routing::RouteSet do
-  describe "#load_routes!" do
-    class TestRouteSet < ActionController::Routing::RouteSet
-      attr_reader :configuration_files
-
-      def initialize
-        @configuration_files = []
-      end
-
-      def add_configuration_file(routes)
-        configuration_files << routes
-      end
-    end
-
-    attr_reader :routeset
-
-    before do
-      @routeset = TestRouteSet.new
-    end
-
-    it "adds the engine-assets routes configuration" do
-      routeset.load_routes!
-      routeset.configuration_files[0].should =~ /engine[-_ ]assets.*\/config\/routes\.rb/
-    end
-  end
-end