encoded_id-rails 1.0.0.rc7 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1ef8577374a192378855b9f20acd2885770b3e49d379e3051a187db83f7de497
-  data.tar.gz: 9f574a5e8336f3588bf55c1cb9f69f8b47bcfd46a689bc007abd6f7e0143b8e6
+  metadata.gz: 7e99068282cd5784294cc5d14e2c9b9d0a80604c1a2f585438e547fb0dd83bd4
+  data.tar.gz: e089cc0f30a7e18bc4034fa80ec11c9a48e69b89133fc6e283a912ca143c3bc8
 SHA512:
-  metadata.gz: 33157300365c009da10a1a035d88aeeff2e021cace89194ab779a0ec598dd8acb6614444143f01efc3982ff68f320ce1cc2511909ca57ff1a18c712569510256
-  data.tar.gz: '08879af617396021978d6b5a46833841a8362eca06a74d151cc36934200188526c5bacac5c57cd5abf84ee8e8816e31d7ae50277a5dae756608dca1c0c5f141c'
+  metadata.gz: 0156bd7504114ab4857e34851ec615511c5100f8d86a580078573e3d761e5475405a5399dbc089a26f34dcb234e92bd2685db693db509187f148658f6b56920d
+  data.tar.gz: 72d5b551086ac2e979cbde77bac313586d5c5e02f3f0f7c2e041eacfe5b44210ad6327f78da65a917b4ad97be28606548aadffd217528b6a067257e19a41534d

data/CHANGELOG.md

@@ -2,12 +2,17 @@
 
 - nothing yet
 
-## [1.0.0] - unreleased
+## [1.0.0] - 2025-11-21
 
 - First stable release!
 
 **Important!!: `:sqids` are not compatible with `:hashids`, DO NOT CHANGE FROM ONE TO THE OTHER AFTER GOING LIVE.**
 
+### Fixed (Rails integration)
+
+- Ensure finder methods correctly override their ActiveRecord counterparts 
+- Warn when ActiveRecord integration used in model that doesn't use `id` as primary key
+
 ## [1.0.0.rc7] - 2025-11-19
 
 ### Breaking changes

data/lib/encoded_id/rails/active_record_finders.rb

@@ -18,10 +18,21 @@ module EncodedId
         if columns_hash["id"]&.type == :string
           ::Rails.logger.warn("EncodedId::Rails::ActiveRecordFinders has been included in #{name}, but this model uses string-based IDs. This may cause conflicts with encoded ID handling.")
         end
+
+        unless columns_hash.key?("id")
+          ::Rails.logger.warn("EncodedId::Rails::ActiveRecordFinders has been included in #{name}, but this model has no 'id' column. The finders will not work as expected.")
+        end
+
+        if primary_key && primary_key != "id" && columns_hash.key?("id")
+          ::Rails.logger.warn("EncodedId::Rails::ActiveRecordFinders has been included in #{name}, but the primary key is '#{primary_key}', not 'id'. This may cause unexpected behavior with find methods.")
+        end
+
+        # Use prepend so our methods take precedence over ActiveRecord's dynamic finders
+        singleton_class.prepend(ClassMethodsPrepend)
       end
 
       # Class methods for overriding ActiveRecord's finder methods to decode encoded IDs.
-      module ClassMethods
+      module ClassMethodsPrepend
         # @rbs (*untyped args) -> untyped
         def find(*args)
           first_arg = args.first

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: encoded_id-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc7
+  version: 1.0.0
 platform: ruby
 authors:
 - Stephen Ierodiaconou
 bindir: exe
 cert_chain: []
-date: 2025-11-20 00:00:00.000000000 Z
+date: 2025-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -55,14 +55,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.rc7
+        version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.rc7
+        version: 1.0.0
 description: ActiveRecord concern to use EncodedID to turn IDs into reversible and
   human friendly obfuscated strings.
 email: