emque-producing 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7696c08ea749cf14c85f0ce963fc626038baa140
-  data.tar.gz: ea30e9981cb33b17abf705ee85a9d37a946a4180
+  metadata.gz: aebb4228bc88f76f459602c76fb168366a837f35
+  data.tar.gz: 1d103b5040d76049b86e427889f84a90fcc47a5b
 SHA512:
-  metadata.gz: d3132e5cbce4b9c1fec5a428e5d7d202e6d56fa4e7f03946df231e9a73435713f49acf1d4a7de07aea1cc27fb8dc64ed58b907d65f76aa3ceb6c184789a26247
-  data.tar.gz: 3025a044fd1d2ed21200b3d8aa093bc8b340dd6637dd42b7c5ccc6cb86c60489c6ec3ec03a65a2c95d81445f004ba5f221090420ae16daf4d7c964c2ac81c48d
+  metadata.gz: 5e044a178cf2a427db36dc1629cd863220a05cdaf424bda1b34aa5e4661f6e946203aa698663788a15f0fee7da7fb71c85aefde0a86d9f37b4da0ae02c38058a
+  data.tar.gz: 067b91871131b82ff47cfe9079c03012b6282c9e0ef3d11f923ca4dc25d3df18a2827fac9a042712ae71413eb7ac1d9e16715242331fea15306438a86941951c

data/emque-producing.gemspec

@@ -29,4 +29,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec",   "~> 3.2.0"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "bunny", "~> 1.7.0"
+  spec.add_development_dependency "simplecov"
 end

data/lib/emque/producing/configuration.rb

@@ -7,6 +7,7 @@ module Emque
       attr_accessor :log_publish_message
       attr_accessor :publish_messages
       attr_reader :rabbitmq_options
+      attr_accessor :ignored_exceptions
 
       def initialize
         @app_name = ""
@@ -17,6 +18,7 @@ module Emque
         @rabbitmq_options = {
           :url => "amqp://guest:guest@localhost:5672"
         }
+        @ignored_exceptions = [Emque::Producing::Message::MessagesNotSentError]
       end
     end
   end

data/lib/emque/producing/message/message.rb

@@ -36,6 +36,14 @@ module Emque
           end
         end
 
+        def ignored_exceptions(*ignored_exceptions)
+          @ignored_exceptions = ignored_exceptions
+        end
+
+        def read_ignored_exceptions
+          (Array(@ignored_exceptions) + Emque::Producing.configuration.ignored_exceptions).uniq
+        end
+
         def private_attribute(name, coercion=nil, opts={})
           @private_attrs ||= []
           @private_attrs << name
@@ -80,6 +88,10 @@ module Emque
         self.class.read_raise_on_failure
       end
 
+      def ignored_exceptions
+        self.class.read_ignored_exceptions
+      end
+
       def valid?
         invalid_attributes.empty? && topic && message_type
       end
@@ -97,21 +109,26 @@ module Emque
         Oj.dump(data, :mode => :compat)
       end
 
-      def publish(publisher=Emque::Producing.publisher)
+      def publish(publisher=nil)
+        publisher ||= Emque::Producing.publisher
         log "publishing...", true
         if valid?
           log "valid...", true
           if Emque::Producing.configuration.publish_messages
             sent = publisher.publish(topic, message_type, to_json, partition_key)
             log "sent #{sent}"
-            if raise_on_failure? && !sent
-              raise MessagesNotSentError.new
-            end
+            raise MessagesNotSentError.new unless sent
           end
         else
           log "failed...", true
           raise InvalidMessageError.new(invalid_message)
         end
+      rescue *ignored_exceptions => error
+        if raise_on_failure?
+          raise
+        else
+          log "failed ignoring exception... #{error}", true
+        end
       end
 
       private

data/lib/emque/producing/publisher/rabbitmq.rb

@@ -5,6 +5,10 @@ module Emque
   module Producing
     module Publisher
       class RabbitMq < Emque::Producing::Publisher::Base
+        Emque::Producing.configure do |c|
+          c.ignored_exceptions = c.ignored_exceptions + [Bunny::Exception, Timeout::Error]
+        end
+
         CONN = Bunny
           .new(Emque::Producing.configuration.rabbitmq_options[:url])
           .tap { |conn|

data/lib/emque/producing/version.rb

@@ -1,5 +1,5 @@
 module Emque
   module Producing
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

data/spec/producing/message/message_spec.rb

@@ -56,6 +56,32 @@ class TestMessageWithChangeset
   )
 end
 
+class TestMessageDontRaiseOnFailure
+  include Emque::Producing.message
+
+  IgnoreThisError = Class.new(StandardError)
+  DontIgnoreThisError = Class.new(StandardError)
+
+  topic "queue"
+  message_type "queue.new"
+
+  ignored_exceptions IgnoreThisError
+
+  raise_on_failure false
+end
+
+class TestPublisher
+  InvalidMessageError = Class.new(StandardError)
+  TimeoutMessageError = Class.new(StandardError)
+
+  Emque::Producing.configure do |c|
+    c.ignored_exceptions = c.ignored_exceptions + [InvalidMessageError, TimeoutMessageError]
+  end
+
+  def publish(topic, message_type, message, key = nil)
+  end
+end
+
 describe Emque::Producing::Message do
   before { Emque::Producing.configure { |c| c.app_name = "my_app" } }
 
@@ -260,4 +286,65 @@ describe Emque::Producing::Message do
       )
     end
   end
+
+  context "raise_on_failure" do
+    describe "when false" do
+      let(:message) { TestMessageDontRaiseOnFailure.new() }
+      let(:publisher) { TestPublisher.new }
+
+      it "catches exceptions from publisher" do
+        allow(Emque::Producing).to receive(:publisher) { raise TestPublisher::InvalidMessageError }
+
+        expect{message.publish()}.not_to raise_error
+      end
+
+      it "catches exceptions from publish" do
+        allow(publisher).to receive(:publish) { raise TestPublisher::TimeoutMessageError }
+
+        expect{message.publish(publisher)}.not_to raise_error
+      end
+
+      it "catches exceptions when publish doesn't send" do
+        allow(publisher).to receive(:publish) { false }
+
+        expect{message.publish(publisher)}.not_to raise_error
+      end
+
+      it "catches exceptions when publish doesn't send" do
+        allow(publisher).to receive(:publish) { raise TestMessageDontRaiseOnFailure::IgnoreThisError }
+
+        expect{message.publish(publisher)}.not_to raise_error
+      end
+
+      it "doesnt catch an exceptions that isn't in the " do
+        allow(publisher).to receive(:publish) { raise TestMessageDontRaiseOnFailure::DontIgnoreThisError }
+
+        expect{message.publish(publisher)}.to raise_error(TestMessageDontRaiseOnFailure::DontIgnoreThisError)
+      end
+
+    end
+
+    describe "when true" do
+      let(:message) { TestMessage.new(:test_id => 1) }
+      let(:publisher) { TestPublisher.new }
+
+      it "doesn't catch exceptions from publisher" do
+        allow(Emque::Producing).to receive(:publisher) { raise TestPublisher::InvalidMessageError }
+
+        expect{message.publish()}.to raise_error(TestPublisher::InvalidMessageError)
+      end
+
+      it "doesn't catch exceptions from publish" do
+        allow(publisher).to receive(:publish) { raise TestPublisher::TimeoutMessageError }
+
+        expect{message.publish(publisher)}.to raise_error(TestPublisher::TimeoutMessageError)
+      end
+
+      it "doesn't catch exceptions when publish doesn't send" do
+        allow(publisher).to receive(:publish) { false }
+
+        expect{message.publish(publisher)}.to raise_error(Emque::Producing::Message::MessagesNotSentError)
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,10 @@
 $TESTING = true
 
+require "simplecov"
+SimpleCov.start do
+  add_filter "spec/"
+end
+
 require "pry"
 require "emque-producing"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: emque-producing
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Emily Dobervich
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-22 00:00:00.000000000 Z
+date: 2015-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oj
@@ -109,6 +109,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.7.0
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Define and send messages to a variety of message brokers
 email:
 - emily@teamsnap.com