emque-consuming 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4fd47c625dd718cb34caef7debf0ed863e281aa8
-  data.tar.gz: 96ec8d035b27f2dfdd026190c6676a49ef4a1a47
+  metadata.gz: 12f58267d541cb53c2dcd731663e1c19da52c801
+  data.tar.gz: c9555bff3fc2315e542cd637d4d2a4f387895169
 SHA512:
-  metadata.gz: d8d897f63d2584abd1193524ee2ef24736fcd5319586a3933511f5f2b9f8ad345f6f2ecf37ec6c891af79be535606cd303276469d0817a113de155702b3f60f0
-  data.tar.gz: c35297d72fe10c75b6a45778367f21886c6a14a4c16aec28335bb80e577554f766940c44d9207ce400fdff2ed207c1aecc5d0e1ad311e96db9741d128fac5c66
+  metadata.gz: 9fce1adb82ccb832409b252e1ed3d2741fc80ae8e4706cac533bd594141915b10d98a3aacef168fc145e3f95170c3e9ef5675d402bad1a46b4651e069b4012fc
+  data.tar.gz: d0d287ed1519c23dcccc52bf9cc1dd3641af322d0ba1f47382a4fcc529321eb1251c714394bf3a5cf575d545bfc45d78dfad59b309683ae87dc907eb2f22c661

data/CHANGELOG.md

@@ -1,4 +1,8 @@
-## 1.0.0.beta4 — (unreleased)
+# Emque Consuming CHANGELOG
+
+- [Add in a configuration option to disable auto shutdown on reaching the error limit](https://github.com/emque/emque-consuming/pull/58) 1.1.3
+
+## 1.0.0.beta4
 
 ### BREAKING CHANGE - New Queue Names
 Applications updating to this version will have new queue names in RabbitMQ.

data/README.md

@@ -157,6 +157,7 @@ emque <options> (start|stop|new|console|help) <name (new only)>
     -x, --error-expiration SECONDS   Expire errors after SECONDS
         --app-name NAME              Run the application as NAME
         --env (ex. production)       Set the application environment, overrides EMQUE_ENV
+        --auto-shutdown (false|true) Enable or disable auto shutdown on reaching the error limit
 ```
 
 and a series of rake commands:

data/lib/emque/consuming/application.rb

@@ -62,13 +62,19 @@ module Emque
 
       def verify_error_status
         if error_tracker.limit_reached?
-          handle_shutdown
-          runner.stop
+          if auto_shutdown_enabled
+            handle_shutdown
+            runner.stop
+          end
         end
       end
 
       # private
 
+      def auto_shutdown_enabled
+        config.auto_shutdown
+      end
+
       def ensure_adapter_is_configured!
         if config.adapter.nil?
           raise AdapterConfigurationError,

data/lib/emque/consuming/cli.rb

@@ -132,6 +132,18 @@ module Emque
             options[:env] = arg
           end
 
+          o.on(
+            "--auto-shutdown (false|true)",
+            "Enable or disable auto shutdown on reaching the error limit"
+          ) do |arg|
+            exp = arg.to_s
+            if exp == "true"
+              options[:auto_shutdown] = true
+            else
+              options[:auto_shutdown] = false
+            end
+          end
+
           o.banner = "emque <options> (start|stop|new|console|help) <name (new only)>"
         }
       end

data/lib/emque/consuming/configuration.rb

@@ -3,13 +3,14 @@ require "logger"
 module Emque
   module Consuming
     class Configuration
-      attr_accessor :app_name, :adapter, :error_handlers, :error_limit,
-        :error_expiration, :status, :status_port, :status_host, :socket_path,
-        :shutdown_handlers
+      attr_accessor :app_name, :auto_shutdown, :adapter, :error_handlers,
+        :error_limit, :error_expiration, :status, :status_port, :status_host,
+        :socket_path, :shutdown_handlers
       attr_writer :env, :log_level
 
       def initialize
-        @app_name = ""
+        @app_name           = ""
+        @auto_shutdown      = false
         @error_handlers     = []
         @error_limit        = 5
         @error_expiration   = 3600 # 60 minutes
@@ -41,6 +42,7 @@ module Emque
         {}.tap { |config|
           [
             :app_name,
+            :auto_shutdown,
             :adapter,
             :env,
             :error_handlers,

data/lib/emque/consuming/version.rb

@@ -1,5 +1,5 @@
 module Emque
   module Consuming
-    VERSION = "1.1.2"
+    VERSION = "1.1.3"
   end
 end

data/spec/application_spec.rb

@@ -14,6 +14,7 @@ describe Emque::Consuming::Application do
 
     it "triggers a shutdown one the error_limit is reached" do
       Dummy::Application.config.error_limit = 2
+      Dummy::Application.config.auto_shutdown = true
       app = Dummy::Application.new
       Emque::Consuming::Runner.instance =
         double(:runner, :status => double(:status, :to_h => {}))
@@ -24,5 +25,20 @@ describe Emque::Consuming::Application do
       app.notice_error({ :test => "failure" })
       app.notice_error({ :test => "another failure" })
     end
+
+    it "doesn't shutdown if the error_limit is disabled" do
+      Dummy::Application.config.error_limit = 2
+      Dummy::Application.config.auto_shutdown = false
+      app = Dummy::Application.new
+      Emque::Consuming::Runner.instance =
+        double(:runner, :status => double(:status, :to_h => {}))
+
+      expect(Emque::Consuming::Runner.instance)
+        .to receive(:stop).exactly(0).times
+
+      app.notice_error({ :test => "failure" })
+      app.notice_error({ :test => "another failure" })
+
+    end
   end
 end

data/spec/configuration_spec.rb

@@ -22,9 +22,9 @@ describe Emque::Consuming::Configuration do
 
     it "returns the value of all the accessors" do
       accessors = [
-        :app_name, :adapter, :env, :error_handlers, :error_limit,
-        :error_expiration, :log_level, :status_port, :status_host, :status,
-        :socket_path, :shutdown_handlers
+        :app_name, :auto_shutdown, :adapter, :env, :error_handlers,
+        :error_limit, :error_expiration, :log_level, :status_port, :status_host,
+        :status, :socket_path, :shutdown_handlers
       ]
       config = Emque::Consuming::Configuration.new
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: emque-consuming
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Ryan Williams
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-03 00:00:00.000000000 Z
+date: 2016-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: celluloid
@@ -287,7 +287,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Microservices framework for Ruby
@@ -307,4 +307,3 @@ test_files:
 - spec/router_spec.rb
 - spec/runner_spec.rb
 - spec/spec_helper.rb
-has_rdoc: