emporium 0.0.1 → 0.0.2.alpha

data/README.md

@@ -12,19 +12,29 @@ Add to your Gemfile and run the `bundle` command to install it.
 
 **Requires Ruby 1.9.2 or later.**
 
+## Configuration
+
+ ```ruby
+ Product.configuration do |config|
+   config.service = :amazon
+   # ...
+ end
+ ```
+
 
 ## Usage
 
-Given a UPC returns a product object that gets populated calling fetch. The Code class takes UPC-A or EAN digits
+Give it a UPC to fetch a product object. The Code only takes UPC-A digits
 
  ```ruby
  require 'emporium'
 
  product = Emporium::Product.new "066661234567"
- product.use :amazon
  product.fetch!
  ```
 
+
+
 ## Development
 
-This gem is created by Hugo Bastien and is under the MIT License.
+This gem is under the MIT License.

data/lib/emporium/product.rb

@@ -1,36 +1,21 @@
 module Emporium
   class Product
     attr_accessor :code
+    attr_accessor :service
     
-    def initialize(code, options={})
-      @code = ::Code.new(code)
+    def initialize(code)
+      @code = Emporium::Code.new(code)
       raise "invalid code" unless @code.valid?
-      @options = options.merge! code: @code.value
     end
     
     def fetch!
-      if @@service == :amazon
-        create ::Nokogiri::XML(open("#{@@service_url}?#{signed_query}"))
-      end
+      create @service.response
     end
 
-    def self.class_option(*symbols)
-      symbols.each do |symbol|
-        class_eval(<<-EOS)
-          def self.#{symbol}
-            @@#{symbol}
-          end
-
-          def self.#{symbol}=(value)
-            @@#{symbol} = value
-          end
-        EOS
-      end
+    def use(service)
+      @service = service.new(code: @code.value)
     end
 
-    class_option :access_key, :secret, :associate_tag
-    class_option :service, :service_url
-
     def method_missing(name, *args)
       if self.instance_variables.include? :"@#{name}"
         self.instance_variable_get("@#{name}")
@@ -40,47 +25,10 @@ module Emporium
     end
     
   private
-
-    def create(result)
-      if @@service == :amazon
-        result.search("ItemAttributes").children.each do |value|
-          self.instance_variable_set("@#{value.name.downcase}",  value.content)
-        end
+    def create(response)
+      response.search("ItemAttributes").children.each do |value|
+        self.instance_variable_set("@#{value.name.downcase}",  value.content)
       end
     end
-  
-    def params
-      {
-        "Service" => "AWSECommerceService",
-        "Operation" => "ItemLookup",
-        "IdType" => "UPC",
-        "ItemId" => @code.value,
-        "SearchIndex" => @options[:search_index] || "All",
-        "ResponseGroup" => @options[:response_group] || "Medium",
-        "Version" => @options[:version] || "2011-08-01",
-        "AssociateTag" => @@associate_tag,
-        "Timestamp" => Time.now.iso8601,
-        "AWSAccessKeyId" => @@access_key
-      }
-    end
-
-    def to_query(hash)
-      hash.sort.collect { |k, v| [encode(k), encode(v.to_s)].join("=") }.join("&")
-    end
-
-    def signed_query
-      digest = HMAC::SHA256.digest(@@secret, request)
-      signature = Base64.encode64(digest).chomp
-      to_query(params.merge "Signature" => signature)
-    end
-
-    def encode(value)
-      CGI.escape(value).gsub("%7E", "~").gsub("+", "%20")
-    end
-
-    def request
-      "GET\nwebservices.amazon.com\n/onca/xml\n#{to_query(params)}"
-    end
-
   end
 end

data/lib/emporium/services/amazon.rb

@@ -0,0 +1,72 @@
+module Emporium
+  module Services
+    class Amazon
+      def initialize(options={})
+        @options = options
+      end
+
+      def response
+        res = ::Nokogiri::XML(open("http://webservices.amazon.com/onca/xml?#{signed_query}"))
+        message = res.search('Message')
+        raise message.children.first.content unless message.empty?
+        res
+      end
+
+    private
+      def params
+        {
+          "Service" => "AWSECommerceService",
+          "Operation" => "ItemLookup",
+          "IdType" => "UPC",
+          "ItemId" => @options[:code],
+          "SearchIndex" => @options[:search_index] || "All",
+          "ResponseGroup" => @options[:response_group] || "Medium",
+          "Version" => @options[:version] || "2011-08-01",
+          "AssociateTag" => @@associate_tag,
+          "Timestamp" => Time.now.iso8601,
+          "AWSAccessKeyId" => @@access_key
+        }
+      end
+
+      def to_query(hash)
+        hash.sort.collect { |k, v| [encode(k), encode(v.to_s)].join("=") }.join("&")
+      end
+
+      def signed_query
+        digest = HMAC::SHA256.digest(@@secret, request)
+        signature = Base64.encode64(digest).chomp
+        to_query(params.merge "Signature" => signature)
+      end
+
+      def encode(value)
+        CGI.escape(value).gsub("%7E", "~").gsub("+", "%20")
+      end
+
+      def request
+        "GET\nwebservices.amazon.com\n/onca/xml\n#{to_query(params)}"
+      end
+      class << self
+
+        def configuration
+          yield self
+        end
+
+        def class_option(*symbols)
+          symbols.each do |symbol|
+            class_eval(<<-EOS)
+              def self.#{symbol}
+                @@#{symbol}
+              end
+
+              def self.#{symbol}=(value)
+                @@#{symbol} = value
+              end
+            EOS
+          end
+        end
+      end
+
+      class_option :access_key, :secret, :associate_tag
+    end
+  end
+end

data/lib/emporium/services.rb

@@ -0,0 +1,9 @@
+require 'emporium/services/amazon'
+
+require 'hmac'
+require 'hmac-sha2'
+require 'time'
+require 'cgi'
+require 'base64'
+require 'open-uri'
+require 'nokogiri'

data/lib/emporium/version.rb

@@ -1,3 +1,3 @@
 module Emporium
-  VERSION = "0.0.1"
+  VERSION = "0.0.2.alpha"
 end

data/lib/emporium.rb

@@ -1,11 +1,4 @@
 require "emporium/version"
+require "emporium/services"
 require "emporium/code"
 require "emporium/product"
-
-require 'hmac'
-require 'hmac-sha2'
-require 'time'
-require 'cgi'
-require 'base64'
-require 'nokogiri'
-require 'open-uri'

data/spec/emporium/emporium_spec.rb

@@ -1,40 +1,30 @@
 require 'spec_helper'
 
-describe Product do
-  before(:each) do
-    Product.service = :amazon
-    Product.service_url = "http://webservices.amazon.com/onca/xml"
-    Product.access_key = CONFIG["access_key"]
-    Product.associate_tag = CONFIG["associate_tag"]
-    Product.secret = CONFIG["secret"]
-  end
-
-  it "uses the amazon service" do
-    Product.service.should be :amazon
-  end
+Emporium::Services::Amazon.configuration do |config|
+  config.access_key = CONFIG["access_key"]
+  config.associate_tag = CONFIG["associate_tag"]
+  config.secret = CONFIG["secret"]
+end
 
+describe Emporium::Product do
   describe "#new" do
     it "creates an instance from a upc" do
-      product = Product.new("036000241457")
-      product.should be_an_instance_of Product
+      product = Emporium::Product.new("036000241457")
+      product.should be_an_instance_of Emporium::Product
     end
     
     it "fails to create an instance if no upc is given" do
-      lambda { Product.new() }.should raise_error
+      lambda { Emporium::Product.new() }.should raise_error
     end
     
     it "fails to create an instance if invalid upc is given" do
-      lambda { Product.new("036000241452") }.should raise_error
-    end
-
-    it "has options in options if provided" do
-      product = Product.new("036000241457", secret: 'secret')
-      product.instance_eval { @options[:secret] }.should match 'secret'
+      lambda { Emporium::Product.new("036000241452") }.should raise_error
     end
   end
 
   describe "#fetch!" do
-    product = Product.new("610839331574")
+    product = Emporium::Product.new("610839331574")
+    product.use Emporium::Services::Amazon
 
     it "should fetch product information" do
       lambda { product.fetch! }.should_not raise_error
@@ -44,19 +34,47 @@ describe Product do
       product.fetch!
       product.brand.should match 'Asus'
     end
+  end
+
+  describe "#use" do
+    it "tells a product what service to use" do
+      product = Emporium::Product.new("610839331574")
+      product.use Emporium::Services::Amazon
+      product.service.should be_an_instance_of Emporium::Services::Amazon
+    end
+  end
+end
 
+describe Emporium::Services::Amazon do
+  describe "#new" do
+    it "should initialize with options" do
+      options = {some: "option"}
+      service = Emporium::Services::Amazon.new(options)
+      service.instance_variable_get('@options')[:some].should match "option"
+    end
+  end
+
+  describe "#response" do
+    it "should return an XML document" do
+      service = Emporium::Services::Amazon.new(code: "610839331574")
+      service.response.should be_a_kind_of ::Nokogiri::XML::Document
+    end
+
+    it "should raise an error if nothing is found" do
+      lambda { Emporium::Services::Amazon.new(code: "036000241452").response }.should raise_error
+    end
   end
 end
 
-describe Code do
+describe Emporium::Code do
   describe "#valid?" do
     it "returns true for a valid UPC" do
-      code = Code.new("036000241457")
+      code = Emporium::Code.new("036000241457")
       code.valid?.should be true
     end
     
     it "returns false for an invalid UPC" do
-      code = Code.new("036000241452")
+      code = Emporium::Code.new("036000241452")
       code.valid?.should_not be true
     end
   end

data/spec/spec_helper.rb

@@ -2,4 +2,3 @@ require 'emporium'
 require 'yaml'
 
 CONFIG = YAML.load_file('./spec/config.yml')
-include Emporium

metadata

@@ -1,8 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: emporium
 version: !ruby/object:Gem::Version 
-  prerelease: 
-  version: 0.0.1
+  prerelease: 6
+  version: 0.0.2.alpha
 platform: ruby
 authors: 
 - Hugo Bastien
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-12-04 00:00:00 Z
+date: 2011-12-05 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: nokogiri
@@ -64,6 +64,8 @@ files:
 - lib/emporium.rb
 - lib/emporium/code.rb
 - lib/emporium/product.rb
+- lib/emporium/services.rb
+- lib/emporium/services/amazon.rb
 - lib/emporium/version.rb
 - spec/emporium/emporium_spec.rb
 - spec/spec_helper.rb
@@ -84,9 +86,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version 
-      version: "0"
+      version: 1.3.1
 requirements: []
 
 rubyforge_project: emporium