embulk-parser-query_string 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ac626f433219956351f1469cb10fcb04bc6d8f7
-  data.tar.gz: 9867d72ed16d696d33a03c7221f7ca628ac9f50b
+  metadata.gz: 1d212e03f093b093ae862308c637069251feb71a
+  data.tar.gz: 968354927bcd4ab12998fe8c366e79e3613401bc
 SHA512:
-  metadata.gz: 891c288a06ffff07142f4e12ad7ebbcb73d6b0c3811547d678f7b83a80a9790de7b2cf9fdbf8bf1b9bbe9afaf9dc1bded2d83a18d1c800b85d4c57328add6aa1
-  data.tar.gz: 6dfc5c6461092a8fb5243c9b910a798b5a82c87fc9a71cc7612ecad3f2d91a7bb73a26ab0d14d2383a03a32ab449afb24bb62cc50fa0bbd63f0ae7c8c4ff6862
+  metadata.gz: 5e31e9f7e2675cf161686d05a4517bddeac6be16cc8eeb890c86257bff274077a8735060e8dd0d5a269a061497fec1b30a4e7b930b2f02c740a8f982be0ae12f
+  data.tar.gz: e5e3adfa549e74d627b6afa06acad1b30026811b0db9073cafaa63254156f16774ae00143dc6a9ba630f10fac6c2904d572b3d31adabfeaa4336b1efd5127416

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.1.2 - 2015-07-14
+* [fixed] Fix to ignore empty line same as invalid line [#14](https://github.com/treasure-data/embulk-parser-query_string/pull/14)
+
 ## 0.1.1 - 2015-07-14
 * [fixed] Add missing support capture option to parser [#13](https://github.com/treasure-data/embulk-parser-query_string/pull/13)
 

data/embulk-parser-query_string.gemspec

@@ -1,7 +1,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "embulk-parser-query_string"
-  spec.version       = "0.1.1"
+  spec.version       = "0.1.2"
   spec.authors       = ["yoshihara", "uu59"]
   spec.summary       = "Query String parser plugin for Embulk"
   spec.description   = "Parses Query String files read by other file input plugins."

data/lib/embulk/parser/query_string.rb

@@ -52,10 +52,12 @@ module Embulk
 
       def self.parse(line, options = {})
         if options[:capture]
-          line = line.match(options[:capture]).to_a[1]
+          line = line.match(options[:capture]).to_a[1] || ""
           # TODO: detect incorrect regexp given
         end
-        line.chomp!
+
+        return if line == ""
+
         line.strip! if options[:strip_whitespace]
         if options[:strip_quote]
           line = line[/\A(?:["'])?(.*?)(?:["'])?\z/, 1]

data/test/embulk/parser/test_query_string_plugin.rb

@@ -36,6 +36,16 @@ module Embulk
           assert_nil(result)
         end
 
+        def test_empty_line
+          result = QueryString.parse("")
+          assert_nil(result)
+        end
+
+        def test_empty_matched
+          result = QueryString.parse("foo=bar", capture: /foo/) # $1 is undefined, so treated as empty string
+          assert_nil(result)
+        end
+
         private
 
         def expected

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: embulk-parser-query_string
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - yoshihara