embulk-parser-poi_excel 0.1.1 → 0.1.2

data/src/main/java/org/embulk/parser/poi_excel/visitor/PoiExcelClientAnchorVisitor.java

@@ -7,7 +7,7 @@ import java.util.Map;
 
 import org.apache.poi.ss.usermodel.Cell;
 import org.apache.poi.ss.usermodel.ClientAnchor;
-import org.embulk.parser.poi_excel.PoiExcelParserPlugin.ColumnOptionTask;
+import org.embulk.parser.poi_excel.bean.PoiExcelColumnBean;
 import org.embulk.spi.Column;
 
 public class PoiExcelClientAnchorVisitor extends AbstractPoiExcelCellAttributeVisitor<ClientAnchor> {
@@ -25,7 +25,7 @@ public class PoiExcelClientAnchorVisitor extends AbstractPoiExcelCellAttributeVi
 	}
 
 	@Override
-	protected ClientAnchor getAttributeSource(Column column, ColumnOptionTask option, Cell cell) {
+	protected ClientAnchor getAttributeSource(PoiExcelColumnBean bean, Cell cell) {
 		throw new UnsupportedOperationException();
 	}
 

data/src/main/java/org/embulk/parser/poi_excel/visitor/PoiExcelColumnVisitor.java

@@ -1,14 +1,12 @@
 package org.embulk.parser.poi_excel.visitor;
 
 import java.text.MessageFormat;
-import java.util.List;
 
 import org.apache.poi.ss.usermodel.Cell;
 import org.apache.poi.ss.usermodel.Row;
 import org.apache.poi.ss.util.CellReference;
 import org.embulk.parser.poi_excel.PoiExcelColumnValueType;
-import org.embulk.parser.poi_excel.PoiExcelParserPlugin.ColumnOptionTask;
-import org.embulk.parser.poi_excel.PoiExcelParserPlugin.PluginTask;
+import org.embulk.parser.poi_excel.bean.PoiExcelColumnBean;
 import org.embulk.parser.poi_excel.visitor.embulk.CellVisitor;
 import org.embulk.spi.Column;
 import org.embulk.spi.ColumnVisitor;
@@ -26,14 +24,6 @@ public class PoiExcelColumnVisitor implements ColumnVisitor {
 		this.visitorValue = visitorValue;
 		this.pageBuilder = visitorValue.getPageBuilder();
 		this.factory = visitorValue.getVisitorFactory();
-
-		initializeColumnOptions();
-	}
-
-	protected void initializeColumnOptions() {
-		PluginTask task = visitorValue.getPluginTask();
-		List<ColumnOptionTask> options = visitorValue.getColumnOptions();
-		new PoiExcelColumnIndex().initializeColumnIndex(task, options);
 	}
 
 	public void setRow(Row row) {
@@ -70,16 +60,16 @@ public class PoiExcelColumnVisitor implements ColumnVisitor {
 			visitCell(column, visitor);
 		} catch (Exception e) {
 			String sheetName = visitorValue.getSheet().getSheetName();
-			String ref = new CellReference(currentRow.getRowNum(), visitorValue.getColumnOption(column)
-					.getColumnIndex()).formatAsString();
+			String ref = new CellReference(currentRow.getRowNum(), visitorValue.getColumnBean(column).getColumnIndex())
+					.formatAsString();
 			throw new RuntimeException(MessageFormat.format("error at {0} cell={1}!{2}. {3}", column, sheetName, ref,
 					e.getMessage()), e);
 		}
 	}
 
 	protected void visitCell(Column column, CellVisitor visitor) {
-		ColumnOptionTask option = visitorValue.getColumnOption(column);
-		PoiExcelColumnValueType valueType = option.getValueTypeEnum();
+		PoiExcelColumnBean bean = visitorValue.getColumnBean(column);
+		PoiExcelColumnValueType valueType = bean.getValueType();
 
 		switch (valueType) {
 		case SHEET_NAME:
@@ -89,14 +79,17 @@ public class PoiExcelColumnVisitor implements ColumnVisitor {
 			visitor.visitRowNumber(column, currentRow.getRowNum() + 1);
 			return;
 		case COLUMN_NUMBER:
-			visitor.visitColumnNumber(column, option.getColumnIndex() + 1);
+			visitor.visitColumnNumber(column, bean.getColumnIndex() + 1);
+			return;
+		case CONSTANT:
+			visitCellConstant(column, bean.getValueTypeSuffix(), visitor);
 			return;
 		default:
 			break;
 		}
 
 		assert valueType.useCell();
-		Cell cell = currentRow.getCell(option.getColumnIndex());
+		Cell cell = currentRow.getCell(bean.getColumnIndex());
 		if (cell == null) {
 			visitCellNull(column);
 			return;
@@ -104,43 +97,51 @@ public class PoiExcelColumnVisitor implements ColumnVisitor {
 		switch (valueType) {
 		case CELL_VALUE:
 		case CELL_FORMULA:
-			visitCellValue(column, option, cell, visitor);
+			visitCellValue(bean, cell, visitor);
 			return;
 		case CELL_STYLE:
-			visitCellStyle(column, option, cell, visitor);
+			visitCellStyle(bean, cell, visitor);
 			return;
 		case CELL_FONT:
-			visitCellFont(column, option, cell, visitor);
+			visitCellFont(bean, cell, visitor);
 			return;
 		case CELL_COMMENT:
-			visitCellComment(column, option, cell, visitor);
+			visitCellComment(bean, cell, visitor);
 			return;
 		default:
 			throw new UnsupportedOperationException(MessageFormat.format("unsupported value_type={0}", valueType));
 		}
 	}
 
+	protected void visitCellConstant(Column column, String value, CellVisitor visitor) {
+		if (value == null) {
+			pageBuilder.setNull(column);
+			return;
+		}
+		visitor.visitCellValueString(column, null, value);
+	}
+
 	protected void visitCellNull(Column column) {
 		pageBuilder.setNull(column);
 	}
 
-	private void visitCellValue(Column column, ColumnOptionTask option, Cell cell, CellVisitor visitor) {
+	private void visitCellValue(PoiExcelColumnBean bean, Cell cell, CellVisitor visitor) {
 		PoiExcelCellValueVisitor delegator = factory.getPoiExcelCellValueVisitor();
-		delegator.visitCellValue(column, option, cell, visitor);
+		delegator.visitCellValue(bean, cell, visitor);
 	}
 
-	private void visitCellStyle(Column column, ColumnOptionTask option, Cell cell, CellVisitor visitor) {
+	private void visitCellStyle(PoiExcelColumnBean bean, Cell cell, CellVisitor visitor) {
 		PoiExcelCellStyleVisitor delegator = factory.getPoiExcelCellStyleVisitor();
-		delegator.visit(column, option, cell, visitor);
+		delegator.visit(bean, cell, visitor);
 	}
 
-	private void visitCellFont(Column column, ColumnOptionTask option, Cell cell, CellVisitor visitor) {
+	private void visitCellFont(PoiExcelColumnBean bean, Cell cell, CellVisitor visitor) {
 		PoiExcelCellFontVisitor delegator = factory.getPoiExcelCellFontVisitor();
-		delegator.visit(column, option, cell, visitor);
+		delegator.visit(bean, cell, visitor);
 	}
 
-	private void visitCellComment(Column column, ColumnOptionTask option, Cell cell, CellVisitor visitor) {
+	private void visitCellComment(PoiExcelColumnBean bean, Cell cell, CellVisitor visitor) {
 		PoiExcelCellCommentVisitor delegator = factory.getPoiExcelCellCommentVisitor();
-		delegator.visit(column, option, cell, visitor);
+		delegator.visit(bean, cell, visitor);
 	}
 }

data/src/main/java/org/embulk/parser/poi_excel/visitor/PoiExcelVisitorFactory.java

@@ -15,6 +15,10 @@ public class PoiExcelVisitorFactory {
 		visitorValue.setVisitorFactory(this);
 	}
 
+	public final PoiExcelVisitorValue getVisitorValue() {
+		return visitorValue;
+	}
+
 	// visitor root (Embulk ColumnVisitor)
 	private PoiExcelColumnVisitor poiExcelColumnVisitor;
 

data/src/main/java/org/embulk/parser/poi_excel/visitor/PoiExcelVisitorValue.java

@@ -1,28 +1,25 @@
 package org.embulk.parser.poi_excel.visitor;
 
-import java.util.ArrayList;
-import java.util.List;
-
 import org.apache.poi.ss.usermodel.Sheet;
-import org.embulk.parser.poi_excel.PoiExcelParserPlugin.ColumnOptionTask;
 import org.embulk.parser.poi_excel.PoiExcelParserPlugin.PluginTask;
+import org.embulk.parser.poi_excel.bean.PoiExcelColumnBean;
+import org.embulk.parser.poi_excel.bean.PoiExcelSheetBean;
 import org.embulk.spi.Column;
-import org.embulk.spi.ColumnConfig;
 import org.embulk.spi.PageBuilder;
-import org.embulk.spi.SchemaConfig;
+import org.embulk.spi.Schema;
 
 public class PoiExcelVisitorValue {
 	private final PluginTask task;
 	private final Sheet sheet;
 	private final PageBuilder pageBuilder;
+	private final PoiExcelSheetBean sheetBean;
 	private PoiExcelVisitorFactory factory;
 
-	private List<ColumnOptionTask> columnOptions;
-
-	public PoiExcelVisitorValue(PluginTask task, Sheet sheet, PageBuilder pageBuilder) {
+	public PoiExcelVisitorValue(PluginTask task, Schema schema, Sheet sheet, PageBuilder pageBuilder) {
 		this.task = task;
 		this.sheet = sheet;
 		this.pageBuilder = pageBuilder;
+		this.sheetBean = new PoiExcelSheetBean(task, schema, sheet);
 	}
 
 	public PluginTask getPluginTask() {
@@ -45,19 +42,11 @@ public class PoiExcelVisitorValue {
 		return factory;
 	}
 
-	public ColumnOptionTask getColumnOption(Column column) {
-		return getColumnOptions().get(column.getIndex());
+	public PoiExcelSheetBean getSheetBean() {
+		return sheetBean;
 	}
 
-	public List<ColumnOptionTask> getColumnOptions() {
-		if (columnOptions == null) {
-			SchemaConfig schemaConfig = task.getColumns();
-			columnOptions = new ArrayList<>(schemaConfig.getColumnCount());
-			for (ColumnConfig c : schemaConfig.getColumns()) {
-				ColumnOptionTask option = c.getOption().loadConfig(ColumnOptionTask.class);
-				columnOptions.add(option);
-			}
-		}
-		return columnOptions;
+	public PoiExcelColumnBean getColumnBean(Column column) {
+		return sheetBean.getColumnBean(column);
 	}
 }

data/src/main/java/org/embulk/parser/poi_excel/visitor/embulk/BooleanCellVisitor.java

@@ -51,4 +51,9 @@ public class BooleanCellVisitor extends CellVisitor {
 	public void visitColumnNumber(Column column, int index1) {
 		pageBuilder.setBoolean(column, index1 != 0);
 	}
+
+	@Override
+	protected void doConvertErrorConstant(Column column, String value) throws Exception {
+		pageBuilder.setBoolean(column, Boolean.parseBoolean(value));
+	}
 }

data/src/main/java/org/embulk/parser/poi_excel/visitor/embulk/CellVisitor.java

@@ -1,6 +1,11 @@
 package org.embulk.parser.poi_excel.visitor.embulk;
 
+import java.text.MessageFormat;
+
 import org.apache.poi.ss.usermodel.Cell;
+import org.embulk.config.ConfigException;
+import org.embulk.parser.poi_excel.bean.PoiExcelColumnBean;
+import org.embulk.parser.poi_excel.bean.PoiExcelColumnBean.ErrorStrategy;
 import org.embulk.parser.poi_excel.visitor.PoiExcelVisitorValue;
 import org.embulk.spi.Column;
 import org.embulk.spi.PageBuilder;
@@ -38,4 +43,29 @@ public abstract class CellVisitor {
 	public abstract void visitRowNumber(Column column, int index1);
 
 	public abstract void visitColumnNumber(Column column, int index1);
+
+	protected void doConvertError(Column column, Object srcValue, Throwable t) {
+		PoiExcelColumnBean bean = visitorValue.getColumnBean(column);
+		ErrorStrategy strategy = bean.getConvertErrorStrategy();
+		switch (strategy.getStrategy()) {
+		default:
+			break;
+		case CONSTANT:
+			String value = strategy.getValue();
+			if (value == null) {
+				pageBuilder.setNull(column);
+			} else {
+				try {
+					doConvertErrorConstant(column, value);
+				} catch (Exception e) {
+					throw new ConfigException(MessageFormat.format("constant value convert error. value={0}", value), e);
+				}
+			}
+			return;
+		}
+
+		throw new RuntimeException(MessageFormat.format("convert error. value={0}", srcValue), t);
+	}
+
+	protected abstract void doConvertErrorConstant(Column column, String value) throws Exception;
 }

data/src/main/java/org/embulk/parser/poi_excel/visitor/embulk/DoubleCellVisitor.java

@@ -17,7 +17,14 @@ public class DoubleCellVisitor extends CellVisitor {
 
 	@Override
 	public void visitCellValueString(Column column, Object source, String value) {
-		pageBuilder.setDouble(column, Double.parseDouble(value));
+		double d;
+		try {
+			d = Double.parseDouble(value);
+		} catch (NumberFormatException e) {
+			doConvertError(column, value, e);
+			return;
+		}
+		pageBuilder.setDouble(column, d);
 	}
 
 	@Override
@@ -51,4 +58,9 @@ public class DoubleCellVisitor extends CellVisitor {
 	public void visitColumnNumber(Column column, int index1) {
 		pageBuilder.setDouble(column, index1);
 	}
+
+	@Override
+	protected void doConvertErrorConstant(Column column, String value) throws Exception {
+		pageBuilder.setDouble(column, Double.parseDouble(value));
+	}
 }

data/src/main/java/org/embulk/parser/poi_excel/visitor/embulk/LongCellVisitor.java

@@ -17,7 +17,14 @@ public class LongCellVisitor extends CellVisitor {
 
 	@Override
 	public void visitCellValueString(Column column, Object source, String value) {
-		pageBuilder.setLong(column, Long.parseLong(value));
+		long l;
+		try {
+			l = Long.parseLong(value);
+		} catch (NumberFormatException e) {
+			doConvertError(column, value, e);
+			return;
+		}
+		pageBuilder.setLong(column, l);
 	}
 
 	@Override
@@ -51,4 +58,9 @@ public class LongCellVisitor extends CellVisitor {
 	public void visitColumnNumber(Column column, int index1) {
 		pageBuilder.setLong(column, index1);
 	}
+
+	@Override
+	protected void doConvertErrorConstant(Column column, String value) throws Exception {
+		pageBuilder.setLong(column, Long.parseLong(value));
+	}
 }

data/src/main/java/org/embulk/parser/poi_excel/visitor/embulk/StringCellVisitor.java

@@ -60,4 +60,9 @@ public class StringCellVisitor extends CellVisitor {
 		String value = CellReference.convertNumToColString(index1 - 1);
 		pageBuilder.setString(column, value);
 	}
+
+	@Override
+	protected void doConvertErrorConstant(Column column, String value) throws Exception {
+		pageBuilder.setString(column, value);
+	}
 }

data/src/main/java/org/embulk/parser/poi_excel/visitor/embulk/TimestampCellVisitor.java

@@ -4,10 +4,12 @@ import java.util.Date;
 import java.util.TimeZone;
 
 import org.apache.poi.ss.usermodel.DateUtil;
+import org.apache.poi.ss.usermodel.Sheet;
 import org.embulk.parser.poi_excel.PoiExcelParserPlugin.PluginTask;
 import org.embulk.parser.poi_excel.visitor.PoiExcelVisitorValue;
 import org.embulk.spi.Column;
 import org.embulk.spi.time.Timestamp;
+import org.embulk.spi.time.TimestampParseException;
 import org.embulk.spi.time.TimestampParser;
 import org.embulk.spi.util.Timestamps;
 
@@ -22,23 +24,33 @@ public class TimestampCellVisitor extends CellVisitor {
 		TimestampParser parser = getTimestampParser(column);
 		TimeZone tz = parser.getDefaultTimeZone().toTimeZone();
 		Date date = DateUtil.getJavaDate(value, tz);
-		pageBuilder.setTimestamp(column, Timestamp.ofEpochMilli(date.getTime()));
+		Timestamp t = Timestamp.ofEpochMilli(date.getTime());
+		pageBuilder.setTimestamp(column, t);
 	}
 
 	@Override
 	public void visitCellValueString(Column column, Object source, String value) {
-		TimestampParser parser = getTimestampParser(column);
-		pageBuilder.setTimestamp(column, parser.parse(value));
+		Timestamp t;
+		try {
+			TimestampParser parser = getTimestampParser(column);
+			t = parser.parse(value);
+		} catch (TimestampParseException e) {
+			doConvertError(column, value, e);
+			return;
+		}
+		pageBuilder.setTimestamp(column, t);
 	}
 
 	@Override
 	public void visitCellValueBoolean(Column column, Object source, boolean value) {
-		throw new UnsupportedOperationException("unsupported conversion Excel boolean to Embulk timestamp.");
+		doConvertError(column, value, new UnsupportedOperationException(
+				"unsupported conversion Excel boolean to Embulk timestamp"));
 	}
 
 	@Override
 	public void visitCellValueError(Column column, Object source, int code) {
-		pageBuilder.setNull(column);
+		doConvertError(column, code, new UnsupportedOperationException(
+				"unsupported conversion Excel Cell error code to Embulk timestamp"));
 	}
 
 	@Override
@@ -48,17 +60,27 @@ public class TimestampCellVisitor extends CellVisitor {
 
 	@Override
 	public void visitSheetName(Column column) {
-		throw new UnsupportedOperationException("unsupported conversion sheet_name to Embulk timestamp.");
+		Sheet sheet = visitorValue.getSheet();
+		doConvertError(column, sheet.getSheetName(), new UnsupportedOperationException(
+				"unsupported conversion sheet_name to Embulk timestamp"));
 	}
 
 	@Override
 	public void visitRowNumber(Column column, int index1) {
-		throw new UnsupportedOperationException("unsupported conversion row_number to Embulk timestamp.");
+		doConvertError(column, index1, new UnsupportedOperationException(
+				"unsupported conversion row_number to Embulk timestamp"));
 	}
 
 	@Override
 	public void visitColumnNumber(Column column, int index1) {
-		throw new UnsupportedOperationException("unsupported conversion column_number to Embulk timestamp.");
+		doConvertError(column, index1, new UnsupportedOperationException(
+				"unsupported conversion column_number to Embulk timestamp"));
+	}
+
+	@Override
+	protected void doConvertErrorConstant(Column column, String value) throws Exception {
+		TimestampParser parser = getTimestampParser(column);
+		pageBuilder.setTimestamp(column, parser.parse(value));
 	}
 
 	private TimestampParser[] timestampParsers;

data/src/test/java/org/embulk/parser/poi_excel/TestPoiExcelParserPlugin.java

@@ -75,7 +75,6 @@ public class TestPoiExcelParserPlugin {
 			EmbulkTestParserConfig parser = tester.newParserConfig(PoiExcelParserPlugin.TYPE);
 			parser.set("sheets", Arrays.asList("test1"));
 			parser.set("skip_header_lines", 1);
-			parser.set("cell_error_null", false);
 			parser.addColumn("sheet", "string").set("value", "sheet_name");
 			parser.addColumn("sheet-n", "long").set("value", "sheet_name");
 			parser.addColumn("row", "long").set("value", "row_number");

data/src/test/java/org/embulk/parser/poi_excel/TestPoiExcelParserPlugin_cellError.java

@@ -0,0 +1,184 @@
+package org.embulk.parser.poi_excel;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.CoreMatchers.nullValue;
+import static org.junit.Assert.assertThat;
+import static org.junit.Assert.fail;
+
+import java.net.URL;
+import java.text.SimpleDateFormat;
+import java.util.List;
+
+import org.apache.poi.ss.usermodel.FormulaError;
+import org.embulk.parser.EmbulkPluginTester;
+import org.embulk.parser.EmbulkTestOutputPlugin.OutputRecord;
+import org.embulk.parser.EmbulkTestParserConfig;
+import org.embulk.spi.time.Timestamp;
+import org.junit.Test;
+
+public class TestPoiExcelParserPlugin_cellError {
+
+	@Test
+	public void testCellError_default() throws Exception {
+		try (EmbulkPluginTester tester = new EmbulkPluginTester()) {
+			tester.addParserPlugin(PoiExcelParserPlugin.TYPE, PoiExcelParserPlugin.class);
+
+			EmbulkTestParserConfig parser = tester.newParserConfig(PoiExcelParserPlugin.TYPE);
+			parser.set("sheet", "test1");
+			parser.set("skip_header_lines", 7);
+			parser.addColumn("b", "boolean").set("column_number", "A");
+			parser.addColumn("l", "long").set("column_number", "A");
+			parser.addColumn("d", "double").set("column_number", "A");
+			parser.addColumn("s", "string").set("column_number", "A");
+			parser.addColumn("t", "timestamp").set("column_number", "A");
+
+			URL inFile = getClass().getResource("test1.xls");
+			List<OutputRecord> result = tester.runParser(inFile, parser);
+
+			assertThat(result.size(), is(1));
+			OutputRecord r = result.get(0);
+			assertThat(r.getAsBoolean("b"), is(nullValue()));
+			assertThat(r.getAsLong("l"), is(nullValue()));
+			assertThat(r.getAsDouble("d"), is(nullValue()));
+			assertThat(r.getAsString("s"), is(nullValue()));
+			assertThat(r.getAsString("t"), is(nullValue()));
+		}
+	}
+
+	@Test
+	public void testCellError_code() throws Exception {
+		try (EmbulkPluginTester tester = new EmbulkPluginTester()) {
+			tester.addParserPlugin(PoiExcelParserPlugin.TYPE, PoiExcelParserPlugin.class);
+
+			EmbulkTestParserConfig parser = tester.newParserConfig(PoiExcelParserPlugin.TYPE);
+			parser.set("sheet", "test1");
+			parser.set("skip_header_lines", 7);
+			parser.set("on_cell_error", "error_code");
+			parser.addColumn("b", "boolean").set("column_number", "A");
+			parser.addColumn("l", "long").set("column_number", "A");
+			parser.addColumn("d", "double").set("column_number", "A");
+			parser.addColumn("s", "string").set("column_number", "A");
+
+			URL inFile = getClass().getResource("test1.xls");
+			List<OutputRecord> result = tester.runParser(inFile, parser);
+
+			OutputRecord r = result.get(0);
+			assertThat(r.getAsBoolean("b"), is(nullValue()));
+			assertThat(r.getAsLong("l"), is((long) FormulaError.DIV0.getCode()));
+			assertThat(r.getAsDouble("d"), is((double) FormulaError.DIV0.getCode()));
+			assertThat(r.getAsString("s"), is("#DIV/0!"));
+		}
+	}
+
+	@Test
+	public void testCellError_null() throws Exception {
+		try (EmbulkPluginTester tester = new EmbulkPluginTester()) {
+			tester.addParserPlugin(PoiExcelParserPlugin.TYPE, PoiExcelParserPlugin.class);
+
+			EmbulkTestParserConfig parser = tester.newParserConfig(PoiExcelParserPlugin.TYPE);
+			parser.set("sheet", "test1");
+			parser.set("skip_header_lines", 7);
+			parser.set("on_cell_error", "constant");
+			parser.addColumn("b", "boolean").set("column_number", "A");
+			parser.addColumn("l", "long").set("column_number", "A");
+			parser.addColumn("d", "double").set("column_number", "A");
+			parser.addColumn("s", "string").set("column_number", "A");
+			parser.addColumn("t", "timestamp").set("column_number", "A");
+
+			URL inFile = getClass().getResource("test1.xls");
+			List<OutputRecord> result = tester.runParser(inFile, parser);
+
+			assertThat(result.size(), is(1));
+			OutputRecord r = result.get(0);
+			assertThat(r.getAsBoolean("b"), is(nullValue()));
+			assertThat(r.getAsLong("l"), is(nullValue()));
+			assertThat(r.getAsDouble("d"), is(nullValue()));
+			assertThat(r.getAsString("s"), is(nullValue()));
+			assertThat(r.getAsString("t"), is(nullValue()));
+		}
+	}
+
+	@Test
+	public void testCellError_empty() throws Exception {
+		try (EmbulkPluginTester tester = new EmbulkPluginTester()) {
+			tester.addParserPlugin(PoiExcelParserPlugin.TYPE, PoiExcelParserPlugin.class);
+
+			EmbulkTestParserConfig parser = tester.newParserConfig(PoiExcelParserPlugin.TYPE);
+			parser.set("sheet", "test1");
+			parser.set("skip_header_lines", 7);
+			parser.set("on_cell_error", "constant.zzz");
+			parser.addColumn("s1", "string").set("column_number", "A");
+			parser.addColumn("s2", "string").set("column_number", "A").set("on_cell_error", "constant");
+			parser.addColumn("s3", "string").set("column_number", "A").set("on_cell_error", "constant.");
+			parser.addColumn("s4", "string").set("column_number", "A").set("on_cell_error", "constant. ");
+
+			URL inFile = getClass().getResource("test1.xls");
+			List<OutputRecord> result = tester.runParser(inFile, parser);
+
+			assertThat(result.size(), is(1));
+			OutputRecord r = result.get(0);
+			assertThat(r.getAsString("s1"), is("zzz"));
+			assertThat(r.getAsString("s2"), is(nullValue()));
+			assertThat(r.getAsString("s3"), is(""));
+			assertThat(r.getAsString("s4"), is(" "));
+		}
+	}
+
+	@Test
+	public void testCellError_constant() throws Exception {
+		try (EmbulkPluginTester tester = new EmbulkPluginTester()) {
+			tester.addParserPlugin(PoiExcelParserPlugin.TYPE, PoiExcelParserPlugin.class);
+
+			EmbulkTestParserConfig parser = tester.newParserConfig(PoiExcelParserPlugin.TYPE);
+			parser.set("sheet", "test1");
+			parser.set("skip_header_lines", 7);
+			parser.set("on_cell_error", "constant.0");
+			parser.addColumn("b", "boolean").set("column_number", "A");
+			parser.addColumn("l", "long").set("column_number", "A");
+			parser.addColumn("d", "double").set("column_number", "A");
+			parser.addColumn("s", "string").set("column_number", "A");
+			parser.addColumn("t", "timestamp").set("column_number", "A").set("format", "%Y/%m/%d")
+					.set("on_cell_error", "constant.2000/1/1");
+
+			URL inFile = getClass().getResource("test1.xls");
+			List<OutputRecord> result = tester.runParser(inFile, parser);
+
+			OutputRecord r = result.get(0);
+			assertThat(r.getAsBoolean("b"), is(false));
+			assertThat(r.getAsLong("l"), is(0L));
+			assertThat(r.getAsDouble("d"), is(0d));
+			assertThat(r.getAsString("s"), is("0"));
+			assertThat(r.getAsTimestamp("t"),
+					is(Timestamp.ofEpochMilli(new SimpleDateFormat("yyyy/MM/dd z").parse("2000/01/01 UTC").getTime())));
+		}
+	}
+
+	@Test
+	public void testCellError_exception() throws Exception {
+		try (EmbulkPluginTester tester = new EmbulkPluginTester()) {
+			tester.addParserPlugin(PoiExcelParserPlugin.TYPE, PoiExcelParserPlugin.class);
+
+			EmbulkTestParserConfig parser = tester.newParserConfig(PoiExcelParserPlugin.TYPE);
+			parser.set("sheet", "test1");
+			parser.set("skip_header_lines", 7);
+			parser.set("on_cell_error", "exception");
+			parser.addColumn("b", "boolean").set("column_number", "A");
+			parser.addColumn("l", "long").set("column_number", "A");
+			parser.addColumn("d", "double").set("column_number", "A");
+			parser.addColumn("s", "string").set("column_number", "A");
+			parser.addColumn("t", "timestamp").set("column_number", "A");
+
+			URL inFile = getClass().getResource("test1.xls");
+			try {
+				tester.runParser(inFile, parser);
+			} catch (Exception e) {
+				Throwable c1 = e.getCause();
+				assertThat(c1.getMessage().contains("error at Column"), is(true));
+				Throwable c2 = c1.getCause();
+				assertThat(c2.getMessage().contains("encount cell error"), is(true));
+				return; // success
+			}
+			fail("must throw Exception");
+		}
+	}
+}